[{"id":1769563,"web_url":"http://patchwork.ozlabs.org/comment/1769563/","msgid":"<20170915.230838.1519702385714790065.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-16T06:08:38","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Saint Etienne \nDate: Sat, 16 Sep 2017 05:42:41 +0100\n\n> To get a snapshot as complete as possible of what the system is\n> composed of,\n> this commit adds the ability to retrieve a set of hardware details\n> that are only\n> available to the ILOM and export them via sysfs to userspace programs\n> and\n> utilities. Not all the ILOM properties are exposed, only a subset\n> useful to\n> system utilities.\n\nAgain, patch is whitespace damaged, and a model like /dev/mdesc\nis better for this.\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvMK34DSXz9t2Q\n\tfor ;\n\tSat, 16 Sep 2017 16:08:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751221AbdIPGIj (ORCPT );\n\tSat, 16 Sep 2017 02:08:39 -0400","from shards.monkeyblade.net ([184.105.139.130]:39394 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751182AbdIPGIi (ORCPT\n\t); Sat, 16 Sep 2017 02:08:38 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id A547D13409011;\n\tFri, 15 Sep 2017 23:08:38 -0700 (PDT)"],"Date":"Fri, 15 Sep 2017 23:08:38 -0700 (PDT)","Message-Id":"<20170915.230838.1519702385714790065.davem@davemloft.net>","To":"eric.saint.etienne@oracle.com","Cc":"sparclinux@vger.kernel.org","Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","From":"David Miller ","In-Reply-To":"","References":"","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 15 Sep 2017 23:08:38 -0700 (PDT)","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}},{"id":1770200,"web_url":"http://patchwork.ozlabs.org/comment/1770200/","msgid":"<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>","list_archive_url":null,"date":"2017-09-18T14:27:45","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":70919,"url":"http://patchwork.ozlabs.org/api/people/70919/","name":"Eric Saint Etienne","email":"eric.saint.etienne@oracle.com"},"content":"Dave,\n\nI doubt that a blob model like /dev/mdesc is better since it's not the \napproach that has been used in the kernel. You can convince yourself of \nthis by looking at where lshw gets most if its data: from sysfs. That's \nbecause kernel developers before us (since 2.4 when sysfs has been \nintroduced, really) have decided to expose things on sysfs rather then \nvia blobs. So sysfs is definitely the way to go.\n\nregards,\n\nEric\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwpJ84StMz9s7F\n\tfor ;\n\tTue, 19 Sep 2017 00:27:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754499AbdIRO1v (ORCPT );\n\tMon, 18 Sep 2017 10:27:51 -0400","from userp1040.oracle.com ([156.151.31.81]:40013 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752976AbdIRO1v (ORCPT\n\t); Mon, 18 Sep 2017 10:27:51 -0400","from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v8IERmex003797\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 18 Sep 2017 14:27:48 GMT","from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8IERmI8024147\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 18 Sep 2017 14:27:48 GMT","from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8IERlTe031168; Mon, 18 Sep 2017 14:27:47 GMT","from [10.175.174.114] (/10.175.174.114)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 18 Sep 2017 07:27:47 -0700"],"Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","To":"David Miller ","Cc":"sparclinux@vger.kernel.org","References":"\n\t<20170915.230838.1519702385714790065.davem@davemloft.net>","From":"Eric Saint Etienne ","Organization":"Oracle","Message-ID":"<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>","Date":"Mon, 18 Sep 2017 15:27:45 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915.230838.1519702385714790065.davem@davemloft.net>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Source-IP":"userv0022.oracle.com [156.151.31.74]","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}},{"id":1770307,"web_url":"http://patchwork.ozlabs.org/comment/1770307/","msgid":"<20170918.094522.564342283929263646.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-18T16:45:22","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Saint Etienne \nDate: Mon, 18 Sep 2017 15:27:45 +0100\n\n> I doubt that a blob model like /dev/mdesc is better since it's not\n> the approach that has been used in the kernel. You can convince\n> yourself of this by looking at where lshw gets most if its data:\n> from sysfs. That's because kernel developers before us (since 2.4\n> when sysfs has been introduced, really) have decided to expose\n> things on sysfs rather then via blobs. So sysfs is definitely the\n> way to go.\n\nIf some small library converts the blob into hierachical tree of text\nobjects, _WHAT_ is the difference?\n\nWe don't export things multiple ways form the kernel.\n\nWe have an existing mechanism for mdesc export, please use it.\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwsLr0ftsz9rxl\n\tfor ;\n\tTue, 19 Sep 2017 02:45:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932876AbdIRQpX (ORCPT );\n\tMon, 18 Sep 2017 12:45:23 -0400","from shards.monkeyblade.net ([184.105.139.130]:44216 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932873AbdIRQpW (ORCPT\n\t); Mon, 18 Sep 2017 12:45:22 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 71FB5101FEAB8;\n\tMon, 18 Sep 2017 09:45:22 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 09:45:22 -0700 (PDT)","Message-Id":"<20170918.094522.564342283929263646.davem@davemloft.net>","To":"eric.saint.etienne@oracle.com","Cc":"sparclinux@vger.kernel.org","Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","From":"David Miller ","In-Reply-To":"<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>","References":"\n\t<20170915.230838.1519702385714790065.davem@davemloft.net>\n\t<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 09:45:22 -0700 (PDT)","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}},{"id":1770688,"web_url":"http://patchwork.ozlabs.org/comment/1770688/","msgid":"<00251eaf-5304-b295-7026-525bb62f4b07@oracle.com>","list_archive_url":null,"date":"2017-09-19T07:06:37","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":70919,"url":"http://patchwork.ozlabs.org/api/people/70919/","name":"Eric Saint Etienne","email":"eric.saint.etienne@oracle.com"},"content":"> If some small library converts the blob into hierachical tree of text\n> objects, _WHAT_ is the difference?\n>\n> We don't export things multiple ways form the kernel.\n>\n> We have an existing mechanism for mdesc export, please use it.\n\nThis email thread is not about mdesc, you must be confused.\n\nAFAIK no data from the ILOM is exposed in any way inside the kernel and \nthere is no existing library to parse the output from the ILOM command \nline. This module hence provides new pieces of information that don't \nexist yet in any form from within Linux, so this module is eligible to \nbeing exported via sysfs using your very own standards (as drawn up in \nthe mdesc module thread).\n\nThe main purpose of this ILOM module is to provide more hardware \ninformation to utilities like lshw.\n\nAnother use is to provide detailed information to utilities that gather \na snapshot of the system to send to support teams, for example it's not \npossible at the moment to get the machine firmware versions or RAM DIMM \ndetails, they're only available through the ILOM UI.\n\nOn x86 this kind of info is available mostly through DMI tables which \nlack on Sparc (for good reasons, DMI is a thing of the past) but \nunfortunately for sparclinux there is no mechanism in place to achieve \nthe same as DMI.\n\n-eric\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxDSk2Ksgz9s3w\n\tfor ;\n\tTue, 19 Sep 2017 17:06:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751365AbdISHGp (ORCPT );\n\tTue, 19 Sep 2017 03:06:45 -0400","from userp1040.oracle.com ([156.151.31.81]:50630 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750982AbdISHGp (ORCPT\n\t); Tue, 19 Sep 2017 03:06:45 -0400","from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v8J76gd5026012\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 19 Sep 2017 07:06:43 GMT","from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8J76gY9025635\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 19 Sep 2017 07:06:42 GMT","from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16])\n\tby aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tv8J76gJR013042; Tue, 19 Sep 2017 07:06:42 GMT","from [192.168.1.250] (/82.129.97.25)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 19 Sep 2017 00:06:42 -0700"],"Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","To":"David Miller ","Cc":"sparclinux@vger.kernel.org","References":"\n\t<20170915.230838.1519702385714790065.davem@davemloft.net>\n\t<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>\n\t<20170918.094522.564342283929263646.davem@davemloft.net>","From":"Eric Saint Etienne ","Organization":"Oracle","Message-ID":"<00251eaf-5304-b295-7026-525bb62f4b07@oracle.com>","Date":"Tue, 19 Sep 2017 08:06:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918.094522.564342283929263646.davem@davemloft.net>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Source-IP":"aserv0022.oracle.com [141.146.126.234]","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}},{"id":1771228,"web_url":"http://patchwork.ozlabs.org/comment/1771228/","msgid":"<20170919.103624.182139001553350928.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T17:36:24","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Saint Etienne \nDate: Tue, 19 Sep 2017 08:06:37 +0100\n\n> This email thread is not about mdesc, you must be confused.\n\nYes it is.\n\nThe discussion about the \"Expose mdesc to sysfs\" patch was primarily\nheld here in this email thread unfortunately.\n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxVRG1sMBz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:36:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751377AbdISRgZ (ORCPT );\n\tTue, 19 Sep 2017 13:36:25 -0400","from shards.monkeyblade.net ([184.105.139.130]:37106 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750919AbdISRgZ (ORCPT\n\t); Tue, 19 Sep 2017 13:36:25 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 176C1102C0802;\n\tTue, 19 Sep 2017 10:36:25 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 10:36:24 -0700 (PDT)","Message-Id":"<20170919.103624.182139001553350928.davem@davemloft.net>","To":"eric.saint.etienne@oracle.com","Cc":"sparclinux@vger.kernel.org","Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","From":"David Miller ","In-Reply-To":"<00251eaf-5304-b295-7026-525bb62f4b07@oracle.com>","References":"<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>\n\t<20170918.094522.564342283929263646.davem@davemloft.net>\n\t<00251eaf-5304-b295-7026-525bb62f4b07@oracle.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 10:36:25 -0700 (PDT)","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}},{"id":1771306,"web_url":"http://patchwork.ozlabs.org/comment/1771306/","msgid":"","list_archive_url":null,"date":"2017-09-19T19:09:57","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":70919,"url":"http://patchwork.ozlabs.org/api/people/70919/","name":"Eric Saint Etienne","email":"eric.saint.etienne@oracle.com"},"content":"> The discussion about the \"Expose mdesc to sysfs\" patch was primarily\n> held here in this email thread unfortunately.\n\nOkay, I'm not entirely sure what you mean, but it doesn't matter.\n\nCan you please have a look to the ilom patch (arch/sparc/kernel/ilom.c)\nthen please? If you can't find it then let me know and I'll resend it.\n\nThank you.\n\n-eric\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxXWT5wS1z9s8J\n\tfor ;\n\tWed, 20 Sep 2017 05:10:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751237AbdISTKC (ORCPT );\n\tTue, 19 Sep 2017 15:10:02 -0400","from userp1040.oracle.com ([156.151.31.81]:44874 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751227AbdISTKC (ORCPT\n\t); Tue, 19 Sep 2017 15:10:02 -0400","from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id v8JJA0V6018641\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 19 Sep 2017 19:10:00 GMT","from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n\tby userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8JJ9xVh007601\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Tue, 19 Sep 2017 19:10:00 GMT","from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23])\n\tby aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8JJ9xsc020620; Tue, 19 Sep 2017 19:09:59 GMT","from [10.175.233.95] (/10.175.233.95)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Tue, 19 Sep 2017 12:09:58 -0700"],"Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","To":"David Miller ","Cc":"sparclinux@vger.kernel.org","References":"<59e0a2f6-78db-0846-1f4c-72f972055e11@oracle.com>\n\t<20170918.094522.564342283929263646.davem@davemloft.net>\n\t<00251eaf-5304-b295-7026-525bb62f4b07@oracle.com>\n\t<20170919.103624.182139001553350928.davem@davemloft.net>","From":"Eric Saint Etienne ","Organization":"Oracle","Message-ID":"","Date":"Tue, 19 Sep 2017 20:09:57 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919.103624.182139001553350928.davem@davemloft.net>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Source-IP":"userv0022.oracle.com [156.151.31.74]","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}},{"id":1771372,"web_url":"http://patchwork.ozlabs.org/comment/1771372/","msgid":"<20170919.134038.855876532081330031.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-19T20:40:38","subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Saint Etienne \nDate: Tue, 19 Sep 2017 20:09:57 +0100\n\n> Can you please have a look to the ilom patch\n> (arch/sparc/kernel/ilom.c) then please? If you can't find it then\n> let me know and I'll resend it.\n\nOk, I guess that is alright. But it needs a bunch of changes.\n\nDon't use uint_8_t etc. in the kernel, use u8 et al. instead.\n\nDo not use the __packed attribute unless absolutely necessary\nwhich seems entirely not the case for sunoem_cli_msg.\n\nPlease remove the ILOM_PROFILING, you can achieve the same effect\nwith tracepoints and perf.\n\nLooking at the driver from a high level, it just seems to export\na seemingly arbitrary set of ILOM properties. Why not provide\na real hierarchy of all the /SYS, /HOST, etc. stuff via /sysfs?\n\nThe string parsing and matching in there is exactly the kind of\ncode I'm talking about which doesn't belong in the kernel.\n\nThe kernel should export a family of values for whatever (bus,\nfirmware settings, etc.) transparently to the user and let them\ndo whatever they want with whichever values they find interesting.\n\nIt is not the kernel's business to filter, not interpret, the\nobjects. Yet that is what these drivers are doing.\n--\nTo unsubscribe from this list: send the line \"unsubscribe sparclinux\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=sparclinux-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxZWs2VG5z9sBW\n\tfor ;\n\tWed, 20 Sep 2017 06:40:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751780AbdISUkk (ORCPT );\n\tTue, 19 Sep 2017 16:40:40 -0400","from shards.monkeyblade.net ([184.105.139.130]:44260 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751778AbdISUkj (ORCPT\n\t); Tue, 19 Sep 2017 16:40:39 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 4B6DC102C8261;\n\tTue, 19 Sep 2017 13:40:39 -0700 (PDT)"],"Date":"Tue, 19 Sep 2017 13:40:38 -0700 (PDT)","Message-Id":"<20170919.134038.855876532081330031.davem@davemloft.net>","To":"eric.saint.etienne@oracle.com","Cc":"sparclinux@vger.kernel.org","Subject":"Re: [PATCH] Expose some h/w info from ILOM to userspace via sysfs","From":"David Miller ","In-Reply-To":"","References":"<00251eaf-5304-b295-7026-525bb62f4b07@oracle.com>\n\t<20170919.103624.182139001553350928.davem@davemloft.net>\n\t","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 19 Sep 2017 13:40:39 -0700 (PDT)","Sender":"sparclinux-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"sparclinux@vger.kernel.org"}}]