[{"id":1769586,"web_url":"http://patchwork.ozlabs.org/comment/1769586/","msgid":"<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>","date":"2017-09-16T09:43:45","subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","submitter":{"id":15185,"url":"http://patchwork.ozlabs.org/api/people/15185/","name":"Naveen N. Rao","email":"naveen.n.rao@linux.vnet.ibm.com"},"content":"On 2017/09/16 12:53PM, Sergey Senozhatsky wrote:\n> We are moving towards separate kernel and module function descriptor\n> dereference callbacks. This patch enables it for powerpc64.\n> \n> For pointers that belong to the kernel\n> - Added __start_opd and __end_opd pointers, to track the kernel\n> .opd section address range;\n> \n> - Added dereference_kernel_function_descriptor(). Now we\n> will dereference only function pointers that are within\n> [__start_opd, __end_opd];\n> \n> For pointers that belong to a module\n> - Added dereference_module_function_descriptor() to handle module\n> function descriptor dereference. Now we will dereference only\n> pointers that are within [module->opd.start, module->opd.end].\n\nWould it be simpler to just use kernel_text_address() and dereference \neverything else? See commit 83e840c770f2c5 (\"powerpc64/elfv1: Only \ndereference function descriptor for non-text symbols\") for a related \npatch.\n\n- Naveen","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvS8G485nz9sPk\n\tfor ;\n\tSat, 16 Sep 2017 19:46:22 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xvS8G2y5TzDrqK\n\tfor ;\n\tSat, 16 Sep 2017 19:46:22 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xvS6y0HsczDrhx\n\tfor ;\n\tSat, 16 Sep 2017 19:45:13 +1000 (AEST)","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8G9iwOl046631\n\tfor ; Sat, 16 Sep 2017 05:45:11 -0400","from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d10gfj6ks-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Sat, 16 Sep 2017 05:45:11 -0400","from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from\n\t; Sat, 16 Sep 2017 19:45:09 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tSat, 16 Sep 2017 19:45:06 +1000","from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8G9hpLL28115030\n\tfor ; Sat, 16 Sep 2017 19:43:51 +1000","from d23av06.au.ibm.com (localhost [127.0.0.1])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8G9hoi7018133\n\tfor ; Sat, 16 Sep 2017 19:43:51 +1000","from localhost ([9.79.191.157])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8G9hmJb018106; Sat, 16 Sep 2017 19:43:49 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=naveen.n.rao@linux.vnet.ibm.com; receiver=)","Date":"Sat, 16 Sep 2017 15:13:45 +0530","From":"\"Naveen N. Rao\" ","To":"Sergey Senozhatsky ","Subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170916035347.19705-4-sergey.senozhatsky@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170916035347.19705-4-sergey.senozhatsky@gmail.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-TM-AS-MML":"disable","x-cbid":"17091609-0040-0000-0000-000003566039","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091609-0041-0000-0000-00000CD6D8B5","Message-Id":"<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-16_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709160148","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , Tony Luck ,\n\tlinux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tPetr Mladek , Helge Deller ,\n\tJessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tPaul Mackerras , Nicholas Piggin ,\n\tAndrew Morton ,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1769598,"web_url":"http://patchwork.ozlabs.org/comment/1769598/","msgid":"<20170916112535.GA495@tigerII.localdomain>","date":"2017-09-16T11:25:35","subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","submitter":{"id":3905,"url":"http://patchwork.ozlabs.org/api/people/3905/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky@gmail.com"},"content":"On (09/16/17 15:13), Naveen N. Rao wrote:\n[..]\n> Would it be simpler to just use kernel_text_address() and dereference \n> everything else? See commit 83e840c770f2c5 (\"powerpc64/elfv1: Only \n> dereference function descriptor for non-text symbols\") for a related \n> patch.\n\nI had this idea, see\n\nlkml.kernel.org/r/20170908172528.qc2vdtxzqh777k6o@intel.com\n\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvVV54tQjz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 21:31:57 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xvVV53H10zDqYG\n\tfor ;\n\tSat, 16 Sep 2017 21:31:57 +1000 (AEST)","from mail-pf0-x229.google.com (mail-pf0-x229.google.com\n\t[IPv6:2607:f8b0:400e:c00::229])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xvVSJ5f6LzDq78\n\tfor ;\n\tSat, 16 Sep 2017 21:30:24 +1000 (AEST)","by mail-pf0-x229.google.com with SMTP id r71so2673561pfe.12\n\tfor ;\n\tSat, 16 Sep 2017 04:30:24 -0700 (PDT)","from localhost ([121.137.63.184]) by smtp.gmail.com with ESMTPSA id\n\tj68sm7513721pfa.93.2017.09.16.04.30.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSat, 16 Sep 2017 04:30:21 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aDJpqDqk\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aDJpqDqk\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::229; helo=mail-pf0-x229.google.com;\n\tenvelope-from=sergey.senozhatsky@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aDJpqDqk\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=2BybNKxn/OJ1EAknbK2Nw4mCslaBDC0c581QMLQAZwo=;\n\tb=aDJpqDqkJ7qThec5F2ubKc5r70T7GW5HPqD1Fj1VcVTUoSvjrMYowx6SHxqIz0d/OJ\n\tFKNOXL2wwM4Bh/pp3FXoQBeR+G+xbF9NMsSslQLQ6BkEfHKalUu/eR2Sd6s+FEuYrf7N\n\tRPNUlcfmcR/HFo0nP0awp6YV8Y4uH3WPZtUM8j+jJF9oyEylhutVL/IIy5v3apsprVx6\n\t1R/7DSH7cCN+anuk8EG4/xRdM9ZYfs0nerirHcslIaZUysoHOXiobMEcdZ/FfHnuy89s\n\tfteeJ6HykQ4RXNnXFlCGrQYOxj07lshJWmzubgTeWWdj/pME5ian13o/c6lGYl+mv3tu\n\t3d9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=2BybNKxn/OJ1EAknbK2Nw4mCslaBDC0c581QMLQAZwo=;\n\tb=jmP7hE8Ozi2kUDt0c0cpoMdcRE63qNnxQD2AbuwOSGcE5trS91TATTNZZfRWL/OwHS\n\t/bq8RMoVoPY0BotC2a6RGxC9oOLSweTZqVQ2UMRhFdREUqBAa6kJHix2EE1ClcGsKVPg\n\t/6iS4wuWHrLh6/iswpfAMAydSFrIVCVw5VT1eSvs9GS8xpnShHwSyrAXE21Il1cKVHHh\n\t3IawfznhTx9Zlc7dJWli18aMAjmvoe12CYcIGHECHwuGEf/FVGMLidVvBYoISrbGCux5\n\tMvnlVaZWF0x3Zz0rTJ3PxsS/LPr4zrxY2EEAK854Amewe1RmKMNnUXVs7I0ex0zpVZek\n\tIZDA==","X-Gm-Message-State":"AHPjjUgugHu5B+Gbg8fJZlIgouN8/7OoT5nkRazr3NPsbtRGnMUfGY5+\n\tq35XgsV9rvIB8Q==","X-Google-Smtp-Source":"ADKCNb62ZrR/3wcQa+tx6rRUkLM7SAL00M0bQy9KJ+V8CJeYF7HljspZGAZqCxkw6/ap3lMp13eZEg==","X-Received":"by 10.84.133.41 with SMTP id 38mr17547732plf.203.1505561422060; \n\tSat, 16 Sep 2017 04:30:22 -0700 (PDT)","Date":"Sat, 16 Sep 2017 20:25:35 +0900","From":"Sergey Senozhatsky ","To":"\"Naveen N. Rao\" ","Subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","Message-ID":"<20170916112535.GA495@tigerII.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170916035347.19705-4-sergey.senozhatsky@gmail.com>\n\t<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , Tony Luck ,\n\tlinux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tPetr Mladek , Helge Deller ,\n\tJessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Nicholas Piggin ,\n\tAndrew Morton ,\n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1770832,"web_url":"http://patchwork.ozlabs.org/comment/1770832/","msgid":"<87shfjkmxe.fsf@concordia.ellerman.id.au>","date":"2017-09-19T10:22:37","subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"\"Naveen N. Rao\" writes:\n\n> On 2017/09/16 12:53PM, Sergey Senozhatsky wrote:\n>> We are moving towards separate kernel and module function descriptor\n>> dereference callbacks. This patch enables it for powerpc64.\n>> \n>> For pointers that belong to the kernel\n>> - Added __start_opd and __end_opd pointers, to track the kernel\n>> .opd section address range;\n>> \n>> - Added dereference_kernel_function_descriptor(). Now we\n>> will dereference only function pointers that are within\n>> [__start_opd, __end_opd];\n>> \n>> For pointers that belong to a module\n>> - Added dereference_module_function_descriptor() to handle module\n>> function descriptor dereference. Now we will dereference only\n>> pointers that are within [module->opd.start, module->opd.end].\n>\n> Would it be simpler to just use kernel_text_address() and dereference \n> everything else? See commit 83e840c770f2c5 (\"powerpc64/elfv1: Only \n> dereference function descriptor for non-text symbols\") for a related \n> patch.\n\nYeah that would be a lot simpler and probably work perfectly well.\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxJqt5jSLz9s82\n\tfor ;\n\tTue, 19 Sep 2017 20:23:38 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxJqt4w7CzDqj2\n\tfor ;\n\tTue, 19 Sep 2017 20:23:38 +1000 (AEST)","from ozlabs.org (bilbo.ozlabs.org [103.22.144.67])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxJpk4cPtzDq8f\n\tfor ;\n\tTue, 19 Sep 2017 20:22:38 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xxJpk21Hhz9s7h;\n\tTue, 19 Sep 2017 20:22:38 +1000 (AEST)"],"From":"Michael Ellerman ","To":"\"Naveen N. Rao\" ,\n\tSergey Senozhatsky ","Subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","In-Reply-To":"<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170916035347.19705-4-sergey.senozhatsky@gmail.com>\n\t<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Tue, 19 Sep 2017 20:22:37 +1000","Message-ID":"<87shfjkmxe.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , Tony Luck ,\n\tlinux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tPetr Mladek , Helge Deller ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tPaul Mackerras , Nicholas Piggin ,\n\tJessica Yu , Andrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1770834,"web_url":"http://patchwork.ozlabs.org/comment/1770834/","msgid":"<20170919103154.GC401@jagdpanzerIV.localdomain>","date":"2017-09-19T10:31:54","subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","submitter":{"id":67261,"url":"http://patchwork.ozlabs.org/api/people/67261/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky.work@gmail.com"},"content":"On (09/19/17 20:22), Michael Ellerman wrote:\n> > On 2017/09/16 12:53PM, Sergey Senozhatsky wrote:\n> >> We are moving towards separate kernel and module function descriptor\n> >> dereference callbacks. This patch enables it for powerpc64.\n> >> \n> >> For pointers that belong to the kernel\n> >> - Added __start_opd and __end_opd pointers, to track the kernel\n> >> .opd section address range;\n> >> \n> >> - Added dereference_kernel_function_descriptor(). Now we\n> >> will dereference only function pointers that are within\n> >> [__start_opd, __end_opd];\n> >> \n> >> For pointers that belong to a module\n> >> - Added dereference_module_function_descriptor() to handle module\n> >> function descriptor dereference. Now we will dereference only\n> >> pointers that are within [module->opd.start, module->opd.end].\n> >\n> > Would it be simpler to just use kernel_text_address() and dereference \n> > everything else? See commit 83e840c770f2c5 (\"powerpc64/elfv1: Only \n> > dereference function descriptor for non-text symbols\") for a related \n> > patch.\n> \n> Yeah that would be a lot simpler and probably work perfectly well.\n\nunlike ppc_function_entry(), printk() can get called on any symbol,\nnot just function pointers.\n\nfor example,\n\ncat /proc/kallsyms | grep shrinker_rwsem\nffffffff81a4b1e0 d shrinker_rwsem\n\nor\n\ncat /proc/kallsyms | grep vm_total_pages\nffffffff81dcd418 B vm_total_pages\n\n\nand so on.\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxK3D5Z30z9s82\n\tfor ;\n\tTue, 19 Sep 2017 20:33:28 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxK3D4NTSzDqY3\n\tfor ;\n\tTue, 19 Sep 2017 20:33:28 +1000 (AEST)","from mail-pg0-x244.google.com (mail-pg0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c05::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxK1Y4J6LzDq8f\n\tfor ;\n\tTue, 19 Sep 2017 20:32:01 +1000 (AEST)","by mail-pg0-x244.google.com with SMTP id j16so1819297pga.2\n\tfor ;\n\tTue, 19 Sep 2017 03:32:01 -0700 (PDT)","from localhost ([39.7.53.230]) by smtp.gmail.com with ESMTPSA id\n\tv8sm2325663pgs.9.2017.09.19.03.31.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 03:31:57 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oEq9HO7C\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oEq9HO7C\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::244; helo=mail-pg0-x244.google.com;\n\tenvelope-from=sergey.senozhatsky.work@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oEq9HO7C\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=tp0GmYmsJK9TK+CwSFIGGwunOwGEF2n8/CnVALxgAiQ=;\n\tb=oEq9HO7CJ+rIa7nPCybURM6xvBx26m9UBMez3KZXIJLrqG1od76dOQ51TRGqNiKxDb\n\t6Y9C+r10XV2SwJGWRObY8KpkZPzoYL/LPJvHQjhI+CnHwV4l1hHjy+ljVu5tI0DDSXWB\n\tUEdN4glVh9jSA/sHRz7te24glbm8CJ1uQ1DZdBXiJryfL38pp165B06mz1+cS8KRmiZZ\n\tfLSiNZhXy+bO67av4URZVyuX24ZsUvTM320an60Sg7HS5Zh9Ue/4PaCC+yGCaLQQmveQ\n\t6GkN7Qr1LsIpn8KaSwBY20/dHdn/WLZT5LhHnpxIx8IVVYypfHcc4sJpEYg1RpyLKldK\n\t3GCw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=tp0GmYmsJK9TK+CwSFIGGwunOwGEF2n8/CnVALxgAiQ=;\n\tb=rrZNpuWjzHPbImFgUr3CKdgw6oXrtNgihjmYgt+utLY/YTTQLfY1gSYBnyMP9Tg5i9\n\toB9anRWsYIveWHVjwzH8nP2jS8p+Fj2yiWtQr1e0osbvJGJQxQjiZeVDM/QAgVv0ERuG\n\taVrgltZs9iLJ1ODbaAARbsZLzMXtFDgNT0tp1WzaROhCk/x7krEnU8KTPplFFi8HYnEZ\n\t2m0z2kjAnRFyOut8RzCph5f48mE6ossFM3dZv555ZJDNpFXzrGFMeH0ISbFb8p+tvFk2\n\tlAi0nl/o54G3pGjdY2Wq4LljOtl+f1MJTP0wM118ftYyEMi6TseZiVEZLExJOrhfMKBz\n\tEg8Q==","X-Gm-Message-State":"AHPjjUhZ8zkF2fxsqi8kPdIDTxPgZoOta+l3iJvbDlVS1b37mBNQtSlf\n\tY/r5UmMdADtwSVpJoKRoXsA=","X-Google-Smtp-Source":"AOwi7QCvU8ljG/oXn6/SGsNXHWl6xnUiDN+nZoOuFhPHKqL4rLIKqnuRMx3eN5yGvaqmhdVdTvlXJQ==","X-Received":"by 10.101.85.70 with SMTP id t6mr858360pgr.255.1505817119198;\n\tTue, 19 Sep 2017 03:31:59 -0700 (PDT)","Date":"Tue, 19 Sep 2017 19:31:54 +0900","From":"Sergey Senozhatsky ","To":"Michael Ellerman ","Subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","Message-ID":"<20170919103154.GC401@jagdpanzerIV.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170916035347.19705-4-sergey.senozhatsky@gmail.com>\n\t<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>\n\t<87shfjkmxe.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<87shfjkmxe.fsf@concordia.ellerman.id.au>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , Tony Luck ,\n\tlinux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tPetr Mladek , Helge Deller ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Nicholas Piggin ,\n\tJessica Yu ,\n\t\"Naveen N. Rao\" ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tAndrew Morton , linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771498,"web_url":"http://patchwork.ozlabs.org/comment/1771498/","msgid":"<878tha9lxm.fsf@concordia.ellerman.id.au>","date":"2017-09-20T01:51:49","subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","submitter":{"id":46580,"url":"http://patchwork.ozlabs.org/api/people/46580/","name":"Michael Ellerman","email":"mpe@ellerman.id.au"},"content":"Sergey Senozhatsky writes:\n\n> On (09/19/17 20:22), Michael Ellerman wrote:\n>> > On 2017/09/16 12:53PM, Sergey Senozhatsky wrote:\n>> >> We are moving towards separate kernel and module function descriptor\n>> >> dereference callbacks. This patch enables it for powerpc64.\n>> >> \n>> >> For pointers that belong to the kernel\n>> >> - Added __start_opd and __end_opd pointers, to track the kernel\n>> >> .opd section address range;\n>> >> \n>> >> - Added dereference_kernel_function_descriptor(). Now we\n>> >> will dereference only function pointers that are within\n>> >> [__start_opd, __end_opd];\n>> >> \n>> >> For pointers that belong to a module\n>> >> - Added dereference_module_function_descriptor() to handle module\n>> >> function descriptor dereference. Now we will dereference only\n>> >> pointers that are within [module->opd.start, module->opd.end].\n>> >\n>> > Would it be simpler to just use kernel_text_address() and dereference \n>> > everything else? See commit 83e840c770f2c5 (\"powerpc64/elfv1: Only \n>> > dereference function descriptor for non-text symbols\") for a related \n>> > patch.\n>> \n>> Yeah that would be a lot simpler and probably work perfectly well.\n>\n> unlike ppc_function_entry(), printk() can get called on any symbol,\n> not just function pointers.\n>\n> for example,\n>\n> cat /proc/kallsyms | grep shrinker_rwsem\n> ffffffff81a4b1e0 d shrinker_rwsem\n\nYep, good point. So your patch is probably good then. Maybe someone\nother than me can find time to test it ;)\n\ncheers","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxjS75L4qz9sPt\n\tfor ;\n\tWed, 20 Sep 2017 11:52:55 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxjS74VHBzDqb7\n\tfor ;\n\tWed, 20 Sep 2017 11:52:55 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxjQx0fKzzDqR8\n\tfor ;\n\tWed, 20 Sep 2017 11:51:53 +1000 (AEST)","from authenticated.ozlabs.org (localhost [127.0.0.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPSA id 3xxjQw636Pz9sPt;\n\tWed, 20 Sep 2017 11:51:52 +1000 (AEST)"],"From":"Michael Ellerman ","To":"Sergey Senozhatsky ","Subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","In-Reply-To":"<20170919103154.GC401@jagdpanzerIV.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170916035347.19705-4-sergey.senozhatsky@gmail.com>\n\t<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>\n\t<87shfjkmxe.fsf@concordia.ellerman.id.au>\n\t<20170919103154.GC401@jagdpanzerIV.localdomain>","User-Agent":"Notmuch/0.21 (https://notmuchmail.org)","Date":"Wed, 20 Sep 2017 11:51:49 +1000","Message-ID":"<878tha9lxm.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , Tony Luck ,\n\tlinux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,\n\tPetr Mladek , Helge Deller ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Nicholas Piggin ,\n\tJessica Yu ,\n\t\"Naveen N. Rao\" ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tAndrew Morton , linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771604,"web_url":"http://patchwork.ozlabs.org/comment/1771604/","msgid":"<20170920061026.GB6298@jagdpanzerIV.localdomain>","date":"2017-09-20T06:10:26","subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","submitter":{"id":67261,"url":"http://patchwork.ozlabs.org/api/people/67261/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky.work@gmail.com"},"content":"On (09/20/17 11:51), Michael Ellerman wrote:\n[..]\n> > unlike ppc_function_entry(), printk() can get called on any symbol,\n> > not just function pointers.\n> >\n> > for example,\n> >\n> > cat /proc/kallsyms | grep shrinker_rwsem\n> > ffffffff81a4b1e0 d shrinker_rwsem\n> \n> Yep, good point. So your patch is probably good then. Maybe someone\n> other than me can find time to test it ;)\n\nHi,\n\nI'll re-spin the series today/tomorrow.\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxqCP6QVxz9sP1\n\tfor ;\n\tWed, 20 Sep 2017 16:12:17 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxqCP3JDDzDqXj\n\tfor ;\n\tWed, 20 Sep 2017 16:12:17 +1000 (AEST)","from mail-pg0-x242.google.com (mail-pg0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c05::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxq9Q5d4NzDqBd\n\tfor ;\n\tWed, 20 Sep 2017 16:10:34 +1000 (AEST)","by mail-pg0-x242.google.com with SMTP id i130so1124732pgc.0\n\tfor ;\n\tTue, 19 Sep 2017 23:10:34 -0700 (PDT)","from localhost ([110.70.59.92]) by smtp.gmail.com with ESMTPSA id\n\td69sm6370870pfl.50.2017.09.19.23.10.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 23:10:30 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MdOO9re7\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MdOO9re7\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::242; helo=mail-pg0-x242.google.com;\n\tenvelope-from=sergey.senozhatsky.work@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MdOO9re7\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=DzAkrWoXEH+3GwlLaOfP+81ZM/seZgN+dkRk8UEwi28=;\n\tb=MdOO9re7uCWu5rDT5caOCHY3lSfgzeCre+bbzib4isiF/3i6qEJQujlnXCzWxo9Oiv\n\t0S2I5/mywHn6alsmmA8xfGstPtMtEQzcFI08BsHGo25aQwQ4eFruuFzq3RjA9dhyNnWk\n\t7PDZYe4OT9iVJq1PNxB0ALDhuWaTpT4uanJogYX2k92ocqrI+q5xHmSYD/7JLZnjmhO2\n\txkAPNRiy0iQh8CgQxp8mcSpu0t80UEMOmpclbFnUx4jz4AxeAkprefb5ERQFkk5ChByR\n\tozthnHfhNw+zyC7pZykHeLITy1t6z2LjlDFmyQ+PaMqqie3yNtgqhAN2MrQP3UQfsCQ1\n\tz5DA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=DzAkrWoXEH+3GwlLaOfP+81ZM/seZgN+dkRk8UEwi28=;\n\tb=CTTp+3bMVXYq4+/pnegdj7Y8c/zO67pddm4Xs5FrprYL+0fgYX5I1HMQaE7TkQ/hLb\n\t/ZUwR3S2ooIHadPXsAhiks3WGzgZ8TM+L+II8EE8pfV4kifks2T9xdpum5f19CAfW5w3\n\tSX4FcGUxbVuCX0JngJcdJd/G0ziUlygml+j/X8J/NBM7QyRyP7a6Vzg4aafU4nh8kSUz\n\tj49HcHTZrz0OfjgGVH3ew7b8oTtU+RPmqYtp9u5Ygs7MFk9wH7on5T5utHarVyH6tIR3\n\tsEVO3GvkKJ7Z0UB1paO+bw/X1eMpXbUwYMtfm397yF4JzGqO9eJ4k5NBOG4YyfdVCo13\n\tTDhw==","X-Gm-Message-State":"AHPjjUj7SXL4XMnNZozkroW1OTBjsAtlFRdAyOTe4iZ+bbwEcZ+AjPUv\n\tRRmqTw5L0E9pBW1LvS3U/s8=","X-Google-Smtp-Source":"AOwi7QAUk4Uk55FU9KWY5dadnsTsEUGK1PVIALrTFm5Goa5kHDgS3GA9Xc7mdiNCnapHxAa/UvmDYA==","X-Received":"by 10.84.240.4 with SMTP id y4mr1034348plk.22.1505887832766;\n\tTue, 19 Sep 2017 23:10:32 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:10:26 +0900","From":"Sergey Senozhatsky ","To":"Michael Ellerman ","Subject":"Re: [PATCH 3/5] powerpc64: Add .opd based function descriptor\n\tdereference","Message-ID":"<20170920061026.GB6298@jagdpanzerIV.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170916035347.19705-4-sergey.senozhatsky@gmail.com>\n\t<20170916094345.d332z3odceqiyrll@naverao1-tp.localdomain>\n\t<87shfjkmxe.fsf@concordia.ellerman.id.au>\n\t<20170919103154.GC401@jagdpanzerIV.localdomain>\n\t<878tha9lxm.fsf@concordia.ellerman.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<878tha9lxm.fsf@concordia.ellerman.id.au>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , Tony Luck ,\n\tlinux-ia64@vger.kernel.org,\n\tSergey Senozhatsky ,\n\tlinux-parisc@vger.kernel.org, Petr Mladek ,\n\tHelge Deller ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Nicholas Piggin ,\n\tJessica Yu ,\n\t\"Naveen N. Rao\" ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tAndrew Morton , linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]