[{"id":1769639,"web_url":"http://patchwork.ozlabs.org/comment/1769639/","msgid":"<CAH2r5mtVG3DDSwurFPBcELeuahiuLvxnNhKy40Ok0jcP5Yks+g@mail.gmail.com>","list_archive_url":null,"date":"2017-09-16T21:00:27","subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"Updated with feedback from Pavel\n\nhttps://git.samba.org/?p=sfrench/cifs-2.6.git;a=shortlog;h=refs/heads/for-next\n\nOn Fri, Sep 15, 2017 at 10:59 PM, Steve French <smfrench@gmail.com> wrote:\n> SMB2.1 or later dialect (instead of forcing only SMB3) for cifs.ko -\n> makes it easier if server is Windows 7 (last release dialect default\n> was upgraded from smb1/cifs to smb3 - but multidialect negotiation was\n> not supported until now)\n>\n> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=0e0f8ad440ac117685aeed4df16f320c7e9ac1c6\n>\n> or see attached\n>\n>\n>\n> --\n> Thanks,\n>\n> Steve","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XjV2Tsv5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvl6X4GZRz9sPr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 07:00:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751278AbdIPVAu (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSat, 16 Sep 2017 17:00:50 -0400","from mail-pf0-f175.google.com ([209.85.192.175]:50040 \"EHLO\n\tmail-pf0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750945AbdIPVAt (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Sat, 16 Sep 2017 17:00:49 -0400","by mail-pf0-f175.google.com with SMTP id l188so3038805pfc.6\n\tfor <linux-cifs@vger.kernel.org>;\n\tSat, 16 Sep 2017 14:00:49 -0700 (PDT)","by 10.100.140.202 with HTTP; Sat, 16 Sep 2017 14:00:27 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to;\n\tbh=QfAobuvXX9MclgQ4j+YscSxjJOgAOYFS6aZIxKLyB8Q=;\n\tb=XjV2Tsv5AgXv8SGgXljUEbCYg41GU4X4k7j0mF8Mx8COu0MNxhrk/gjs7XbOItxLVH\n\thgDZwoXHv9oovp7oTwHWlbUH6/xekK6B9OTVX43icBC4phXpyP6fnX1ZJh4uzGfM8yCp\n\tYhcNfUAU0trb4HvSwDvlzdna+xPxYrdaj7j1NMbZhrpW1qu4tMlWv4Q0OAMqUVmecgMl\n\tCIwe3pW8FGk5t2RvtzTFutR/RKEXTWppKkubt06bXa/Kw4hZlGKplLcPZI1nlmaOda/9\n\ttBf/uGh6L1WLjcQRgIZ/v29wBA2SBZg30nQ6Po7GZCmwkQZgcKVcHVw9tekmAQqIVRK0\n\teWxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=QfAobuvXX9MclgQ4j+YscSxjJOgAOYFS6aZIxKLyB8Q=;\n\tb=hw+yf7OUX7AEMWbEoS1okhBCjqdIpAkQCIyLGnEpzCWSZGuGMQ+PFHrCb+xHDIRkF+\n\t9gprT0QY1fhpvudCVYD0fpUAySZucFU/Q4M5IahyboPrG0PtGSHslT5xPKiXSJbGYMRT\n\tDBckEvEvEVqmQcjMJ86fJ8XHginOuU+OP1wDvI2RZxSEQ5RBCV6oC1RVa75dUHegNsRo\n\tGNCPoZoEWwcVjKpT+DfQDQT1cEJgv+quasqxT/1wIvLVV+Zz0PCK7FDRMblAV79g5nl3\n\t5fo77UIc6wyd5dhX8vigXuuVVKsc0tqV7ybZPzTrIGMzVT4ZeG2CN3sEhP5FdOyYhVaU\n\tonVA==","X-Gm-Message-State":"AHPjjUhPqCSb53ycLFGNy96sTvMJmA+P9jZMjD7T9vzGfUd7vG+hwRpQ\n\t/qluyH2FwrBQW+nB5zY798j+DcvGxq8pcyOPVR3BAxvB","X-Google-Smtp-Source":"AOwi7QCVJFkY0RQIZ4hFsywqOxwQpvdGb6oLtgKzBN7/cbbftUFTR872ZQENDLOCHkMeDYFmAaWSGo1IZirwqKWA1aY=","X-Received":"by 10.98.245.74 with SMTP id n71mr3495534pfh.102.1505595648278; \n\tSat, 16 Sep 2017 14:00:48 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAH2r5ms2MG+QoS77v_skYCoRod98xEUmCs2osWJBQUZRAVLhgg@mail.gmail.com>","References":"<CAH2r5ms2MG+QoS77v_skYCoRod98xEUmCs2osWJBQUZRAVLhgg@mail.gmail.com>","From":"Steve French <smfrench@gmail.com>","Date":"Sat, 16 Sep 2017 16:00:27 -0500","Message-ID":"<CAH2r5mtVG3DDSwurFPBcELeuahiuLvxnNhKy40Ok0jcP5Yks+g@mail.gmail.com>","Subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","To":"\"linux-cifs@vger.kernel.org\" <linux-cifs@vger.kernel.org>,\n\tsamba-technical <samba-technical@lists.samba.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1769720,"web_url":"http://patchwork.ozlabs.org/comment/1769720/","msgid":"<CAH2r5muynrFupxEE+OCcaepwnn7wKA4Ua9rtXZCbgPdbVmnSUQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-17T15:21:25","subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"updated with more feedback\nhttps://git.samba.org/?p=sfrench/cifs-2.6.git;a=commitdiff;h=513f5b9040fdb0d1af887da9919be3fc07dcc236\n\nOn Sat, Sep 16, 2017 at 4:00 PM, Steve French <smfrench@gmail.com> wrote:\n> Updated with feedback from Pavel\n>\n> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=shortlog;h=refs/heads/for-next\n>\n> On Fri, Sep 15, 2017 at 10:59 PM, Steve French <smfrench@gmail.com> wrote:\n>> SMB2.1 or later dialect (instead of forcing only SMB3) for cifs.ko -\n>> makes it easier if server is Windows 7 (last release dialect default\n>> was upgraded from smb1/cifs to smb3 - but multidialect negotiation was\n>> not supported until now)\n>>\n>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=0e0f8ad440ac117685aeed4df16f320c7e9ac1c6\n>>\n>> or see attached\n>>\n>>\n>>\n>> --\n>> Thanks,\n>>\n>> Steve\n>\n>\n>\n> --\n> Thanks,\n>\n> Steve","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dYtmHTVc\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwCXr4Z6hz9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 01:21:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751529AbdIQPVr (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSun, 17 Sep 2017 11:21:47 -0400","from mail-pg0-f45.google.com ([74.125.83.45]:48566 \"EHLO\n\tmail-pg0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751353AbdIQPVr (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Sun, 17 Sep 2017 11:21:47 -0400","by mail-pg0-f45.google.com with SMTP id v66so3780110pgb.5\n\tfor <linux-cifs@vger.kernel.org>;\n\tSun, 17 Sep 2017 08:21:46 -0700 (PDT)","by 10.100.140.202 with HTTP; Sun, 17 Sep 2017 08:21:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to;\n\tbh=SNRDn+0r+E7DHPWMMR0vRoQDY8Zo0umvYwSl+mHdOOs=;\n\tb=dYtmHTVcFTahfa3/q4dDRZoeGUtFoFIHW86UwcxwjpNDS6MGSXMXXOotxtWfRTlS9H\n\trgsulFS9amhGeVvFHj2QD7extm9VHxh+K1Ezkm9hvTubFYXkMyWgBo/VvTIEneypTX15\n\tg3IyBCGZ7aLfRWAzZIV79RMWmcybbYqawhcels08gJRqlFLsIAifKdYCN1Lw+6GEeChy\n\tNTafeDF0ZVZMR2+wxUqML/VfnxGWB/BPSPwJrphUA75E8bkOB0f7urgfBSQ+afEzUZLB\n\tpbMzFA9OnXAxK1bjpT1Ong/lK3YkCojbIJhvp2uO1P4Np9kuRrRPHAOJWkJR48sqhFr6\n\ttV4w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=SNRDn+0r+E7DHPWMMR0vRoQDY8Zo0umvYwSl+mHdOOs=;\n\tb=mJkfEA2PSlP5acB24YF1gQ8hkrjX8coXiH8Z1uX5dHJCcsHCFUt7a7Vfhrf6mwN8zW\n\t29wtGnZW595X/cf8hQRnBfZdiRQJwAg3jLGf8PqFlp6Jo63b/F8fWuup31m7bGEzs5YO\n\tXNBsaIXqvXURkTQre7Td/wu//ef0FHQSwodyNyM3rNyGjDrIkwsJN69EqE7jhLyTXud3\n\t6c3OpOfcqRllQMtU5QxwpFPZmnN7zWDjH1g/SsBBlKEGsNGVLe4StR9Fa/s/NoWW7cvU\n\tODaZSB7F2exLcqnylOypM1wXSy8e1M1Yj8Sxrc4BvIaAY1/9bi6HYBnwWbKuss4GDBov\n\t4iLw==","X-Gm-Message-State":"AHPjjUj55jr3FSkqhNBjoE7Odop9ZpoasivWjoZW2xiVjnBrLsMYb9ce\n\thKeL528N3GuLCTi+ZTZsR8mDGKztXg4KjW/1jnFsQmSb","X-Google-Smtp-Source":"AOwi7QBLaXpLV5UmdVemiJfe2jRJHuOQYcotRcEH4+b+28XhpFMw5dKNLHqXBQF5JXTt/Bvf6+xbgxqndlmiGba6S2g=","X-Received":"by 10.84.141.131 with SMTP id 3mr18950806plv.219.1505661705823; \n\tSun, 17 Sep 2017 08:21:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAH2r5mtVG3DDSwurFPBcELeuahiuLvxnNhKy40Ok0jcP5Yks+g@mail.gmail.com>","References":"<CAH2r5ms2MG+QoS77v_skYCoRod98xEUmCs2osWJBQUZRAVLhgg@mail.gmail.com>\n\t<CAH2r5mtVG3DDSwurFPBcELeuahiuLvxnNhKy40Ok0jcP5Yks+g@mail.gmail.com>","From":"Steve French <smfrench@gmail.com>","Date":"Sun, 17 Sep 2017 10:21:25 -0500","Message-ID":"<CAH2r5muynrFupxEE+OCcaepwnn7wKA4Ua9rtXZCbgPdbVmnSUQ@mail.gmail.com>","Subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","To":"\"linux-cifs@vger.kernel.org\" <linux-cifs@vger.kernel.org>,\n\tsamba-technical <samba-technical@lists.samba.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1769783,"web_url":"http://patchwork.ozlabs.org/comment/1769783/","msgid":"<CAN05THQ57rmKMGJ6_1ehRF7TSX2avOB0c+ra+nqhSBqT8p=d5Q@mail.gmail.com>","list_archive_url":null,"date":"2017-09-17T20:27:22","subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","submitter":{"id":6089,"url":"http://patchwork.ozlabs.org/api/people/6089/","name":"ronnie sahlberg","email":"ronniesahlberg@gmail.com"},"content":"Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>\n\n\nMinor nit:\n+       } else if (strcmp(tcon->ses->server->vals->version_string,\n+               SMB3DEFAULT_VERSION_STRING) == 0) {\n+               vneg_inbuf.Dialects[0] = cpu_to_le16(SMB21_PROT_ID);\n+               vneg_inbuf.Dialects[1] = cpu_to_le16(SMB30_PROT_ID);\n+               vneg_inbuf.Dialects[2] = cpu_to_le16(SMB302_PROT_ID);\n\nSMB3DEFAULT_VERSION has SMB3 in the name but also offers and supports smb2.1\nI have no suggestion on a better name though :-(\n\n\n\nOn Mon, Sep 18, 2017 at 1:21 AM, Steve French <smfrench@gmail.com> wrote:\n> updated with more feedback\n> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commitdiff;h=513f5b9040fdb0d1af887da9919be3fc07dcc236\n>\n> On Sat, Sep 16, 2017 at 4:00 PM, Steve French <smfrench@gmail.com> wrote:\n>> Updated with feedback from Pavel\n>>\n>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=shortlog;h=refs/heads/for-next\n>>\n>> On Fri, Sep 15, 2017 at 10:59 PM, Steve French <smfrench@gmail.com> wrote:\n>>> SMB2.1 or later dialect (instead of forcing only SMB3) for cifs.ko -\n>>> makes it easier if server is Windows 7 (last release dialect default\n>>> was upgraded from smb1/cifs to smb3 - but multidialect negotiation was\n>>> not supported until now)\n>>>\n>>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=0e0f8ad440ac117685aeed4df16f320c7e9ac1c6\n>>>\n>>> or see attached\n>>>\n>>>\n>>>\n>>> --\n>>> Thanks,\n>>>\n>>> Steve\n>>\n>>\n>>\n>> --\n>> Thanks,\n>>\n>> Steve\n>\n>\n>\n> --\n> Thanks,\n>\n> Steve\n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TnC+eQW4\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwLKV61Wvz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 06:27:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751632AbdIQU1Z (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSun, 17 Sep 2017 16:27:25 -0400","from mail-qk0-f182.google.com ([209.85.220.182]:43126 \"EHLO\n\tmail-qk0-f182.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751334AbdIQU1Y (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Sun, 17 Sep 2017 16:27:24 -0400","by mail-qk0-f182.google.com with SMTP id j5so5749455qkd.0\n\tfor <linux-cifs@vger.kernel.org>;\n\tSun, 17 Sep 2017 13:27:24 -0700 (PDT)","by 10.12.136.72 with HTTP; Sun, 17 Sep 2017 13:27:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=nvdViCiQgVCUyXEjHcIA4M75HwJUDvV7yXgNcS0cC84=;\n\tb=TnC+eQW4JxEihPqDIp3EktP7oKSmeHMRwldc8fwnDgba5U89tEuKiKgiL9oT93IiWh\n\tOW0n7WlmVL/ybNTL35qLMkY6QNnblJh8O3q7qzrgCQPYfU/NrdIPlr8fGZmPFfMXTFQZ\n\t3B2RqIWH3EYc0qiT8CDKis4CzeDh3pgt/2i3T0ns955HxlvGTH/aAqcA14ZdGCehrYKg\n\tEvBGI0CYDDTGqZ5SWkpqokKGZ+wQab+1DyFBoVp5eA+R2VHg+M5gNK0M4ZA0n1TQwt1G\n\tvF/7604unhTrX+y5BxGIJ5kupI2h0L/vrbtRNt2ckPWQCGp6jbj4s41Fa4t9Y7MnZPVi\n\tqw4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=nvdViCiQgVCUyXEjHcIA4M75HwJUDvV7yXgNcS0cC84=;\n\tb=dT3m5iodxV/nOCW6AsLOUEBTMhFcQmJvxB+NziLpcXdgF5OOXVg4tFNx09xvVF+xSB\n\tBWxcfqO8mrAHhX+gaSJOv6sl+Rm4KvYV4upigRmweS3IztfnOleNSOpXvMgb1d5z+18D\n\te3HGpAPdfXQGY8cDJp9Hhrw7+Xpb0ynikKr6eCC+eLcMnJgUs7rCbmgos7+eaE9fXlIu\n\tpK1SLcprYpeQy6rjColJp+mZtXQJwZ0EV9d9IheSIENYjx8bIjAS1mmTn3vjZ8orDE+n\n\tsr5lwovddFs541JD7hX75O/QJnr+VGBta1nbMW21j72/nJjdHt4SdR8AALMk34ehvM4D\n\tj1ZA==","X-Gm-Message-State":"AHPjjUhcu01ea9r3XKcVgMI6aTS6dkJp+Fe2EzabaaxBQ6g3dWNJSOSG\n\tF7QmSu1EgjuUqbx7X4buyDreVPpVCxqHfZelNY4=","X-Google-Smtp-Source":"AOwi7QD+G7DYPp+sq+Q6rYmNeJHjgEIZhPc9hraIO7mgiM2rCO/UcZRncknhvgakSfhcgD/RamOOOvuFZfoO8aJvBmI=","X-Received":"by 10.55.132.131 with SMTP id g125mr17520214qkd.87.1505680044159;\n\tSun, 17 Sep 2017 13:27:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAH2r5muynrFupxEE+OCcaepwnn7wKA4Ua9rtXZCbgPdbVmnSUQ@mail.gmail.com>","References":"<CAH2r5ms2MG+QoS77v_skYCoRod98xEUmCs2osWJBQUZRAVLhgg@mail.gmail.com>\n\t<CAH2r5mtVG3DDSwurFPBcELeuahiuLvxnNhKy40Ok0jcP5Yks+g@mail.gmail.com>\n\t<CAH2r5muynrFupxEE+OCcaepwnn7wKA4Ua9rtXZCbgPdbVmnSUQ@mail.gmail.com>","From":"ronnie sahlberg <ronniesahlberg@gmail.com>","Date":"Mon, 18 Sep 2017 06:27:22 +1000","Message-ID":"<CAN05THQ57rmKMGJ6_1ehRF7TSX2avOB0c+ra+nqhSBqT8p=d5Q@mail.gmail.com>","Subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","To":"Steve French <smfrench@gmail.com>","Cc":"\"linux-cifs@vger.kernel.org\" <linux-cifs@vger.kernel.org>,\n\tsamba-technical <samba-technical@lists.samba.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}},{"id":1769795,"web_url":"http://patchwork.ozlabs.org/comment/1769795/","msgid":"<CAH2r5mvhBefhgB_T-2GgzXSX=Gh3yBULruVjux7_mjhHnUy3sQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-17T21:15:39","subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","submitter":{"id":510,"url":"http://patchwork.ozlabs.org/api/people/510/","name":"Steve French","email":"smfrench@gmail.com"},"content":"ok - renamed to SMBDEFAULT_VERSION (from SMB3DEFAULT_VERSION) and\nrepushed to cifs-2.6.git for-next (along with additional comment fix\nfrom Pavel)\n\nOn Sun, Sep 17, 2017 at 3:27 PM, ronnie sahlberg\n<ronniesahlberg@gmail.com> wrote:\n> Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>\n>\n>\n> Minor nit:\n> +       } else if (strcmp(tcon->ses->server->vals->version_string,\n> +               SMB3DEFAULT_VERSION_STRING) == 0) {\n> +               vneg_inbuf.Dialects[0] = cpu_to_le16(SMB21_PROT_ID);\n> +               vneg_inbuf.Dialects[1] = cpu_to_le16(SMB30_PROT_ID);\n> +               vneg_inbuf.Dialects[2] = cpu_to_le16(SMB302_PROT_ID);\n>\n> SMB3DEFAULT_VERSION has SMB3 in the name but also offers and supports smb2.1\n> I have no suggestion on a better name though :-(\n>\n>\n>\n> On Mon, Sep 18, 2017 at 1:21 AM, Steve French <smfrench@gmail.com> wrote:\n>> updated with more feedback\n>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commitdiff;h=513f5b9040fdb0d1af887da9919be3fc07dcc236\n>>\n>> On Sat, Sep 16, 2017 at 4:00 PM, Steve French <smfrench@gmail.com> wrote:\n>>> Updated with feedback from Pavel\n>>>\n>>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=shortlog;h=refs/heads/for-next\n>>>\n>>> On Fri, Sep 15, 2017 at 10:59 PM, Steve French <smfrench@gmail.com> wrote:\n>>>> SMB2.1 or later dialect (instead of forcing only SMB3) for cifs.ko -\n>>>> makes it easier if server is Windows 7 (last release dialect default\n>>>> was upgraded from smb1/cifs to smb3 - but multidialect negotiation was\n>>>> not supported until now)\n>>>>\n>>>> https://git.samba.org/?p=sfrench/cifs-2.6.git;a=commit;h=0e0f8ad440ac117685aeed4df16f320c7e9ac1c6\n>>>>\n>>>> or see attached\n>>>>\n>>>>\n>>>>\n>>>> --\n>>>> Thanks,\n>>>>\n>>>> Steve\n>>>\n>>>\n>>>\n>>> --\n>>> Thanks,\n>>>\n>>> Steve\n>>\n>>\n>>\n>> --\n>> Thanks,\n>>\n>> Steve\n>> --\n>> To unsubscribe from this list: send the line \"unsubscribe linux-cifs\" in\n>> the body of a message to majordomo@vger.kernel.org\n>> More majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-cifs-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-cifs-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"db6tsiR1\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwMPc2XF5z9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 07:16:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752047AbdIQVQC (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tSun, 17 Sep 2017 17:16:02 -0400","from mail-pg0-f54.google.com ([74.125.83.54]:48655 \"EHLO\n\tmail-pg0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752046AbdIQVQA (ORCPT\n\t<rfc822; linux-cifs@vger.kernel.org>); Sun, 17 Sep 2017 17:16:00 -0400","by mail-pg0-f54.google.com with SMTP id v66so3987984pgb.5\n\tfor <linux-cifs@vger.kernel.org>;\n\tSun, 17 Sep 2017 14:16:00 -0700 (PDT)","by 10.100.140.202 with HTTP; Sun, 17 Sep 2017 14:15:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=S16Kfy/uyIgnfkG8zrktKm6f0p+Zm0D+4Vceh1DIlsw=;\n\tb=db6tsiR1DF8/FNuOmG8yA4/5peyjNGV7057ZZaNv/IHFdjpmaSu2RxYH+Mh4UEK4dK\n\tA10tr/xhqMo8d2eqzcs7j31H0AgmrgZ+QkcK1czVXYyUX1HPKHmGopwXfGYbIsjij+dw\n\taPAVKJ27nuMVJajSVgHmflq4M14e6ty+DJpOQviXN6WM5a25b4lQZwVaa0YLYt/jHyc2\n\tRbgykBFj6Q6qWEOnxV9MC7CcLEB3AfN8qAZ569QpNo04iSfBcwSx4AA+oTi+IFxO9d0F\n\tHhso498wYCaHQsgHJxdyDPu259QTcBCpA/Baus73tdAgpPx5EB7YV2fHOmxiqBk+xUxN\n\tinsA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=S16Kfy/uyIgnfkG8zrktKm6f0p+Zm0D+4Vceh1DIlsw=;\n\tb=URpBi39F16B7hgFQmaADZb35WHVpQhLAHyAkkDsvysJUfAv9W79S0QM57rKsA5hbHk\n\tiAoI3PF2NAbGgSnwRP+mSb2/UQf805gqQ69lPh7tSb4Y6SUNxHK4win4p6mvlJC0PXQH\n\tY/h7QXX836P8n3R18yygkshu/G9P7RVI5oozW2i2sXjA/o1odJcFkAX76JU+SlZhQpuP\n\tJt/9HKOaUXS77hzNB+ZJihBgSN1Ag/JkYznLvo+q0m2PMX3zZi+wr26H0chj/Yxz89L2\n\tDErqoXGlNgc4/cZbc9urSDvjxwSsOaQ5/VXUv0N1w2JrlebDNp64MDf2rpYZ6ijj6n8e\n\tRckg==","X-Gm-Message-State":"AHPjjUiOSP88dvk4JEUiGqKEJpfFS/s5dqIbutU8p7B7xEXzyc2aY8Jl\n\trN+IN+EEaD3O1+UWObw0uxBQJ+LfTfgIdPJqptE=","X-Google-Smtp-Source":"ADKCNb68O6P6mt6NdX2MX5YgX/+ZV16ZzLSFzdRX9a4skw3m3v2tJ5obORusasHsh2h1rN12qRf8zdNViFNmSMn6zfU=","X-Received":"by 10.101.70.203 with SMTP id n11mr30087215pgr.197.1505682959712;\n\tSun, 17 Sep 2017 14:15:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAN05THQ57rmKMGJ6_1ehRF7TSX2avOB0c+ra+nqhSBqT8p=d5Q@mail.gmail.com>","References":"<CAH2r5ms2MG+QoS77v_skYCoRod98xEUmCs2osWJBQUZRAVLhgg@mail.gmail.com>\n\t<CAH2r5mtVG3DDSwurFPBcELeuahiuLvxnNhKy40Ok0jcP5Yks+g@mail.gmail.com>\n\t<CAH2r5muynrFupxEE+OCcaepwnn7wKA4Ua9rtXZCbgPdbVmnSUQ@mail.gmail.com>\n\t<CAN05THQ57rmKMGJ6_1ehRF7TSX2avOB0c+ra+nqhSBqT8p=d5Q@mail.gmail.com>","From":"Steve French <smfrench@gmail.com>","Date":"Sun, 17 Sep 2017 16:15:39 -0500","Message-ID":"<CAH2r5mvhBefhgB_T-2GgzXSX=Gh3yBULruVjux7_mjhHnUy3sQ@mail.gmail.com>","Subject":"Re: [CIFS] [PATCH] Multidialect protocol negotiation for cifs.ko","To":"ronnie sahlberg <ronniesahlberg@gmail.com>","Cc":"\"linux-cifs@vger.kernel.org\" <linux-cifs@vger.kernel.org>,\n\tsamba-technical <samba-technical@lists.samba.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-cifs-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-cifs.vger.kernel.org>","X-Mailing-List":"linux-cifs@vger.kernel.org"}}]