[{"id":1773286,"web_url":"http://patchwork.ozlabs.org/comment/1773286/","msgid":"<20170922160249.73b36922@firefly.ozlabs.ibm.com>","date":"2017-09-22T06:02:49","subject":"Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled()\n\tis true","submitter":{"id":9347,"url":"http://patchwork.ozlabs.org/api/people/9347/","name":"Balbir Singh","email":"bsingharora@gmail.com"},"content":"On Fri, 15 Sep 2017 18:21:07 -0700\nRam Pai wrote:\n\n> Currently the architecture specific code is expected to\n> display the protection keys in smap for a given vma.\n> This can lead to redundant code and possibly to divergent\n> formats in which the key gets displayed.\n> \n> This patch changes the implementation. It displays the\n> pkey only if the architecture support pkeys.\n> \n> x86 arch_show_smap() function is not needed anymore.\n> Delete it.\n> \n> Signed-off-by: Ram Pai \n> ---\n> arch/x86/kernel/setup.c | 8 --------\n> fs/proc/task_mmu.c | 11 ++++++-----\n> 2 files changed, 6 insertions(+), 13 deletions(-)\n> \n> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c\n> index 3486d04..1953bce 100644\n> --- a/arch/x86/kernel/setup.c\n> +++ b/arch/x86/kernel/setup.c\n> @@ -1340,11 +1340,3 @@ static int __init register_kernel_offset_dumper(void)\n> \treturn 0;\n> }\n> __initcall(register_kernel_offset_dumper);\n> -\n> -void arch_show_smap(struct seq_file *m, struct vm_area_struct *vma)\n> -{\n> -\tif (!boot_cpu_has(X86_FEATURE_OSPKE))\n> -\t\treturn;\n> -\n> -\tseq_printf(m, \"ProtectionKey: %8u\\n\", vma_pkey(vma));\n> -}\n> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c\n> index cf25306..667d44a 100644\n> --- a/fs/proc/task_mmu.c\n> +++ b/fs/proc/task_mmu.c\n> @@ -16,6 +16,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> @@ -714,10 +715,6 @@ static int smaps_hugetlb_range(pte_t *pte, unsigned long hmask,\n> }\n> #endif /* HUGETLB_PAGE */\n> \n> -void __weak arch_show_smap(struct seq_file *m, struct vm_area_struct *vma)\n> -{\n> -}\n> -\n> static int show_smap(struct seq_file *m, void *v, int is_pid)\n> {\n> \tstruct vm_area_struct *vma = v;\n> @@ -803,7 +800,11 @@ static int show_smap(struct seq_file *m, void *v, int is_pid)\n> \t\t (vma->vm_flags & VM_LOCKED) ?\n> \t\t\t(unsigned long)(mss.pss >> (10 + PSS_SHIFT)) : 0);\n> \n> -\tarch_show_smap(m, vma);\n> +#ifdef CONFIG_ARCH_HAS_PKEYS\n> +\tif (arch_pkeys_enabled())\n> +\t\tseq_printf(m, \"ProtectionKey: %8u\\n\", vma_pkey(vma));\n> +#endif\n\nCan CONFIG_ARCH_HAS_PKEYS be true, but the kernel compiled without\nsupport for them or it's just not enabled? I think the\nearlier per_arch function was better\n\nBalbir","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz2xR6vdcz9sBd\n\tfor ;\n\tFri, 22 Sep 2017 16:04:27 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xz2xR5d1hzDsNL\n\tfor ;\n\tFri, 22 Sep 2017 16:04:27 +1000 (AEST)","from mail-pg0-x242.google.com (mail-pg0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c05::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xz2vp1mlfzDsMy\n\tfor ;\n\tFri, 22 Sep 2017 16:03:02 +1000 (AEST)","by mail-pg0-x242.google.com with SMTP id v5so100695pgn.4\n\tfor ;\n\tThu, 21 Sep 2017 23:03:02 -0700 (PDT)","from firefly.ozlabs.ibm.com ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\te3sm6218591pga.80.2017.09.21.23.02.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Sep 2017 23:03:00 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c30PiC1W\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c30PiC1W\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::242; helo=mail-pg0-x242.google.com;\n\tenvelope-from=bsingharora@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c30PiC1W\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OLx5CFeCAOTSp7HiRB88wxxURkEqWT4E3dL8JriaeTg=;\n\tb=c30PiC1W9Zu3PtSndt/TF0tRbjL8Z8iREXZsPLATbWmBYTSW/0p9iRcCi3Gs9qZr2k\n\tNOUl65jKpsWR+GVl6WgDeOfffiXcLJLsKo+PrhWPqkCECBVn99koRIgtF8zY9xNsBYOV\n\taU12l4uKlfbIlOT0hf79jMKB6QnJUyvR9gLDGaGIB+rGNrt72MuxlomzYt30FLk1uLDl\n\tRAmMmYZqIxJQicQ0hW+km5/dn0gG4VqpcNkhbuG+4R9u+muDe2IQ/ExqmFAp1qwXMenn\n\teL34/C1aEqb8ahzJB0Xzz+RSmRdyWWhK4DNPCfkeTdnWqQOX2qCHBIN+XNpml2wsqGtX\n\tB9sQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=OLx5CFeCAOTSp7HiRB88wxxURkEqWT4E3dL8JriaeTg=;\n\tb=tDpa+TVBQTMpKytMDIX1Lz4zclj1Kg4cX0XOZ8eX59/u5wjeiWTIJZVK2zmcUC7My8\n\tNb5/6Dllh84P0ExepyLWjOJ5d2jDuheqK+jSbxYD4cypS5aHRQo/jTueF2BmbwAAGBM1\n\tpt6gepm1J34LErBVzRSipEeIZNpvwaCdatcTHf34HEVXv7VO9OWWy73TJg2kQ7dZsZbh\n\tezP5vAHqo3KTCk7IOzMn9GcKrlaHQoPSdBn3VOLotDS4pZ8oCKnZVy3j46uGPtylhT7Z\n\t1qZObFxJRkzdM3Wx5u6DTAZ5Fu1D+n1dNuPt19E58VS9ftYdkn2nUdVHh3rRLZqoHLXY\n\tssqw==","X-Gm-Message-State":"AHPjjUj7QHrORq2UqRnDTkb0vVR/2SpDTVISPrW+BO6hCwG2GFz/saEf\n\tSzGuocS8r1EkRvAw/QkEs0s=","X-Google-Smtp-Source":"AOwi7QC9AD17NezpHZlj2lLqoVKmvNbtBpA/kjgIEjrjOaaahcCaFrJ/tYKEcwg8sKq1E0nGlqd2XQ==","X-Received":"by 10.84.217.94 with SMTP id e30mr8157458plj.380.1506060180430; \n\tThu, 21 Sep 2017 23:03:00 -0700 (PDT)","Date":"Fri, 22 Sep 2017 16:02:49 +1000","From":"Balbir Singh ","To":"Ram Pai ","Subject":"Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled()\n\tis true","Message-ID":"<20170922160249.73b36922@firefly.ozlabs.ibm.com>","In-Reply-To":"<1505524870-4783-4-git-send-email-linuxram@us.ibm.com>","References":"<1505524870-4783-1-git-send-email-linuxram@us.ibm.com>\n\t<1505524870-4783-4-git-send-email-linuxram@us.ibm.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-arch@vger.kernel.org, corbet@lwn.net, ebiederm@xmission.com,\n\tarnd@arndb.de, linux-doc@vger.kernel.org, x86@kernel.org,\n\tlinux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, \n\tmingo@redhat.com, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com, \n\tbauerman@linux.vnet.ibm.com, akpm@linux-foundation.org,\n\tlinuxppc-dev@lists.ozlabs.org, khandual@linux.vnet.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1773289,"web_url":"http://patchwork.ozlabs.org/comment/1773289/","msgid":"<20170922160859.33a01da9@firefly.ozlabs.ibm.com>","date":"2017-09-22T06:08:59","subject":"Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled()\n\tis true","submitter":{"id":9347,"url":"http://patchwork.ozlabs.org/api/people/9347/","name":"Balbir Singh","email":"bsingharora@gmail.com"},"content":"On Fri, 15 Sep 2017 18:21:07 -0700\nRam Pai wrote:\n\n> +#ifdef CONFIG_ARCH_HAS_PKEYS\n> +\tif (arch_pkeys_enabled())\n\nSorry, I missed this bit in my previous review\nthe patch makes sense\n\n> +\t\tseq_printf(m, \"ProtectionKey: %8u\\n\", vma_pkey(vma));\n> +#endif\n> +\n\nBalbir","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xz34p0kccz9sNc\n\tfor ;\n\tFri, 22 Sep 2017 16:10:50 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xz34n6hFyzDsMB\n\tfor ;\n\tFri, 22 Sep 2017 16:10:49 +1000 (AEST)","from mail-pf0-x243.google.com (mail-pf0-x243.google.com\n\t[IPv6:2607:f8b0:400e:c00::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xz32x0K0czDsM9\n\tfor ;\n\tFri, 22 Sep 2017 16:09:12 +1000 (AEST)","by mail-pf0-x243.google.com with SMTP id h4so89461pfk.0\n\tfor ;\n\tThu, 21 Sep 2017 23:09:12 -0700 (PDT)","from firefly.ozlabs.ibm.com ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tm5sm5733725pfg.12.2017.09.21.23.09.04\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Sep 2017 23:09:10 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c7K6lxhC\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c7K6lxhC\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::243; helo=mail-pf0-x243.google.com;\n\tenvelope-from=bsingharora@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"c7K6lxhC\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=J07uIhPB/irpM2H7E7+g3zf6AmC9pd4/loIKTvz4a3M=;\n\tb=c7K6lxhC5Yp7ZfiKArS8CEkWvrhJgn8osR0IwWaIAEhJeChxEwk0tlw4GiqgaYmtJT\n\tb09eIVfcP9jLulQGWBL1SA5N7g2HI6QodUrZcsPc6vUUjuc510KI0VzG9pBPqQk90oDq\n\tV+7NiXurJ0d74TW1Vc1/o0Pl0kDAwj427AdYd5mETMe+vSDL5U+/xXgCELFMvziLSIPw\n\tUDQzrTgklEldWZDkGc1c5Hu/5+GhW/yldTtls2ZvCLcFnWbmWjVtPxbhhi44b+3TJgsq\n\thQIi6XM7BjuBaSBIYsXLiAoIrCowll+qNJNQYviqfxidhI7/CyO46MPJTqj4hv7gopNP\n\t3kRQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=J07uIhPB/irpM2H7E7+g3zf6AmC9pd4/loIKTvz4a3M=;\n\tb=ZH6tqTyv8Y0zLcaqKitiDThjIBckM5M133qbvFeB70cLw3hHgK0oFpDIyC8Lcmvkc2\n\t+Evoe3fTM3e9RKv9JdkqxtomOHXOx2Jx76lPdFDVUlSLT8cNCwUYe9o9TRKj7SonUthZ\n\twbEawypLep0czwvPXutX/m+d0j9bIGnMLZhYo1ZawUh4l1T+sUlxsGJoOBeJdUnmyLli\n\tFRyhufa7CP9ZDp5ub912qPR9QWMJG3Wi2u7Kt4dKrVmorvLbI0q8z8vuRuo2QCbAxcwK\n\t+x8HwyaA53mqKGL/d9vgsFPRGDeyeyaG9n7ewFonXVoLXOPhllr9o0XJQPV5INNDRo/e\n\t+qIQ==","X-Gm-Message-State":"AHPjjUhgZ+ayTYQhD5eynaWHYJWizhOmsAXbeQhZpX58gJQXlJ5H7tO0\n\tigVqL/18McHEcmBG6KPJntg=","X-Google-Smtp-Source":"AOwi7QAZcx8QmI8uRmlztphl9Mfg4yagwdgRN5tKshy8gn1zow8h/UElwM/H7QqVWNbZzsZKVqKkdw==","X-Received":"by 10.101.77.74 with SMTP id j10mr8248915pgt.324.1506060550457; \n\tThu, 21 Sep 2017 23:09:10 -0700 (PDT)","Date":"Fri, 22 Sep 2017 16:08:59 +1000","From":"Balbir Singh ","To":"Ram Pai ","Subject":"Re: [PATCH 3/6] mm: display pkey in smaps if arch_pkeys_enabled()\n\tis true","Message-ID":"<20170922160859.33a01da9@firefly.ozlabs.ibm.com>","In-Reply-To":"<1505524870-4783-4-git-send-email-linuxram@us.ibm.com>","References":"<1505524870-4783-1-git-send-email-linuxram@us.ibm.com>\n\t<1505524870-4783-4-git-send-email-linuxram@us.ibm.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-arch@vger.kernel.org, corbet@lwn.net, ebiederm@xmission.com,\n\tarnd@arndb.de, linux-doc@vger.kernel.org, x86@kernel.org,\n\tlinux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, \n\tmingo@redhat.com, paulus@samba.org, aneesh.kumar@linux.vnet.ibm.com, \n\tbauerman@linux.vnet.ibm.com, akpm@linux-foundation.org,\n\tlinuxppc-dev@lists.ozlabs.org, khandual@linux.vnet.ibm.com","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]