[{"id":1769532,"web_url":"http://patchwork.ozlabs.org/comment/1769532/","msgid":"<150552534557.36.6298260689683979204@69b6ddf88678>","list_archive_url":null,"date":"2017-09-16T01:29:06","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PULL 00/11] Ide patches\nMessage-id: 20170916010330.10435-1-jsnow@redhat.com\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nSwitched to a new branch 'test'\nbc6172dc94 AHCI: remove DPRINTF macro\n2ea9b926e3 AHCI: pretty-print FIS to buffer instead of stderr\nd23d77942b AHCI: Rework IRQ constants\nc3e3883d53 AHCI: Replace DPRINTF with trace-events\na3f8dc5d3c IDE: replace DEBUG_AIO with trace events\n3c992d8a98 ATAPI: Replace DEBUG_IDE_ATAPI with tracing events\n3beaa3f939 IDE: add tracing for data ports\n1994e49cc7 IDE: Add register hints to tracing\na446948ea3 IDE: replace DEBUG_IDE with tracing system\n8d2b13d3da hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false\n9bc5607864 ide: ahci: unparent children buses before freeing their memory\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/11: ide: ahci: unparent children buses before freeing their memory...\nChecking PATCH 2/11: hw/ide/microdrive: Mark the dscm1xxxx device with user_creatable = false...\nChecking PATCH 3/11: IDE: replace DEBUG_IDE with tracing system...\nERROR: spaces required around that '|' (ctx:VxV)\n#146: FILE: hw/ide/core.c:1197:\n+ if (reg_num != 7 && (s->status & (BUSY_STAT|DRQ_STAT))) {\n ^\n\ntotal: 1 errors, 0 warnings, 337 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 4/11: IDE: Add register hints to tracing...\nChecking PATCH 5/11: IDE: add tracing for data ports...\nChecking PATCH 6/11: ATAPI: Replace DEBUG_IDE_ATAPI with tracing events...\nChecking PATCH 7/11: IDE: replace DEBUG_AIO with trace events...\nChecking PATCH 8/11: AHCI: Replace DPRINTF with trace-events...\nERROR: Hex numbers must be prefixed with '0x'\n#548: FILE: hw/ide/trace-events:91:\n+handle_reg_h2d_fis_pmp(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Port Multiplier not supported, FIS: 0x%02x-%02x-%02x\"\n\nERROR: Hex numbers must be prefixed with '0x'\n#549: FILE: hw/ide/trace-events:92:\n+handle_reg_h2d_fis_res(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Reserved flags set in H2D Register FIS, FIS: 0x%02x-%02x-%02x\"\n\nERROR: Hex numbers must be prefixed with '0x'\n#555: FILE: hw/ide/trace-events:98:\n+handle_cmd_unhandled_fis(void *s, int port, uint8_t b0, uint8_t b1, uint8_t b2) \"ahci(%p)[%d]: unhandled FIS type. cmd_fis: 0x%02x-%02x-%02x\"\n\ntotal: 3 errors, 0 warnings, 496 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 9/11: AHCI: Rework IRQ constants...\nChecking PATCH 10/11: AHCI: pretty-print FIS to buffer instead of stderr...\nWARNING: line over 80 characters\n#60: FILE: hw/ide/ahci.c:1206:\n+ char *pretty_fis = ahci_pretty_buffer_fis(ide_state->io_buffer, 0x10);\n\ntotal: 0 errors, 1 warnings, 60 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 11/11: AHCI: remove DPRINTF macro...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvF7K1cmDz9t16\n\tfor ;\n\tSat, 16 Sep 2017 11:29:43 +1000 (AEST)","from localhost ([::1]:55590 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dt1vP-0007om-B0\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 21:29:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53341)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dt1v4-0007oU-3i\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 21:29:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dt1uz-0007Ps-9v\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 21:29:18 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21463)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dt1uz-0007OP-0J\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 21:29:13 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1505525346142110.24257404256241;\n\tFri, 15 Sep 2017 18:29:06 -0700 (PDT)"],"Resent-Date":"Fri, 15 Sep 2017 21:29:18 -0400","Resent-Message-Id":"","In-Reply-To":"<20170916010330.10435-1-jsnow@redhat.com>","Message-ID":"<150552534557.36.6298260689683979204@69b6ddf88678>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"jsnow@redhat.com","Date":"Fri, 15 Sep 2017 18:29:06 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"jsnow@redhat.com, peter.maydell@linaro.org, famz@redhat.com,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1769610,"web_url":"http://patchwork.ozlabs.org/comment/1769610/","msgid":"","list_archive_url":null,"date":"2017-09-16T14:34:50","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 16 September 2017 at 02:03, John Snow wrote:\n> The following changes since commit 5faf2d376af3cb4eb92da44c2580e08d39832caa:\n>\n> Merge remote-tracking branch 'remotes/huth/tags/check-20170915' into staging (2017-09-15 20:29:44 +0100)\n>\n> are available in the git repository at:\n>\n> https://github.com/jnsnow/qemu.git tags/ide-pull-request\n>\n> for you to fetch changes up to 2a94e34d3ecef91727f467cc012587c632099d40:\n>\n> AHCI: remove DPRINTF macro (2017-09-15 20:36:18 -0400)\n>\n> ----------------------------------------------------------------\n>\n> ----------------------------------------------------------------\n\nHi; I'm afraid this doesn't build with clang:\n\n/home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\ncomparison of unsigned enum expression >= 0 is always true\n[-Werror,-Wtautological-compare]\n if (enval >= 0 && enval < IDE_DMA__COUNT) {\n ~~~~~ ^ ~\n1 error generated.\n\n(It's impdef whether an enum with all positive values is\na signed type or unsigned type, so just deleting the\ncomparison against 0 would also be wrong...)\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"BCSfPPrj\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvZZ11872z9sPk\n\tfor ;\n\tSun, 17 Sep 2017 00:35:36 +1000 (AEST)","from localhost ([::1]:57510 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtEBx-0007iR-JZ\n\tfor incoming@patchwork.ozlabs.org; Sat, 16 Sep 2017 10:35:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50813)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtEBd-0007iJ-Af\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 10:35:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtEBc-0005XI-89\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 10:35:13 -0400","from mail-wr0-x22f.google.com ([2a00:1450:400c:c0c::22f]:49580)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtEBc-0005Wc-1N\n\tfor qemu-devel@nongnu.org; Sat, 16 Sep 2017 10:35:12 -0400","by mail-wr0-x22f.google.com with SMTP id u96so3509779wrb.6\n\tfor ; Sat, 16 Sep 2017 07:35:11 -0700 (PDT)","by 10.223.139.215 with HTTP; Sat, 16 Sep 2017 07:34:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=MaTK3RKPDqpNc36IK8hSFM+dyDYGPfFHyB53yOeCgrg=;\n\tb=BCSfPPrjTZZ/K7ar9BgbFyB7rfv88grr+Lqhmbzon91khDnipFMlP87bRm5FEFYp+C\n\tJq6ifRF/TRUaLGDRZz+Oh2/KrFsACZnOSK2O+RLLIVKni4ZEfT7rXCLcqpQYNzj8/E6x\n\tPGGSrKF2U3nJfNSlUnNWMCz+gYYLYQXVLePvw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=MaTK3RKPDqpNc36IK8hSFM+dyDYGPfFHyB53yOeCgrg=;\n\tb=osgSZj/gdwLDDVM2rrtkX5+sE75GZvvtzOJ/6akCXcqLkv3Kd61zIO/4v2rIakvFAw\n\tkorFWqL7m8vM3dZEp63FXCvKIyV/TmMEmafY5MBFcwpUkcbFHNM/xfhZF5I3NivJHVy5\n\tA0kyuwqmn4/sbb1mU+tKl8X+T0+pI9axiPV4/WmB0oATcvMir/Bs2r8q6mlkIjVwB4jO\n\tq2wtsBhiLA+NILYZTs1nUREWqsAhrRBOSVIFYG2KkVffVoDIICfNvc7POewMOYR7ojcd\n\tgIYpIVI/u2h6IGcIAqkYtn0IZRTP3kvmqpMitiZDN6vPFVX5gW1kY5RNHAUltY1Q86gw\n\tptHQ==","X-Gm-Message-State":"AHPjjUiGdjJYwiKtoyAgQH1dzLuGF1FClYwKWVDgkl4VZ/JMO+i3+BGK\n\tLJVOvLGuzwDmfSL7Y4x+P2PT6MAw35tQjXIdSFTjx3z1V5U=","X-Google-Smtp-Source":"ADKCNb4ghBN2t/HWvGCCSbx1DXeba9xtL436XP6+HH6dbNwdPxNOoXYsQ2hkLwA7MgMa8F4SXioDHO3+Qlme4EZkWHc=","X-Received":"by 10.223.198.202 with SMTP id\n\tc10mr23700946wrh.230.1505572510794; \n\tSat, 16 Sep 2017 07:35:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170916010330.10435-1-jsnow@redhat.com>","References":"<20170916010330.10435-1-jsnow@redhat.com>","From":"Peter Maydell ","Date":"Sat, 16 Sep 2017 15:34:50 +0100","Message-ID":"","To":"John Snow ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::22f","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770174,"web_url":"http://patchwork.ozlabs.org/comment/1770174/","msgid":"","list_archive_url":null,"date":"2017-09-18T13:51:27","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/16/2017 09:34 AM, Peter Maydell wrote:\n\n> Hi; I'm afraid this doesn't build with clang:\n> \n> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\n> comparison of unsigned enum expression >= 0 is always true\n> [-Werror,-Wtautological-compare]\n> if (enval >= 0 && enval < IDE_DMA__COUNT) {\n> ~~~~~ ^ ~\n> 1 error generated.\n> \n> (It's impdef whether an enum with all positive values is\n> a signed type or unsigned type, so just deleting the\n> comparison against 0 would also be wrong...)\n\nBut if ((unsigned)enval < IDE_DMA__COUNT) {\n\nshould work, regardless of the signedness of the enum.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwnVm6yn1z9s7G\n\tfor ;\n\tMon, 18 Sep 2017 23:52:00 +1000 (AEST)","from localhost ([::1]:36734 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtwSt-0005Ad-4w\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 09:51:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34616)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtwSY-0005AQ-AS\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:51:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtwSU-00059Y-FE\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:51:38 -0400","from mx1.redhat.com ([209.132.183.28]:45624)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtwSU-00058w-6e\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 09:51:34 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8D3FA356F8;\n\tMon, 18 Sep 2017 13:51:32 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CC23360BE2;\n\tMon, 18 Sep 2017 13:51:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8D3FA356F8","To":"Peter Maydell , John Snow ","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 18 Sep 2017 08:51:27 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"rj1LbU7xP6O4rDnAUGVIouXg8ppKXfEU9\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 18 Sep 2017 13:51:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770375,"web_url":"http://patchwork.ozlabs.org/comment/1770375/","msgid":"","list_archive_url":null,"date":"2017-09-18T17:55:16","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/16/2017 10:34 AM, Peter Maydell wrote:\n> On 16 September 2017 at 02:03, John Snow wrote:\n>> The following changes since commit 5faf2d376af3cb4eb92da44c2580e08d39832caa:\n>>\n>> Merge remote-tracking branch 'remotes/huth/tags/check-20170915' into staging (2017-09-15 20:29:44 +0100)\n>>\n>> are available in the git repository at:\n>>\n>> https://github.com/jnsnow/qemu.git tags/ide-pull-request\n>>\n>> for you to fetch changes up to 2a94e34d3ecef91727f467cc012587c632099d40:\n>>\n>> AHCI: remove DPRINTF macro (2017-09-15 20:36:18 -0400)\n>>\n>> ----------------------------------------------------------------\n>>\n>> ----------------------------------------------------------------\n> \n> Hi; I'm afraid this doesn't build with clang:\n> \n> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\n> comparison of unsigned enum expression >= 0 is always true\n> [-Werror,-Wtautological-compare]\n> if (enval >= 0 && enval < IDE_DMA__COUNT) {\n> ~~~~~ ^ ~\n> 1 error generated.\n> \n> (It's impdef whether an enum with all positive values is\n> a signed type or unsigned type, so just deleting the\n> comparison against 0 would also be wrong...)\n> \n> thanks\n> -- PMM\n> \n\nHuh, impdef in the general case, but is it undefined for gnu99? I'm\nwondering why Clang can be so certain about this comparison being\nuseless. Is this a Clang \"bug\"?\n\n--js","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwtw46G0Nz9s06\n\tfor ;\n\tTue, 19 Sep 2017 03:55:48 +1000 (AEST)","from localhost ([::1]:38083 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du0Go-0006ip-UE\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 13:55:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51158)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du0GP-0006iQ-Uk\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:55:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du0GM-00006p-UH\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:55:22 -0400","from mx1.redhat.com ([209.132.183.28]:33790)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1du0GM-00006Q-NJ\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:55:18 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DC78CC04B32C;\n\tMon, 18 Sep 2017 17:55:16 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7EF2E60606;\n\tMon, 18 Sep 2017 17:55:16 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DC78CC04B32C","To":"Peter Maydell ","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t","From":"John Snow ","Message-ID":"","Date":"Mon, 18 Sep 2017 13:55:16 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 18 Sep 2017 17:55:17 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770380,"web_url":"http://patchwork.ozlabs.org/comment/1770380/","msgid":"","list_archive_url":null,"date":"2017-09-18T18:00:07","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 18 September 2017 at 18:55, John Snow wrote:\n> On 09/16/2017 10:34 AM, Peter Maydell wrote:\n>> Hi; I'm afraid this doesn't build with clang:\n>>\n>> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\n>> comparison of unsigned enum expression >= 0 is always true\n>> [-Werror,-Wtautological-compare]\n>> if (enval >= 0 && enval < IDE_DMA__COUNT) {\n>> ~~~~~ ^ ~\n>> 1 error generated.\n>>\n>> (It's impdef whether an enum with all positive values is\n>> a signed type or unsigned type, so just deleting the\n>> comparison against 0 would also be wrong...)\n\n> Huh, impdef in the general case, but is it undefined for gnu99? I'm\n> wondering why Clang can be so certain about this comparison being\n> useless. Is this a Clang \"bug\"?\n\nMy guess is that clang as an implementation picks unsigned\nin this case, that it then effectively lowers all the enums\nto just being integer arithmetic, and then the warning pass\ncoming along later doesn't know that the unsigned thing it's\ncomparing is an enum.\n\nI think you could argue that it would at least be helpful\nif clang didn't warn about comparisons that only happen\nto be useless for this particular platform/impdef choice\nbut are useful for the same code compiled with a different\ncompiler.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Br6F4wmt\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwv2H3VxMz9s7F\n\tfor ;\n\tTue, 19 Sep 2017 04:01:10 +1000 (AEST)","from localhost ([::1]:38135 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du0Ly-00007B-80\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 14:01:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53154)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du0LS-00006g-NY\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:00:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du0LN-0002El-Ar\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:00:34 -0400","from mail-wr0-x234.google.com ([2a00:1450:400c:c0c::234]:57098)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1du0LN-0002EO-2x\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:00:29 -0400","by mail-wr0-x234.google.com with SMTP id r74so1166688wrb.13\n\tfor ; Mon, 18 Sep 2017 11:00:28 -0700 (PDT)","by 10.223.139.215 with HTTP; Mon, 18 Sep 2017 11:00:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=CjJoUB7VZz7vzZRkuo/ntRaDr+uDKb9Zxsx6wD4jhTo=;\n\tb=Br6F4wmtaoAce9ceIgZwp0lDBK03DZYXkXI+50WrssbKrCicEVFoyRi1iKkjJSF+sE\n\tuFfYdEoMBfgYAOQoZ0PiEteNtk3dIhCbe2V2V5pDIRamBN4qH5TqCDMUgLiZFsZRYku2\n\t+Zvtjke2UqDbk6kTWR47S2/OuPit5ap3h/VjU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=CjJoUB7VZz7vzZRkuo/ntRaDr+uDKb9Zxsx6wD4jhTo=;\n\tb=HIBO7oqkJtTe1TP6Qz58s6/Y/L6SwwZpb2b5p2WFCO3VdhZ3klqPQX/z0HdtF/kVo9\n\texvr7B/Pzy8pQz4tysuMzlVjy/8Yp+YsY6CZi0Z0mEZiOo9ow1J3G56eMxZsszjPf1X4\n\tl8iUsGFZPQA8Aby8jE7hcqRa34pr7nBtKbWh7zgCmVlCQjs32vvqJqxiDvadG8jiXp/s\n\tETX1OX5bO42bFXO5Epd70RtT9Dg1hE4hWJ8EGAv3tmvoIyKaiQjFuB9VUJFqJAt8WfX8\n\tQOWdACFquiITvi4tlc34QfP3qZ4X4mHcgFeyerONP2aC4L82PdO6vUi+1eEP6y8GjR7u\n\tOqAQ==","X-Gm-Message-State":"AHPjjUjCEihoTtrm7zP6BiGl4Bc7+zMLDuzlx4OZuM0YW/F36+67g0Tk\n\tkSm4RuUkQTl/apbY92lUQA/jShqee34gMnCGXwpZCw==","X-Google-Smtp-Source":"ADKCNb7k3bvoPndIznlEytZUefOsN3WevJEACQNMhGShiq5akTJy19Wppi8IkRzBFhs1xmm3YlaIly0RYJ5eHPoQdIY=","X-Received":"by 10.223.142.82 with SMTP id n76mr32322456wrb.272.1505757627794;\n\tMon, 18 Sep 2017 11:00:27 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t\n\t","From":"Peter Maydell ","Date":"Mon, 18 Sep 2017 19:00:07 +0100","Message-ID":"","To":"John Snow ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::234","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770390,"web_url":"http://patchwork.ozlabs.org/comment/1770390/","msgid":"","list_archive_url":null,"date":"2017-09-18T18:14:57","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 18 September 2017 at 19:00, Peter Maydell wrote:\n> On 18 September 2017 at 18:55, John Snow wrote:\n>> On 09/16/2017 10:34 AM, Peter Maydell wrote:\n>>> Hi; I'm afraid this doesn't build with clang:\n>>>\n>>> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\n>>> comparison of unsigned enum expression >= 0 is always true\n>>> [-Werror,-Wtautological-compare]\n>>> if (enval >= 0 && enval < IDE_DMA__COUNT) {\n>>> ~~~~~ ^ ~\n>>> 1 error generated\n\n\n> I think you could argue that it would at least be helpful\n> if clang didn't warn about comparisons that only happen\n> to be useless for this particular platform/impdef choice\n> but are useful for the same code compiled with a different\n> compiler.\n\nA bit of googling and some experimentation reveals that\nclang deliberately suppresses this warning in the special\ncase of comparing against an enum value which happens to\nbe zero (but not for literal constant zero!). So this will\nbe fine:\n if (enval >= IDE_DMA_READ && enval < IDE_DMA__COUNT)\n\n(or more sensibly you'd want to define an enum constant\nfor IDE_DMA__FIRST or something rather than relying on\nREAD being 0.)\n\n(found here:\nhttp://clang-developers.42468.n3.nabble.com/Possibly-invalid-enum-tautology-warning-td3233140.html\n)\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"cxgLKiHn\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwvMG6Zxdz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 04:15:54 +1000 (AEST)","from localhost ([::1]:38199 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du0aH-0005JG-1R\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 14:15:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57436)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du0Zl-0005HK-0K\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:15:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du0Zj-0001M3-R1\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:15:20 -0400","from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:48190)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1du0Zj-0001KP-JW\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 14:15:19 -0400","by mail-wm0-x234.google.com with SMTP id r68so5051761wmg.3\n\tfor ; Mon, 18 Sep 2017 11:15:19 -0700 (PDT)","by 10.223.139.215 with HTTP; Mon, 18 Sep 2017 11:14:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=OATnBdPfjNOPmBrdsnyTXlbwFoRuAJKqTtY//LvwRXI=;\n\tb=cxgLKiHnPesu/zspeeSAxxoTo+M956Xb14bwGpJwUts8UPlMrv9S1NREjntI/NXJAx\n\tCvhD/5ObvtKx191X9dSaZul/vl03kn+ZDRddjo3iY6s1iNFAOBVd/taEKXQCiaDzh/Xy\n\tnL4SoU2eSLAPnsHGDLp1zomaMS25glrO8f9zE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=OATnBdPfjNOPmBrdsnyTXlbwFoRuAJKqTtY//LvwRXI=;\n\tb=kkQFjgoVR0htVZp8e/5X8IHIK+UT2luIvkM9BPWg7wXZWQ5dTbFN7vWX8uYPnsPn7v\n\t0g69+YMBZJBD/RIj6vtVa+wNLX/PVK4yW2S0soSXBd/MecEk6cKw8gvXEfeYd5i447sY\n\tnaRq9t7vPMFMfchx4QCPMY8A4O1U/0P3NfwxSV+JqtEOpV5LYL14vgsLVI6/fWpZnxUY\n\tHcTHvO6Lpf0eljV5D3fHNrBudgwjaHTMhXUiGNnoWJPBtTBsQqadSQJber2gGkLKXBSm\n\tbGrfJVpqKZ2zYBU3NwWgrf+8g00x4xKHxSBxD7c8dbKFB+Bg+0pcXgRfTDaQeDvnu/nm\n\tYP7Q==","X-Gm-Message-State":"AHPjjUjCDrpbYIxsXSSVpWhVSB9p41PwddNXwdOrmOkV5NA1IXPmQIcI\n\tv4H7j0gvdjfdUG3peDZinXnXK0XdWtF5xfETQD02yNYf","X-Google-Smtp-Source":"AOwi7QC+iOGBetUjA+gAGV3TrIOO6zEVFyeHZW/9fMsn3eTHBQ8HtW7HKIF+t+rTniyEMyh8UPR/jgpb/pmpeaRaskY=","X-Received":"by 10.28.166.135 with SMTP id p129mr2958269wme.147.1505758518455;\n\tMon, 18 Sep 2017 11:15:18 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t\n\t\n\t","From":"Peter Maydell ","Date":"Mon, 18 Sep 2017 19:14:57 +0100","Message-ID":"","To":"John Snow ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::234","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772074,"web_url":"http://patchwork.ozlabs.org/comment/1772074/","msgid":"<824faf32-38bc-f3b9-cafb-f60cbd7fd8a7@ilande.co.uk>","list_archive_url":null,"date":"2017-09-20T17:02:31","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":12451,"url":"http://patchwork.ozlabs.org/api/people/12451/","name":"Mark Cave-Ayland","email":"mark.cave-ayland@ilande.co.uk"},"content":"On 18/09/17 19:14, Peter Maydell wrote:\n\n> On 18 September 2017 at 19:00, Peter Maydell wrote:\n>> On 18 September 2017 at 18:55, John Snow wrote:\n>>> On 09/16/2017 10:34 AM, Peter Maydell wrote:\n>>>> Hi; I'm afraid this doesn't build with clang:\n>>>>\n>>>> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\n>>>> comparison of unsigned enum expression >= 0 is always true\n>>>> [-Werror,-Wtautological-compare]\n>>>> if (enval >= 0 && enval < IDE_DMA__COUNT) {\n>>>> ~~~~~ ^ ~\n>>>> 1 error generated\n> \n> \n>> I think you could argue that it would at least be helpful\n>> if clang didn't warn about comparisons that only happen\n>> to be useless for this particular platform/impdef choice\n>> but are useful for the same code compiled with a different\n>> compiler.\n> \n> A bit of googling and some experimentation reveals that\n> clang deliberately suppresses this warning in the special\n> case of comparing against an enum value which happens to\n> be zero (but not for literal constant zero!). So this will\n> be fine:\n> if (enval >= IDE_DMA_READ && enval < IDE_DMA__COUNT)\n> \n> (or more sensibly you'd want to define an enum constant\n> for IDE_DMA__FIRST or something rather than relying on\n> READ being 0.)\n> \n> (found here:\n> http://clang-developers.42468.n3.nabble.com/Possibly-invalid-enum-tautology-warning-td3233140.html\n> )\n\nDoing a git pull and even with the applied version of this patch I get a\nbuild failure on my local gcc-4.7:\n\ncc -I/home/build/src/qemu/git/qemu/hw/ide -Ihw/ide\n-I/home/build/src/qemu/git/qemu/tcg\n-I/home/build/src/qemu/git/qemu/tcg/i386\n-I/home/build/src/qemu/git/qemu/linux-headers\n-I/home/build/src/qemu/git/qemu/linux-headers -I.\n-I/home/build/src/qemu/git/qemu\n-I/home/build/src/qemu/git/qemu/accel/tcg\n-I/home/build/src/qemu/git/qemu/include -I/usr/include/pixman-1\n-I/home/build/src/qemu/git/qemu/dtc/libfdt -Werror -pthread\n-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include\n-m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE\n-Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings\n-Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv\n-Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs\n-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers\n-Wold-style-declaration -Wold-style-definition -Wtype-limits\n-fstack-protector-all -I/usr/include/p11-kit-1\n-I/usr/include/libpng12 -I/home/build/src/qemu/git/qemu/tests -MMD -MP\n-MT hw/ide/core.o -MF hw/ide/core.d -O2 -U_FORTIFY_SOURCE\n-D_FORTIFY_SOURCE=2 -g -c -o hw/ide/core.o hw/ide/core.c\nhw/ide/core.c: In function ‘IDE_DMA_CMD_str’:\nhw/ide/core.c:71:5: error: comparison of unsigned expression >= 0 is\nalways true [-Werror=type-limits]\ncc1: all warnings being treated as errors\nmake: *** [hw/ide/core.o] Error 1\n\nAre there any other workarounds for this at all?\n\n\nATB,\n\nMark.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy5fV2fLvz9t2V\n\tfor ;\n\tThu, 21 Sep 2017 03:03:13 +1000 (AEST)","from localhost ([::1]:49823 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duiP0-0004Pq-Qy\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 13:03:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42998)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duiOf-0004Ph-8A\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:02:50 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duiOb-0003I3-Vw\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:02:49 -0400","from chuckie.co.uk ([82.165.15.123]:57253\n\thelo=s16892447.onlinehome-server.info)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1duiOb-0003HF-Nu\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:02:45 -0400","from host109-151-159-252.range109-151.btcentralplus.com\n\t([109.151.159.252] helo=[192.168.1.65])\n\tby s16892447.onlinehome-server.info with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76)\n\t(envelope-from )\n\tid 1duiOc-0000c1-EB; Wed, 20 Sep 2017 18:02:47 +0100"],"To":"Peter Maydell , John Snow ","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t\n\t\n\t\n\t","From":"Mark Cave-Ayland ","Message-ID":"<824faf32-38bc-f3b9-cafb-f60cbd7fd8a7@ilande.co.uk>","Date":"Wed, 20 Sep 2017 18:02:31 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-SA-Exim-Connect-IP":"109.151.159.252","X-SA-Exim-Mail-From":"mark.cave-ayland@ilande.co.uk","X-SA-Exim-Version":"4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000)","X-SA-Exim-Scanned":"Yes (on s16892447.onlinehome-server.info)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"82.165.15.123","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772123,"web_url":"http://patchwork.ozlabs.org/comment/1772123/","msgid":"<93915fa3-cadb-7639-79bf-e23c39129352@redhat.com>","list_archive_url":null,"date":"2017-09-20T17:55:54","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/20/2017 01:02 PM, Mark Cave-Ayland wrote:\n> On 18/09/17 19:14, Peter Maydell wrote:\n> \n>> On 18 September 2017 at 19:00, Peter Maydell wrote:\n>>> On 18 September 2017 at 18:55, John Snow wrote:\n>>>> On 09/16/2017 10:34 AM, Peter Maydell wrote:\n>>>>> Hi; I'm afraid this doesn't build with clang:\n>>>>>\n>>>>> /home/petmay01/linaro/qemu-for-merges/hw/ide/core.c:70:15: error:\n>>>>> comparison of unsigned enum expression >= 0 is always true\n>>>>> [-Werror,-Wtautological-compare]\n>>>>> if (enval >= 0 && enval < IDE_DMA__COUNT) {\n>>>>> ~~~~~ ^ ~\n>>>>> 1 error generated\n>>\n>>\n>>> I think you could argue that it would at least be helpful\n>>> if clang didn't warn about comparisons that only happen\n>>> to be useless for this particular platform/impdef choice\n>>> but are useful for the same code compiled with a different\n>>> compiler.\n>>\n>> A bit of googling and some experimentation reveals that\n>> clang deliberately suppresses this warning in the special\n>> case of comparing against an enum value which happens to\n>> be zero (but not for literal constant zero!). So this will\n>> be fine:\n>> if (enval >= IDE_DMA_READ && enval < IDE_DMA__COUNT)\n>>\n>> (or more sensibly you'd want to define an enum constant\n>> for IDE_DMA__FIRST or something rather than relying on\n>> READ being 0.)\n>>\n>> (found here:\n>> http://clang-developers.42468.n3.nabble.com/Possibly-invalid-enum-tautology-warning-td3233140.html\n>> )\n> \n> Doing a git pull and even with the applied version of this patch I get a\n> build failure on my local gcc-4.7:\n> \n> cc -I/home/build/src/qemu/git/qemu/hw/ide -Ihw/ide\n> -I/home/build/src/qemu/git/qemu/tcg\n> -I/home/build/src/qemu/git/qemu/tcg/i386\n> -I/home/build/src/qemu/git/qemu/linux-headers\n> -I/home/build/src/qemu/git/qemu/linux-headers -I.\n> -I/home/build/src/qemu/git/qemu\n> -I/home/build/src/qemu/git/qemu/accel/tcg\n> -I/home/build/src/qemu/git/qemu/include -I/usr/include/pixman-1\n> -I/home/build/src/qemu/git/qemu/dtc/libfdt -Werror -pthread\n> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include\n> -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE\n> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings\n> -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv\n> -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs\n> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers\n> -Wold-style-declaration -Wold-style-definition -Wtype-limits\n> -fstack-protector-all -I/usr/include/p11-kit-1\n> -I/usr/include/libpng12 -I/home/build/src/qemu/git/qemu/tests -MMD -MP\n> -MT hw/ide/core.o -MF hw/ide/core.d -O2 -U_FORTIFY_SOURCE\n> -D_FORTIFY_SOURCE=2 -g -c -o hw/ide/core.o hw/ide/core.c\n> hw/ide/core.c: In function ‘IDE_DMA_CMD_str’:\n> hw/ide/core.c:71:5: error: comparison of unsigned expression >= 0 is\n> always true [-Werror=type-limits]\n> cc1: all warnings being treated as errors\n> make: *** [hw/ide/core.o] Error 1\n> \n> Are there any other workarounds for this at all?\n> \n> \n> ATB,\n> \n> Mark.\n> \n\nGuh. From which distro does your GCC 4.7 hail?\n\nRegardless, I suppose I will revert to Eric's workaround, though I like\nthe way it reads an awful lot less.\n\n--js","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy6qx1t02z9s81\n\tfor ;\n\tThu, 21 Sep 2017 03:56:21 +1000 (AEST)","from localhost ([::1]:50027 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dujER-0006l9-1j\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 13:56:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38923)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dujE8-0006l2-SU\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:56:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dujE4-0006gu-NJ\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:56:00 -0400","from mx1.redhat.com ([209.132.183.28]:39280)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dujE4-0006Y7-FT\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 13:55:56 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2F85880463;\n\tWed, 20 Sep 2017 17:55:55 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 85AE76017B;\n\tWed, 20 Sep 2017 17:55:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2F85880463","To":"Mark Cave-Ayland ,\n\tPeter Maydell ","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t\n\t\n\t\n\t\n\t<824faf32-38bc-f3b9-cafb-f60cbd7fd8a7@ilande.co.uk>","From":"John Snow ","Message-ID":"<93915fa3-cadb-7639-79bf-e23c39129352@redhat.com>","Date":"Wed, 20 Sep 2017 13:55:54 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<824faf32-38bc-f3b9-cafb-f60cbd7fd8a7@ilande.co.uk>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 20 Sep 2017 17:55:55 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772165,"web_url":"http://patchwork.ozlabs.org/comment/1772165/","msgid":"","list_archive_url":null,"date":"2017-09-20T19:01:01","subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","submitter":{"id":12451,"url":"http://patchwork.ozlabs.org/api/people/12451/","name":"Mark Cave-Ayland","email":"mark.cave-ayland@ilande.co.uk"},"content":"On 20/09/17 18:55, John Snow wrote:\n\n> Guh. From which distro does your GCC 4.7 hail?\n> \n> Regardless, I suppose I will revert to Eric's workaround, though I like\n> the way it reads an awful lot less.\n\nThanks John - it's just a standard Debian Wheezy installation on amd64.\n\n\nATB,\n\nMark.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy8HB6SQqz9s7h\n\tfor ;\n\tThu, 21 Sep 2017 05:01:41 +1000 (AEST)","from localhost ([::1]:50233 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dukFf-0001En-9w\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 15:01:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41162)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dukFM-0001Ea-Gq\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 15:01:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dukFH-0007tz-NS\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 15:01:20 -0400","from chuckie.co.uk ([82.165.15.123]:57699\n\thelo=s16892447.onlinehome-server.info)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dukFH-0007lU-CS\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 15:01:15 -0400","from host109-151-159-252.range109-151.btcentralplus.com\n\t([109.151.159.252] helo=[192.168.1.65])\n\tby s16892447.onlinehome-server.info with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76)\n\t(envelope-from )\n\tid 1dukFF-0001Hz-IR; Wed, 20 Sep 2017 20:01:14 +0100"],"To":"John Snow , Peter Maydell ","References":"<20170916010330.10435-1-jsnow@redhat.com>\n\t\n\t\n\t\n\t\n\t<824faf32-38bc-f3b9-cafb-f60cbd7fd8a7@ilande.co.uk>\n\t<93915fa3-cadb-7639-79bf-e23c39129352@redhat.com>","From":"Mark Cave-Ayland ","Message-ID":"","Date":"Wed, 20 Sep 2017 20:01:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<93915fa3-cadb-7639-79bf-e23c39129352@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-SA-Exim-Connect-IP":"109.151.159.252","X-SA-Exim-Mail-From":"mark.cave-ayland@ilande.co.uk","X-SA-Exim-Version":"4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000)","X-SA-Exim-Scanned":"Yes (on s16892447.onlinehome-server.info)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"82.165.15.123","Subject":"Re: [Qemu-devel] [PULL 00/11] Ide patches","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"QEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]