[{"id":1769528,"web_url":"http://patchwork.ozlabs.org/comment/1769528/","msgid":"<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-16T00:34:56","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote:\n> On a linksys E1200v1 (actually a crossflashed E1000v2), the offloading features give no measurable benefit to speed or latency. Furthermore, disabling GRO actually improves iperf performance by a whoppimg 3mbps. Results:\n> \n> Currently:\n\n> \n> v2: Changed napi_gro_receive to netif_receive_skb. Seems to have an identical result.\n> \n> Signed-off-by: Rosen Penev \n> ---\n> drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c\n> index 48d672b204a4..1fb0053aeee7 100644\n> --- a/drivers/net/ethernet/broadcom/bgmac.c\n> +++ b/drivers/net/ethernet/broadcom/bgmac.c\n> @@ -483,7 +483,7 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,\n> \t\t\tskb->protocol = eth_type_trans(skb, bgmac->net_dev);\n> \t\t\tbgmac->net_dev->stats.rx_bytes += len;\n> \t\t\tbgmac->net_dev->stats.rx_packets++;\n> -\t\t\tnapi_gro_receive(&bgmac->napi, skb);\n> +\t\t\tnetif_receive_skb(skb);\n> \t\t\thandled++;\n> \t\t} while (0);\n> \n\nAnd have you tested 1Gbit link speed ?\n( Or 2.5 Gbit link speed )\n\nIf you want to disable GRO on your host, fine : you can use ethtool -K","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Il4BUAHH\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvCw81YXDz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 10:35:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751458AbdIPAe7 (ORCPT );\n\tFri, 15 Sep 2017 20:34:59 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:35885 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751143AbdIPAe6 (ORCPT\n\t); Fri, 15 Sep 2017 20:34:58 -0400","by mail-pg0-f68.google.com with SMTP id d8so2069471pgt.3\n\tfor ; Fri, 15 Sep 2017 17:34:58 -0700 (PDT)","from ?IPv6:2620:15c:2c1:100:a152:36a5:194b:d6c7?\n\t([2620:15c:2c1:100:a152:36a5:194b:d6c7])\n\tby smtp.googlemail.com with ESMTPSA id\n\tf24sm4224229pfk.137.2017.09.15.17.34.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 17:34:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=SN0ztiW369rnWRLCVuG/AsTk2iv92fCC7cTsyTuCK2o=;\n\tb=Il4BUAHHFyBnZEG6S+sQ9reH+VbEZKOwkz8EmIjJSAsJT/Qf+jN4FXzFKohUNJhIF9\n\twK+bpg4CBnZuOoJEqcDDlGLFOCD6eYIDoqWCJ+iN1o6KIh/stl7RzFZMOLbW9scHyIg1\n\t8do5v/Gs1zggEFdbcCkragWnjYsCcFDhINR9Tgk0GK1oDXfyBnqrylcKm5yyLcEocWrg\n\tb5mP/ogfrc0m6D4pqGnbuvg9pJyive1qWbV5zFDng1JDZAQtfkJPy/NqBAxNsFRVGjoR\n\tCbbRlPdDjxr5S+lgcTcDAltHMIVIsDz+v5c10adE6jnXh8GrQW1P/NCZ3WEIe2//40y0\n\tR9dw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=SN0ztiW369rnWRLCVuG/AsTk2iv92fCC7cTsyTuCK2o=;\n\tb=NwsLLCpB/aBF0kAj0eXUDPiYIlHG8rMs4KoQpAWUYyDkriaE6TeaBZpoFJ78Nl+u6C\n\tKvWDfJVx/NftCS9iLQxi0mkYuT3A4ChGzeJK99Ru5bs3HDK2Jk14TxUqxaz58olBUT07\n\tjaMNQnuxYr7A/W313EhuPxIxC7WWbiSHaC2TxgxbX44tbFQFlKUCa3W1XG6NxQ9ywDEk\n\tleJFVqwV+MLx6F4OHWS8gYh4KlVu36xCmtr8qHIFoRTTKbSfIVJFj8ROsF8owerOtQeg\n\tIxSYD3GODc98LsSvgwHL7dolI65igXboSNVQjAV/6Z4ABCkOKy83y/BKIuPUA0BiiZdL\n\tnBeA==","X-Gm-Message-State":"AHPjjUhTMyDQpO3rnGrzvzHTc3rwZYlo/b5QI2I3HozRIWD3X9/etvZk\n\tQ945b2AoB8mQig==","X-Google-Smtp-Source":"AOwi7QAtPGKSYy9sq9Wp/3HAJMRN71Hryh/i/+LE0X0efmbAQS5fCsEFkDV8ja+3mMz2xc/GKuahOw==","X-Received":"by 10.84.253.141 with SMTP id a13mr12404729plm.91.1505522098149; \n\tFri, 15 Sep 2017 17:34:58 -0700 (PDT)","Message-ID":"<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"Eric Dumazet ","To":"Rosen Penev ","Cc":"netdev@vger.kernel.org","Date":"Fri, 15 Sep 2017 17:34:56 -0700","In-Reply-To":"<20170916002305.2794-1-rosenp@gmail.com>","References":"<20170916002305.2794-1-rosenp@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769529,"web_url":"http://patchwork.ozlabs.org/comment/1769529/","msgid":"<1505522322.3726.0.camel@gmail.com>","list_archive_url":null,"date":"2017-09-16T00:38:42","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"I have not. Unfortunately I own no gigabit hardware to test this on.\nThe MIPS CPU runs at 300MHz on my unit.\n\nOn Fri, 2017-09-15 at 17:34 -0700, Eric Dumazet wrote:\n> On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote:\n> > On a linksys E1200v1 (actually a crossflashed E1000v2), the\n> > offloading features give no measurable benefit to speed or latency.\n> > Furthermore, disabling GRO actually improves iperf performance by a\n> > whoppimg 3mbps. Results:\n> > \n> > Currently:\n> > \n> > v2: Changed napi_gro_receive to netif_receive_skb. Seems to have an\n> > identical result.\n> > \n> > Signed-off-by: Rosen Penev \n> > ---\n> > drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/drivers/net/ethernet/broadcom/bgmac.c\n> > b/drivers/net/ethernet/broadcom/bgmac.c\n> > index 48d672b204a4..1fb0053aeee7 100644\n> > --- a/drivers/net/ethernet/broadcom/bgmac.c\n> > +++ b/drivers/net/ethernet/broadcom/bgmac.c\n> > @@ -483,7 +483,7 @@ static int bgmac_dma_rx_read(struct bgmac\n> > *bgmac, struct bgmac_dma_ring *ring,\n> > \t\t\tskb->protocol = eth_type_trans(skb, bgmac-\n> > >net_dev);\n> > \t\t\tbgmac->net_dev->stats.rx_bytes += len;\n> > \t\t\tbgmac->net_dev->stats.rx_packets++;\n> > -\t\t\tnapi_gro_receive(&bgmac->napi, skb);\n> > +\t\t\tnetif_receive_skb(skb);\n> > \t\t\thandled++;\n> > \t\t} while (0);\n> > \n> \n> And have you tested 1Gbit link speed ?\n> ( Or 2.5 Gbit link speed )\n> \n> If you want to disable GRO on your host, fine : you can use ethtool\n> -K\n> \n> \n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oDAIpyPI\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvD0S6CMlz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 10:38:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751248AbdIPAip (ORCPT );\n\tFri, 15 Sep 2017 20:38:45 -0400","from mail-pf0-f196.google.com ([209.85.192.196]:37389 \"EHLO\n\tmail-pf0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751143AbdIPAio (ORCPT\n\t); Fri, 15 Sep 2017 20:38:44 -0400","by mail-pf0-f196.google.com with SMTP id e69so1909577pfg.4\n\tfor ; Fri, 15 Sep 2017 17:38:44 -0700 (PDT)","from mangix.lan ([2001:470:1f05:c3e::8ce])\n\tby smtp.gmail.com with ESMTPSA id\n\tv31sm3986810pgn.43.2017.09.15.17.38.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 15 Sep 2017 17:38:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=EpkOWgLr/lTVm1xmKLj0Jx2454jDBSQBuzeWeFx42PU=;\n\tb=oDAIpyPICJGXbKBafpqFr+Pdjen/VlOp8xcArDaofJPQTvDpRe/hLzRwPJ1r7K06tP\n\tUOOIbT6nBaIfIBA147EJqzMR8iy/+iSeEZClRwVncLmeEHbJKbgPrQbVPNmULjn78UnL\n\tFDvBaLSycCl3nxiBeaD79g3liqeI3DRsh0LENZCSMLytScozkxef88k4e3NKQcVhg5X+\n\ttucu16i616QZJGj8VbmPcMtcZE9t0csNKB5Qef0J+FT56jzZY/58fon4SFAA4mbgXmmu\n\tiiChGJMS4VBwhJBKfJ0xzKgJbjAwG2W0iizVM7FX5F/mfZ0DQzDZzQSUewyq55iMRbcG\n\tRwiA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=EpkOWgLr/lTVm1xmKLj0Jx2454jDBSQBuzeWeFx42PU=;\n\tb=Q6QnwK9cHFOeRMY8shOcpaLguaOsr3u8eINfUuDQyGdRUTYQiCJqbUeQB6xvrHdIrJ\n\ttpYd4iet5mDnfEvRoiAVN2CJWt/NyvmuYU2snQpEG3VBMoV+9dP79WUibVJrKWXIoND3\n\twI3fyg6U4TE+VUuAh2An2Tq6ZKAd4B6eycvs95e2scJ9BPJWUAQVmFNMr+lpUIciQCDF\n\tKWgXxIIyZOIb2eyKjLytgQq+vvp9xVVfjCPRb7SW92Wjf+rRIKMd1+3Zs6bw3XzNt4MW\n\tMzslCvGZDYzWc2fOMLeirbRZBebdsG5SwFHvOLDLFDAKghhNOLb22CyOIVqR794Wfpms\n\tDJyg==","X-Gm-Message-State":"AHPjjUh2d78W992kOSRK5bh0PBopQfCNC0OcOeJNHwfA+u2wiGgP2odn\n\tD2sz+9qm8sDtJSejf/8=","X-Google-Smtp-Source":"ADKCNb6D6Tn/ZtuQtnOmbzRsG5xYNbI8O4gnF3D/Ewayc4rRf02qqE8JrIV56hh74FJuX6qh6EvCRw==","X-Received":"by 10.84.215.205 with SMTP id g13mr29278017plj.165.1505522324011;\n\tFri, 15 Sep 2017 17:38:44 -0700 (PDT)","Message-ID":"<1505522322.3726.0.camel@gmail.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"rosenp@gmail.com","To":"Eric Dumazet ","Cc":"netdev@vger.kernel.org","Date":"Fri, 15 Sep 2017 17:38:42 -0700","In-Reply-To":"<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<20170916002305.2794-1-rosenp@gmail.com>\n\t<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769562,"web_url":"http://patchwork.ozlabs.org/comment/1769562/","msgid":"<0CEBE536-2C18-4ED2-90CB-3836CEF9A70E@gmail.com>","list_archive_url":null,"date":"2017-09-16T06:04:29","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On September 15, 2017 5:38:42 PM PDT, rosenp@gmail.com wrote:\n>I have not. Unfortunately I own no gigabit hardware to test this on.\n>The MIPS CPU runs at 300MHz on my unit.\n>\n\nbgmac is used on Gigabit capable hardware, like Northstar and Northstar Plus, and others too, so unless you can get access to such HW or get confirmation from someone that your patches changes something, I would just drop this change and not bother. This is already not 100mbits/sec linerate...\n\n>On Fri, 2017-09-15 at 17:34 -0700, Eric Dumazet wrote:\n>> On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote:\n>> > On a linksys E1200v1 (actually a crossflashed E1000v2), the\n>> > offloading features give no measurable benefit to speed or latency.\n>> > Furthermore, disabling GRO actually improves iperf performance by a\n>> > whoppimg 3mbps. Results:\n>> > \n>> > Currently:\n>> > \n>> > v2: Changed napi_gro_receive to netif_receive_skb. Seems to have an\n>> > identical result.\n>> > \n>> > Signed-off-by: Rosen Penev \n>> > ---\n>> > drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n>> > 1 file changed, 1 insertion(+), 1 deletion(-)\n>> > \n>> > diff --git a/drivers/net/ethernet/broadcom/bgmac.c\n>> > b/drivers/net/ethernet/broadcom/bgmac.c\n>> > index 48d672b204a4..1fb0053aeee7 100644\n>> > --- a/drivers/net/ethernet/broadcom/bgmac.c\n>> > +++ b/drivers/net/ethernet/broadcom/bgmac.c\n>> > @@ -483,7 +483,7 @@ static int bgmac_dma_rx_read(struct bgmac\n>> > *bgmac, struct bgmac_dma_ring *ring,\n>> > \t\t\tskb->protocol = eth_type_trans(skb, bgmac-\n>> > >net_dev);\n>> > \t\t\tbgmac->net_dev->stats.rx_bytes += len;\n>> > \t\t\tbgmac->net_dev->stats.rx_packets++;\n>> > -\t\t\tnapi_gro_receive(&bgmac->napi, skb);\n>> > +\t\t\tnetif_receive_skb(skb);\n>> > \t\t\thandled++;\n>> > \t\t} while (0);\n>> > \n>> \n>> And have you tested 1Gbit link speed ?\n>> ( Or 2.5 Gbit link speed )\n>> \n>> If you want to disable GRO on your host, fine : you can use ethtool\n>> -K\n>> \n>> \n>> \n\n(please don't top-post)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gQx0SV4f\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvMDV6wd7z9t2c\n\tfor ;\n\tSat, 16 Sep 2017 16:04:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751221AbdIPGEf (ORCPT );\n\tSat, 16 Sep 2017 02:04:35 -0400","from mail-oi0-f68.google.com ([209.85.218.68]:34683 \"EHLO\n\tmail-oi0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751182AbdIPGEe (ORCPT\n\t); Sat, 16 Sep 2017 02:04:34 -0400","by mail-oi0-f68.google.com with SMTP id v66so521088oig.1\n\tfor ; Fri, 15 Sep 2017 23:04:34 -0700 (PDT)","from ?IPv6:2001:470:d:73f:195d:f70:5d55:ac10?\n\t([2001:470:d:73f:195d:f70:5d55:ac10])\n\tby smtp.gmail.com with ESMTPSA id\n\tu129sm3356936oia.2.2017.09.15.23.04.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 23:04:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:subject:to:cc:from:message-id;\n\tbh=lX/8P8zVz8Yycj0qHr9GcFHqwY7GQ72CpPYQ5ne5/uU=;\n\tb=gQx0SV4fuKFX5Z4baErVxhFxdQBHBQxMwidjh/kGw4j8Sj9P9KD6GowdweOQjry9js\n\t2COux8rRkZmQcTJQk2nuB3LRVeOqkrfvXE0RHDeKrCRHg6MLiD8eqhSw5g9e5zh8V9ei\n\tWJTIVl/M7+dqI07EAJN4t5uix/r5T3fhoSOi/FlSZTA2TuLZrP0QY8+fQI4/sxh7Fs4Q\n\t4EzUiCeaNQlXikVxmZ4yg3bUrkj+zxTzZOrx6xf0c+zuWJv5CxoOYo7r/nei/iw5DPRp\n\tkt7Z5XmkmCZxClsBmQk7uEhyCJ6jW5SCUGnzKGgmGobypIU8F+dJs/g9DwO3TEVFbWlf\n\ta2zA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:user-agent:in-reply-to:references\n\t:mime-version:content-transfer-encoding:subject:to:cc:from\n\t:message-id;\n\tbh=lX/8P8zVz8Yycj0qHr9GcFHqwY7GQ72CpPYQ5ne5/uU=;\n\tb=lfBjJoeiY1MzR9GTwq0IWcT1m/AK6ZYvBgbAe0grWq9n0WEhVM/PlxleaGLjJty6P2\n\tTv3cJeg+U0/ZbNhXOY2yGQ10UBQLK+c7CCt5k/mwU9JMS1V4+pAOXjbULy5vAntp8wKb\n\t8GNLc5LNUfjTkFEzmOGqPwYznOwYcvKNI07gZdcBpdfLOn0W9CKUPTAVLUMDQAs0z3AJ\n\taqeWxg3kgsodaQ2OO0HkDFIAmBNzGmmSoz0O3QZhC+wn0cvkdCTNxf4Xg+4soLqPXNBw\n\t0nECLNNI1HaWhi+SEQ9jtKo1vNG1bpTSMHwX24EFnfZnJ85f+vCaL57+7brkfELC2JFE\n\tgXDQ==","X-Gm-Message-State":"AHPjjUhqTrwpQ1XYvFz0rExteZPvemP4NOL/AKU5xMSC8dqcDwFYoGkx\n\tnxMze40J8hOx9g==","X-Google-Smtp-Source":"AOwi7QCAsEhpA0WvE3TFe+mnZSqmIM0aJ+r8NS83S78nePbeLoeKq60FIrmxLP1k0qf6mPQQ7Tu2vA==","X-Received":"by 10.202.75.211 with SMTP id\n\ty202mr30578658oia.140.1505541873656; \n\tFri, 15 Sep 2017 23:04:33 -0700 (PDT)","Date":"Fri, 15 Sep 2017 23:04:29 -0700","User-Agent":"K-9 Mail for Android","In-Reply-To":"<1505522322.3726.0.camel@gmail.com>","References":"<20170916002305.2794-1-rosenp@gmail.com>\n\t<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505522322.3726.0.camel@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain;\n charset=utf-8","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","To":"rosenp@gmail.com, Eric Dumazet ","CC":"netdev@vger.kernel.org","From":"Florian Fainelli ","Message-ID":"<0CEBE536-2C18-4ED2-90CB-3836CEF9A70E@gmail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772258,"web_url":"http://patchwork.ozlabs.org/comment/1772258/","msgid":"<1505942864.3451.3.camel@gmail.com>","list_archive_url":null,"date":"2017-09-20T21:27:44","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/people/70304/","name":"Rosen Penev","email":"rosenp@gmail.com"},"content":"Sorry for the noise. After more testing I've found out that the cause\nwas that I had BBR enabled on my laptop. Switching back to CUBIC fixed\nthe issue.\n\nIn other words, this patch is detrimental.\n\n~67mbps - gro off\n~87mbps - gro on\n\nOn Fri, 2017-09-15 at 23:04 -0700, Florian Fainelli wrote:\n> On September 15, 2017 5:38:42 PM PDT, rosenp@gmail.com wrote:\n> > I have not. Unfortunately I own no gigabit hardware to test this\n> > on.\n> > The MIPS CPU runs at 300MHz on my unit.\n> > \n> \n> bgmac is used on Gigabit capable hardware, like Northstar and\n> Northstar Plus, and others too, so unless you can get access to such\n> HW or get confirmation from someone that your patches changes\n> something, I would just drop this change and not bother. This is\n> already not 100mbits/sec linerate...\n> \n> > On Fri, 2017-09-15 at 17:34 -0700, Eric Dumazet wrote:\n> > > On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote:\n> > > > On a linksys E1200v1 (actually a crossflashed E1000v2), the\n> > > > offloading features give no measurable benefit to speed or\n> > > > latency.\n> > > > Furthermore, disabling GRO actually improves iperf performance\n> > > > by a\n> > > > whoppimg 3mbps. Results:\n> > > > \n> > > > Currently:\n> > > > \n> > > > v2: Changed napi_gro_receive to netif_receive_skb. Seems to\n> > > > have an\n> > > > identical result.\n> > > > \n> > > > Signed-off-by: Rosen Penev \n> > > > ---\n> > > > drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n> > > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > > \n> > > > diff --git a/drivers/net/ethernet/broadcom/bgmac.c\n> > > > b/drivers/net/ethernet/broadcom/bgmac.c\n> > > > index 48d672b204a4..1fb0053aeee7 100644\n> > > > --- a/drivers/net/ethernet/broadcom/bgmac.c\n> > > > +++ b/drivers/net/ethernet/broadcom/bgmac.c\n> > > > @@ -483,7 +483,7 @@ static int bgmac_dma_rx_read(struct bgmac\n> > > > *bgmac, struct bgmac_dma_ring *ring,\n> > > > \t\t\tskb->protocol = eth_type_trans(skb,\n> > > > bgmac-\n> > > > > net_dev);\n> > > > \n> > > > \t\t\tbgmac->net_dev->stats.rx_bytes += len;\n> > > > \t\t\tbgmac->net_dev->stats.rx_packets++;\n> > > > -\t\t\tnapi_gro_receive(&bgmac->napi, skb);\n> > > > +\t\t\tnetif_receive_skb(skb);\n> > > > \t\t\thandled++;\n> > > > \t\t} while (0);\n> > > > \n> > > \n> > > And have you tested 1Gbit link speed ?\n> > > ( Or 2.5 Gbit link speed )\n> > > \n> > > If you want to disable GRO on your host, fine : you can use\n> > > ethtool\n> > > -K\n> > > \n> > > \n> > > \n> \n> (please don't top-post)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"MEsXDbrp\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyCWq0dGHz9sNr\n\tfor ;\n\tThu, 21 Sep 2017 07:27:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751861AbdITV1t (ORCPT );\n\tWed, 20 Sep 2017 17:27:49 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:34867 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751636AbdITV1r (ORCPT\n\t); Wed, 20 Sep 2017 17:27:47 -0400","by mail-pf0-f195.google.com with SMTP id i23so1657939pfi.2\n\tfor ; Wed, 20 Sep 2017 14:27:47 -0700 (PDT)","from mangix.lan ([2001:470:1f05:c3e::ac8])\n\tby smtp.gmail.com with ESMTPSA id\n\th10sm13428817pgn.73.2017.09.20.14.27.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 14:27:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=hmM9IQzAkHGw9lIwyDeG2//CRfzf2nznvrWUCIztVkU=;\n\tb=MEsXDbrpAibIHBK1mO8TViZNdoqFujrrEXOkijYGV7hY6oUDAgbNPJ0MgA1xn11gvj\n\t8JgNKCE4/2RQpG3qWAkMt91lwT6nbIMovhZP4IUd+vzXKpJNahz0rCxUOigky7qBTD+k\n\tsXW7qaPmfjLLhSFwaeAxiA62HSF0m2m44K6aalI5WIS2mAzm4dE8DbmwJjq/xr2A0w50\n\tmd9BLjFICm0kixur91OgpaVkd5qR2jtRHmKrXXErjkKoZ6Y2OTUaqCQ5M/x93oaYBWSl\n\t0ZE8qU6xSpSL9T7G9KIeDFuODK5Q2DEMSd1mYZmyvCzKSWY3uE1BphoQCBwzwgKnSJNn\n\tg50A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=hmM9IQzAkHGw9lIwyDeG2//CRfzf2nznvrWUCIztVkU=;\n\tb=hdeORNAWuywmTwCpJK/wYm7A6Rk9tAMjUP7fDFzY7pLO/9TI/xV6rJAl3VsiFo0EF1\n\tzNMAhHlIHnpwZ3CRaT+yExC8vJQo91iJL4X0Hhy9rAbqg0i59AvCJm3117OiuAemlRrl\n\tUcfO5MrSgh7QlpjoHq5JTdHVI5L0/1gvg17sujh3C9Q2ll8P34IzL4rTx6cjimewVvGS\n\tNbndQDYz5DPdUHsmYpolwMy3rOxS0Dini9Z204cvjCt7J6BhTYjXhX6Q+frGTGmhuG7u\n\t2SmWsFtIL0jt5gmXUw9l5z7t8JuE/NiUKZfFDUzFhUFHLfiRT8bFVTODt1t707gFeIfC\n\tOTjg==","X-Gm-Message-State":"AHPjjUiOekP1agKSTey1q8hXjMtdkATFKceSWHvwCVq1GkVogdKAIg71\n\tA7X2hVoyWOtP1J7geDhr1tEqwsP9","X-Google-Smtp-Source":"AOwi7QCRIJnyGuD6wrHnKnRyTRGDvP/6+jM9NdvkkWAYG8dqULBXfRpnyG3Zxhs7Hz8b1h2NevsQUQ==","X-Received":"by 10.98.58.16 with SMTP id h16mr3497402pfa.153.1505942867022;\n\tWed, 20 Sep 2017 14:27:47 -0700 (PDT)","Message-ID":"<1505942864.3451.3.camel@gmail.com>","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","From":"rosenp@gmail.com","To":"Florian Fainelli ,\n\tEric Dumazet ","Cc":"netdev@vger.kernel.org","Date":"Wed, 20 Sep 2017 14:27:44 -0700","In-Reply-To":"<0CEBE536-2C18-4ED2-90CB-3836CEF9A70E@gmail.com>","References":"<20170916002305.2794-1-rosenp@gmail.com>\n\t<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505522322.3726.0.camel@gmail.com>\n\t<0CEBE536-2C18-4ED2-90CB-3836CEF9A70E@gmail.com>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.24.5 (3.24.5-1.fc26) ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1772268,"web_url":"http://patchwork.ozlabs.org/comment/1772268/","msgid":"<80772c78-ec1f-8d62-5085-f653bcd6bd12@gmail.com>","list_archive_url":null,"date":"2017-09-20T21:32:40","subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/20/2017 02:27 PM, rosenp@gmail.com wrote:\n> Sorry for the noise. After more testing I've found out that the cause\n> was that I had BBR enabled on my laptop. Switching back to CUBIC fixed\n> the issue.\n> \n> In other words, this patch is detrimental.\n\nQuite unsurprisingly, thanks for coming back, and please don't top-post\non netdev.\n\n> \n> ~67mbps - gro off\n> ~87mbps - gro on\n> \n> On Fri, 2017-09-15 at 23:04 -0700, Florian Fainelli wrote:\n>> On September 15, 2017 5:38:42 PM PDT, rosenp@gmail.com wrote:\n>>> I have not. Unfortunately I own no gigabit hardware to test this\n>>> on.\n>>> The MIPS CPU runs at 300MHz on my unit.\n>>>\n>>\n>> bgmac is used on Gigabit capable hardware, like Northstar and\n>> Northstar Plus, and others too, so unless you can get access to such\n>> HW or get confirmation from someone that your patches changes\n>> something, I would just drop this change and not bother. This is\n>> already not 100mbits/sec linerate...\n>>\n>>> On Fri, 2017-09-15 at 17:34 -0700, Eric Dumazet wrote:\n>>>> On Fri, 2017-09-15 at 17:23 -0700, Rosen Penev wrote:\n>>>>> On a linksys E1200v1 (actually a crossflashed E1000v2), the\n>>>>> offloading features give no measurable benefit to speed or\n>>>>> latency.\n>>>>> Furthermore, disabling GRO actually improves iperf performance\n>>>>> by a\n>>>>> whoppimg 3mbps. Results:\n>>>>>\n>>>>> Currently:\n>>>>>\n>>>>> v2: Changed napi_gro_receive to netif_receive_skb. Seems to\n>>>>> have an\n>>>>> identical result.\n>>>>>\n>>>>> Signed-off-by: Rosen Penev \n>>>>> ---\n>>>>> drivers/net/ethernet/broadcom/bgmac.c | 2 +-\n>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>>\n>>>>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c\n>>>>> b/drivers/net/ethernet/broadcom/bgmac.c\n>>>>> index 48d672b204a4..1fb0053aeee7 100644\n>>>>> --- a/drivers/net/ethernet/broadcom/bgmac.c\n>>>>> +++ b/drivers/net/ethernet/broadcom/bgmac.c\n>>>>> @@ -483,7 +483,7 @@ static int bgmac_dma_rx_read(struct bgmac\n>>>>> *bgmac, struct bgmac_dma_ring *ring,\n>>>>> \t\t\tskb->protocol = eth_type_trans(skb,\n>>>>> bgmac-\n>>>>>> net_dev);\n>>>>>\n>>>>> \t\t\tbgmac->net_dev->stats.rx_bytes += len;\n>>>>> \t\t\tbgmac->net_dev->stats.rx_packets++;\n>>>>> -\t\t\tnapi_gro_receive(&bgmac->napi, skb);\n>>>>> +\t\t\tnetif_receive_skb(skb);\n>>>>> \t\t\thandled++;\n>>>>> \t\t} while (0);\n>>>>> \n>>>>\n>>>> And have you tested 1Gbit link speed ?\n>>>> ( Or 2.5 Gbit link speed )\n>>>>\n>>>> If you want to disable GRO on your host, fine : you can use\n>>>> ethtool\n>>>> -K\n>>>>\n>>>>\n>>>>\n>>\n>> (please don't top-post)","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"m2KM3TCY\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyCdX27LPz9sPk\n\tfor ;\n\tThu, 21 Sep 2017 07:32:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdITVcq (ORCPT );\n\tWed, 20 Sep 2017 17:32:46 -0400","from mail-qk0-f195.google.com ([209.85.220.195]:38869 \"EHLO\n\tmail-qk0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751378AbdITVcp (ORCPT\n\t); Wed, 20 Sep 2017 17:32:45 -0400","by mail-qk0-f195.google.com with SMTP id c69so2492267qke.5\n\tfor ; Wed, 20 Sep 2017 14:32:45 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tf13sm1910177qtj.57.2017.09.20.14.32.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 14:32:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=oj0nZ4fDqUt7s68LDafGkHbTs37nDkSuI99KoXVVx+M=;\n\tb=m2KM3TCYXPxny30Av9x8GhcJRMP2puHnv2bSmk+s/BRRb/Pdpx+Qp3oetNw9CRoHok\n\th8gqaeFoIcRs+SNguktACiIQ0djXNb5ZGzzjrIDMhEti1HeWOb2ww1yQa0qUO2IZesmx\n\tK5W7atoH+hfpCwoLJlbVwnWnYfm6XeAqz+mHgDNgcucam0hW7UHSknihsYsIl8bOADpr\n\tOLXmRH6dvSWgvCr31c8mHj0QBcC8F1Yu0suKyBx2IZ3Z1tjrVBVfLU+8m4ZSBDSdtJw/\n\tJ8rvHej+h6NSDmXKUWpWhzzQiWPb/xpF3fhlM8g4O0yaKJDLICGCYOQTZrih8xW2emTm\n\tM3Lg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=oj0nZ4fDqUt7s68LDafGkHbTs37nDkSuI99KoXVVx+M=;\n\tb=ADtOUh+KNTRYXByGhGyfXWcoaGfEuPEhLGSeXKZJAMVmhSVp7AR7MvJSZMzu6hggB4\n\tWZSo6YUrnBc+k3CvVW+z3/4t0KyirVMQrHxqPevCFgNllBaBsVuiE7T6iF0G7tcl4FMJ\n\twcGsyMBUusjzAGEkVaD2pxrZ0KKDEBpButeHPoYiXAde89yBSUXNfHpB38aizRJXLPRF\n\tq6khNJH0Kew6lznqMmRbJiaRD4Vr05Dra1HD4ro6wVyUuUtXryAAfSDqjm3waUqXOXRm\n\t00eWZ+grZn52bAnfHRVpzqSlpyJ29x6uN+NpXbdAGQKCMV9emGO5c47mNPE7AEJ9MXcX\n\t/auA==","X-Gm-Message-State":"AHPjjUizKJuXsEVEqEAxAIyhRMp2RiFxowTYLxo+6nFuJDWvyCEWkKsP\n\tKXaD8gFhbvJ8lJuUHHWJ4va6dwzU","X-Google-Smtp-Source":"AOwi7QAtXVAWIS1/vvSX9uk55Cw00XDX6VZ1JWf11FQQJSYenupRJ49NZYK3ZeSYCLGd9F+7qHGHgw==","X-Received":"by 10.55.150.195 with SMTP id y186mr172347qkd.36.1505943164204; \n\tWed, 20 Sep 2017 14:32:44 -0700 (PDT)","Subject":"Re: [PATCH] bgmac: Remove all offloading features, including GRO.","To":"rosenp@gmail.com, Eric Dumazet ","Cc":"netdev@vger.kernel.org","References":"<20170916002305.2794-1-rosenp@gmail.com>\n\t<1505522096.29839.13.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505522322.3726.0.camel@gmail.com>\n\t<0CEBE536-2C18-4ED2-90CB-3836CEF9A70E@gmail.com>\n\t<1505942864.3451.3.camel@gmail.com>","From":"Florian Fainelli ","Message-ID":"<80772c78-ec1f-8d62-5085-f653bcd6bd12@gmail.com>","Date":"Wed, 20 Sep 2017 14:32:40 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1505942864.3451.3.camel@gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]