[{"id":1769533,"web_url":"http://patchwork.ozlabs.org/comment/1769533/","msgid":"","list_archive_url":null,"date":"2017-09-16T01:33:03","subject":"Re: [PATCH net] tcp: fix data delivery rate","submitter":{"id":68664,"url":"http://patchwork.ozlabs.org/api/people/68664/","name":"Soheil Hassas Yeganeh","email":"soheil.kdev@gmail.com"},"content":"On Fri, Sep 15, 2017 at 7:47 PM, Eric Dumazet wrote:\n> From: Eric Dumazet \n>\n> Now skb->mstamp_skb is updated later, we also need to call\n> tcp_rate_skb_sent() after the update is done.\n>\n> Fixes: 8c72c65b426b (\"tcp: update skb->skb_mstamp more carefully\")\n> Signed-off-by: Eric Dumazet \n\nAcked-by: Soheil Hassas Yeganeh \n\nNice catch!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P4JE7VAl\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvFCz2Vn0z9t16\n\tfor ;\n\tSat, 16 Sep 2017 11:33:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751248AbdIPBdp (ORCPT );\n\tFri, 15 Sep 2017 21:33:45 -0400","from mail-vk0-f48.google.com ([209.85.213.48]:46956 \"EHLO\n\tmail-vk0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751117AbdIPBdo (ORCPT\n\t); Fri, 15 Sep 2017 21:33:44 -0400","by mail-vk0-f48.google.com with SMTP id v203so1745361vkv.3\n\tfor ; Fri, 15 Sep 2017 18:33:44 -0700 (PDT)","by 10.176.64.234 with HTTP; Fri, 15 Sep 2017 18:33:03 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=YvQ+pFhIpem1u3gK2vQtgbCFVNYTqJwcTjtc/8zVT2Q=;\n\tb=P4JE7VAltzzm97zICsf+bZFUzONRyroFDkLhbqivLnqZ+1KJBj3COsF692X7LSp/Ih\n\tbZ23i7F4Z6n2QuH+50Trc6F/JjjsEpWB4wXiZQvGzUR/PVN4qaQFHkv8YJr3FBYBaUX0\n\teIXRR/Vy7mGzJGLPI9Ayw6m1ZGMmvjGk3+oge2XYAUShgTqMwpQATWskQwnpBkMHuIBB\n\tOo0ru7mD0foJ65KFWE5ohGXbcilGUU/2jiYC4qVoentyWV2J48VNLTdJadGvX6oRM81J\n\tLNiLJ3jPxsJpYfYB8Y3IfDs4P4fkueLIQAfc5kjQR1Rvlxb+bZ99qIXffCOYHdaz2/WR\n\ttjNA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=YvQ+pFhIpem1u3gK2vQtgbCFVNYTqJwcTjtc/8zVT2Q=;\n\tb=HwcpdAoQpUfDotZfdsMmrCLPbPs8SUARyP1/Bz0YP3TS967UkIUpwq+Iudg4RrqKQF\n\tOlyT7hPzc9GDHfU0cmAWm81KWtH6iSV1jV10lexBj9tNeyzyU1NtzbWqca8iKBV/3O4E\n\t2KI7L5OvRSkVXLFv3EJgyavpPKs28VT13tPovMjAmic/epG9EXW08jOizw7X+8r6WNZ7\n\txp04TJGCvDOlMMVpxp8kBkAaEvMK8Arh0k1RwIcy4zDV6Ji9IoSUXHWPEa5qveU8V9o6\n\t1HezDFPNLLBIRgdbWqVtYwpmeDf9f164AhhgGOEg/aSx97zhIkzPd1ddO/FoIF3ZnqEI\n\twfrQ==","X-Gm-Message-State":"AHPjjUhBdKyqhgPyVMVB5ck1u29wNUG7ZF3tQSGPBEYbIUNouBC8TyCt\n\teEL33AhVDukdq2SKkLLAo7tdrOAGGwNam1mrpgE=","X-Google-Smtp-Source":"AOwi7QAqVzaKRH/PKqm56JFTBv4A8svb+yT1ead9Cr8adIa/A/jMSOhnmQ8R6ON0ysmehTG/MYYfr5JjIFnlBaKYJu0=","X-Received":"by 10.31.190.77 with SMTP id o74mr17482048vkf.99.1505525623641; \n\tFri, 15 Sep 2017 18:33:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505519262.29839.5.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<3c750ac3-8739-89ed-ce41-d4cde755171e@huawei.com>\n\t<1505313647.15310.165.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505359839.15310.209.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<20170915.143706.992734259378949259.davem@davemloft.net>\n\t<1505517411.29839.1.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505519262.29839.5.camel@edumazet-glaptop3.roam.corp.google.com>","From":"Soheil Hassas Yeganeh ","Date":"Fri, 15 Sep 2017 21:33:03 -0400","Message-ID":"","Subject":"Re: [PATCH net] tcp: fix data delivery rate","To":"Eric Dumazet ","Cc":"David Miller , liujian ,\n\tEric Dumazet , Yuchung Cheng ,\n\tJerry Chu , netdev ,\n\t\"weiyongjun (A)\" ,\n\twangkefeng 00227729 ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769614,"web_url":"http://patchwork.ozlabs.org/comment/1769614/","msgid":"<20170916.090729.108058689813174554.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-16T16:07:29","subject":"Re: [PATCH net] tcp: fix data delivery rate","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Eric Dumazet \nDate: Fri, 15 Sep 2017 16:47:42 -0700\n\n> From: Eric Dumazet \n> \n> Now skb->mstamp_skb is updated later, we also need to call\n> tcp_rate_skb_sent() after the update is done.\n> \n> Fixes: 8c72c65b426b (\"tcp: update skb->skb_mstamp more carefully\")\n> Signed-off-by: Eric Dumazet \n\nApplied, thanks Eric.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvccB3YqXz9sP1\n\tfor ;\n\tSun, 17 Sep 2017 02:07:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751278AbdIPQHb (ORCPT );\n\tSat, 16 Sep 2017 12:07:31 -0400","from shards.monkeyblade.net ([184.105.139.130]:51388 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751231AbdIPQHa (ORCPT\n\t); Sat, 16 Sep 2017 12:07:30 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E3C57136A4ACA;\n\tSat, 16 Sep 2017 09:07:29 -0700 (PDT)"],"Date":"Sat, 16 Sep 2017 09:07:29 -0700 (PDT)","Message-Id":"<20170916.090729.108058689813174554.davem@davemloft.net>","To":"eric.dumazet@gmail.com","Cc":"liujian56@huawei.com, edumazet@google.com, ycheng@google.com,\n\thkchu@google.com, netdev@vger.kernel.org, weiyongjun1@huawei.com,\n\twangkefeng.wang@huawei.com","Subject":"Re: [PATCH net] tcp: fix data delivery rate","From":"David Miller ","In-Reply-To":"<1505519262.29839.5.camel@edumazet-glaptop3.roam.corp.google.com>","References":"<20170915.143706.992734259378949259.davem@davemloft.net>\n\t<1505517411.29839.1.camel@edumazet-glaptop3.roam.corp.google.com>\n\t<1505519262.29839.5.camel@edumazet-glaptop3.roam.corp.google.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Sat, 16 Sep 2017 09:07:30 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]