[{"id":1769508,"web_url":"http://patchwork.ozlabs.org/comment/1769508/","msgid":"<20170915234514.GA8407@kroah.com>","list_archive_url":null,"date":"2017-09-15T23:45:14","subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote:\n> USB2517i hubs are very like USB251xb devices series. They have almost\n> the same configuration registers space except number of ports, led\n> configurations and lack of battery settings. All these peculiarities\n> are reflected in this patch.\n\nPlease add one type of feature at a time per patch. That makes it\neasier to review and ensure you got it right.\n\nthanks,\n\ngreg k-h\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvBq16Rjjz9sPk\n\tfor ;\n\tSat, 16 Sep 2017 09:45:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdIOXpR (ORCPT\n\t);\n\tFri, 15 Sep 2017 19:45:17 -0400","from mail.linuxfoundation.org ([140.211.169.12]:59266 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751211AbdIOXpQ (ORCPT\n\t); Fri, 15 Sep 2017 19:45:16 -0400","from localhost (unknown [12.145.98.253])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id B7E29A48;\n\tFri, 15 Sep 2017 23:45:15 +0000 (UTC)"],"Date":"Fri, 15 Sep 2017 16:45:14 -0700","From":"Greg KH ","To":"Serge Semin ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","Message-ID":"<20170915234514.GA8407@kroah.com>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170915233113.17855-2-fancer.lancer@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170915233113.17855-2-fancer.lancer@gmail.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1769514,"web_url":"http://patchwork.ozlabs.org/comment/1769514/","msgid":"<20170915235550.GB21291@mobilestation>","list_archive_url":null,"date":"2017-09-15T23:55:50","subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"content":"On Fri, Sep 15, 2017 at 04:45:14PM -0700, Greg KH wrote:\n> On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote:\n> > USB2517i hubs are very like USB251xb devices series. They have almost\n> > the same configuration registers space except number of ports, led\n> > configurations and lack of battery settings. All these peculiarities\n> > are reflected in this patch.\n> \n> Please add one type of feature at a time per patch. That makes it\n> easier to review and ensure you got it right.\n> \n> thanks,\n> \n> greg k-h\n\nOk. The patch isn't that big though.\n\nRegards,\n-Sergey\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YOZDxuuQ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvC2r3V05z9s7g\n\tfor ;\n\tSat, 16 Sep 2017 09:55:48 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751424AbdIOXzq (ORCPT\n\t);\n\tFri, 15 Sep 2017 19:55:46 -0400","from mail-lf0-f68.google.com ([209.85.215.68]:34011 \"EHLO\n\tmail-lf0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751184AbdIOXzp (ORCPT\n\t); Fri, 15 Sep 2017 19:55:45 -0400","by mail-lf0-f68.google.com with SMTP id h80so1895270lfe.1;\n\tFri, 15 Sep 2017 16:55:44 -0700 (PDT)","from mobilestation ([95.79.181.62])\n\tby smtp.gmail.com with ESMTPSA id\n\tw20sm431723ljd.85.2017.09.15.16.55.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 16:55:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=MVuuV1qavqFOEhCZy16nmIlrolnMLlCAJbpwdT+T8fo=;\n\tb=YOZDxuuQn9/mFbYFQIrV1kbIeoMMOl+aG3cYo6BXain9aNXflkIB2ss9CIZ/6o8KKe\n\tyBMphCgBMMQLiFGpvBbH9kgOGzgzWjQOZ6RSQNpCwcT0Iq+RDjM3fpZv8DSE5Bezp6Ls\n\tUrG5ABkvifLR4a6HVlM+BNoH9wAKz1OWDd7+Xmi4sMUgZ1rFjJ7PTgTiMvXH7/XLm0Cz\n\tsWqTQ6vNKGDPBGStUC+7R9B4ePCgGSwleaOgYsdL+HrGFdWn1nvIenQyw8NY8wKkxnbd\n\tTont8nklHeH12i4qtoBBLyX2LVx/afcYfNvppHcr2xtTH8wQ+0jju1CZfoNw9tcsQ4Dp\n\tRrAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=MVuuV1qavqFOEhCZy16nmIlrolnMLlCAJbpwdT+T8fo=;\n\tb=ejE+Wu5oQcr3X2aUky5SrzxG1qybwZdXFBOX0Ch7rLLDkcU6vOjsTf/aDJNB7Bya7k\n\tXow16T0JkWorIPKz1P2Dpd66B0iVMw/zOndy8B39KNAqpcClbV/tk+7IOFfla0/sWCZu\n\tr+4rJARCncd3LJvlTMCw7wnXQHNyr6js0OL/xzHBpz/fREVL74Cl04FOvyY7BbJt2xG6\n\tmET6oiEr5MPe07vR8DtJI26PcVN6ta/8pGDGBoLH7uvqcbY2BaJlcf6441Z2XNVlij97\n\tE4OcNHBpeea8wHtsrs4C00vqsZWPBVH8EJYjvRgfbX6wqvcbFtePgBRnHi31qPlOJdw/\n\tQAPg==","X-Gm-Message-State":"AHPjjUiJUax+eDAOYbWBJp/nfJ9HE7l46OL6Jn6NZkJEKZFixoqHBUdR\n\tu/yBCskLIOQzTw==","X-Google-Smtp-Source":"AOwi7QAtpCGJ61PEKGkd7XYC/6W4mRLjtZ4e6mJawo+F1Onni/3S1rS+dFYyeBQo8rSo3PK6INv5og==","X-Received":"by 10.46.66.197 with SMTP id h66mr1937345ljf.108.1505519744005; \n\tFri, 15 Sep 2017 16:55:44 -0700 (PDT)","Date":"Sat, 16 Sep 2017 02:55:50 +0300","From":"Serge Semin ","To":"Greg KH ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","Message-ID":"<20170915235550.GB21291@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170915233113.17855-2-fancer.lancer@gmail.com>\n\t<20170915234514.GA8407@kroah.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170915234514.GA8407@kroah.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772225,"web_url":"http://patchwork.ozlabs.org/comment/1772225/","msgid":"<20170920205235.qhxhq3it6377bjcq@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-20T20:52:35","subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote:\n> USB2517i hubs are very like USB251xb devices series. They have almost\n> the same configuration registers space except number of ports, led\n> configurations and lack of battery settings. All these peculiarities\n> are reflected in this patch.\n> \n> Signed-off-by: Serge Semin \n> ---\n> Documentation/devicetree/bindings/usb/usb251xb.txt | 4 +-\n\nThough Greg wants the code split, I want the binding as one change. H/w \ndoesn't gain features one by one.\n\nIt's preferred to split bindings to a separate patch.\n\n> drivers/usb/misc/usb251xb.c | 84 +++++++++++++++++++---\n> 2 files changed, 78 insertions(+), 10 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt\n> index 3957d4eda..3d84626d3 100644\n> --- a/Documentation/devicetree/bindings/usb/usb251xb.txt\n> +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt\n> @@ -6,7 +6,8 @@ Hi-Speed Controller.\n> Required properties :\n> - compatible : Should be \"microchip,usb251xb\" or one of the specific types:\n> \t\"microchip,usb2512b\", \"microchip,usb2512bi\", \"microchip,usb2513b\",\n> -\t\"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\"\n> +\t\"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\",\n> +\t\"microchip,usb2517\", \"microchip,usb2517i\"\n> - reset-gpios : Should specify the gpio for hub reset\n> - reg : I2C address on the selected bus (default is <0x2C>)\n> \n> @@ -36,6 +37,7 @@ Optional properties :\n> \tan invalid value is given, the default is used instead.\n> - compound-device : indicate the hub is part of a compound device\n> - port-mapping-mode : enable port mapping mode\n> + - speed-led-mode : led speed indiation mode selection (usb2517 only)\n\nThis is a boolean or has values? What are valid values?\n\nThis needs a vendor prefix. Somehow the other properties got in without.\n\n> - string-support : enable string descriptor support (required for manufacturer,\n> \tproduct and serial string configuration)\n> - non-removable-ports : Should specify the ports which have a non-removable\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBxV0QHXz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 07:01:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751794AbdITVBU (ORCPT\n\t);\n\tWed, 20 Sep 2017 17:01:20 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:33852 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751938AbdITUwj (ORCPT\n\t); Wed, 20 Sep 2017 16:52:39 -0400","by mail-pg0-f66.google.com with SMTP id u18so2251659pgo.1;\n\tWed, 20 Sep 2017 13:52:39 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\t72sm9513693pfj.102.2017.09.20.13.52.36\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 13:52:36 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=+olrNbE4zPK7U9LcY647NGBQdBzipfwjLeJ8p8DMrJw=;\n\tb=JCJ7q58q7oYoDcl3iPrvF1671G/okVt46Yzo18MP07elMHG1EXIh8sS3PotctVj9YZ\n\tivZ8Nkz0pwLoLJmaAi2Br0ZhQYg3EqLeiynH+8KkZ2cj2A+Xc2oAN/yYvMlsQC87Vg0X\n\tUmsaizRP4Cew5V7z6rSLJvHLqkpVArZ0YZlt4Cwz6ARmaSBXh9DLBWpZWap5iCIXamqp\n\tC0jSuB8RzJapnnx8mPlPXDd6tpnbRVGtQHQDe+WcMKTNCJGHcciURyzDTpkONeWTZCrI\n\tiQ3HajM9xtAcZOnLqISywEvjtznxVIGREdQE4zTj/M6LPUyMx2xy8MeszJFwh1ppGtJV\n\tGnxQ==","X-Gm-Message-State":"AHPjjUgVRLt0+lMFce2jdfHdVD7ThQy/JGpVkTxMZjV9RbS1McSpB/4p\n\tPr1ifptrXmyLl7/BIo3u2g==","X-Google-Smtp-Source":"AOwi7QBYUhw7s6N+RyZE98/hmnaXmOzwOyswhApqpDL2KSOqh71JVCDOxxv24zS+QRha6EUE1OOQ6Q==","X-Received":"by 10.98.211.72 with SMTP id q69mr3447703pfg.308.1505940758762; \n\tWed, 20 Sep 2017 13:52:38 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:52:35 -0500","From":"Rob Herring ","To":"Serge Semin ","Cc":"richard.leitner@skidata.com, gregkh@linuxfoundation.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","Message-ID":"<20170920205235.qhxhq3it6377bjcq@rob-hp-laptop>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170915233113.17855-2-fancer.lancer@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170915233113.17855-2-fancer.lancer@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772250,"web_url":"http://patchwork.ozlabs.org/comment/1772250/","msgid":"<20170920211517.GA3547@mobilestation>","list_archive_url":null,"date":"2017-09-20T21:15:17","subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"content":"On Wed, Sep 20, 2017 at 03:52:35PM -0500, Rob Herring wrote:\n> On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote:\n> > USB2517i hubs are very like USB251xb devices series. They have almost\n> > the same configuration registers space except number of ports, led\n> > configurations and lack of battery settings. All these peculiarities\n> > are reflected in this patch.\n> > \n> > Signed-off-by: Serge Semin \n> > ---\n> > Documentation/devicetree/bindings/usb/usb251xb.txt | 4 +-\n> \n> Though Greg wants the code split, I want the binding as one change. H/w \n> doesn't gain features one by one.\n> \n> It's preferred to split bindings to a separate patch.\n> \n\nFolks, you are really driving people crazy. When I was reviewing a\nkernel-patchset from a Logan-guy, I asked him to combine some of his patches,\nsince in fact their combination represented one solid driver. I was told to go\nvery far, and Greg supported him with it. I'm not going to be that rude and will\ndo as you asked me to. But really, isn't it possible to have some strict rule\ncreated so a developer would always follow it thereby not being asked to\ncombine/split patches almost everytime?\nThe only way I see for now is to know each maintainer personal preferences.\n\n> > drivers/usb/misc/usb251xb.c | 84 +++++++++++++++++++---\n> > 2 files changed, 78 insertions(+), 10 deletions(-)\n> > \n> > diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt\n> > index 3957d4eda..3d84626d3 100644\n> > --- a/Documentation/devicetree/bindings/usb/usb251xb.txt\n> > +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt\n> > @@ -6,7 +6,8 @@ Hi-Speed Controller.\n> > Required properties :\n> > - compatible : Should be \"microchip,usb251xb\" or one of the specific types:\n> > \t\"microchip,usb2512b\", \"microchip,usb2512bi\", \"microchip,usb2513b\",\n> > -\t\"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\"\n> > +\t\"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\",\n> > +\t\"microchip,usb2517\", \"microchip,usb2517i\"\n> > - reset-gpios : Should specify the gpio for hub reset\n> > - reg : I2C address on the selected bus (default is <0x2C>)\n> > \n> > @@ -36,6 +37,7 @@ Optional properties :\n> > \tan invalid value is given, the default is used instead.\n> > - compound-device : indicate the hub is part of a compound device\n> > - port-mapping-mode : enable port mapping mode\n> > + - speed-led-mode : led speed indiation mode selection (usb2517 only)\n> \n> This is a boolean or has values? What are valid values?\n> \n\nIt's boolean. Shall I rename it as:\n\"- speed-led-mode : enable led speed indication mode (usb2517 only)\"?\n\n> This needs a vendor prefix. Somehow the other properties got in without.\n> \n\nHmm, it's not vendor specific, but device-specific. USB2517 is produced\nby the same vendor - microchip. The new device got almost the same functionality as\nthe others, except number or ports, LED feature and battery enable feature.\nThe last one isn't configurable by dts. The rest of the properties are the same\nfor all the compatible devices. So what properties you are talking about then?\n\n> > - string-support : enable string descriptor support (required for manufacturer,\n> > \tproduct and serial string configuration)\n> > - non-removable-ports : Should specify the ports which have a non-removable\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"RDAjKHw5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyCFN2CWYz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 07:15:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751408AbdITVPS (ORCPT\n\t);\n\tWed, 20 Sep 2017 17:15:18 -0400","from mail-lf0-f65.google.com ([209.85.215.65]:36512 \"EHLO\n\tmail-lf0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751833AbdITVPR (ORCPT\n\t); Wed, 20 Sep 2017 17:15:17 -0400","by mail-lf0-f65.google.com with SMTP id l196so2000014lfl.3;\n\tWed, 20 Sep 2017 14:15:16 -0700 (PDT)","from mobilestation ([95.79.181.62])\n\tby smtp.gmail.com with ESMTPSA id\n\tv28sm601574ljd.0.2017.09.20.14.15.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 14:15:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=K/ko7loCjftoMXjFwuxWxk53aai/3fq8EEG5syGCw+E=;\n\tb=RDAjKHw5scOFJe0vVQSW46JbJX989RqedRyTFopnoy2r+b6+c28n6kldYKZdaxxWwh\n\tTrKxhuCVj7X17lNhKE0EwOAcbol68R5E15HrcBEfD4ZjREL+Cfn4OEs1PRCl3P+cW5jN\n\tutObujsyvDj+BS6WGEf2/wKuS5/ZbjO7XGM/fn8irWs8lUJDFD6WmjqkedKEG+8wnWNt\n\tp1dg7eeqTcPQ7wwp9ORMiWVWYS+vASWV75ppAl3weG2R93+BPXlxR4i6znF0sNPnC6c6\n\tMXwsGgcpgrIxnjovXbMaSmmsN8KDBxD7y2X2dyOrKyq5jL+zWcESp7tJOslM9sACUPgP\n\tvqVQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=K/ko7loCjftoMXjFwuxWxk53aai/3fq8EEG5syGCw+E=;\n\tb=NGD51xviYqZdU/WzkSfJRdhJR8tjc5tZ/RrjbtL5y/EYBo6PczQSOJqDsfPcmxWka5\n\t9xWb54VwCBzoGoe5A7Vhp/5rbd3kvuSXbSORjs4fKLVKnaWLPZsuVQWFL2q/QGCog5Xs\n\t4Hhq+2YS1Vjn5e+7LAn5uGw127xIIRsRN1svm8ocUIQoPnJqx6TuMqOWQlVwvAxo5EWJ\n\tmdWEifHwPv/hRMWzhEZYu+oG8E+ntMZy4mFlhTuSPSTYnZu1xRPYTLDO6woR4yxcC7C1\n\tr0PFIKsNZUgxBoCPDaz8RG+BjFi9vuCR4OmKgVEWbrhbX6UoXszwczFxwZpaRcgMDDBs\n\tkeOg==","X-Gm-Message-State":"AHPjjUhmGzYJulJt5uZPiSJUBT6ZW0eOFi+fs7KNAV0c6DEYA0Q3NTKq\n\tbUIkrEIMFtGyY7XR//4VHd4=","X-Google-Smtp-Source":"AOwi7QCeOQO5QFw7GxDrgDnB0Te7wfBntjTT5IxgHWy3OiSvuVFVLyWoMXZ8UTS6z3Nc0zx4phXR9A==","X-Received":"by 10.25.17.42 with SMTP id g42mr6149lfi.183.1505942115201;\n\tWed, 20 Sep 2017 14:15:15 -0700 (PDT)","Date":"Thu, 21 Sep 2017 00:15:17 +0300","From":"Serge Semin ","To":"Rob Herring ","Cc":"richard.leitner@skidata.com, gregkh@linuxfoundation.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","Message-ID":"<20170920211517.GA3547@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170915233113.17855-2-fancer.lancer@gmail.com>\n\t<20170920205235.qhxhq3it6377bjcq@rob-hp-laptop>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170920205235.qhxhq3it6377bjcq@rob-hp-laptop>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772992,"web_url":"http://patchwork.ozlabs.org/comment/1772992/","msgid":"","list_archive_url":null,"date":"2017-09-21T16:53:29","subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Wed, Sep 20, 2017 at 4:15 PM, Serge Semin wrote:\n> On Wed, Sep 20, 2017 at 03:52:35PM -0500, Rob Herring wrote:\n>> On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote:\n>> > USB2517i hubs are very like USB251xb devices series. They have almost\n>> > the same configuration registers space except number of ports, led\n>> > configurations and lack of battery settings. All these peculiarities\n>> > are reflected in this patch.\n>> >\n>> > Signed-off-by: Serge Semin \n>> > ---\n>> > Documentation/devicetree/bindings/usb/usb251xb.txt | 4 +-\n>>\n>> Though Greg wants the code split, I want the binding as one change. H/w\n>> doesn't gain features one by one.\n>>\n>> It's preferred to split bindings to a separate patch.\n>>\n>\n> Folks, you are really driving people crazy. When I was reviewing a\n> kernel-patchset from a Logan-guy, I asked him to combine some of his patches,\n> since in fact their combination represented one solid driver. I was told to go\n> very far, and Greg supported him with it. I'm not going to be that rude and will\n> do as you asked me to. But really, isn't it possible to have some strict rule\n> created so a developer would always follow it thereby not being asked to\n> combine/split patches almost everytime?\n> The only way I see for now is to know each maintainer personal preferences.\n\nThat rule is in Documentation/devicetree/bindings/submitting-patches.txt.\n\nI generally only ask to respin and split bindings if there's other changes.\n\n>> > drivers/usb/misc/usb251xb.c | 84 +++++++++++++++++++---\n>> > 2 files changed, 78 insertions(+), 10 deletions(-)\n>> >\n>> > diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt\n>> > index 3957d4eda..3d84626d3 100644\n>> > --- a/Documentation/devicetree/bindings/usb/usb251xb.txt\n>> > +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt\n>> > @@ -6,7 +6,8 @@ Hi-Speed Controller.\n>> > Required properties :\n>> > - compatible : Should be \"microchip,usb251xb\" or one of the specific types:\n>> > \"microchip,usb2512b\", \"microchip,usb2512bi\", \"microchip,usb2513b\",\n>> > - \"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\"\n>> > + \"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\",\n>> > + \"microchip,usb2517\", \"microchip,usb2517i\"\n>> > - reset-gpios : Should specify the gpio for hub reset\n>> > - reg : I2C address on the selected bus (default is <0x2C>)\n>> >\n>> > @@ -36,6 +37,7 @@ Optional properties :\n>> > an invalid value is given, the default is used instead.\n>> > - compound-device : indicate the hub is part of a compound device\n>> > - port-mapping-mode : enable port mapping mode\n>> > + - speed-led-mode : led speed indiation mode selection (usb2517 only)\n>>\n>> This is a boolean or has values? What are valid values?\n>>\n>\n> It's boolean. Shall I rename it as:\n> \"- speed-led-mode : enable led speed indication mode (usb2517 only)\"?\n\nHaving the the word \"boolean\" in there would help.\n\n>> This needs a vendor prefix. Somehow the other properties got in without.\n>>\n>\n> Hmm, it's not vendor specific, but device-specific. USB2517 is produced\n> by the same vendor - microchip. The new device got almost the same functionality as\n> the others, except number or ports, LED feature and battery enable feature.\n> The last one isn't configurable by dts. The rest of the properties are the same\n> for all the compatible devices. So what properties you are talking about then?\n\nWell, we don't name things after devices. Properties are either common\n(either from DT Spec or a class of device (clocks, regulators, USB\ndevice, USB hubs, etc.)) or vendor specific. I haven't looked at which\nother ones specifically could be common for hubs or USB devices and\nwhich ones should be MicroChip specific.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyjPX2rBNz9t4Z\n\tfor ;\n\tFri, 22 Sep 2017 02:54:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751732AbdIUQxw (ORCPT\n\t);\n\tThu, 21 Sep 2017 12:53:52 -0400","from mail.kernel.org ([198.145.29.99]:46300 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751581AbdIUQxv (ORCPT );\n\tThu, 21 Sep 2017 12:53:51 -0400","from mail-qt0-f180.google.com (mail-qt0-f180.google.com\n\t[209.85.216.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id B946022A99;\n\tThu, 21 Sep 2017 16:53:50 +0000 (UTC)","by mail-qt0-f180.google.com with SMTP id o3so5513615qte.6;\n\tThu, 21 Sep 2017 09:53:50 -0700 (PDT)","by 10.12.209.75 with HTTP; Thu, 21 Sep 2017 09:53:29 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org B946022A99","X-Gm-Message-State":"AHPjjUjllPhVlS07i6sBXBq9fb7xOekXDT6thtwynATB9IUKyRbOGEET\n\t4SJoKdk5BTsvGpLVg7k7655AgbMdY0csE9eHAA==","X-Google-Smtp-Source":"AOwi7QDYZf7FYo2s2OqYI6aARqDcAkMADeJxjlHGfij3Chs8p4PIzQ3uCeq/r+QfMypGtORyAR4moqeLmw1kqNArIDM=","X-Received":"by 10.237.62.129 with SMTP id n1mr4311381qtf.39.1506012829875;\n\tThu, 21 Sep 2017 09:53:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170920211517.GA3547@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170915233113.17855-2-fancer.lancer@gmail.com>\n\t<20170920205235.qhxhq3it6377bjcq@rob-hp-laptop>\n\t<20170920211517.GA3547@mobilestation>","From":"Rob Herring ","Date":"Thu, 21 Sep 2017 11:53:29 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","To":"Serge Semin ","Cc":"Richard Leitner ,\n\tGreg Kroah-Hartman ,\n\tMark Rutland , Sergey.Semin@t-platforms.ru,\n\tLinux USB List ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773028,"web_url":"http://patchwork.ozlabs.org/comment/1773028/","msgid":"<20170921174027.GB13721@mobilestation>","list_archive_url":null,"date":"2017-09-21T17:40:27","subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"content":"On Thu, Sep 21, 2017 at 11:53:29AM -0500, Rob Herring wrote:\n> On Wed, Sep 20, 2017 at 4:15 PM, Serge Semin wrote:\n> > On Wed, Sep 20, 2017 at 03:52:35PM -0500, Rob Herring wrote:\n> >> On Sat, Sep 16, 2017 at 02:31:09AM +0300, Serge Semin wrote:\n> >> > USB2517i hubs are very like USB251xb devices series. They have almost\n> >> > the same configuration registers space except number of ports, led\n> >> > configurations and lack of battery settings. All these peculiarities\n> >> > are reflected in this patch.\n> >> >\n> >> > Signed-off-by: Serge Semin \n> >> > ---\n> >> > Documentation/devicetree/bindings/usb/usb251xb.txt | 4 +-\n> >>\n> >> Though Greg wants the code split, I want the binding as one change. H/w\n> >> doesn't gain features one by one.\n> >>\n> >> It's preferred to split bindings to a separate patch.\n> >>\n> >\n> > Folks, you are really driving people crazy. When I was reviewing a\n> > kernel-patchset from a Logan-guy, I asked him to combine some of his patches,\n> > since in fact their combination represented one solid driver. I was told to go\n> > very far, and Greg supported him with it. I'm not going to be that rude and will\n> > do as you asked me to. But really, isn't it possible to have some strict rule\n> > created so a developer would always follow it thereby not being asked to\n> > combine/split patches almost everytime?\n> > The only way I see for now is to know each maintainer personal preferences.\n> \n> That rule is in Documentation/devicetree/bindings/submitting-patches.txt.\n> \n> I generally only ask to respin and split bindings if there's other changes.\n> \n\nGreat! I didn't know there is a document like that. Ok. From now I'll do as\nit's prescribed there.\n\n> >> > drivers/usb/misc/usb251xb.c | 84 +++++++++++++++++++---\n> >> > 2 files changed, 78 insertions(+), 10 deletions(-)\n> >> >\n> >> > diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b/Documentation/devicetree/bindings/usb/usb251xb.txt\n> >> > index 3957d4eda..3d84626d3 100644\n> >> > --- a/Documentation/devicetree/bindings/usb/usb251xb.txt\n> >> > +++ b/Documentation/devicetree/bindings/usb/usb251xb.txt\n> >> > @@ -6,7 +6,8 @@ Hi-Speed Controller.\n> >> > Required properties :\n> >> > - compatible : Should be \"microchip,usb251xb\" or one of the specific types:\n> >> > \"microchip,usb2512b\", \"microchip,usb2512bi\", \"microchip,usb2513b\",\n> >> > - \"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\"\n> >> > + \"microchip,usb2513bi\", \"microchip,usb2514b\", \"microchip,usb2514bi\",\n> >> > + \"microchip,usb2517\", \"microchip,usb2517i\"\n> >> > - reset-gpios : Should specify the gpio for hub reset\n> >> > - reg : I2C address on the selected bus (default is <0x2C>)\n> >> >\n> >> > @@ -36,6 +37,7 @@ Optional properties :\n> >> > an invalid value is given, the default is used instead.\n> >> > - compound-device : indicate the hub is part of a compound device\n> >> > - port-mapping-mode : enable port mapping mode\n> >> > + - speed-led-mode : led speed indiation mode selection (usb2517 only)\n> >>\n> >> This is a boolean or has values? What are valid values?\n> >>\n> >\n> > It's boolean. Shall I rename it as:\n> > \"- speed-led-mode : enable led speed indication mode (usb2517 only)\"?\n> \n> Having the the word \"boolean\" in there would help.\n> \n> >> This needs a vendor prefix. Somehow the other properties got in without.\n> >>\n> >\n> > Hmm, it's not vendor specific, but device-specific. USB2517 is produced\n> > by the same vendor - microchip. The new device got almost the same functionality as\n> > the others, except number or ports, LED feature and battery enable feature.\n> > The last one isn't configurable by dts. The rest of the properties are the same\n> > for all the compatible devices. So what properties you are talking about then?\n> \n> Well, we don't name things after devices. Properties are either common\n> (either from DT Spec or a class of device (clocks, regulators, USB\n> device, USB hubs, etc.)) or vendor specific. I haven't looked at which\n> other ones specifically could be common for hubs or USB devices and\n> which ones should be MicroChip specific.\n> \n\nAlright. I found the recommended vendor-specific prefix, it's \"microchip\". What's \nnext? The thing is, that this driver isn't usual USB root port controller driver.\nIt's the driver to perform the usb251x hubs configuration on boot time in accordance\nwith the hardware specifics. So to speak, this driver is something like EEPROM firmware\nembedded in the kernel and configured by device tree node properties. I can't be sure,\nwhether all of these settings might be vendor specific, or some of them still can be\nexposed by the hubs of other vendors. Most of the circuit designers just add real\nEEPROMs to be connected to hubs, so their configurations would be loaded from them.\nWhat shall we do with this bindings then? Shall we add the vendor-specific vendor to\nthe bindings file?\n\n> Rob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sFWeoWEV\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xykR11zBdz9s3T\n\tfor ;\n\tFri, 22 Sep 2017 03:40:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751598AbdIURk1 (ORCPT\n\t);\n\tThu, 21 Sep 2017 13:40:27 -0400","from mail-lf0-f67.google.com ([209.85.215.67]:38819 \"EHLO\n\tmail-lf0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750790AbdIURk0 (ORCPT\n\t); Thu, 21 Sep 2017 13:40:26 -0400","by mail-lf0-f67.google.com with SMTP id m199so3347339lfe.5;\n\tThu, 21 Sep 2017 10:40:24 -0700 (PDT)","from mobilestation ([95.79.181.62])\n\tby smtp.gmail.com with ESMTPSA id\n\ti123sm394774lji.92.2017.09.21.10.40.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 21 Sep 2017 10:40:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=RAnqfJmBj7jQGq4qhGeHtDYouoYFGD6LEF6M8gePwpQ=;\n\tb=sFWeoWEV4nFfqZUtVDIMWN57beLpjT1GrXBH9Pk3xlFCHnUUsxMiRJORbPzE/rDQtT\n\tnMpWu1SqedJpKBEgqRKgONyxb+cX/gHibP7uk68HCRmu0iWWuXMF/5chrN/jlIy+0b9/\n\tceG+EDgMtVZl9D6gnNQkiC3a0K0aLHAF1dD36r/8WITsxSryJ4P8L6S3BN2I2XzBCGj7\n\tpSVpjVU1GcMWerFQxDbZLsPkpEmcZqzMb7Im5jxlZoeh5CH49eL2EBN6BjeIwqdpZVjq\n\tecyQT1ExDZ4VNsTcZxapwk8qsuMTXrTNjiu/JeYunFipKyhA+hNcxgoknyb06z5/Rb4B\n\t25kA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=RAnqfJmBj7jQGq4qhGeHtDYouoYFGD6LEF6M8gePwpQ=;\n\tb=WuUCMZmRg/Ew9gIvHQJO6C4RUyaeFXAFg2tvjc1NT+PHmwMTqZz5mhNVOn4zyIKw0J\n\tu84b9KmumoZFGofcu+a7Sr0aDosvneUD6KjJPOHpZM5cw+diCIYnfjpkFlCaBCQscSCW\n\tX7CnhIj0cmig2+vEkIet27eVnbIbefEwp4VGd4emrpdbIT/9Dq2vOAYSuhHVDk2OGt2e\n\toiZgZHRusLgKShbHi4xpURuuZhBCugahzEUQWxojUpMPqEmenMq1eJD3DltHRdxGhKGH\n\tQmGH2xKYOGHlzcB32K1FCEpMQ6Hrun0cVahsNzkJq+xZ+E28t4n5EUTEyMB5POkV470z\n\tIRRQ==","X-Gm-Message-State":"AHPjjUjS5VTriKTlYWce/NX4qDkH+u4uphr22yWPvABtSPjpO936n2Q0\n\tM7ffo0AMqwJG61e8/YMUnLQ=","X-Google-Smtp-Source":"AOwi7QBNoKFUx184mqbpq2+YwlfSNsjJYhtwcB3jE7q28YpMMxwmEc27fOrtA6MZWAegmRMCUMsSFw==","X-Received":"by 10.46.87.23 with SMTP id l23mr1302375ljb.128.1506015624151;\n\tThu, 21 Sep 2017 10:40:24 -0700 (PDT)","Date":"Thu, 21 Sep 2017 20:40:27 +0300","From":"Serge Semin ","To":"Rob Herring ","Cc":"Richard Leitner ,\n\tGreg Kroah-Hartman ,\n\tMark Rutland , Sergey.Semin@t-platforms.ru,\n\tLinux USB List ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Subject":"Re: [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support","Message-ID":"<20170921174027.GB13721@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170915233113.17855-2-fancer.lancer@gmail.com>\n\t<20170920205235.qhxhq3it6377bjcq@rob-hp-laptop>\n\t<20170920211517.GA3547@mobilestation>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]