[{"id":1769420,"web_url":"http://patchwork.ozlabs.org/comment/1769420/","msgid":"","list_archive_url":null,"date":"2017-09-15T20:00:16","subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","submitter":{"id":10041,"url":"http://patchwork.ozlabs.org/api/people/10041/","name":"Julia Lawall","email":"julia.lawall@lip6.fr"},"content":"On Sat, 16 Sep 2017, Srishti Sharma wrote:\n\n> Write assignment statement outside the if statement. Done using\n> the following semantic patch by coccinelle.\n>\n> @@\n> identifier E;\n> expression F;\n> statement S;\n> @@\n>\n> -if((E = F))\n> +E = F;\n> +if(E)\n> S\n>\n> Signed-off-by: Srishti Sharma \n\nAcked-by: Julia Lawall \n\n\n> ---\n> Changes in v2:\n> -Semicolon was missing in one of the statements of the\n> semantic patch\n>\n> drivers/staging/irda/drivers/irda-usb.c | 4 ++--\n> drivers/staging/irda/drivers/mcs7780.c | 9 ++++++---\n> drivers/staging/irda/net/irqueue.c | 3 ++-\n> 3 files changed, 10 insertions(+), 6 deletions(-)\n>\n> diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c\n> index 723e49b..82bfc05 100644\n> --- a/drivers/staging/irda/drivers/irda-usb.c\n> +++ b/drivers/staging/irda/drivers/irda-usb.c\n> @@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self)\n> \turb->transfer_flags = 0;\n>\n> \t/* Irq disabled -> GFP_ATOMIC */\n> -\tif ((ret = usb_submit_urb(urb, GFP_ATOMIC))) {\n> +\tret = usb_submit_urb(urb, GFP_ATOMIC);\n> +\tif (ret)\n> \t\tnet_warn_ratelimited(\"%s(), failed Speed URB\\n\", __func__);\n> -\t}\n> }\n>\n> /*------------------------------------------------------------------*/\n> diff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c\n> index c3f0b25..2b674d5 100644\n> --- a/drivers/staging/irda/drivers/mcs7780.c\n> +++ b/drivers/staging/irda/drivers/mcs7780.c\n> @@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs)\n> \tif (mcs->new_speed <= 115200) {\n> \t\trval &= ~MCS_FIR;\n>\n> -\t\tif ((rst = (mcs->speed > 115200)))\n> +\t\trst = (mcs->speed > 115200);\n> +\t\tif (rst)\n> \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 0);\n>\n> \t} else if (mcs->new_speed <= 1152000) {\n> \t\trval &= ~MCS_FIR;\n>\n> -\t\tif ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000)))\n> +\t\trst = !(mcs->speed == 576000 || mcs->speed == 1152000);\n> +\t\tif (rst)\n> \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n>\n> \t} else {\n> \t\trval |= MCS_FIR;\n>\n> -\t\tif ((rst = (mcs->speed != 4000000)))\n> +\t\trst = (mcs->speed != 4000000);\n> +\t\tif (rst)\n> \t\t\tmcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n>\n> \t}\n> diff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c\n> index 160dc89..5aab072 100644\n> --- a/drivers/staging/irda/net/irqueue.c\n> +++ b/drivers/staging/irda/net/irqueue.c\n> @@ -217,7 +217,8 @@ static __u32 hash( const char* name)\n>\n> \twhile(*name) {\n> \t\th = (h<<4) + *name++;\n> -\t\tif ((g = (h & 0xf0000000)))\n> +\t\tg = (h & 0xf0000000);\n> +\t\tif (g)\n> \t\t\th ^=g>>24;\n> \t\th &=~g;\n> \t}\n> --\n> 2.7.4\n>\n> --\n> You received this message because you are subscribed to the Google Groups \"outreachy-kernel\" group.\n> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.\n> To post to this group, send email to outreachy-kernel@googlegroups.com.\n> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505504680-22167-1-git-send-email-srishtishar%40gmail.com.\n> For more options, visit https://groups.google.com/d/optout.\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv5qL57X3z9s7g\n\tfor ;\n\tSat, 16 Sep 2017 06:00:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751556AbdIOUAS (ORCPT );\n\tFri, 15 Sep 2017 16:00:18 -0400","from mail2-relais-roc.national.inria.fr ([192.134.164.83]:1856\n\t\"EHLO mail2-relais-roc.national.inria.fr\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751452AbdIOUAR (ORCPT\n\t); Fri, 15 Sep 2017 16:00:17 -0400","from 85-171-60-79.rev.numericable.fr (HELO [192.168.0.15])\n\t([85.171.60.79]) by mail2-relais-roc.national.inria.fr with\n\tESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2017 22:00:16 +0200"],"X-IronPort-AV":"E=Sophos;i=\"5.42,398,1500933600\"; d=\"scan'208\";a=\"291327264\"","Date":"Fri, 15 Sep 2017 22:00:16 +0200 (CEST)","From":"Julia Lawall ","X-X-Sender":"jll@hadrien","To":"Srishti Sharma ","cc":"samuel@sortiz.org, gregkh@linuxfoundation.org,\n\tnetdev@vger.kernel.org, devel@driverdev.osuosl.org,\n\tlinux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com","Subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","In-Reply-To":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>","Message-ID":"","References":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769447,"web_url":"http://patchwork.ozlabs.org/comment/1769447/","msgid":"","list_archive_url":null,"date":"2017-09-15T21:07:37","subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","submitter":{"id":72376,"url":"http://patchwork.ozlabs.org/api/people/72376/","name":"Srishti Sharma","email":"srishtishar@gmail.com"},"content":"On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote:\n>\n>\n> On Sat, 16 Sep 2017, Srishti Sharma wrote:\n>\n>> Write assignment statement outside the if statement. Done using\n>> the following semantic patch by coccinelle.\n>>\n>> @@\n>> identifier E;\n>> expression F;\n>> statement S;\n>> @@\n>>\n>> -if((E = F))\n>> +E = F;\n>> +if(E)\n>> S\n>>\n>> Signed-off-by: Srishti Sharma \n>\n> Acked-by: Julia Lawall \n\nHave sent a patchset for this instead .\n\nRegards,\nSrishti\n>\n>> ---\n>> Changes in v2:\n>> -Semicolon was missing in one of the statements of the\n>> semantic patch\n>>\n>> drivers/staging/irda/drivers/irda-usb.c | 4 ++--\n>> drivers/staging/irda/drivers/mcs7780.c | 9 ++++++---\n>> drivers/staging/irda/net/irqueue.c | 3 ++-\n>> 3 files changed, 10 insertions(+), 6 deletions(-)\n>>\n>> diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c\n>> index 723e49b..82bfc05 100644\n>> --- a/drivers/staging/irda/drivers/irda-usb.c\n>> +++ b/drivers/staging/irda/drivers/irda-usb.c\n>> @@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self)\n>> urb->transfer_flags = 0;\n>>\n>> /* Irq disabled -> GFP_ATOMIC */\n>> - if ((ret = usb_submit_urb(urb, GFP_ATOMIC))) {\n>> + ret = usb_submit_urb(urb, GFP_ATOMIC);\n>> + if (ret)\n>> net_warn_ratelimited(\"%s(), failed Speed URB\\n\", __func__);\n>> - }\n>> }\n>>\n>> /*------------------------------------------------------------------*/\n>> diff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c\n>> index c3f0b25..2b674d5 100644\n>> --- a/drivers/staging/irda/drivers/mcs7780.c\n>> +++ b/drivers/staging/irda/drivers/mcs7780.c\n>> @@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs)\n>> if (mcs->new_speed <= 115200) {\n>> rval &= ~MCS_FIR;\n>>\n>> - if ((rst = (mcs->speed > 115200)))\n>> + rst = (mcs->speed > 115200);\n>> + if (rst)\n>> mcs_set_reg(mcs, MCS_MINRXPW_REG, 0);\n>>\n>> } else if (mcs->new_speed <= 1152000) {\n>> rval &= ~MCS_FIR;\n>>\n>> - if ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000)))\n>> + rst = !(mcs->speed == 576000 || mcs->speed == 1152000);\n>> + if (rst)\n>> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n>>\n>> } else {\n>> rval |= MCS_FIR;\n>>\n>> - if ((rst = (mcs->speed != 4000000)))\n>> + rst = (mcs->speed != 4000000);\n>> + if (rst)\n>> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n>>\n>> }\n>> diff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c\n>> index 160dc89..5aab072 100644\n>> --- a/drivers/staging/irda/net/irqueue.c\n>> +++ b/drivers/staging/irda/net/irqueue.c\n>> @@ -217,7 +217,8 @@ static __u32 hash( const char* name)\n>>\n>> while(*name) {\n>> h = (h<<4) + *name++;\n>> - if ((g = (h & 0xf0000000)))\n>> + g = (h & 0xf0000000);\n>> + if (g)\n>> h ^=g>>24;\n>> h &=~g;\n>> }\n>> --\n>> 2.7.4\n>>\n>> --\n>> You received this message because you are subscribed to the Google Groups \"outreachy-kernel\" group.\n>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.\n>> To post to this group, send email to outreachy-kernel@googlegroups.com.\n>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505504680-22167-1-git-send-email-srishtishar%40gmail.com.\n>> For more options, visit https://groups.google.com/d/optout.\n>>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZEfr3mkC\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv7K53jz0z9s3w\n\tfor ;\n\tSat, 16 Sep 2017 07:07:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751977AbdIOVHk (ORCPT );\n\tFri, 15 Sep 2017 17:07:40 -0400","from mail-qk0-f196.google.com ([209.85.220.196]:34352 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751685AbdIOVHi (ORCPT\n\t); Fri, 15 Sep 2017 17:07:38 -0400","by mail-qk0-f196.google.com with SMTP id d70so2165858qkc.1;\n\tFri, 15 Sep 2017 14:07:38 -0700 (PDT)","by 10.200.55.118 with HTTP; Fri, 15 Sep 2017 14:07:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=h38fOAUJS2SBEJx3TjKu0jE4hy3+Wpi5fDqHmpt+EzU=;\n\tb=ZEfr3mkC+a7CNm64IkE8GuEvUtZ5ddM+Rqpjyn04oo5Q0kvd/mrtAyQ7usWNz0zX1d\n\t9a2IUmcldYMenXz5Kej7JIX5OVk0LQD4CBtdU8b9dOAMDmRXIDsrpYn/6iWEKb/zgiT9\n\t9/L6zAN+IweTZ8DAsyBIMY/NiSD+Rq+pek34BEMBiQEYNQt9ITMrjkrQAaP2mxn0msu+\n\tzu31dMWWdCvN/6jpB7EaizNAkjdAYIs+4sAhcN7q96p8EcXu2FIrughKvkL527W6Ff/U\n\tfLs3Qlk3sv7Y7akIuFtveZBSqe2OmeAykyqpSwU+D+udzK1OuBbG9EEc2aS6VBq2/+xL\n\tty3Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=h38fOAUJS2SBEJx3TjKu0jE4hy3+Wpi5fDqHmpt+EzU=;\n\tb=CCpbht+elagR64l9jXH+EXg/Z0aFlWNR7RXzVOXu+6Rz1qQ88yUWsewJmTxbqsO/eV\n\tQj2PXr04ZTXlyZxqFeB2Y0gw/z13x6fdoumSyypBys/ldQQkfHrmFJL7u+VqCqUMMBfF\n\tTd618pjXyoyjpGj577i22bpvMVMRQdSPmuJ8tmqbMT948g/8c9ixfGxVfpvwnL3E7iDA\n\t+dMX0PAKpmDNTpZzsDCcXmMPONEm7AfKb8H/D/ulLxWwkP3Yac0m51H/9HjhGLh3S61d\n\thn1bwrc62YXoNudYpkmMLwtFzl7z78Ni+EwZnNnAogjQYcpT6kSoRjW3ips1ai7YXTQe\n\t8TNw==","X-Gm-Message-State":"AHPjjUhmCzqhEKvBadEY1Vrk3/3XVmuoQXe+HjoTo/GxRNTZuL8pc8Dz\n\tbhEvR8AnuB/xtgaMoWCLpnsetvBVMsqHI70HKx4=","X-Google-Smtp-Source":"AOwi7QAa3Ow6j6o2FzB/wZnubJrAhCOERW9tv6dOCz/kC05YnraHhwOl0J0ATAKa27QvHxToWgxFEI9JiFZTb0LQJ3Q=","X-Received":"by 10.55.151.135 with SMTP id z129mr9850637qkd.119.1505509657957;\n\tFri, 15 Sep 2017 14:07:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>\n\t","From":"Srishti Sharma ","Date":"Sat, 16 Sep 2017 02:37:37 +0530","Message-ID":"","Subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","To":"Julia Lawall ","Cc":"samuel@sortiz.org, Greg KH ,\n\tnetdev@vger.kernel.org, devel@driverdev.osuosl.org,\n\tLinux kernel mailing list ,\n\toutreachy-kernel@googlegroups.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769448,"web_url":"http://patchwork.ozlabs.org/comment/1769448/","msgid":"","list_archive_url":null,"date":"2017-09-15T21:09:33","subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","submitter":{"id":10041,"url":"http://patchwork.ozlabs.org/api/people/10041/","name":"Julia Lawall","email":"julia.lawall@lip6.fr"},"content":"On Sat, 16 Sep 2017, Srishti Sharma wrote:\n\n> On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote:\n> >\n> >\n> > On Sat, 16 Sep 2017, Srishti Sharma wrote:\n> >\n> >> Write assignment statement outside the if statement. Done using\n> >> the following semantic patch by coccinelle.\n> >>\n> >> @@\n> >> identifier E;\n> >> expression F;\n> >> statement S;\n> >> @@\n> >>\n> >> -if((E = F))\n> >> +E = F;\n> >> +if(E)\n> >> S\n> >>\n> >> Signed-off-by: Srishti Sharma \n> >\n> > Acked-by: Julia Lawall \n>\n> Have sent a patchset for this instead .\n\nThanks. Actually, you should have copied the ack.\n\njulia\n\n>\n> Regards,\n> Srishti\n> >\n> >> ---\n> >> Changes in v2:\n> >> -Semicolon was missing in one of the statements of the\n> >> semantic patch\n> >>\n> >> drivers/staging/irda/drivers/irda-usb.c | 4 ++--\n> >> drivers/staging/irda/drivers/mcs7780.c | 9 ++++++---\n> >> drivers/staging/irda/net/irqueue.c | 3 ++-\n> >> 3 files changed, 10 insertions(+), 6 deletions(-)\n> >>\n> >> diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c\n> >> index 723e49b..82bfc05 100644\n> >> --- a/drivers/staging/irda/drivers/irda-usb.c\n> >> +++ b/drivers/staging/irda/drivers/irda-usb.c\n> >> @@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self)\n> >> urb->transfer_flags = 0;\n> >>\n> >> /* Irq disabled -> GFP_ATOMIC */\n> >> - if ((ret = usb_submit_urb(urb, GFP_ATOMIC))) {\n> >> + ret = usb_submit_urb(urb, GFP_ATOMIC);\n> >> + if (ret)\n> >> net_warn_ratelimited(\"%s(), failed Speed URB\\n\", __func__);\n> >> - }\n> >> }\n> >>\n> >> /*------------------------------------------------------------------*/\n> >> diff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c\n> >> index c3f0b25..2b674d5 100644\n> >> --- a/drivers/staging/irda/drivers/mcs7780.c\n> >> +++ b/drivers/staging/irda/drivers/mcs7780.c\n> >> @@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs)\n> >> if (mcs->new_speed <= 115200) {\n> >> rval &= ~MCS_FIR;\n> >>\n> >> - if ((rst = (mcs->speed > 115200)))\n> >> + rst = (mcs->speed > 115200);\n> >> + if (rst)\n> >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 0);\n> >>\n> >> } else if (mcs->new_speed <= 1152000) {\n> >> rval &= ~MCS_FIR;\n> >>\n> >> - if ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000)))\n> >> + rst = !(mcs->speed == 576000 || mcs->speed == 1152000);\n> >> + if (rst)\n> >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n> >>\n> >> } else {\n> >> rval |= MCS_FIR;\n> >>\n> >> - if ((rst = (mcs->speed != 4000000)))\n> >> + rst = (mcs->speed != 4000000);\n> >> + if (rst)\n> >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n> >>\n> >> }\n> >> diff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c\n> >> index 160dc89..5aab072 100644\n> >> --- a/drivers/staging/irda/net/irqueue.c\n> >> +++ b/drivers/staging/irda/net/irqueue.c\n> >> @@ -217,7 +217,8 @@ static __u32 hash( const char* name)\n> >>\n> >> while(*name) {\n> >> h = (h<<4) + *name++;\n> >> - if ((g = (h & 0xf0000000)))\n> >> + g = (h & 0xf0000000);\n> >> + if (g)\n> >> h ^=g>>24;\n> >> h &=~g;\n> >> }\n> >> --\n> >> 2.7.4\n> >>\n> >> --\n> >> You received this message because you are subscribed to the Google Groups \"outreachy-kernel\" group.\n> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.\n> >> To post to this group, send email to outreachy-kernel@googlegroups.com.\n> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505504680-22167-1-git-send-email-srishtishar%40gmail.com.\n> >> For more options, visit https://groups.google.com/d/optout.\n> >>\n>\n> --\n> You received this message because you are subscribed to the Google Groups \"outreachy-kernel\" group.\n> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.\n> To post to this group, send email to outreachy-kernel@googlegroups.com.\n> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAB3L5oxr5K5aMo06ROCVV9ejY6a_g1%2BuUkjU%3DZ5bKTJtzUs7sA%40mail.gmail.com.\n> For more options, visit https://groups.google.com/d/optout.\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv7MK1wqGz9sDB\n\tfor ;\n\tSat, 16 Sep 2017 07:09:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751825AbdIOVJh (ORCPT );\n\tFri, 15 Sep 2017 17:09:37 -0400","from mail2-relais-roc.national.inria.fr ([192.134.164.83]:31325\n\t\"EHLO mail2-relais-roc.national.inria.fr\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1751675AbdIOVJf (ORCPT\n\t); Fri, 15 Sep 2017 17:09:35 -0400","from 85-171-60-79.rev.numericable.fr (HELO [192.168.0.15])\n\t([85.171.60.79]) by mail2-relais-roc.national.inria.fr with\n\tESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2017 23:09:34 +0200"],"X-IronPort-AV":"E=Sophos;i=\"5.42,399,1500933600\"; d=\"scan'208\";a=\"291331168\"","Date":"Fri, 15 Sep 2017 23:09:33 +0200 (CEST)","From":"Julia Lawall ","X-X-Sender":"jll@hadrien","To":"Srishti Sharma ","cc":"samuel@sortiz.org, Greg KH ,\n\tnetdev@vger.kernel.org, devel@driverdev.osuosl.org,\n\tLinux kernel mailing list ,\n\toutreachy-kernel@googlegroups.com","Subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","In-Reply-To":"","Message-ID":"","References":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>\n\t\n\t","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769452,"web_url":"http://patchwork.ozlabs.org/comment/1769452/","msgid":"","list_archive_url":null,"date":"2017-09-15T21:14:16","subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","submitter":{"id":72376,"url":"http://patchwork.ozlabs.org/api/people/72376/","name":"Srishti Sharma","email":"srishtishar@gmail.com"},"content":"On Sat, Sep 16, 2017 at 2:39 AM, Julia Lawall wrote:\n>\n>\n> On Sat, 16 Sep 2017, Srishti Sharma wrote:\n>\n>> On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote:\n>> >\n>> >\n>> > On Sat, 16 Sep 2017, Srishti Sharma wrote:\n>> >\n>> >> Write assignment statement outside the if statement. Done using\n>> >> the following semantic patch by coccinelle.\n>> >>\n>> >> @@\n>> >> identifier E;\n>> >> expression F;\n>> >> statement S;\n>> >> @@\n>> >>\n>> >> -if((E = F))\n>> >> +E = F;\n>> >> +if(E)\n>> >> S\n>> >>\n>> >> Signed-off-by: Srishti Sharma \n>> >\n>> > Acked-by: Julia Lawall \n>>\n>> Have sent a patchset for this instead .\n>\n> Thanks. Actually, you should have copied the ack.\n\nOh.. Sorry didn't realise I could do that :)\n\nRegards,\nSrishti\n\n>\n> julia\n>\n>>\n>> Regards,\n>> Srishti\n>> >\n>> >> ---\n>> >> Changes in v2:\n>> >> -Semicolon was missing in one of the statements of the\n>> >> semantic patch\n>> >>\n>> >> drivers/staging/irda/drivers/irda-usb.c | 4 ++--\n>> >> drivers/staging/irda/drivers/mcs7780.c | 9 ++++++---\n>> >> drivers/staging/irda/net/irqueue.c | 3 ++-\n>> >> 3 files changed, 10 insertions(+), 6 deletions(-)\n>> >>\n>> >> diff --git a/drivers/staging/irda/drivers/irda-usb.c b/drivers/staging/irda/drivers/irda-usb.c\n>> >> index 723e49b..82bfc05 100644\n>> >> --- a/drivers/staging/irda/drivers/irda-usb.c\n>> >> +++ b/drivers/staging/irda/drivers/irda-usb.c\n>> >> @@ -334,9 +334,9 @@ static void irda_usb_change_speed_xbofs(struct irda_usb_cb *self)\n>> >> urb->transfer_flags = 0;\n>> >>\n>> >> /* Irq disabled -> GFP_ATOMIC */\n>> >> - if ((ret = usb_submit_urb(urb, GFP_ATOMIC))) {\n>> >> + ret = usb_submit_urb(urb, GFP_ATOMIC);\n>> >> + if (ret)\n>> >> net_warn_ratelimited(\"%s(), failed Speed URB\\n\", __func__);\n>> >> - }\n>> >> }\n>> >>\n>> >> /*------------------------------------------------------------------*/\n>> >> diff --git a/drivers/staging/irda/drivers/mcs7780.c b/drivers/staging/irda/drivers/mcs7780.c\n>> >> index c3f0b25..2b674d5 100644\n>> >> --- a/drivers/staging/irda/drivers/mcs7780.c\n>> >> +++ b/drivers/staging/irda/drivers/mcs7780.c\n>> >> @@ -605,19 +605,22 @@ static int mcs_speed_change(struct mcs_cb *mcs)\n>> >> if (mcs->new_speed <= 115200) {\n>> >> rval &= ~MCS_FIR;\n>> >>\n>> >> - if ((rst = (mcs->speed > 115200)))\n>> >> + rst = (mcs->speed > 115200);\n>> >> + if (rst)\n>> >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 0);\n>> >>\n>> >> } else if (mcs->new_speed <= 1152000) {\n>> >> rval &= ~MCS_FIR;\n>> >>\n>> >> - if ((rst = !(mcs->speed == 576000 || mcs->speed == 1152000)))\n>> >> + rst = !(mcs->speed == 576000 || mcs->speed == 1152000);\n>> >> + if (rst)\n>> >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n>> >>\n>> >> } else {\n>> >> rval |= MCS_FIR;\n>> >>\n>> >> - if ((rst = (mcs->speed != 4000000)))\n>> >> + rst = (mcs->speed != 4000000);\n>> >> + if (rst)\n>> >> mcs_set_reg(mcs, MCS_MINRXPW_REG, 5);\n>> >>\n>> >> }\n>> >> diff --git a/drivers/staging/irda/net/irqueue.c b/drivers/staging/irda/net/irqueue.c\n>> >> index 160dc89..5aab072 100644\n>> >> --- a/drivers/staging/irda/net/irqueue.c\n>> >> +++ b/drivers/staging/irda/net/irqueue.c\n>> >> @@ -217,7 +217,8 @@ static __u32 hash( const char* name)\n>> >>\n>> >> while(*name) {\n>> >> h = (h<<4) + *name++;\n>> >> - if ((g = (h & 0xf0000000)))\n>> >> + g = (h & 0xf0000000);\n>> >> + if (g)\n>> >> h ^=g>>24;\n>> >> h &=~g;\n>> >> }\n>> >> --\n>> >> 2.7.4\n>> >>\n>> >> --\n>> >> You received this message because you are subscribed to the Google Groups \"outreachy-kernel\" group.\n>> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.\n>> >> To post to this group, send email to outreachy-kernel@googlegroups.com.\n>> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505504680-22167-1-git-send-email-srishtishar%40gmail.com.\n>> >> For more options, visit https://groups.google.com/d/optout.\n>> >>\n>>\n>> --\n>> You received this message because you are subscribed to the Google Groups \"outreachy-kernel\" group.\n>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.\n>> To post to this group, send email to outreachy-kernel@googlegroups.com.\n>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAB3L5oxr5K5aMo06ROCVV9ejY6a_g1%2BuUkjU%3DZ5bKTJtzUs7sA%40mail.gmail.com.\n>> For more options, visit https://groups.google.com/d/optout.\n>>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vOhJrVUO\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv7T86x6Rz9ryQ\n\tfor ;\n\tSat, 16 Sep 2017 07:14:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751763AbdIOVOS (ORCPT );\n\tFri, 15 Sep 2017 17:14:18 -0400","from mail-qt0-f194.google.com ([209.85.216.194]:35586 \"EHLO\n\tmail-qt0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751616AbdIOVOR (ORCPT\n\t); Fri, 15 Sep 2017 17:14:17 -0400","by mail-qt0-f194.google.com with SMTP id l25so2249045qtf.2;\n\tFri, 15 Sep 2017 14:14:16 -0700 (PDT)","by 10.200.55.118 with HTTP; Fri, 15 Sep 2017 14:14:16 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=UoU8+cFtbnfNyRZluS1bc8beMXbmhYLm4Rt9Lz5210Q=;\n\tb=vOhJrVUOzQd9dbaAWK8Au381se7hidgRVKNlQXMn9j7ZQWKxie13yRcO7H1+JThbOF\n\t3H4U2HKgwpCKUS38+6fw2epOS+XEe81h5EoMhb+MZaEvDIpL2ESk069piq1sm2TOkESc\n\tE0S6TYSHzVUpnNwo3kXAp62055AUtqVPaaErxW7EAs1+aAGtIsVTASHZnCV6WqtsCt4B\n\tNWhph30WAsOcAQD/r/JyAX9sYsR1eFtlUzJcDyc1IZ02likOOOlLxuMoj+1505RgAUns\n\tAKlOy+gKZRGbBLilkPwJ92wD6MjGhGaDFPqkeVp7Y1ppB535Zd7MBL0gzvmm38utNyFD\n\tWSRA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=UoU8+cFtbnfNyRZluS1bc8beMXbmhYLm4Rt9Lz5210Q=;\n\tb=SEN2pmUU3/SASD3floVCsZUZwlBlyCQsGlC65aaoMsAkf4CIV/CjAPZUCIy6jNSXi7\n\tf6XPnN/d76zLsXigh5VgbWijqRgvTXbMW21lVbk7d+h4AIl8c93WDiY4BWYU+mwVGEw/\n\t/Mw8p0ZF0qzTclAHj87mwyNLAIigNfs+3CWxe7PCuosYJrwzdStZwScm9PXjKk7xZrBf\n\tNveTPIa5g0hBYcerfuDXEYTGZtSz+SNlZth/ZethciLu8N9dpAZfB04DsJKrbB9+0eQ6\n\tGw6hrEmwoCUdmdZISudwj2DcHABpeyZ9lcs+wsdpu/kvmyNgjeVs5XVdteRu/hZ/oo0r\n\tmRbw==","X-Gm-Message-State":"AHPjjUizqCGD8hxst/DuvyQNfULigJw7dCyytM+aj5gzK0Pa3k/vHGLx\n\t7Cce/veOTkDm8LSDf4pgKZ5wvAq1/SUb3uB2+KI=","X-Google-Smtp-Source":"AOwi7QDzmGXrNeCU72DjhoNx7bFBRMIi0grtvbVlidmDRzkIXivqbsmkLChClimju+NWqeGJizaU1U+cIhhpdvgjO8s=","X-Received":"by 10.200.27.6 with SMTP id y6mr39900183qtj.247.1505510056409;\n\tFri, 15 Sep 2017 14:14:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1505504680-22167-1-git-send-email-srishtishar@gmail.com>\n\t\n\t\n\t","From":"Srishti Sharma ","Date":"Sat, 16 Sep 2017 02:44:16 +0530","Message-ID":"","Subject":"Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use\n\tassignment inside if statement","To":"Julia Lawall ","Cc":"samuel@sortiz.org, Greg KH ,\n\tnetdev@vger.kernel.org, devel@driverdev.osuosl.org,\n\tLinux kernel mailing list ,\n\toutreachy-kernel@googlegroups.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]