[{"id":1769378,"web_url":"http://patchwork.ozlabs.org/comment/1769378/","msgid":"<150550344628.36.3236693333533070993@69b6ddf88678>","list_archive_url":null,"date":"2017-09-15T19:24:06","subject":"Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Handle SH4's\n\texceptional alignment for p{read, write}64","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64\nMessage-id: 20170915190748.82389-1-jrtc27@jrtc27.com\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n t [tag update] patchew/1504888905-22396-1-git-send-email-chugh.ishani@research.iiit.ac.in -> patchew/1504888905-22396-1-git-send-email-chugh.ishani@research.iiit.ac.in\nSwitched to a new branch 'test'\n5c4a338e12 linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/1: linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64...\nERROR: open brace '{' following function declarations go on the next line\n#20: FILE: linux-user/syscall.c:670:\n+static inline int regpairs_aligned(void *cpu_env, int num) {\n\nERROR: open brace '{' following function declarations go on the next line\n#34: FILE: linux-user/syscall.c:682:\n+static inline int regpairs_aligned(void *cpu_env, int num) {\n\ntotal: 2 errors, 0 warnings, 90 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv52B62Fhz9s7g\n\tfor ;\n\tSat, 16 Sep 2017 05:24:49 +1000 (AEST)","from localhost ([::1]:54741 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dswEI-0004nZ-Gc\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 15:24:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58800)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dswDz-0004nG-TL\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 15:24:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dswDv-0000ro-NK\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 15:24:27 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21404)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dswDv-0000qr-G8\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 15:24:23 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1505503446879997.4711386092374;\n\tFri, 15 Sep 2017 12:24:06 -0700 (PDT)"],"Resent-Date":"Fri, 15 Sep 2017 15:24:27 -0400","Resent-Message-Id":"","In-Reply-To":"<20170915190748.82389-1-jrtc27@jrtc27.com>","Message-ID":"<150550344628.36.3236693333533070993@69b6ddf88678>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"jrtc27@jrtc27.com","Date":"Fri, 15 Sep 2017 12:24:06 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v2] linux-user/syscall.c: Handle SH4's\n\texceptional alignment for p{read, write}64","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org, famz@redhat.com, richard.henderson@linaro.org, \n\tlaurent@vivier.eu, qemu-devel@nongnu.org,\n\tglaubitz@physik.fu-berlin.de, jrtc27@jrtc27.com, f4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]