[{"id":1769419,"web_url":"http://patchwork.ozlabs.org/comment/1769419/","msgid":"<20170915194803.GL4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-15T19:48:03","subject":"Re: [U-Boot] [PATCH V2] test/py: gpt: make use of infra-structure","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Sep 15, 2017 at 12:19:38PM -0600, Stephen Warren wrote:\n\n> From: Stephen Warren \n> \n> Make various changes to the GPT test:\n> \n> 1) Reference the disk image using an absolute path in all cases. This\n> allows test/py to operate correctly if it's run from a directory other\n> than the root of the U-Boot source tree.\n> \n> 2) Store the disk image in the teswt/py persistent data directory. This\n> removes the need to re-generate it every time the tests are run.\n> \n> 3) Execute sgdisk using u_boot_utils.run_and_log() so that its output is\n> captured in the test log. This allows debugging any problems running it.\n> \n> 4) Make the disk image a test fixture. This removes the requirement to\n> always run all GPT tests, and run them in order. The current code doesn't\n> create the disk image if e.g. just test_gpt_uuid() is executed via the\n> test.py -k command-line option.\n> \n> 5) Use @pytest.mark.buildconfigspec for all feature dependencies, rather\n> than manually implementing some of them.\n> \n> 6) Make all tests depend on sandbox, since they use the sandbox-specific\n> host command.\n> \n> Fixes: a2f422555fc8 (\"add pytests for 'gpt guid' command in sandbox\")\n> Fixes: c5772188ede9 (\"add pytests for 'gpt rename' and 'gpt swap'\")\n> Signed-off-by: Stephen Warren \n\nTested-by: Tom Rini ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"U8dxNIy8\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv5nT5nM7z9s7c\n\tfor ;\n\tSat, 16 Sep 2017 05:58:53 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 109B2C226DA; Fri, 15 Sep 2017 19:52:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EAD94C222F6;\n\tFri, 15 Sep 2017 19:52:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 21D84C221DC; Fri, 15 Sep 2017 19:48:08 +0000 (UTC)","from mail-yw0-f170.google.com (mail-yw0-f170.google.com\n\t[209.85.161.170])\n\tby lists.denx.de (Postfix) with ESMTPS id 9A35EC22458\n\tfor ; Fri, 15 Sep 2017 19:48:07 +0000 (UTC)","by mail-yw0-f170.google.com with SMTP id w9so2052278ywi.11\n\tfor ; Fri, 15 Sep 2017 12:48:07 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\ti64sm592224ywi.73.2017.09.15.12.48.05\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 12:48:05 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=bteUXkQ4JvuNMOJmWglXUaNyoprLS6d78b9GQ26AgXI=;\n\tb=U8dxNIy8TLUGihjZeOeWYFCaapdgDc//jeYA37IvT7QtdOemjt1o8jryhevRnojhXa\n\txVE++++dw0DqyKzmuzcKA8xIFnAadeUJXNK6vK7vXvB0LOP1rA9+1yP1QQIZhztOCPTA\n\tE7xHyKe6eyvzwiYL41UuZBK/FT4XtKJGzekKo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=bteUXkQ4JvuNMOJmWglXUaNyoprLS6d78b9GQ26AgXI=;\n\tb=M3IMKAyYYBNW46vL0CYYb6iBRSQrlGSvxHFDus/OFRyaPj+cgFgYe1p60jMcsa74MQ\n\tk/fRMe4Bnw2sm8rnDcXnYe2VIe7Wr8mvsJOF7bVEYtjsaEslk0uQg5/r8TCay8TMUkgu\n\tArYVPapifeCA8zGkxnKzbqN1oRw3bb57a2H9OzK3XGPwufb1+tz+vTF0hXlU0hgeIkJn\n\tc3nilyOCmFc25uaInZhb+ft9iF04v49B9NE7ZJrDr9HwIHLpWG2VUt8zL9L2Xo0mKUbI\n\taoXk07KzfatwgDzryI9AH/8mW33URrhEfWNRvK0kubAyaoRhmntOXgeNsl6F42fYiiGT\n\t6hKw==","X-Gm-Message-State":"AHPjjUiDo3eSJdgDAYhYsKNjW2FY9s3d+ctPmwBmf/Ro4S3mGhf8IEpS\n\tem0CQn4KP/OAyE1M","X-Google-Smtp-Source":"ADKCNb4dEo38NQ0jsw3rD5zwK7ewF8pJfJZgjeRff0RfRMmmYMwRR2G9Q/74pb08CqNWWJdusOaNwA==","X-Received":"by 10.129.112.134 with SMTP id\n\tl128mr21794986ywc.220.1505504886437; \n\tFri, 15 Sep 2017 12:48:06 -0700 (PDT)","Date":"Fri, 15 Sep 2017 15:48:03 -0400","From":"Tom Rini ","To":"Stephen Warren ","Message-ID":"<20170915194803.GL4560@bill-the-cat>","References":"<20170915181938.18122-1-swarren@wwwdotorg.org>","MIME-Version":"1.0","In-Reply-To":"<20170915181938.18122-1-swarren@wwwdotorg.org>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Alison Chaiken , u-boot@lists.denx.de,\n\tStephen Warren ","Subject":"Re: [U-Boot] [PATCH V2] test/py: gpt: make use of infra-structure","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1733643220988239607==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1773644,"web_url":"http://patchwork.ozlabs.org/comment/1773644/","msgid":"<20170922141857.GG30205@bill-the-cat>","list_archive_url":null,"date":"2017-09-22T14:18:57","subject":"Re: [U-Boot] [U-Boot,V2] test/py: gpt: make use of infra-structure","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Sep 15, 2017 at 12:19:38PM -0600, Stephen Warren wrote:\n\n> From: Stephen Warren \n> \n> Make various changes to the GPT test:\n> \n> 1) Reference the disk image using an absolute path in all cases. This\n> allows test/py to operate correctly if it's run from a directory other\n> than the root of the U-Boot source tree.\n> \n> 2) Store the disk image in the teswt/py persistent data directory. This\n> removes the need to re-generate it every time the tests are run.\n> \n> 3) Execute sgdisk using u_boot_utils.run_and_log() so that its output is\n> captured in the test log. This allows debugging any problems running it.\n> \n> 4) Make the disk image a test fixture. This removes the requirement to\n> always run all GPT tests, and run them in order. The current code doesn't\n> create the disk image if e.g. just test_gpt_uuid() is executed via the\n> test.py -k command-line option.\n> \n> 5) Use @pytest.mark.buildconfigspec for all feature dependencies, rather\n> than manually implementing some of them.\n> \n> 6) Make all tests depend on sandbox, since they use the sandbox-specific\n> host command.\n> \n> Fixes: a2f422555fc8 (\"add pytests for 'gpt guid' command in sandbox\")\n> Fixes: c5772188ede9 (\"add pytests for 'gpt rename' and 'gpt swap'\")\n> Signed-off-by: Stephen Warren \n> Tested-by: Tom Rini \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"IdbeXugd\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzG291WMKz9t16\n\tfor ;\n\tSat, 23 Sep 2017 00:24:17 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 03665C220B3; Fri, 22 Sep 2017 14:21:15 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 41E5BC22077;\n\tFri, 22 Sep 2017 14:21:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 06538C22088; Fri, 22 Sep 2017 14:19:04 +0000 (UTC)","from mail-yw0-f178.google.com (mail-yw0-f178.google.com\n\t[209.85.161.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 826D3C22095\n\tfor ; Fri, 22 Sep 2017 14:18:58 +0000 (UTC)","by mail-yw0-f178.google.com with SMTP id q80so838334ywg.2\n\tfor ; Fri, 22 Sep 2017 07:18:58 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:5d8f:7fe1:3da9:ee9d])\n\tby smtp.gmail.com with ESMTPSA id\n\tr29sm1623717ywa.46.2017.09.22.07.18.56\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 22 Sep 2017 07:18:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=XIhm4/rwo/+DCkw37peL8hriqv/Wo/SH/1mENldDBws=;\n\tb=IdbeXugdRC2RlnJ6Lwp7S6Asr77EYULgPiWRGXR22vKHDZS+6kUZIh2XZkEWLpazR4\n\tBgwXrWmBMCsag4Io8zJretKt02NXwTfaPlTlvXpbhAenFwc3KEQBD07xpyGpIDq0t4HP\n\tbsytKnxxCXqFwQsv14SSOmA/uspMxSNrbX41k=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=XIhm4/rwo/+DCkw37peL8hriqv/Wo/SH/1mENldDBws=;\n\tb=d9Le1HN1/32IG6RIRFc2dESE95+6XrWwEfupnR2iSVv7o4tUEAXah3dpAHvOY7/5JW\n\tOlJk8bgdNyYfYdNmVmoCg4e3+XIiQm07qu0MgJSRd3c/ZJsGCfS8n9+c1W/9GHQ1Q7kM\n\tDsgbNsH6yUgzWgBY+hDJO8YK40D+GmuR/rF9JTP3ySNb/EtOlM1dXHg1zCmJC4bvr/QQ\n\tsoX2WEixVfezUdTm8UInavf677YjxMRamNGJoyxjqeHWg7Fo4AL2TTBfbFZQN1TutuVV\n\tl7j3OO3Td4YFW3llu0yYWyfiP26BQzXYAZ8HL9hPtdxbLemXM1QCxHw+/uvbB5VHSgKS\n\tOMcw==","X-Gm-Message-State":"AHPjjUj3NF5gZAdxrxVZqR+vKYjKsQLmx2XAy6a2bGGv0LQUrZEpwUjU\n\t7q/4gHqwtFQ3tga0r6A9Oc/0Rg==","X-Google-Smtp-Source":"AOwi7QAgt1whsCNy7ADbhG7U0KHkQJCv1FA2RRhUve3uCKfCFQ+LPjYNlaKDR74HIPT+LvAo3IEoCw==","X-Received":"by 10.129.155.206 with SMTP id\n\ts197mr3984320ywg.363.1506089937346; \n\tFri, 22 Sep 2017 07:18:57 -0700 (PDT)","Date":"Fri, 22 Sep 2017 10:18:57 -0400","From":"Tom Rini ","To":"Stephen Warren ","Message-ID":"<20170922141857.GG30205@bill-the-cat>","References":"<20170915181938.18122-1-swarren@wwwdotorg.org>","MIME-Version":"1.0","In-Reply-To":"<20170915181938.18122-1-swarren@wwwdotorg.org>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Alison Chaiken , u-boot@lists.denx.de,\n\tStephen Warren ","Subject":"Re: [U-Boot] [U-Boot,V2] test/py: gpt: make use of infra-structure","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1517263485988270959==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]