[{"id":1769340,"web_url":"http://patchwork.ozlabs.org/comment/1769340/","msgid":"<20170915175455.GK4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-15T17:54:55","subject":"Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Sep 15, 2017 at 11:25:51AM -0600, Stephen Warren wrote:\n\n> From: Stephen Warren <swarren@nvidia.com>\n> \n> Make various changes to the GPT test:\n> \n> 1) Reference the disk image using an absolute path in all cases. This\n> allows test/py to operate correctly if it's run from a directory other\n> than the root of the U-Boot source tree.\n> \n> 2) Store the disk image in the teswt/py persistent data directory. This\n> removes the need to re-generate it every time the tests are run.\n> \n> 3) Execute sgdisk using u_boot_utils.run_and_log() so that its output is\n> captured in the test log. This allows debugging any problems running it.\n> \n> 4) Make the disk image a test fixture. This removes the requirement to\n> always run all GPT tests, and run them in order. The current code doesn't\n> create the disk image if e.g. just test_gpt_uuid() is executed via the\n> test.py -k command-line option.\n> \n> 5) Use @pytest.mark.buildconfigspec for all feature dependencies, rather\n> than manually implementing some of them.\n> \n> Fixes: a2f422555fc8 (\"add pytests for 'gpt guid' command in sandbox\")\n> Fixes: c5772188ede9 (\"add pytests for 'gpt rename' and 'gpt swap'\")\n> Signed-off-by: Stephen Warren <swarren@nvidia.com>\n\nHaving kicked my jenkins (sigh), and then really tried to run these\ntests on hardware, I think we're not quite done:\n\n>  @pytest.mark.buildconfigspec('cmd_gpt')\n> -def test_gpt_guid(u_boot_console):\n> +def test_gpt_guid(state_disk_image, u_boot_console):\n>      \"\"\"Test the gpt guid command.\"\"\"\n>  \n> -    if u_boot_console.config.buildconfig.get('config_cmd_gpt', 'n') != 'y':\n> -        pytest.skip('gpt command not supported')\n> -    make_test_disk.makeDisk()\n> -    u_boot_console.run_command('host bind 0 testdisk.raw')\n> +    u_boot_console.run_command('host bind 0 ' + state_disk_image.path)\n\nHere and elsewhere we also need to say it depends on sandbox as that's\nwhat gives the host command.  Thanks!","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"WFSbZu8s\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv32g10MBz9s82\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 16 Sep 2017 03:55:05 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A1E4EC21D90; Fri, 15 Sep 2017 17:55:02 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E51C6C21C72;\n\tFri, 15 Sep 2017 17:54:59 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5D321C21C72; Fri, 15 Sep 2017 17:54:59 +0000 (UTC)","from mail-yw0-f169.google.com (mail-yw0-f169.google.com\n\t[209.85.161.169])\n\tby lists.denx.de (Postfix) with ESMTPS id D7362C21C3C\n\tfor <u-boot@lists.denx.de>; Fri, 15 Sep 2017 17:54:58 +0000 (UTC)","by mail-yw0-f169.google.com with SMTP id o143so1883650ywd.12\n\tfor <u-boot@lists.denx.de>; Fri, 15 Sep 2017 10:54:58 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tq31sm525536ywa.25.2017.09.15.10.54.56\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 10:54:56 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=MfISCGUNtyvNeaBYMVGsx+arXIvOjfbJMF7b3d4bEQA=;\n\tb=WFSbZu8srqiABICwA6HgLFOs+qGgoDytwAs7r1OimsPh+4CrDeAYQqvDXKzKR9hqWw\n\tECLRJlSCo9kaBFMM0qF8RgUjgG3oc9dFhjBAxr0MZ4dt1XvqZGLootk7S6sBiYpnl1vD\n\t09AHkQQXJoE6sSLtx3fTvEGu7Qa5vRsEKBwhM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=MfISCGUNtyvNeaBYMVGsx+arXIvOjfbJMF7b3d4bEQA=;\n\tb=bur0DyHcxQbIoGjNChoaQGqL0RZQLitTmzMnDvZkGQwLbfT9VjB4xi+PnmU3RMYbc/\n\tqXMC8IlkqZBET3ApBskbLXyqOOvW0yzItNRPntBXEGYeILfoGjD1hFvuhby5aqON8O0d\n\tf4O6JeyA+Ljy/SbtfwDHCMQR9Ags1H6r6oG/swA8yFV+JhNTydEpINneYqNkP4Kx0Ck7\n\tASLfaqY3SfUxsCz2KaB7PWcsd7sS5uyJUGMeVXFmY1moo3Bo+SBmnMOXaNbKBFGzY84W\n\teTbMcxQUfww5/F6EEBhR8ikSUz4B+fkpPtPBQIXN3SyF20135vaTT3kaG+sBV1JusiSK\n\tZg9Q==","X-Gm-Message-State":"AHPjjUiiAAmHWR5ZPsp4T1448LXXbH8EyzW2VQhEkh8Vx/TmX7Qu2GzX\n\tuQqAG0DNrv5Sq1WW","X-Google-Smtp-Source":"ADKCNb4L3H0CV65cicj6IKK4cdOAt7IhPpR2LG+kTrxjLmx5AJg8WEEzknskhDHX5vFvETULAOb+aw==","X-Received":"by 10.129.90.214 with SMTP id\n\to205mr21925543ywb.362.1505498097473; \n\tFri, 15 Sep 2017 10:54:57 -0700 (PDT)","Date":"Fri, 15 Sep 2017 13:54:55 -0400","From":"Tom Rini <trini@konsulko.com>","To":"Stephen Warren <swarren@wwwdotorg.org>","Message-ID":"<20170915175455.GK4560@bill-the-cat>","References":"<20170915172551.26500-1-swarren@wwwdotorg.org>","MIME-Version":"1.0","In-Reply-To":"<20170915172551.26500-1-swarren@wwwdotorg.org>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Alison Chaiken <alison@peloton-tech.com>, u-boot@lists.denx.de,\n\tStephen Warren <swarren@nvidia.com>","Subject":"Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============1885737283095549034==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1769663,"web_url":"http://patchwork.ozlabs.org/comment/1769663/","msgid":"<CAOuSAjf+49TRLh81egshZRg_1EzHGBrdH2mdGZ9P1wZWUwERsg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-17T02:47:51","subject":"Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure","submitter":{"id":69170,"url":"http://patchwork.ozlabs.org/api/people/69170/","name":"Alison Chaiken","email":"alison@peloton-tech.com"},"content":"I suggest that while we're cleaning this test up, that we add\nsomething like this to each of the tests:\n\ndiff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py\nindex e2bbd08e6d..485d092371 100644\n--- a/test/py/tests/test_gpt.py\n+++ b/test/py/tests/test_gpt.py\n@@ -67,6 +67,8 @@ def state_disk_image(u_boot_console):\ndef test_gpt_guid(state_disk_image, u_boot_console):\n    \"\"\"Test the gpt guid command.\"\"\"\n\n+    if not os.path.exists('/sbin/sgdisk'):\n+        pytest.skip('install gdisk package to test gpt commands')\n\n\nOtherwise, the tests will all fail if the gdisk package is not\ninstalled.   Assuredly anyone who does not have gdisk installed does\nnot care about these tests anyway.   If people agree, I can submit a\npatch, or perhaps Stephen could just add it to his.\n\nBest wishes,\nAlison Chaiken\nPeloton Technology\n\nOn Fri, Sep 15, 2017 at 10:54 AM, Tom Rini <trini@konsulko.com> wrote:\n>\n> On Fri, Sep 15, 2017 at 11:25:51AM -0600, Stephen Warren wrote:\n>\n> > From: Stephen Warren <swarren@nvidia.com>\n> >\n> > Make various changes to the GPT test:\n> >\n> > 1) Reference the disk image using an absolute path in all cases. This\n> > allows test/py to operate correctly if it's run from a directory other\n> > than the root of the U-Boot source tree.\n> >\n> > 2) Store the disk image in the teswt/py persistent data directory. This\n> > removes the need to re-generate it every time the tests are run.\n> >\n> > 3) Execute sgdisk using u_boot_utils.run_and_log() so that its output is\n> > captured in the test log. This allows debugging any problems running it.\n> >\n> > 4) Make the disk image a test fixture. This removes the requirement to\n> > always run all GPT tests, and run them in order. The current code doesn't\n> > create the disk image if e.g. just test_gpt_uuid() is executed via the\n> > test.py -k command-line option.\n> >\n> > 5) Use @pytest.mark.buildconfigspec for all feature dependencies, rather\n> > than manually implementing some of them.\n> >\n> > Fixes: a2f422555fc8 (\"add pytests for 'gpt guid' command in sandbox\")\n> > Fixes: c5772188ede9 (\"add pytests for 'gpt rename' and 'gpt swap'\")\n> > Signed-off-by: Stephen Warren <swarren@nvidia.com>\n>\n> Having kicked my jenkins (sigh), and then really tried to run these\n> tests on hardware, I think we're not quite done:\n>\n> >  @pytest.mark.buildconfigspec('cmd_gpt')\n> > -def test_gpt_guid(u_boot_console):\n> > +def test_gpt_guid(state_disk_image, u_boot_console):\n> >      \"\"\"Test the gpt guid command.\"\"\"\n> >\n> > -    if u_boot_console.config.buildconfig.get('config_cmd_gpt', 'n') != 'y':\n> > -        pytest.skip('gpt command not supported')\n> > -    make_test_disk.makeDisk()\n> > -    u_boot_console.run_command('host bind 0 testdisk.raw')\n> > +    u_boot_console.run_command('host bind 0 ' + state_disk_image.path)\n>\n> Here and elsewhere we also need to say it depends on sandbox as that's\n> what gives the host command.  Thanks!\n>\n> --\n> Tom","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=peloton-tech-com.20150623.gappssmtp.com\n\theader.i=@peloton-tech-com.20150623.gappssmtp.com\n\theader.b=\"xS5Ieo84\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvtqD4Tf1z9s7v\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 12:48:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4B2C2C21E21; Sun, 17 Sep 2017 02:47:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 63E51C21D19;\n\tSun, 17 Sep 2017 02:47:56 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BF884C21D19; Sun, 17 Sep 2017 02:47:54 +0000 (UTC)","from mail-pg0-f48.google.com (mail-pg0-f48.google.com\n\t[74.125.83.48])\n\tby lists.denx.de (Postfix) with ESMTPS id E6067C21C62\n\tfor <u-boot@lists.denx.de>; Sun, 17 Sep 2017 02:47:53 +0000 (UTC)","by mail-pg0-f48.google.com with SMTP id i130so3383613pgc.3\n\tfor <u-boot@lists.denx.de>; Sat, 16 Sep 2017 19:47:53 -0700 (PDT)","by 10.100.166.205 with HTTP; Sat, 16 Sep 2017 19:47:51 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=peloton-tech-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=unc/SxDga0/ert1dx8fzpHwuqOGKTOi9NLMDva34YlQ=;\n\tb=xS5Ieo84+e+g/x8czLX1qf8NtPxkoDE/cO3AL1Run+Dhe/aDpIYQVP4zdGwWX5Dr3K\n\tyDjK6xQ0u6//o7VrmOfiSBiAcXNvNxZDkBxKOSMhDJQUajb2AjEfnPxY82PbbFUGfouy\n\t9r2gSzwrMUn92QEfQZxLIHgEqGB28OWFRjSjYi0s8H6Xnr56bnHl1UrBupkTk14hfWxW\n\t+1V4DzLjjjkJF4Ssk9GP4hjs/8bFt8lP+NVvcSmITNQKddHxwwnFpcaZvCeyqJpV62El\n\tJv+3zO30tesIr+uty33j39BpcJc7bH5tyqNuMZLNNX+pTrrF/VaMceLZI45A48luTeaO\n\tKanA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=unc/SxDga0/ert1dx8fzpHwuqOGKTOi9NLMDva34YlQ=;\n\tb=ne/klthL0y6ZnhFo/rxEl4kJuV1HdsvPUS28g9fjquootQy6skcBD8q15lKDPTQ5OK\n\tXC18upHNMNq9sltcahryY+d2JU5/kzci6OuA0qEcH/VlISLbCd7iH5ezeaKo/39AiLrk\n\tMPsUQB+O/5haeOlmyqoEHP1Hyo3wtDcrOO8d3NgTCcC5Ljvxz5qiZ9DWo+bFb7ShkLtp\n\tosqtaoLzSa0uXqprnsVhY+i1N9U+1iLwq8RNcCNNr6VGUTUna5Dgf/5tgj83koHol3BH\n\tP9pCdu5aF/OxZ6ZbHaM+RIf/WFKIGR/rvlFKFFeywZrumnWO0x/CHzxoLOISJC30pZwT\n\t6Lrg==","X-Gm-Message-State":"AHPjjUic0ACIZxPB0TAHwQK/CMCD/Zl/a8LGLmL8rJKSTj4/mpC8xO4n\n\tc/fbrzsm4v4b8RvyrCP/V47EyD7HCAmAtSCWV0BAFvxEEWU=","X-Google-Smtp-Source":"ADKCNb4pBrbAZLfUxnthJmMJb4aIOMIl2DwJtNFv6TImPH86prLHubD24VaVTZwFbvYJ/ZOEFT7VhETT1D5/ZfAZSBM=","X-Received":"by 10.84.224.206 with SMTP id k14mr33002457pln.317.1505616472130;\n\tSat, 16 Sep 2017 19:47:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170915175455.GK4560@bill-the-cat>","References":"<20170915172551.26500-1-swarren@wwwdotorg.org>\n\t<20170915175455.GK4560@bill-the-cat>","From":"Alison Chaiken <alison@peloton-tech.com>","Date":"Sat, 16 Sep 2017 19:47:51 -0700","Message-ID":"<CAOuSAjf+49TRLh81egshZRg_1EzHGBrdH2mdGZ9P1wZWUwERsg@mail.gmail.com>","To":"Tom Rini <trini@konsulko.com>","Cc":"u-boot@lists.denx.de, Stephen Warren <swarren@nvidia.com>","Subject":"Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1770250,"web_url":"http://patchwork.ozlabs.org/comment/1770250/","msgid":"<c608d599-1506-e026-f70d-f845bb657383@wwwdotorg.org>","list_archive_url":null,"date":"2017-09-18T15:23:40","subject":"Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure","submitter":{"id":12517,"url":"http://patchwork.ozlabs.org/api/people/12517/","name":"Stephen Warren","email":"swarren@wwwdotorg.org"},"content":"On 09/16/2017 08:47 PM, Alison Chaiken wrote:\n> I suggest that while we're cleaning this test up, that we add\n> something like this to each of the tests:\n> \n> diff --git a/test/py/tests/test_gpt.py b/test/py/tests/test_gpt.py\n\n> +    if not os.path.exists('/sbin/sgdisk'):\n> +        pytest.skip('install gdisk package to test gpt commands')\n\nI'd suggest doing that in a separate commit; my patch below already does \nenough things that it should probably be a series of smaller patches, \nand the change above probably applies to other tests as well.\n\n> \n> Otherwise, the tests will all fail if the gdisk package is not\n> installed.   Assuredly anyone who does not have gdisk installed does\n> not care about these tests anyway.   If people agree, I can submit a\n> patch, or perhaps Stephen could just add it to his.\n> \n> Best wishes,\n> Alison Chaiken\n> Peloton Technology\n> \n> On Fri, Sep 15, 2017 at 10:54 AM, Tom Rini <trini@konsulko.com> wrote:\n>>\n>> On Fri, Sep 15, 2017 at 11:25:51AM -0600, Stephen Warren wrote:\n>>\n>>> From: Stephen Warren <swarren@nvidia.com>\n>>>\n>>> Make various changes to the GPT test:\n>>>\n>>> 1) Reference the disk image using an absolute path in all cases. This\n>>> allows test/py to operate correctly if it's run from a directory other\n>>> than the root of the U-Boot source tree.\n>>>\n>>> 2) Store the disk image in the teswt/py persistent data directory. This\n>>> removes the need to re-generate it every time the tests are run.\n>>>\n>>> 3) Execute sgdisk using u_boot_utils.run_and_log() so that its output is\n>>> captured in the test log. This allows debugging any problems running it.\n>>>\n>>> 4) Make the disk image a test fixture. This removes the requirement to\n>>> always run all GPT tests, and run them in order. The current code doesn't\n>>> create the disk image if e.g. just test_gpt_uuid() is executed via the\n>>> test.py -k command-line option.\n>>>\n>>> 5) Use @pytest.mark.buildconfigspec for all feature dependencies, rather\n>>> than manually implementing some of them.\n>>>\n>>> Fixes: a2f422555fc8 (\"add pytests for 'gpt guid' command in sandbox\")\n>>> Fixes: c5772188ede9 (\"add pytests for 'gpt rename' and 'gpt swap'\")\n>>> Signed-off-by: Stephen Warren <swarren@nvidia.com>\n>>\n>> Having kicked my jenkins (sigh), and then really tried to run these\n>> tests on hardware, I think we're not quite done:\n>>\n>>>   @pytest.mark.buildconfigspec('cmd_gpt')\n>>> -def test_gpt_guid(u_boot_console):\n>>> +def test_gpt_guid(state_disk_image, u_boot_console):\n>>>       \"\"\"Test the gpt guid command.\"\"\"\n>>>\n>>> -    if u_boot_console.config.buildconfig.get('config_cmd_gpt', 'n') != 'y':\n>>> -        pytest.skip('gpt command not supported')\n>>> -    make_test_disk.makeDisk()\n>>> -    u_boot_console.run_command('host bind 0 testdisk.raw')\n>>> +    u_boot_console.run_command('host bind 0 ' + state_disk_image.path)\n>>\n>> Here and elsewhere we also need to say it depends on sandbox as that's\n>> what gives the host command.  Thanks!\n>>\n>> --\n>> Tom\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwqXz5Vbtz9s78\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 01:24:03 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7379FC21F1C; Mon, 18 Sep 2017 15:23:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DD6A6C21DC8;\n\tMon, 18 Sep 2017 15:23:55 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0ECFFC21DC8; Mon, 18 Sep 2017 15:23:53 +0000 (UTC)","from avon.wwwdotorg.org (avon.wwwdotorg.org [104.237.132.123])\n\tby lists.denx.de (Postfix) with ESMTPS id 5F4D1C21C4C\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 15:23:53 +0000 (UTC)","from [10.20.204.51] (unknown [216.228.112.22])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby avon.wwwdotorg.org (Postfix) with ESMTPSA id C45081C02E3;\n\tMon, 18 Sep 2017 09:23:51 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","X-Virus-Status":"Clean","X-Virus-Scanned":"clamav-milter 0.99.2 at avon.wwwdotorg.org","To":"Alison Chaiken <alison@peloton-tech.com>, Tom Rini <trini@konsulko.com>","References":"<20170915172551.26500-1-swarren@wwwdotorg.org>\n\t<20170915175455.GK4560@bill-the-cat>\n\t<CAOuSAjf+49TRLh81egshZRg_1EzHGBrdH2mdGZ9P1wZWUwERsg@mail.gmail.com>","From":"Stephen Warren <swarren@wwwdotorg.org>","Message-ID":"<c608d599-1506-e026-f70d-f845bb657383@wwwdotorg.org>","Date":"Mon, 18 Sep 2017 09:23:40 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<CAOuSAjf+49TRLh81egshZRg_1EzHGBrdH2mdGZ9P1wZWUwERsg@mail.gmail.com>","Content-Language":"en-GB","Cc":"u-boot@lists.denx.de, Stephen Warren <swarren@nvidia.com>","Subject":"Re: [U-Boot] [PATCH] test/py: gpt: make use of infra-structure","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]