[{"id":1769454,"web_url":"http://patchwork.ozlabs.org/comment/1769454/","msgid":"<20170915211918.GL8421@gate.crashing.org>","list_archive_url":null,"date":"2017-09-15T21:19:18","subject":"Re: [PATCH, rs6000] [v3] Folding of vector loads in GIMPLE","submitter":{"id":134,"url":"http://patchwork.ozlabs.org/api/people/134/","name":"Segher Boessenkool","email":"segher@kernel.crashing.org"},"content":"Hi Will,\n\nOn Fri, Sep 15, 2017 at 09:59:54AM -0500, Will Schmidt wrote:\n> + /* Vector loads. */\n> + case ALTIVEC_BUILTIN_LVX_V16QI:\n> + case ALTIVEC_BUILTIN_LVX_V8HI:\n> + case ALTIVEC_BUILTIN_LVX_V4SI:\n> + case ALTIVEC_BUILTIN_LVX_V4SF:\n> + case ALTIVEC_BUILTIN_LVX_V2DI:\n> + case ALTIVEC_BUILTIN_LVX_V2DF:\n> + {\n> +\t gimple *g;\n\nThis is only used much later (and for a short time only), so just declare\nit there?\n\nOther than that nit, looks fine to me. Okay for trunk. Thanks!\n\n\nSegher","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462300-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"pI3oZH+L\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv7ZZ5Y3rz9ryQ\n\tfor ;\n\tSat, 16 Sep 2017 07:19:32 +1000 (AEST)","(qmail 23164 invoked by alias); 15 Sep 2017 21:19:25 -0000","(qmail 23098 invoked by uid 89); 15 Sep 2017 21:19:24 -0000","from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by\n\tsourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 15 Sep 2017 21:19:22 +0000","from gate.crashing.org (localhost.localdomain [127.0.0.1])\tby\n\tgate.crashing.org (8.14.1/8.13.8) with ESMTP id\n\tv8FLJJSi021383; Fri, 15 Sep 2017 16:19:19 -0500","(from segher@localhost)\tby gate.crashing.org\n\t(8.14.1/8.14.1/Submit) id v8FLJI4A021382;\n\tFri, 15 Sep 2017 16:19:18 -0500"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; q=dns; s=default; b=orptMd6+G3sSI82i/\n\tAcpOS0R1nv8pUfY9/nVUgQ7iIwP/pLyoKhcqu+pVz+Ap7GzB0p8QXGV8PujrIyzt\n\tb7BbW95ar7hOsXRQMPkoYYsKsA/MAdcWaP/N7FS+7VM+0M5vZ+7gjxFUMYNtDQQJ\n\tpEOKWmKuyInPXyYwr5cIgmwGS4=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:date\n\t:from:to:cc:subject:message-id:references:mime-version\n\t:content-type:in-reply-to; s=default; bh=jhdz/GfNww+LKpN/Czsk4MZ\n\tTIVw=; b=pI3oZH+LQEQYWsPh2wMgIuugoYUXD+EXFUDPAZj+Kf9AMUmZTtiWf9N\n\tJLIpW8x8CiVab5dIzs9Go3wZnlR6IUuqz55YnoEDILAWp3DSzm8cl76fdeW5RjtK\n\tsq/t+2aznLV+pDvhyz2Pt44z1PGLTqXh4LWT8UJH6sBAUL0cxuno=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.1 required=5.0 tests=AWL, BAYES_00,\n\tRP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=","X-HELO":"gate.crashing.org","Date":"Fri, 15 Sep 2017 16:19:18 -0500","From":"Segher Boessenkool ","To":"Will Schmidt ","Cc":"Bill Schmidt ,\n\tRichard Biener ,\n\tGCC Patches , David Edelsohn ","Subject":"Re: [PATCH, rs6000] [v3] Folding of vector loads in GIMPLE","Message-ID":"<20170915211918.GL8421@gate.crashing.org>","References":"<1505227262.14827.155.camel@brimstone.rchland.ibm.com>\n\t<1505250505.14827.191.camel@brimstone.rchland.ibm.com>\n\t\n\t<24A6439E-6268-44F8-92CE-EF0F22DA5773@linux.vnet.ibm.com>\n\t\n\t\n\t<73D3C195-E029-4050-9764-57C07845DBEB@linux.vnet.ibm.com>\n\t\n\t<0B9CF26C-8F9E-4C4E-8F42-50B99DA3D7B8@linux.vnet.ibm.com>\n\t<1505487594.26707.25.camel@brimstone.rchland.ibm.com>","Mime-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505487594.26707.25.camel@brimstone.rchland.ibm.com>","User-Agent":"Mutt/1.4.2.3i","X-IsSubscribed":"yes"}}]