[{"id":1770048,"web_url":"http://patchwork.ozlabs.org/comment/1770048/","msgid":"<20170918120536.6186c7fe.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-18T10:05:36","subject":"Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu\n\tdevice for the ccw bus","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 15 Sep 2017 10:40:32 -0400\nFarhan Ali wrote:\n\n> Wire up the virtio-gpu device for the CCW bus. The virtio-gpu\n> is a virtio-1 device, so disable revision 0.\n> \n> Signed-off-by: Farhan Ali \n> Acked-by: Christian Borntraeger \n> Reviewed-by: Halil Pasic \n> Reviewed-by: Thomas Huth \n> ---\n> hw/s390x/virtio-ccw.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++\n> hw/s390x/virtio-ccw.h | 10 ++++++++++\n> 2 files changed, 59 insertions(+)\n> \n> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c\n> index b1976fd..12cacf6 100644\n> --- a/hw/s390x/virtio-ccw.c\n> +++ b/hw/s390x/virtio-ccw.c\n\n> @@ -1815,6 +1863,7 @@ static void virtio_ccw_register(void)\n> type_register_static(&vhost_vsock_ccw_info);\n> #endif\n> type_register_static(&virtio_ccw_crypto);\n> + type_register_static(&virtio_ccw_gpu);\n\nNot a critique of this patch, just an observation: For virtio-ccw, we\ntend to collect the various virtio devices all in the same file. For\nvirtio-pci, they sometimes get separate files. Not sure which is\nbetter, but it means that sometimes only the virtio-pci version is\nadded...\n\n> }\n> \n> type_init(virtio_ccw_register)\n\nThe patch looks good to me.\n\nGerd, if the first patch looks good to you, I can take both patches\nthrough the s390 tree. If you prefer to merge the patches yourself,\nthat's fine with me as well.\n\nReviewed-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwhVF1M97z9s7c\n\tfor ;\n\tMon, 18 Sep 2017 20:06:11 +1000 (AEST)","from localhost ([::1]:35538 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtswJ-000834-Se\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:06:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38417)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtsw0-00082u-8F\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:05:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtsvw-00076U-IJ\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:05:47 -0400","from mx1.redhat.com ([209.132.183.28]:41558)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtsvw-00075m-2h\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:05:44 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 029BC80469;\n\tMon, 18 Sep 2017 10:05:43 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 05C515C541;\n\tMon, 18 Sep 2017 10:05:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 029BC80469","Date":"Mon, 18 Sep 2017 12:05:36 +0200","From":"Cornelia Huck ","To":"Farhan Ali , kraxel@redhat.com","Message-ID":"<20170918120536.6186c7fe.cohuck@redhat.com>","In-Reply-To":"<6c53f939cf2d64b66d2a6878b29c9bf3820f3d5b.1505485574.git.alifm@linux.vnet.ibm.com>","References":"\n\t<6c53f939cf2d64b66d2a6878b29c9bf3820f3d5b.1505485574.git.alifm@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 18 Sep 2017 10:05:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu\n\tdevice for the ccw bus","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770065,"web_url":"http://patchwork.ozlabs.org/comment/1770065/","msgid":"<1505730794.10119.9.camel@redhat.com>","list_archive_url":null,"date":"2017-09-18T10:33:14","subject":"Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu\n\tdevice for the ccw bus","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"Hi,\n\n> Gerd, if the first patch looks good to you, I can take both patches\n> through the s390 tree.\n\nYes, please. Just sent a reviewed-by for patch #1.\n\nthanks,\n Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwj7M0yJ2z9s7M\n\tfor ;\n\tMon, 18 Sep 2017 20:34:55 +1000 (AEST)","from localhost ([::1]:35675 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dttO9-0001ia-6W\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:34:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48371)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dttMe-0000uz-OE\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:33:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dttMa-0002oi-S1\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:33:20 -0400","from mx1.redhat.com ([209.132.183.28]:45316)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dttMa-0002oE-Kw\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:33:16 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B5C99883BA;\n\tMon, 18 Sep 2017 10:33:15 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-116-116.ams2.redhat.com\n\t[10.36.116.116])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 77FBC5C3FA;\n\tMon, 18 Sep 2017 10:33:15 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id BD05020488;\n\tMon, 18 Sep 2017 12:33:14 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B5C99883BA","Message-ID":"<1505730794.10119.9.camel@redhat.com>","From":"Gerd Hoffmann ","To":"Cornelia Huck , Farhan Ali ","Date":"Mon, 18 Sep 2017 12:33:14 +0200","In-Reply-To":"<20170918120536.6186c7fe.cohuck@redhat.com>","References":"\n\t<6c53f939cf2d64b66d2a6878b29c9bf3820f3d5b.1505485574.git.alifm@linux.vnet.ibm.com>\n\t<20170918120536.6186c7fe.cohuck@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 18 Sep 2017 10:33:15 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu\n\tdevice for the ccw bus","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]