[{"id":1770922,"web_url":"http://patchwork.ozlabs.org/comment/1770922/","msgid":"<8102551.bT9icskWgv@avalon>","list_archive_url":null,"date":"2017-09-19T12:12:42","subject":"Re: [PATCH v13 15/25] dt: bindings: Add a binding for flash LED\n\tdevices associated to a sensor","submitter":{"id":11034,"url":"http://patchwork.ozlabs.org/api/people/11034/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Sakari,\n\nThank you for the patch.\n\nOn Friday, 15 September 2017 17:17:14 EEST Sakari Ailus wrote:\n> Camera flash drivers (and LEDs) are separate from the sensor devices in\n> DT. In order to make an association between the two, provide the\n> association information to the software.\n> \n> Signed-off-by: Sakari Ailus \n> Acked-by: Rob Herring \n> Acked-by: Hans Verkuil \n> Acked-by: Pavel Machek \n> ---\n> Documentation/devicetree/bindings/media/video-interfaces.txt | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> b/Documentation/devicetree/bindings/media/video-interfaces.txt index\n> 852041a7480c..fdba30479b47 100644\n> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> @@ -67,6 +67,14 @@ are required in a relevant parent node:\n> \t\t identifier, should be 1.\n> - #size-cells : should be zero.\n> \n> +\n> +Optional properties\n> +-------------------\n> +\n> +- flash-leds: An array of phandles, each referring to a flash LED, a\n> sub-node\n> + of the LED driver device node.\n\nWhat happens with non-LED flash controllers ?\n\n> +\n> +\n> Optional endpoint properties\n> ----------------------------","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Tnwk1TrL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMFg6dhhz9s7c\n\tfor ;\n\tTue, 19 Sep 2017 22:12:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751547AbdISMMi (ORCPT\n\t);\n\tTue, 19 Sep 2017 08:12:38 -0400","from galahad.ideasonboard.com ([185.26.127.97]:38069 \"EHLO\n\tgalahad.ideasonboard.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751210AbdISMMi (ORCPT\n\t); Tue, 19 Sep 2017 08:12:38 -0400","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby galahad.ideasonboard.com (Postfix) with ESMTPSA id 4BF84200AD;\n\tTue, 19 Sep 2017 14:10:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1505823001;\n\tbh=xTwtW/P0QssaxgRxKD5taYfYkiW+sX6Dn9mOSZaTdfk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Tnwk1TrLj3FJ9C1eL6PzmDFledoX5nzbPMVujHuhdT+Zm8OyyES+qYSkkAQGD669D\n\tuNNEJo0MaabQFISccBYcDmtKh3f0OPAJ4GvPjgfvh0TGMECtDa8fZcRWvm1qk0081k\n\tNqIoFioAuoNH/eca7BOfUAJaE0yg5NSahFgnnSyE=","From":"Laurent Pinchart ","To":"Sakari Ailus ","Cc":"linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\tmaxime.ripard@free-electrons.com, robh@kernel.org,\n\thverkuil@xs4all.nl, devicetree@vger.kernel.org, pavel@ucw.cz,\n\tsre@kernel.org","Subject":"Re: [PATCH v13 15/25] dt: bindings: Add a binding for flash LED\n\tdevices associated to a sensor","Date":"Tue, 19 Sep 2017 15:12:42 +0300","Message-ID":"<8102551.bT9icskWgv@avalon>","In-Reply-To":"<20170915141724.23124-16-sakari.ailus@linux.intel.com>","References":"<20170915141724.23124-1-sakari.ailus@linux.intel.com>\n\t<20170915141724.23124-16-sakari.ailus@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770938,"web_url":"http://patchwork.ozlabs.org/comment/1770938/","msgid":"<20170919121638.znu2drbzzayxrbwz@paasikivi.fi.intel.com>","list_archive_url":null,"date":"2017-09-19T12:16:38","subject":"Re: [PATCH v13 15/25] dt: bindings: Add a binding for flash LED\n\tdevices associated to a sensor","submitter":{"id":65485,"url":"http://patchwork.ozlabs.org/api/people/65485/","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"content":"Hi Laurent,\n\nOn Tue, Sep 19, 2017 at 03:12:42PM +0300, Laurent Pinchart wrote:\n> Hi Sakari,\n> \n> Thank you for the patch.\n> \n> On Friday, 15 September 2017 17:17:14 EEST Sakari Ailus wrote:\n> > Camera flash drivers (and LEDs) are separate from the sensor devices in\n> > DT. In order to make an association between the two, provide the\n> > association information to the software.\n> > \n> > Signed-off-by: Sakari Ailus \n> > Acked-by: Rob Herring \n> > Acked-by: Hans Verkuil \n> > Acked-by: Pavel Machek \n> > ---\n> > Documentation/devicetree/bindings/media/video-interfaces.txt | 8 ++++++++\n> > 1 file changed, 8 insertions(+)\n> > \n> > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > b/Documentation/devicetree/bindings/media/video-interfaces.txt index\n> > 852041a7480c..fdba30479b47 100644\n> > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > @@ -67,6 +67,14 @@ are required in a relevant parent node:\n> > \t\t identifier, should be 1.\n> > - #size-cells : should be zero.\n> > \n> > +\n> > +Optional properties\n> > +-------------------\n> > +\n> > +- flash-leds: An array of phandles, each referring to a flash LED, a\n> > sub-node\n> > + of the LED driver device node.\n> \n> What happens with non-LED flash controllers ?\n\nWe don't have any at the moment.\n\nThe way the bindings are currently defined (LED references are to\nindividual LEDs for instance) are specific to LED bindings. I'd rather not\nmake assumptions for e.g. Xenon flash devices. Which might never appear:\nLED luminosity, efficiency and maximum current has been steadily increasing\nover the past years.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxMLy2mwXz9s7c\n\tfor ;\n\tTue, 19 Sep 2017 22:17:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751754AbdISMRM (ORCPT\n\t);\n\tTue, 19 Sep 2017 08:17:12 -0400","from mga11.intel.com ([192.55.52.93]:19355 \"EHLO mga11.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751747AbdISMRM (ORCPT );\n\tTue, 19 Sep 2017 08:17:12 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t19 Sep 2017 05:17:12 -0700","from paasikivi.fi.intel.com ([10.237.72.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 19 Sep 2017 05:17:09 -0700","by paasikivi.fi.intel.com (Postfix, from userid 1000)\n\tid C352520642; Tue, 19 Sep 2017 15:16:38 +0300 (EEST)"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,418,1500966000\"; d=\"scan'208\";a=\"901811110\"","Date":"Tue, 19 Sep 2017 15:16:38 +0300","From":"Sakari Ailus ","To":"Laurent Pinchart ","Cc":"linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se,\n\tmaxime.ripard@free-electrons.com, robh@kernel.org,\n\thverkuil@xs4all.nl, devicetree@vger.kernel.org, pavel@ucw.cz,\n\tsre@kernel.org","Subject":"Re: [PATCH v13 15/25] dt: bindings: Add a binding for flash LED\n\tdevices associated to a sensor","Message-ID":"<20170919121638.znu2drbzzayxrbwz@paasikivi.fi.intel.com>","References":"<20170915141724.23124-1-sakari.ailus@linux.intel.com>\n\t<20170915141724.23124-16-sakari.ailus@linux.intel.com>\n\t<8102551.bT9icskWgv@avalon>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<8102551.bT9icskWgv@avalon>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]