[{"id":1770788,"web_url":"http://patchwork.ozlabs.org/comment/1770788/","msgid":"<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","list_archive_url":null,"date":"2017-09-19T09:29:12","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 15/09/2017 at 16:04, Romain Izard wrote:\n> The controller used by a flexcom module is configured at boot, and left\n> alone after this. As the configuration will be lost after backup mode,\n> restore the state of the flexcom driver on resume.\n> \n> Signed-off-by: Romain Izard \n\nTested-by: Nicolas Ferre \nOn sama5d2 Xplained board (i2c0 from flexcom 4).\nand obviously:\nAcked-by: Nicolas Ferre \n\nThanks Romain!\n\nRegards,\n\n> ---\n> drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n> 1 file changed, 50 insertions(+), 15 deletions(-)\n> \n> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c\n> index 064bde9cff5a..ef1235c4a179 100644\n> --- a/drivers/mfd/atmel-flexcom.c\n> +++ b/drivers/mfd/atmel-flexcom.c\n> @@ -39,34 +39,44 @@\n> #define FLEX_MR_OPMODE(opmode)\t(((opmode) << FLEX_MR_OPMODE_OFFSET) &\t\\\n> \t\t\t\t FLEX_MR_OPMODE_MASK)\n> \n> +struct atmel_flexcom {\n> +\tvoid __iomem *base;\n> +\tu32 opmode;\n> +\tstruct clk *clk;\n> +};\n> \n> static int atmel_flexcom_probe(struct platform_device *pdev)\n> {\n> \tstruct device_node *np = pdev->dev.of_node;\n> -\tstruct clk *clk;\n> \tstruct resource *res;\n> -\tvoid __iomem *base;\n> -\tu32 opmode;\n> +\tstruct atmel_flexcom *afc;\n> \tint err;\n> +\tu32 val;\n> +\n> +\tafc = devm_kzalloc(&pdev->dev, sizeof(*afc), GFP_KERNEL);\n> +\tif (!afc)\n> +\t\treturn -ENOMEM;\n> \n> -\terr = of_property_read_u32(np, \"atmel,flexcom-mode\", &opmode);\n> +\tplatform_set_drvdata(pdev, afc);\n> +\n> +\terr = of_property_read_u32(np, \"atmel,flexcom-mode\", &afc->opmode);\n> \tif (err)\n> \t\treturn err;\n> \n> -\tif (opmode < ATMEL_FLEXCOM_MODE_USART ||\n> -\t opmode > ATMEL_FLEXCOM_MODE_TWI)\n> +\tif (afc->opmode < ATMEL_FLEXCOM_MODE_USART ||\n> +\t afc->opmode > ATMEL_FLEXCOM_MODE_TWI)\n> \t\treturn -EINVAL;\n> \n> \tres = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n> -\tbase = devm_ioremap_resource(&pdev->dev, res);\n> -\tif (IS_ERR(base))\n> -\t\treturn PTR_ERR(base);\n> +\tafc->base = devm_ioremap_resource(&pdev->dev, res);\n> +\tif (IS_ERR(afc->base))\n> +\t\treturn PTR_ERR(afc->base);\n> \n> -\tclk = devm_clk_get(&pdev->dev, NULL);\n> -\tif (IS_ERR(clk))\n> -\t\treturn PTR_ERR(clk);\n> +\tafc->clk = devm_clk_get(&pdev->dev, NULL);\n> +\tif (IS_ERR(afc->clk))\n> +\t\treturn PTR_ERR(afc->clk);\n> \n> -\terr = clk_prepare_enable(clk);\n> +\terr = clk_prepare_enable(afc->clk);\n> \tif (err)\n> \t\treturn err;\n> \n> @@ -76,9 +86,10 @@ static int atmel_flexcom_probe(struct platform_device *pdev)\n> \t * inaccessible and are read as zero. Also the external I/O lines of the\n> \t * Flexcom are muxed to reach the selected device.\n> \t */\n> -\twritel(FLEX_MR_OPMODE(opmode), base + FLEX_MR);\n> +\tval = FLEX_MR_OPMODE(afc->opmode);\n> +\twritel(val, afc->base + FLEX_MR);\n> \n> -\tclk_disable_unprepare(clk);\n> +\tclk_disable_unprepare(afc->clk);\n> \n> \treturn devm_of_platform_populate(&pdev->dev);\n> }\n> @@ -89,10 +100,34 @@ static const struct of_device_id atmel_flexcom_of_match[] = {\n> };\n> MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);\n> \n> +#ifdef CONFIG_PM_SLEEP\n> +static int atmel_flexcom_resume(struct device *dev)\n> +{\n> +\tstruct atmel_flexcom *afc = dev_get_drvdata(dev);\n> +\tint err;\n> +\tu32 val;\n> +\n> +\terr = clk_prepare_enable(afc->clk);\n> +\tif (err)\n> +\t\treturn err;\n> +\n> +\tval = FLEX_MR_OPMODE(afc->opmode),\n> +\twritel(val, afc->base + FLEX_MR);\n> +\n> +\tclk_disable_unprepare(afc->clk);\n> +\n> +\treturn 0;\n> +}\n> +#endif\n> +\n> +static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL,\n> +\t\t\t atmel_flexcom_resume);\n> +\n> static struct platform_driver atmel_flexcom_driver = {\n> \t.probe\t= atmel_flexcom_probe,\n> \t.driver\t= {\n> \t\t.name\t\t= \"atmel_flexcom\",\n> +\t\t.pm\t\t= &atmel_flexcom_pm_ops,\n> \t\t.of_match_table\t= atmel_flexcom_of_match,\n> \t},\n> };\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"oSXhYb0D\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxHdd5jFLz9s78\n\tfor ;\n\tTue, 19 Sep 2017 19:29:41 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duEqQ-0003KM-86; Tue, 19 Sep 2017 09:29:30 +0000","from esa4.microchip.iphmx.com ([68.232.154.123])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duEpZ-00037I-Sn; Tue, 19 Sep 2017 09:28:47 +0000","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t19 Sep 2017 02:28:03 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch04.mchp-main.com\n\t(10.10.76.105) with Microsoft SMTP Server id 14.3.352.0;\n\tTue, 19 Sep 2017 02:28:03 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7ZMwMOuVtEtfQ1YOetI9o/kTfs7/iE4TTgWmbxTTCts=;\n\tb=oSXhYb0DTiYdrX\n\tR90WCtKt7mXRkz62I/eQcqI8XRPP6YHADGlXiHiEvodqT0p5ePdzm5RciCFw69U89TH36IF1eMCuq\n\taXV/YJko1F+WIWy0v+/jlC9ZFzS60JVpkjOh9Q9ORa7F8eajW+Ft/ABnXb/P+f7nLApq0garzsPcK\n\tvamqDiSROELyo2EL0B2qxiA1qKDBmk8jqd7ooLd5WtnAhvmmsoO/9rE1Drcoypmcx7SpMzOPJInAC\n\ttGUsS9R7OoLH12FVTJI/gKfDXzFM9K9gy5MirMHekpzQ+nxI1tMH78WevzFffA5TeOvX2uAEvCUFN\n\tZgw6Ft22WPhWGoW8dpKQ==;","X-IronPort-AV":"E=Sophos;i=\"5.42,417,1500966000\"; d=\"scan'208\";a=\"6931727\"","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","To":"Romain Izard , Alexandre Belloni\n\t, Boris Brezillon\n\t, Michael Turquette\n\t, Stephen Boyd , Ludovic\n\tDesroches , Wenyou Yang\n\t, Josh Wu ,\n\tDavid Woodhouse\n\t, Brian Norris , Marek\n\tVasut ,\n\tCyrille Pitchen , \n\tThierry Reding , Richard Genoud\n\t,\n\tGreg Kroah-Hartman , \n\tAlan Stern , Lee Jones ","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","Date":"Tue, 19 Sep 2017 11:29:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915140411.31716-9-romain.izard.pro@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_022838_045919_6AC3F4AF ","X-CRM114-Status":"GOOD ( 16.93 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.154.123 listed in list.dnswl.org]\n\t0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror)\n\t0.0 T_SPF_HELO_TEMPERROR SPF: test of HELO record failed (temperror)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, linux-clk@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1771152,"web_url":"http://patchwork.ozlabs.org/comment/1771152/","msgid":"<20170919152504.nhp5i734u75gb5gq@dell>","list_archive_url":null,"date":"2017-09-19T15:25:04","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Tue, 19 Sep 2017, Nicolas Ferre wrote:\n\n> On 15/09/2017 at 16:04, Romain Izard wrote:\n> > The controller used by a flexcom module is configured at boot, and left\n> > alone after this. As the configuration will be lost after backup mode,\n> > restore the state of the flexcom driver on resume.\n> > \n> > Signed-off-by: Romain Izard \n> \n> Tested-by: Nicolas Ferre \n> On sama5d2 Xplained board (i2c0 from flexcom 4).\n> and obviously:\n> Acked-by: Nicolas Ferre \n> \n> Thanks Romain!\n> \n> Regards,\n> \n> > ---\n> > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n> > 1 file changed, 50 insertions(+), 15 deletions(-)\n\nThis is the first time I've seen this patch. Why's that?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"GVEgyx9w\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DdTtWYcC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxRXV5bMvz9s7B\n\tfor ;\n\tWed, 20 Sep 2017 01:25:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duKP0-0007e1-SU; Tue, 19 Sep 2017 15:25:34 +0000","from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duKOw-0006ZA-Pu\n\tfor linux-mtd@lists.infradead.org; Tue, 19 Sep 2017 15:25:32 +0000","by mail-wm0-x22e.google.com with SMTP id v142so443090wmv.5\n\tfor ;\n\tTue, 19 Sep 2017 08:25:09 -0700 (PDT)","from dell ([2.27.167.120]) by smtp.gmail.com with ESMTPSA id\n\tl15sm10986527wrl.47.2017.09.19.08.25.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 08:25:06 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=BMgg9B2eKtlJGAGiIMdfrhE2d5ssaGAoufHvmKaxA44=;\n\tb=GVEgyx9wxkDUt0\n\toorkTIEirBzgK38yileaV/Ob301GrR8DMOktZafivbv+ZwR9IIWOz5n2Cf3JjNXiyNBmgRLIplLEI\n\tnlOUIj0XnoAYGrgA2wnS0n0QTn7xshgXaQMid4N/jsKP4ibCm9B3x4/+qrHytebZMEZYjNLih2CcO\n\tqfQs9T+WKfMlCM3BQJUvtuHXOzfiKy1Ho+1qOLi9on5dnqhJ7z8uaS//rfShmMWT5VUNArlKvDL8C\n\tz0XK9wwkvooGDw7wD9NJUZGu2UDKakOrnzXqdMDvSLHvA1Z/QKoYbzgfmaaxl3S52xOU2yMctw4AR\n\t0mKgiP2wFUNooV83fRuQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=0hy1DNH6IUk/eooqqqoHDvi6UUKWF3Gz11ADsqtHBqE=;\n\tb=DdTtWYcCmfERD5JqFwYwqt3xe9hXFpRhh5WeesxzeYseCDdAgq+kiOHcW9+zrg0kj3\n\tzCJMWW0YmcJa0eVWdkfxwnPt8Tv9cZQ0b7M8bdA3XAzpfwVJN4QHQHJIzrVqR18/Xoht\n\tekN7KnjP+pU3yGbNpsmdm4ZVHG0FPxsJpJT2o="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=0hy1DNH6IUk/eooqqqoHDvi6UUKWF3Gz11ADsqtHBqE=;\n\tb=RgbRwRM8P/QvS3coNQKNkeBdYEaddf9mugvB1soKNUdAVRpnf+OhT9Y9lPkJgTojAY\n\tPbcYrkV3GyEEjxMHtQMfbZ9kf4bYT7u5t2rFwWcFeoz0msdiEIT96nHjF/fAI5PTmVpS\n\tRz39dQ++cPsV8uOlR3oVSIhzoxSY03DsGl1sd+Vs58EZkEcXnfRg3sVc3orOMN/HJ9/t\n\toVdlj5Vb2WzUYua7uyFyLpXBNKPlvzNMKUP6h1NiS022XG+CmZQChDZJiFvHk/ffXYwo\n\tiWs2enSOvFFbBOk+F3j1/4NBoqP313Hx/ZzFHixDyIbPD0PUX8BOyZvGstpqHNcfL6uy\n\tD5sw==","X-Gm-Message-State":"AHPjjUjQi7EFYQnkz3Um/m/Gprc2lKmwUXzpcmS4ea9iLEnwkopkh3Qf\n\tUBTfu2EXO0ALZ4w4iFciEX0qDg==","X-Google-Smtp-Source":"AOwi7QBi6n4lc4LDz9UsKpFBc++szWHphAVzaqPFVmDr1y/UWgAOy58CzJ/IOLZkJx3yzYTVy424VQ==","X-Received":"by 10.28.48.71 with SMTP id w68mr1459949wmw.3.1505834708099;\n\tTue, 19 Sep 2017 08:25:08 -0700 (PDT)","Date":"Tue, 19 Sep 2017 16:25:04 +0100","From":"Lee Jones ","To":"Nicolas Ferre ","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","Message-ID":"<20170919152504.nhp5i734u75gb5gq@dell>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>\n\t<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_082531_044304_4ABAA5FA ","X-CRM114-Status":"GOOD ( 12.21 )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a00:1450:400c:c09:0:0:0:22e listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Turquette ,\n\tThierry Reding ,\n\tAlexandre Belloni ,\n\tRomain Izard , linux-clk@vger.kernel.org, \n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, \n\tStephen Boyd , linux-kernel@vger.kernel.org,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tlinux-mtd@lists.infradead.org, \n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1771676,"web_url":"http://patchwork.ozlabs.org/comment/1771676/","msgid":"","list_archive_url":null,"date":"2017-09-20T08:30:31","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"content":"2017-09-19 17:25 GMT+02:00 Lee Jones :\n> On Tue, 19 Sep 2017, Nicolas Ferre wrote:\n>\n>> On 15/09/2017 at 16:04, Romain Izard wrote:\n>> > The controller used by a flexcom module is configured at boot, and left\n>> > alone after this. As the configuration will be lost after backup mode,\n>> > restore the state of the flexcom driver on resume.\n>> >\n>> > Signed-off-by: Romain Izard \n>>\n>> Tested-by: Nicolas Ferre \n>> On sama5d2 Xplained board (i2c0 from flexcom 4).\n>> and obviously:\n>> Acked-by: Nicolas Ferre \n>>\n>> Thanks Romain!\n>>\n>> Regards,\n>>\n>> > ---\n>> > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n>> > 1 file changed, 50 insertions(+), 15 deletions(-)\n>\n> This is the first time I've seen this patch. Why's that?\n>\n\nAs the patchset covers many subsystems, get_maintainers.pl provided a\nvery long list of both developpers and mailing lists (28). I thought it\nwas a good idea to shorten it a little. Bad idea. Sorry.\n\nBest regards,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"iGr8/ch3\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"bzF7vF4y\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mobile-devices.fr header.i=@mobile-devices.fr\n\theader.b=\"scEozuOl\"; \n\tdkim=neutral (0-bit key) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tUhDWT2/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxtJD1dBlz9s06\n\tfor ;\n\tWed, 20 Sep 2017 18:31:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duaPo-00059u-NR; Wed, 20 Sep 2017 08:31:28 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duaPl-00058S-4b\n\tfor linux-mtd@bombadil.infradead.org; Wed, 20 Sep 2017 08:31:25 +0000","from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duaPg-0003fy-W2\n\tfor linux-mtd@lists.infradead.org; Wed, 20 Sep 2017 08:31:23 +0000","by mail-qt0-x22d.google.com with SMTP id o3so1005168qte.6\n\tfor ;\n\tWed, 20 Sep 2017 01:30:55 -0700 (PDT)","by 10.200.48.120 with HTTP; Wed, 20 Sep 2017 01:30:31 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=sbLDr4YPMWYDrRlcAh+/k1Kb2OxmPEk999oFTv8Zhdg=;\n\tb=iGr8/ch3gvh+No\n\t7LVvfAPym1dEQLdv9RcUj0le/odZdS5V04RiO8YuNElgxgV/jWF4edmMgorwrX6z8NDkU8pLf3Qqz\n\t59ByO2U405pbhmd2SugpBLJwwij9macsrjJ1KqNAxBmHvqlL1SJrIJ+WgREbGDjgOkUK+Uwlven6z\n\t2xlKHmqZcympMna92RM8X+zIxWyCMpZoqjQvPBzB1O2J5d/mV7IWjLeQDCVpCbbR/LS12Cw2WYXmY\n\tYU8JgMjVsqbiNqxSwdkqtCGF6V2DkFM5ihjIRhVB9LZFP28Dtxe6gPxrsVRiKfYwWNUoRu/FwUEHt\n\tcgOCx93Sy4C91sIkxjAQ==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=Content-Type:Cc:To:Subject:Message-ID:\n\tDate:From:References:In-Reply-To:Sender:MIME-Version:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=bzF7vF4yKcq1MYnt4oDGmC5k1\n\tGR1UrZtSWNXsAfAgqSaozx2rh7E98Sl3kixmFuJPrhyzwxbftfzx8vS1KuXEFVo5XEHz+2ZVs8DSR\n\t+Wm+9reXQu51Y6VoLmWtROnxdhw7kwxgSybFhxsVz9gUDIp7RjOgjRmFu28OWvSOteAmV7jC6HmFl\n\t4HpYlT8cVUy84f4erGrzJGO7AotIVvW0DvyKRWptwJkZQzIJCWpGJi3GZu+vNi2stJfJnRLuHyw4C\n\t2Aa8pOhogplcYvQE/lbUn75EPVeIjJG470UigwVRptDwBk4FT5z4JtWaW9z+Ajl7xZprxx3iRIs0x\n\tN3g+qLcYQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mobile-devices.fr; s=google;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=scEozuOlZXsX4GsoCBl+ioz9IMb+sEctjK4YYCjtv8WnJ3QAUkXWOZoVLJsx47IJrS\n\ty/7VZgIq7sOKFin1yvKrytpmHv+Czsfyou77vsVOZiX0PZminUpjHoOnx2UrNqeZJGQc\n\tldWMJbXDcN5YAQ6oUrSjnOZQ5cra37WY7dBmc=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=tUhDWT2/RBMXpuUCTDT4viHNt3V1ZdvQKO3++1CzF0t0WmgpTUnsze+ZVYYTAjs+ii\n\tbBnCouVAmQPI9Ee+bdZvVSe7TRzhFAEz3WqhB5J87SBcywEcme+F6W6ZrNB09Ud5o7HP\n\t6zBRlI8CkvVgM4jpNMXrcE8eFEURrkq/xrnkyDWGRJdBcCuDksBMxC3BmTav7krUEG9r\n\tdFix3C/MQMMeTNUvhXlSX5QyJFXtUKBqDPoZcPGeWhd26XfSs+KMKn7xb+SXcgvUP2tC\n\tMBH+iwQZHJzNe7m+RWTBzhhqpw9erUOaDc7AHyDorEU87RGZZRXXm4rXjY+3WRP0U+Pc\n\tvDLQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=EUOkbAeFne8yuT7e5ZprMyzHqpTXVrVqxvGH7jT8wQFzX/bcGHKrv+ECS2w5bC5DSd\n\tKO5W5QXc7duGDRhDRXdXbEnWVWLJbNpNIS7UrY6BZQw/pZ9kS8G9pg6Jb7xI//9Kth2T\n\tw433gwEyc2A70+deraBe81fEP7XaBH6EsAfKM+RPoDubJuJNMW9V8rIAXW5JWuPl+vrj\n\tmPAUvlQ1dySgSTdx9lEoudU8/ZeXy5NHixwcOROE6Nv1/SvenPhd6KX0+re8PkqO5414\n\tKWMmteGOjtlV8bJRrAYTAsaqzko4KGEfK9sJBFialCqy6AEKEr7qPnWGDBaZLlNcaQxv\n\tE3rg==","X-Gm-Message-State":"AHPjjUhAaR7yTPtFJ0WTY+gchwn9BfQH/ZfV6VZPsFTpHrqitrQ535a7\n\tUtHm3GZOoPYm2QxMWB6qSr2x/MRcbnakYZT/271OGQ==","X-Google-Smtp-Source":"AOwi7QD2qHwwFX5hcf6DrauayPdFa3S1WR/tk6LH0AnkqLdMz7va7oN9ov8C7I5Ac8vaC1baBWOk3Q6O9mvuhM11wmY=","X-Received":"by 10.237.42.79 with SMTP id k15mr6336986qtf.222.1505896251856; \n\tWed, 20 Sep 2017 01:30:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170919152504.nhp5i734u75gb5gq@dell>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>\n\t<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>\n\t<20170919152504.nhp5i734u75gb5gq@dell>","From":"Romain Izard ","Date":"Wed, 20 Sep 2017 10:30:31 +0200","X-Google-Sender-Auth":"MFips3p53529z0qRxwDTz-hlErk","Message-ID":"","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","To":"Lee Jones ","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400d:c0d:0:0:0:22d listed in] [list.dnswl.org]\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (romain.izard.pro[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Turquette ,\n\tLKML ,\n\tThierry Reding , \n\tAlexandre Belloni ,\n\tlinux-clk@vger.kernel.org,\n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tNicolas Ferre ,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tlinux-mtd ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1771704,"web_url":"http://patchwork.ozlabs.org/comment/1771704/","msgid":"<20170920091829.wftbjshog3ixvpmu@piout.net>","list_archive_url":null,"date":"2017-09-20T09:18:29","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 20/09/2017 at 10:30:31 +0200, Romain Izard wrote:\n> 2017-09-19 17:25 GMT+02:00 Lee Jones :\n> > On Tue, 19 Sep 2017, Nicolas Ferre wrote:\n> >\n> >> On 15/09/2017 at 16:04, Romain Izard wrote:\n> >> > The controller used by a flexcom module is configured at boot, and left\n> >> > alone after this. As the configuration will be lost after backup mode,\n> >> > restore the state of the flexcom driver on resume.\n> >> >\n> >> > Signed-off-by: Romain Izard \n> >>\n> >> Tested-by: Nicolas Ferre \n> >> On sama5d2 Xplained board (i2c0 from flexcom 4).\n> >> and obviously:\n> >> Acked-by: Nicolas Ferre \n> >>\n> >> Thanks Romain!\n> >>\n> >> Regards,\n> >>\n> >> > ---\n> >> > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n> >> > 1 file changed, 50 insertions(+), 15 deletions(-)\n> >\n> > This is the first time I've seen this patch. Why's that?\n> >\n> \n> As the patchset covers many subsystems, get_maintainers.pl provided a\n> very long list of both developpers and mailing lists (28). I thought it\n> was a good idea to shorten it a little. Bad idea. Sorry.\n> \n\nI think the correct way of handling that would have been to send each\npatch to the proper subsystem as there are no dependency here.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"GO7HvsWO\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxvMK3bQ2z9sP1\n\tfor ;\n\tWed, 20 Sep 2017 19:19:25 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dubA4-00055Q-GR; Wed, 20 Sep 2017 09:19:16 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dub9j-0004kB-Jc; Wed, 20 Sep 2017 09:18:58 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 2A8B620945; Wed, 20 Sep 2017 11:18:32 +0200 (CEST)","from localhost (cpe-98-151-125-52.hawaii.res.rr.com\n\t[98.151.125.52])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 2DC2020929;\n\tWed, 20 Sep 2017 11:18:31 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=36ygsga7bWo9e9gqMdxTff5OgvhyuPfxVwv1tHkmB2I=;\n\tb=GO7HvsWO0LgbfA\n\t2YBStIimb101lJJz3rICLGktWaStav20SLdORvBW6m1Mkd7YeNMOsdlzjZTZdB2abn2p0aOCHd4hk\n\t91kr7gOgb/YPDnmAcjPAPej2GwX/tAe/GBDMJ5p2Sq0KL6vYHZFfVT1tudMBoekINRTFkmJWDfptZ\n\tOf8X++p41+8kR6amL5QpxbcQjTBuEUNrq8rdC+HZM5NKrdiAZkgNonkU9DY6w3qh6sUKQ5HrgGrWk\n\tsF5aMqguMCoZtWa8ZzNX8V9R54BBb1ZGkOj9SacaUn7yE2S7KK277bzz5rPM/HCl4u6kpVpGuEzgE\n\tKRdynd1yzVWgG/NJ0d6A==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 20 Sep 2017 11:18:29 +0200","From":"Alexandre Belloni ","To":"Romain Izard ","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","Message-ID":"<20170920091829.wftbjshog3ixvpmu@piout.net>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>\n\t<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>\n\t<20170919152504.nhp5i734u75gb5gq@dell>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_021855_808802_64FCB962 ","X-CRM114-Status":"GOOD ( 18.06 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Turquette ,\n\tLKML ,\n\tThierry Reding , \n\tlinux-mtd ,\n\tLee Jones , linux-clk@vger.kernel.org,\n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tNicolas Ferre ,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]