[{"id":1773550,"web_url":"http://patchwork.ozlabs.org/comment/1773550/","msgid":"<90b0ce5e-d99e-7bba-0e6e-3d375053487d@microchip.com>","list_archive_url":null,"date":"2017-09-22T12:40:21","subject":"Re: [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 15/09/2017 at 16:04, Romain Izard wrote:\n> When an Atmel SoC is suspended with the backup mode, the USB bus will be\n> powered down. As this is expected, do not return an error to the driver\n> core when ehci_resume detects it.\n> \n> Signed-off-by: Romain Izard \n> ---\n> drivers/usb/host/ehci-atmel.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c\n> index 7440722bfbf0..2a8b9bdc0e57 100644\n> --- a/drivers/usb/host/ehci-atmel.c\n> +++ b/drivers/usb/host/ehci-atmel.c\n> @@ -205,7 +205,8 @@ static int __maybe_unused ehci_atmel_drv_resume(struct device *dev)\n> \tstruct atmel_ehci_priv *atmel_ehci = hcd_to_atmel_ehci_priv(hcd);\n> \n> \tatmel_start_clock(atmel_ehci);\n> -\treturn ehci_resume(hcd, false);\n> +\tehci_resume(hcd, false);\n> +\treturn 0;\n\nOk, I agree with that as the underlying function takes care about the\ncontroller, in any case (even for !B+S-R case). So we don't have any\nadded value to propagate this information.\n\nAcked-by: Nicolas Ferre \n\n> }\n> \n> #ifdef CONFIG_OF\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"h5P8rlse\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzCjd3HS6z9sRW\n\tfor ;\n\tFri, 22 Sep 2017 22:39:49 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvNF6-0006zf-QS; Fri, 22 Sep 2017 12:39:40 +0000","from esa1.microchip.iphmx.com ([68.232.147.91])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvNF3-0006vf-CD; Fri, 22 Sep 2017 12:39:38 +0000","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t22 Sep 2017 05:39:14 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch04.mchp-main.com\n\t(10.10.76.105) with Microsoft SMTP Server id 14.3.352.0;\n\tFri, 22 Sep 2017 05:39:13 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=a5cbWJNtk9VQcRxVcuoJFJ9fxl1fv5G/iy6GqI4/Evo=;\n\tb=h5P8rlseQEFTa+\n\t2mL4sDi7HE69t16zC/qroMynJ9JVnPe0JWOaRJF6Yq6MZ+Y/FJQ2WHCjbHS0zqXXskwcInPS780Vr\n\tgHNQNVtBX2Vm+DlCv6OEeUEMhyhcEGi6CEaNYWV410etATzQM6eMKNYeTMzAPeWYICPJU0llH9Znp\n\t2C3siqLcLq9ultDy0KxtxIw4SRJsN/3X/na7WemfHb/wckHLW0BYxhi7rWLeGBjOeQqpbJfek1UbI\n\t+yOiz3K+V5AVK0Xi7EXpZOZkl82AJPcA5e5M3AoBErqipX2DLVBvtTpteGHTU/l7sxleYqjV46MuZ\n\t9ya3W8j2yiHn8TbhZWfw==;","X-IronPort-AV":"E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"7640420\"","Subject":"Re: [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal","To":"Romain Izard , Alexandre Belloni\n\t, Boris Brezillon\n\t, Michael Turquette\n\t, Stephen Boyd , Ludovic\n\tDesroches , Wenyou Yang\n\t, Josh Wu ,\n\tDavid Woodhouse\n\t, Brian Norris , Marek\n\tVasut ,\n\tCyrille Pitchen , \n\tThierry Reding , Richard Genoud\n\t,\n\tGreg Kroah-Hartman , \n\tAlan Stern ","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-7-romain.izard.pro@gmail.com>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"<90b0ce5e-d99e-7bba-0e6e-3d375053487d@microchip.com>","Date":"Fri, 22 Sep 2017 14:40:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915140411.31716-7-romain.izard.pro@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_053937_470570_E9882EC7 ","X-CRM114-Status":"GOOD ( 11.54 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.147.91 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, linux-clk@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]