[{"id":1773532,"web_url":"http://patchwork.ozlabs.org/comment/1773532/","msgid":"<20170922120532.jddabnd57yt3iowe@rfolt0960.corp.atmel.com>","list_archive_url":null,"date":"2017-09-22T12:05:32","subject":"Re: [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming","submitter":{"id":70920,"url":"http://patchwork.ozlabs.org/api/people/70920/","name":"Ludovic Desroches","email":"ludovic.desroches@microchip.com"},"content":"On Fri, Sep 15, 2017 at 04:04:03PM +0200, Romain Izard wrote:\n> Wait for the syncronization of all clocks when resuming, not only the\n> UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()\n> when interrupts are masked, which is the case in here.\n> \n> Signed-off-by: Romain Izard \nAcked-by: Ludovic Desroches \n\nI faced the same issue because of the use of regmap_read_poll_timeout\nwhen timekeeping is not ready.\n\n\nLudovic\n\n> ---\n> drivers/clk/at91/pmc.c | 24 ++++++++++++++++--------\n> 1 file changed, 16 insertions(+), 8 deletions(-)\n> \n> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n> index 775af473fe11..5c2b26de303e 100644\n> --- a/drivers/clk/at91/pmc.c\n> +++ b/drivers/clk/at91/pmc.c\n> @@ -107,10 +107,20 @@ static int pmc_suspend(void)\n> \treturn 0;\n> }\n> \n> +static bool pmc_ready(unsigned int mask)\n> +{\n> +\tunsigned int status;\n> +\n> +\tregmap_read(pmcreg, AT91_PMC_SR, &status);\n> +\n> +\treturn ((status & mask) == mask) ? 1 : 0;\n> +}\n> +\n> static void pmc_resume(void)\n> {\n> -\tint i, ret = 0;\n> +\tint i;\n> \tu32 tmp;\n> +\tu32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;\n> \n> \tregmap_read(pmcreg, AT91_PMC_MCKR, &tmp);\n> \tif (pmc_cache.mckr != tmp)\n> @@ -134,13 +144,11 @@ static void pmc_resume(void)\n> \t\t\t AT91_PMC_PCR_CMD);\n> \t}\n> \n> -\tif (pmc_cache.uckr & AT91_PMC_UPLLEN) {\n> -\t\tret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp,\n> -\t\t\t\t\t !(tmp & AT91_PMC_LOCKU),\n> -\t\t\t\t\t 10, 5000);\n> -\t\tif (ret)\n> -\t\t\tpr_crit(\"USB PLL didn't lock when resuming\\n\");\n> -\t}\n> +\tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n> +\t\tmask |= AT91_PMC_LOCKU;\n> +\n> +\twhile (!pmc_ready(mask))\n> +\t\tcpu_relax();\n> }\n> \n> static struct syscore_ops pmc_syscore_ops = {\n> -- \n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"k3la0lWe\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzC112PQ5z9sPk\n\tfor ;\n\tFri, 22 Sep 2017 22:08:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvMkI-0002OD-00; Fri, 22 Sep 2017 12:07:50 +0000","from esa3.microchip.iphmx.com ([68.232.153.233])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvMjt-00025G-1C; Fri, 22 Sep 2017 12:07:27 +0000","from exsmtp02.microchip.com (HELO email.microchip.com)\n\t([198.175.253.38])\n\tby esa3.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t22 Sep 2017 05:06:39 -0700","from localhost (10.10.76.4) by chn-sv-exch02.mchp-main.com\n\t(10.10.76.38) with Microsoft SMTP Server id 14.3.352.0;\n\tFri, 22 Sep 2017 05:06:38 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=NKIly9+L6yFl3T2fCYn/d3Q8TkGW3rRb5rgLiP/cvjs=;\n\tb=k3la0lWeBepSGx\n\tHDSIhZKHSlg5wm7YYJ6L74pMPrreBE3PxSGMVGwru2LNEJthjSbXYAuwAg2xOjce6KWSaukwLsZWk\n\tezEix5GaqOy3GPU3fu9QkXH33lvL7f7nyEbgpM+HIlXkinK/YZqmWOKXZNTJ8HFdDXyP4fikQdq8q\n\t+iOstMyoa4S84vrMVRH0xeftKQu78vmTpfjmcCL1JvxMml+9xKCu5Q6BalG668vgW1WtJ868wJpaY\n\tEL0zfpIKxyTqE2PQLZLJxdfIvY/nTddV2wjcxiwGgV98OOZJuFxDbVxaeDPf47ZQATeYIiIM8xnMc\n\ttWlWgSg8HVepLBX2gtUA==;","X-IronPort-AV":"E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"7272402\"","Date":"Fri, 22 Sep 2017 14:05:32 +0200","From":"Ludovic Desroches ","To":"Romain Izard ","Subject":"Re: [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming","Message-ID":"<20170922120532.jddabnd57yt3iowe@rfolt0960.corp.atmel.com>","Mail-Followup-To":"Romain Izard ,\n\tNicolas Ferre ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tWenyou Yang ,\n\tJosh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern , linux-clk@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-2-romain.izard.pro@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170915140411.31716-2-romain.izard.pro@gmail.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_050725_168627_BA247342 ","X-CRM114-Status":"GOOD ( 15.07 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.153.233 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michael Turquette , linux-kernel@vger.kernel.org,\n\tThierry Reding ,\n\tAlexandre Belloni ,\n\tlinux-clk@vger.kernel.org,\n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tNicolas Ferre ,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tlinux-mtd@lists.infradead.org, \n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1773538,"web_url":"http://patchwork.ozlabs.org/comment/1773538/","msgid":"","list_archive_url":null,"date":"2017-09-22T12:13:26","subject":"Re: [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 15/09/2017 at 16:04, Romain Izard wrote:\n> Wait for the syncronization of all clocks when resuming, not only the\n> UPLL clock. Do not use regmap_read_poll_timeout, as it will call BUG()\n> when interrupts are masked, which is the case in here.\n> \n> Signed-off-by: Romain Izard \n\nAnd here is my:\nAcked-by: Nicolas Ferre \n\n> ---\n> drivers/clk/at91/pmc.c | 24 ++++++++++++++++--------\n> 1 file changed, 16 insertions(+), 8 deletions(-)\n> \n> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n> index 775af473fe11..5c2b26de303e 100644\n> --- a/drivers/clk/at91/pmc.c\n> +++ b/drivers/clk/at91/pmc.c\n> @@ -107,10 +107,20 @@ static int pmc_suspend(void)\n> \treturn 0;\n> }\n> \n> +static bool pmc_ready(unsigned int mask)\n> +{\n> +\tunsigned int status;\n> +\n> +\tregmap_read(pmcreg, AT91_PMC_SR, &status);\n> +\n> +\treturn ((status & mask) == mask) ? 1 : 0;\n> +}\n> +\n> static void pmc_resume(void)\n> {\n> -\tint i, ret = 0;\n> +\tint i;\n> \tu32 tmp;\n> +\tu32 mask = AT91_PMC_MCKRDY | AT91_PMC_LOCKA;\n> \n> \tregmap_read(pmcreg, AT91_PMC_MCKR, &tmp);\n> \tif (pmc_cache.mckr != tmp)\n> @@ -134,13 +144,11 @@ static void pmc_resume(void)\n> \t\t\t AT91_PMC_PCR_CMD);\n> \t}\n> \n> -\tif (pmc_cache.uckr & AT91_PMC_UPLLEN) {\n> -\t\tret = regmap_read_poll_timeout(pmcreg, AT91_PMC_SR, tmp,\n> -\t\t\t\t\t !(tmp & AT91_PMC_LOCKU),\n> -\t\t\t\t\t 10, 5000);\n> -\t\tif (ret)\n> -\t\t\tpr_crit(\"USB PLL didn't lock when resuming\\n\");\n> -\t}\n> +\tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n> +\t\tmask |= AT91_PMC_LOCKU;\n> +\n> +\twhile (!pmc_ready(mask))\n> +\t\tcpu_relax();\n> }\n> \n> static struct syscore_ops pmc_syscore_ops = {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"b6BUropG\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzC6p0XHJz9sPk\n\tfor ;\n\tFri, 22 Sep 2017 22:13:06 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvMpD-00053Y-Dx; Fri, 22 Sep 2017 12:12:55 +0000","from esa2.microchip.iphmx.com ([68.232.149.84])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dvMoz-0004vt-50; Fri, 22 Sep 2017 12:12:52 +0000","from exsmtp01.microchip.com (HELO email.microchip.com)\n\t([198.175.253.37])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/AES128-SHA;\n\t22 Sep 2017 05:12:19 -0700","from [10.159.245.112] (10.10.76.4) by CHN-SV-EXCH01.mchp-main.com\n\t(10.10.76.37) with Microsoft SMTP Server id 14.3.352.0;\n\tFri, 22 Sep 2017 05:12:19 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=UeT0ADiIk1tcvNwYKp2seKpWn2rJoE34G9jHNBPtq10=;\n\tb=b6BUropGXQBirB\n\tuXHzpYtk2lRPrDMvtvLoCjUsLZW/PxFAXGjPT3BMxrVgfZmjvHYYWYBjx/HYKuYlSI5mrO9KaFPzx\n\tf4EeSF1o36vaAg9irYMqttM3W4s74g5jsB+fXoto90Ng/Fjs6BF2oF4rVUycq9YBWbnRMsJk5wu2Z\n\tB3hFEV8fU8jmY8NuKUPITTAxsaYOQ+q/dsLk/OgIe8PayEkrZKq2YoGfBuhHADwGHt9zwFLgN3prn\n\tSs6BOcru7Irp0BnijfL+JsnY7BOvlhu6RL66lfB0sTXUdx1eWGo2JM08WtO4LnX3x816OJRQI9LFY\n\tL/zmJHWWGAyc8R+RG+mg==;","X-IronPort-AV":"E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"7216739\"","Subject":"Re: [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming","To":"Romain Izard , Alexandre Belloni\n\t, Boris Brezillon\n\t, Michael Turquette\n\t, Stephen Boyd , Ludovic\n\tDesroches , Wenyou Yang\n\t, Josh Wu ,\n\tDavid Woodhouse\n\t, Brian Norris , Marek\n\tVasut ,\n\tCyrille Pitchen , \n\tThierry Reding , Richard Genoud\n\t,\n\tGreg Kroah-Hartman , \n\tAlan Stern ","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-2-romain.izard.pro@gmail.com>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"","Date":"Fri, 22 Sep 2017 14:13:26 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915140411.31716-2-romain.izard.pro@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170922_051241_543545_8B2A8261 ","X-CRM114-Status":"GOOD ( 14.00 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.149.84 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, linux-clk@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]