[{"id":1773549,"web_url":"http://patchwork.ozlabs.org/comment/1773549/","msgid":"<90b0ce5e-d99e-7bba-0e6e-3d375053487d@microchip.com>","list_archive_url":null,"date":"2017-09-22T12:40:21","subject":"Re: [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 15/09/2017 at 16:04, Romain Izard wrote:\n> When an Atmel SoC is suspended with the backup mode, the USB bus will be\n> powered down. As this is expected, do not return an error to the driver\n> core when ehci_resume detects it.\n> \n> Signed-off-by: Romain Izard \n> ---\n> drivers/usb/host/ehci-atmel.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c\n> index 7440722bfbf0..2a8b9bdc0e57 100644\n> --- a/drivers/usb/host/ehci-atmel.c\n> +++ b/drivers/usb/host/ehci-atmel.c\n> @@ -205,7 +205,8 @@ static int __maybe_unused ehci_atmel_drv_resume(struct device *dev)\n> \tstruct atmel_ehci_priv *atmel_ehci = hcd_to_atmel_ehci_priv(hcd);\n> \n> \tatmel_start_clock(atmel_ehci);\n> -\treturn ehci_resume(hcd, false);\n> +\tehci_resume(hcd, false);\n> +\treturn 0;\n\nOk, I agree with that as the underlying function takes care about the\ncontroller, in any case (even for !B+S-R case). So we don't have any\nadded value to propagate this information.\n\nAcked-by: Nicolas Ferre \n\n> }\n> \n> #ifdef CONFIG_OF\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzCj15hyJz9sPk\n\tfor ;\n\tFri, 22 Sep 2017 22:39:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752342AbdIVMjR (ORCPT );\n\tFri, 22 Sep 2017 08:39:17 -0400","from esa1.microchip.iphmx.com ([68.232.147.91]:52938 \"EHLO\n\tesa1.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752245AbdIVMjP (ORCPT\n\t); Fri, 22 Sep 2017 08:39:15 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t22 Sep 2017 05:39:14 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch04.mchp-main.com\n\t(10.10.76.105) with Microsoft SMTP Server id 14.3.352.0;\n\tFri, 22 Sep 2017 05:39:13 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,427,1500966000\"; d=\"scan'208\";a=\"7640420\"","Subject":"Re: [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal","To":"Romain Izard ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ","CC":", ,\n\t, ,\n\t, ,\n\t","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-7-romain.izard.pro@gmail.com>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"<90b0ce5e-d99e-7bba-0e6e-3d375053487d@microchip.com>","Date":"Fri, 22 Sep 2017 14:40:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915140411.31716-7-romain.izard.pro@gmail.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}}]