[{"id":1770787,"web_url":"http://patchwork.ozlabs.org/comment/1770787/","msgid":"<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","list_archive_url":null,"date":"2017-09-19T09:29:12","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 15/09/2017 at 16:04, Romain Izard wrote:\n> The controller used by a flexcom module is configured at boot, and left\n> alone after this. As the configuration will be lost after backup mode,\n> restore the state of the flexcom driver on resume.\n> \n> Signed-off-by: Romain Izard \n\nTested-by: Nicolas Ferre \nOn sama5d2 Xplained board (i2c0 from flexcom 4).\nand obviously:\nAcked-by: Nicolas Ferre \n\nThanks Romain!\n\nRegards,\n\n> ---\n> drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n> 1 file changed, 50 insertions(+), 15 deletions(-)\n> \n> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c\n> index 064bde9cff5a..ef1235c4a179 100644\n> --- a/drivers/mfd/atmel-flexcom.c\n> +++ b/drivers/mfd/atmel-flexcom.c\n> @@ -39,34 +39,44 @@\n> #define FLEX_MR_OPMODE(opmode)\t(((opmode) << FLEX_MR_OPMODE_OFFSET) &\t\\\n> \t\t\t\t FLEX_MR_OPMODE_MASK)\n> \n> +struct atmel_flexcom {\n> +\tvoid __iomem *base;\n> +\tu32 opmode;\n> +\tstruct clk *clk;\n> +};\n> \n> static int atmel_flexcom_probe(struct platform_device *pdev)\n> {\n> \tstruct device_node *np = pdev->dev.of_node;\n> -\tstruct clk *clk;\n> \tstruct resource *res;\n> -\tvoid __iomem *base;\n> -\tu32 opmode;\n> +\tstruct atmel_flexcom *afc;\n> \tint err;\n> +\tu32 val;\n> +\n> +\tafc = devm_kzalloc(&pdev->dev, sizeof(*afc), GFP_KERNEL);\n> +\tif (!afc)\n> +\t\treturn -ENOMEM;\n> \n> -\terr = of_property_read_u32(np, \"atmel,flexcom-mode\", &opmode);\n> +\tplatform_set_drvdata(pdev, afc);\n> +\n> +\terr = of_property_read_u32(np, \"atmel,flexcom-mode\", &afc->opmode);\n> \tif (err)\n> \t\treturn err;\n> \n> -\tif (opmode < ATMEL_FLEXCOM_MODE_USART ||\n> -\t opmode > ATMEL_FLEXCOM_MODE_TWI)\n> +\tif (afc->opmode < ATMEL_FLEXCOM_MODE_USART ||\n> +\t afc->opmode > ATMEL_FLEXCOM_MODE_TWI)\n> \t\treturn -EINVAL;\n> \n> \tres = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n> -\tbase = devm_ioremap_resource(&pdev->dev, res);\n> -\tif (IS_ERR(base))\n> -\t\treturn PTR_ERR(base);\n> +\tafc->base = devm_ioremap_resource(&pdev->dev, res);\n> +\tif (IS_ERR(afc->base))\n> +\t\treturn PTR_ERR(afc->base);\n> \n> -\tclk = devm_clk_get(&pdev->dev, NULL);\n> -\tif (IS_ERR(clk))\n> -\t\treturn PTR_ERR(clk);\n> +\tafc->clk = devm_clk_get(&pdev->dev, NULL);\n> +\tif (IS_ERR(afc->clk))\n> +\t\treturn PTR_ERR(afc->clk);\n> \n> -\terr = clk_prepare_enable(clk);\n> +\terr = clk_prepare_enable(afc->clk);\n> \tif (err)\n> \t\treturn err;\n> \n> @@ -76,9 +86,10 @@ static int atmel_flexcom_probe(struct platform_device *pdev)\n> \t * inaccessible and are read as zero. Also the external I/O lines of the\n> \t * Flexcom are muxed to reach the selected device.\n> \t */\n> -\twritel(FLEX_MR_OPMODE(opmode), base + FLEX_MR);\n> +\tval = FLEX_MR_OPMODE(afc->opmode);\n> +\twritel(val, afc->base + FLEX_MR);\n> \n> -\tclk_disable_unprepare(clk);\n> +\tclk_disable_unprepare(afc->clk);\n> \n> \treturn devm_of_platform_populate(&pdev->dev);\n> }\n> @@ -89,10 +100,34 @@ static const struct of_device_id atmel_flexcom_of_match[] = {\n> };\n> MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);\n> \n> +#ifdef CONFIG_PM_SLEEP\n> +static int atmel_flexcom_resume(struct device *dev)\n> +{\n> +\tstruct atmel_flexcom *afc = dev_get_drvdata(dev);\n> +\tint err;\n> +\tu32 val;\n> +\n> +\terr = clk_prepare_enable(afc->clk);\n> +\tif (err)\n> +\t\treturn err;\n> +\n> +\tval = FLEX_MR_OPMODE(afc->opmode),\n> +\twritel(val, afc->base + FLEX_MR);\n> +\n> +\tclk_disable_unprepare(afc->clk);\n> +\n> +\treturn 0;\n> +}\n> +#endif\n> +\n> +static SIMPLE_DEV_PM_OPS(atmel_flexcom_pm_ops, NULL,\n> +\t\t\t atmel_flexcom_resume);\n> +\n> static struct platform_driver atmel_flexcom_driver = {\n> \t.probe\t= atmel_flexcom_probe,\n> \t.driver\t= {\n> \t\t.name\t\t= \"atmel_flexcom\",\n> +\t\t.pm\t\t= &atmel_flexcom_pm_ops,\n> \t\t.of_match_table\t= atmel_flexcom_of_match,\n> \t},\n> };\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxHc33XNwz9s78\n\tfor ;\n\tTue, 19 Sep 2017 19:28:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751098AbdISJ2S (ORCPT );\n\tTue, 19 Sep 2017 05:28:18 -0400","from esa4.microchip.iphmx.com ([68.232.154.123]:33224 \"EHLO\n\tesa4.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751001AbdISJ2Q (ORCPT\n\t); Tue, 19 Sep 2017 05:28:16 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t19 Sep 2017 02:28:03 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch04.mchp-main.com\n\t(10.10.76.105) with Microsoft SMTP Server id 14.3.352.0;\n\tTue, 19 Sep 2017 02:28:03 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,417,1500966000\"; d=\"scan'208\";a=\"6931727\"","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","To":"Romain Izard ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern , Lee Jones ","CC":", ,\n\t, ,\n\t, ,\n\t","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","Date":"Tue, 19 Sep 2017 11:29:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915140411.31716-9-romain.izard.pro@gmail.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1771150,"web_url":"http://patchwork.ozlabs.org/comment/1771150/","msgid":"<20170919152504.nhp5i734u75gb5gq@dell>","list_archive_url":null,"date":"2017-09-19T15:25:04","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Tue, 19 Sep 2017, Nicolas Ferre wrote:\n\n> On 15/09/2017 at 16:04, Romain Izard wrote:\n> > The controller used by a flexcom module is configured at boot, and left\n> > alone after this. As the configuration will be lost after backup mode,\n> > restore the state of the flexcom driver on resume.\n> > \n> > Signed-off-by: Romain Izard \n> \n> Tested-by: Nicolas Ferre \n> On sama5d2 Xplained board (i2c0 from flexcom 4).\n> and obviously:\n> Acked-by: Nicolas Ferre \n> \n> Thanks Romain!\n> \n> Regards,\n> \n> > ---\n> > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n> > 1 file changed, 50 insertions(+), 15 deletions(-)\n\nThis is the first time I've seen this patch. Why's that?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DdTtWYcC\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxRX76rBfz9s7B\n\tfor ;\n\tWed, 20 Sep 2017 01:25:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751859AbdISPZO (ORCPT );\n\tTue, 19 Sep 2017 11:25:14 -0400","from mail-wm0-f45.google.com ([74.125.82.45]:51038 \"EHLO\n\tmail-wm0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751641AbdISPZJ (ORCPT\n\t); Tue, 19 Sep 2017 11:25:09 -0400","by mail-wm0-f45.google.com with SMTP id v142so443091wmv.5\n\tfor ; Tue, 19 Sep 2017 08:25:08 -0700 (PDT)","from dell ([2.27.167.120]) by smtp.gmail.com with ESMTPSA id\n\tl15sm10986527wrl.47.2017.09.19.08.25.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 08:25:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=0hy1DNH6IUk/eooqqqoHDvi6UUKWF3Gz11ADsqtHBqE=;\n\tb=DdTtWYcCmfERD5JqFwYwqt3xe9hXFpRhh5WeesxzeYseCDdAgq+kiOHcW9+zrg0kj3\n\tzCJMWW0YmcJa0eVWdkfxwnPt8Tv9cZQ0b7M8bdA3XAzpfwVJN4QHQHJIzrVqR18/Xoht\n\tekN7KnjP+pU3yGbNpsmdm4ZVHG0FPxsJpJT2o=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=0hy1DNH6IUk/eooqqqoHDvi6UUKWF3Gz11ADsqtHBqE=;\n\tb=o4UbiDKZpL89tPnee1Dkqpb6FBYhbbVo/hhyq+2W5tkaVWW/AlsxqXVgXygsdD+497\n\tBHaUl+kV6reOqPzMm/J0kuKs6ObhRmv5tJCVBJIvXCM5Ny8zsxQZRMWk796DClB2cYOo\n\tczAqKOkJ+5WKcG0KTgm0QZPXuEwMRbut5RdQKNcDILdoSJGuBbTYg2UCw5H1lRlvb8Uo\n\t39kfjBZdwYJgCt6oYDqS4p2apwk9CnXeBnUyugmco6Hu4ZuAZN6mpcZQ+T3ZpQFbWojO\n\t7f2UimewXSjQ8laJRWbocjl9UYZgqoWoEc0yeIppPFHsY8D8tI9fPYNDaBBf1K49KkZJ\n\t1JQQ==","X-Gm-Message-State":"AHPjjUgY0KCgi3hIrihzxFUKzm1ufkonT3iCKWaPe55MqOB0Y30HJkVo\n\t5W6DQAORt1/vo29ZGYSCKk+b3g==","X-Google-Smtp-Source":"AOwi7QBi6n4lc4LDz9UsKpFBc++szWHphAVzaqPFVmDr1y/UWgAOy58CzJ/IOLZkJx3yzYTVy424VQ==","X-Received":"by 10.28.48.71 with SMTP id w68mr1459949wmw.3.1505834708099;\n\tTue, 19 Sep 2017 08:25:08 -0700 (PDT)","Date":"Tue, 19 Sep 2017 16:25:04 +0100","From":"Lee Jones ","To":"Nicolas Ferre ","Cc":"Romain Izard ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ,\n\tlinux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org,\n\tlinux-serial@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","Message-ID":"<20170919152504.nhp5i734u75gb5gq@dell>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>\n\t<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1771675,"web_url":"http://patchwork.ozlabs.org/comment/1771675/","msgid":"","list_archive_url":null,"date":"2017-09-20T08:30:31","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"content":"2017-09-19 17:25 GMT+02:00 Lee Jones :\n> On Tue, 19 Sep 2017, Nicolas Ferre wrote:\n>\n>> On 15/09/2017 at 16:04, Romain Izard wrote:\n>> > The controller used by a flexcom module is configured at boot, and left\n>> > alone after this. As the configuration will be lost after backup mode,\n>> > restore the state of the flexcom driver on resume.\n>> >\n>> > Signed-off-by: Romain Izard \n>>\n>> Tested-by: Nicolas Ferre \n>> On sama5d2 Xplained board (i2c0 from flexcom 4).\n>> and obviously:\n>> Acked-by: Nicolas Ferre \n>>\n>> Thanks Romain!\n>>\n>> Regards,\n>>\n>> > ---\n>> > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n>> > 1 file changed, 50 insertions(+), 15 deletions(-)\n>\n> This is the first time I've seen this patch. Why's that?\n>\n\nAs the patchset covers many subsystems, get_maintainers.pl provided a\nvery long list of both developpers and mailing lists (28). I thought it\nwas a good idea to shorten it a little. Bad idea. Sorry.\n\nBest regards,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mobile-devices.fr header.i=@mobile-devices.fr\n\theader.b=\"scEozuOl\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tUhDWT2/\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxtHn0GXZz9s06\n\tfor ;\n\tWed, 20 Sep 2017 18:31:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751887AbdITIa4 (ORCPT );\n\tWed, 20 Sep 2017 04:30:56 -0400","from mail-qt0-f179.google.com ([209.85.216.179]:57135 \"EHLO\n\tmail-qt0-f179.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751783AbdITIaw (ORCPT\n\t); Wed, 20 Sep 2017 04:30:52 -0400","by mail-qt0-f179.google.com with SMTP id l25so2011092qtf.13\n\tfor ; Wed, 20 Sep 2017 01:30:52 -0700 (PDT)","by 10.200.48.120 with HTTP; Wed, 20 Sep 2017 01:30:31 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mobile-devices.fr; s=google;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=scEozuOlZXsX4GsoCBl+ioz9IMb+sEctjK4YYCjtv8WnJ3QAUkXWOZoVLJsx47IJrS\n\ty/7VZgIq7sOKFin1yvKrytpmHv+Czsfyou77vsVOZiX0PZminUpjHoOnx2UrNqeZJGQc\n\tldWMJbXDcN5YAQ6oUrSjnOZQ5cra37WY7dBmc=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=tUhDWT2/RBMXpuUCTDT4viHNt3V1ZdvQKO3++1CzF0t0WmgpTUnsze+ZVYYTAjs+ii\n\tbBnCouVAmQPI9Ee+bdZvVSe7TRzhFAEz3WqhB5J87SBcywEcme+F6W6ZrNB09Ud5o7HP\n\t6zBRlI8CkvVgM4jpNMXrcE8eFEURrkq/xrnkyDWGRJdBcCuDksBMxC3BmTav7krUEG9r\n\tdFix3C/MQMMeTNUvhXlSX5QyJFXtUKBqDPoZcPGeWhd26XfSs+KMKn7xb+SXcgvUP2tC\n\tMBH+iwQZHJzNe7m+RWTBzhhqpw9erUOaDc7AHyDorEU87RGZZRXXm4rXjY+3WRP0U+Pc\n\tvDLQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=LpuSl7BpgJsU3oAPh1uH4RyFRnR92eJoq0bvYK5Oujg=;\n\tb=YLrrO+ATmyhFfu32Qhk8YSsIHsSg9jxHMM5O9cIH9T5MTacGBelWskPueT1M5cwt54\n\tjqF9ejbL3zYr2tDiYaXY5Z6lNA5iiRQMoY2vrKrxZOg1Zlhm6NQk3W0BpYvEVMYOihJX\n\tqu0FDSzYV9coc0HpKbbELkmiCfNt7MFvR5wWCUa5/TQPjf4d3fE/MsNnhb2pbd5knwlG\n\tsyTJEvodZOFxbGRXNBCf+kbGKIIQK1fgT8Xb9AERLvn7gGuCTBqGN1PhxgIFpE7Wqjcb\n\tn2H4zpQW/AibJwJtgQQlj/MTUvdf9ClxXHeOZqIWUf45U6Ol1FNo6v9x9Ahz6vI9MsVw\n\t47FA==","X-Gm-Message-State":"AHPjjUgJGlIbqLkyx/07ONrg79jFmM1R9CKklkmnGy+gukIij9zaq+IV\n\tjtC7VBrUbYLPXB8VpSy8iZPGpqkSgAu6UGGQmuq0iQ==","X-Google-Smtp-Source":"AOwi7QD2qHwwFX5hcf6DrauayPdFa3S1WR/tk6LH0AnkqLdMz7va7oN9ov8C7I5Ac8vaC1baBWOk3Q6O9mvuhM11wmY=","X-Received":"by 10.237.42.79 with SMTP id k15mr6336986qtf.222.1505896251856; \n\tWed, 20 Sep 2017 01:30:51 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170919152504.nhp5i734u75gb5gq@dell>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>\n\t<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>\n\t<20170919152504.nhp5i734u75gb5gq@dell>","From":"Romain Izard ","Date":"Wed, 20 Sep 2017 10:30:31 +0200","X-Google-Sender-Auth":"MFips3p53529z0qRxwDTz-hlErk","Message-ID":"","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","To":"Lee Jones ","Cc":"Nicolas Ferre ,\n\tAlexandre Belloni ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ,\n\tlinux-clk@vger.kernel.org, LKML ,\n\tlinux-mtd ,\n\tlinux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,\n\tlinux-usb@vger.kernel.org,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1771702,"web_url":"http://patchwork.ozlabs.org/comment/1771702/","msgid":"<20170920091829.wftbjshog3ixvpmu@piout.net>","list_archive_url":null,"date":"2017-09-20T09:18:29","subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 20/09/2017 at 10:30:31 +0200, Romain Izard wrote:\n> 2017-09-19 17:25 GMT+02:00 Lee Jones :\n> > On Tue, 19 Sep 2017, Nicolas Ferre wrote:\n> >\n> >> On 15/09/2017 at 16:04, Romain Izard wrote:\n> >> > The controller used by a flexcom module is configured at boot, and left\n> >> > alone after this. As the configuration will be lost after backup mode,\n> >> > restore the state of the flexcom driver on resume.\n> >> >\n> >> > Signed-off-by: Romain Izard \n> >>\n> >> Tested-by: Nicolas Ferre \n> >> On sama5d2 Xplained board (i2c0 from flexcom 4).\n> >> and obviously:\n> >> Acked-by: Nicolas Ferre \n> >>\n> >> Thanks Romain!\n> >>\n> >> Regards,\n> >>\n> >> > ---\n> >> > drivers/mfd/atmel-flexcom.c | 65 ++++++++++++++++++++++++++++++++++-----------\n> >> > 1 file changed, 50 insertions(+), 15 deletions(-)\n> >\n> > This is the first time I've seen this patch. Why's that?\n> >\n> \n> As the patchset covers many subsystems, get_maintainers.pl provided a\n> very long list of both developpers and mailing lists (28). I thought it\n> was a good idea to shorten it a little. Bad idea. Sorry.\n> \n\nI think the correct way of handling that would have been to send each\npatch to the proper subsystem as there are no dependency here.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxvLP4jqSz9sP1\n\tfor ;\n\tWed, 20 Sep 2017 19:18:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751585AbdITJSg (ORCPT );\n\tWed, 20 Sep 2017 05:18:36 -0400","from mail.free-electrons.com ([62.4.15.54]:49698 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751554AbdITJSe (ORCPT\n\t); Wed, 20 Sep 2017 05:18:34 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 2A8B620945; Wed, 20 Sep 2017 11:18:32 +0200 (CEST)","from localhost (cpe-98-151-125-52.hawaii.res.rr.com\n\t[98.151.125.52])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 2DC2020929;\n\tWed, 20 Sep 2017 11:18:31 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 20 Sep 2017 11:18:29 +0200","From":"Alexandre Belloni ","To":"Romain Izard ","Cc":"Lee Jones ,\n\tNicolas Ferre ,\n\tBoris Brezillon ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ,\n\tlinux-clk@vger.kernel.org, LKML ,\n\tlinux-mtd ,\n\tlinux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,\n\tlinux-usb@vger.kernel.org,\n\tlinux-arm-kernel ","Subject":"Re: [PATCH v2 8/9] atmel_flexcom: Support backup mode","Message-ID":"<20170920091829.wftbjshog3ixvpmu@piout.net>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-9-romain.izard.pro@gmail.com>\n\t<53aa7783-0ecf-1e68-1bf9-c470ba2f79eb@microchip.com>\n\t<20170919152504.nhp5i734u75gb5gq@dell>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}}]