[{"id":1770043,"web_url":"http://patchwork.ozlabs.org/comment/1770043/","msgid":"<20170918120051.298bdabf@bbrezillon>","list_archive_url":null,"date":"2017-09-18T10:00:51","subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"Hi Romain,\n\nOn Fri, 15 Sep 2017 16:04:07 +0200\nRomain Izard wrote:\n\n> It is not normal for the PMECC to fail when trying to fix ECC errors.\n> Report these cases as errors.\n\nI'm not sure we want to have ECC error messages at this level. ECC\nerrors are rather unusual but not impossible, and sometimes it's even\nnot a real error (I'm thinking of bitflips in erased pages for\nexample, which are not necessarily detected/fixed in hardware).\n\nIf we decide to print error messages when unfixable bitflips are\ndetected, it should be done in the nand-controller driver (somewhere\nalong those lines [1]).\n\nRegards,\n\nBoris\n\n[1]http://elixir.free-electrons.com/linux/latest/source/drivers/mtd/nand/atmel/nand-controller.c#L827\n\n> \n> Signed-off-by: Romain Izard \n> ---\n> drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\n> index 8d1208f38025..2a23f1ff945f 100644\n> --- a/drivers/mtd/nand/atmel/pmecc.c\n> +++ b/drivers/mtd/nand/atmel/pmecc.c\n> @@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n> \t * Number of roots does not match the degree of smu\n> \t * unable to correct error.\n> \t */\n> +\tdev_err(pmecc->dev,\n> +\t\t\"PMECC: Impossible to calculate error location.\\n\");\n> \treturn -EBADMSG;\n> }\n> \n> @@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n> \t\t\tptr = ecc + byte - sectorsize;\n> \t\t\tarea = \"ECC\";\n> \t\t} else {\n> -\t\t\tdev_dbg(pmecc->dev,\n> +\t\t\tdev_err(pmecc->dev,\n> \t\t\t\t\"Invalid errpos value (%d, max is %d)\\n\",\n> \t\t\t\terrpos, (sectorsize + eccbytes) * 8);\n> \t\t\treturn -EINVAL;\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-pwm\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwhNg1ksBz9sBZ\n\tfor ;\n\tMon, 18 Sep 2017 20:01:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754651AbdIRKBH (ORCPT );\n\tMon, 18 Sep 2017 06:01:07 -0400","from mail.free-electrons.com ([62.4.15.54]:59983 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754665AbdIRKBE (ORCPT\n\t); Mon, 18 Sep 2017 06:01:04 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 7B43B2084A; Mon, 18 Sep 2017 12:01:02 +0200 (CEST)","from bbrezillon (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E319F20828;\n\tMon, 18 Sep 2017 12:00:51 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 12:00:51 +0200","From":"Boris Brezillon ","To":"Romain Izard ","Cc":"Nicolas Ferre ,\n\tAlexandre Belloni ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ,\n\tlinux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-serial@vger.kernel.org, linux-clk@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","Message-ID":"<20170918120051.298bdabf@bbrezillon>","In-Reply-To":"<20170915140411.31716-6-romain.izard.pro@gmail.com>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-6-romain.izard.pro@gmail.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1772606,"web_url":"http://patchwork.ozlabs.org/comment/1772606/","msgid":"","list_archive_url":null,"date":"2017-09-21T09:22:42","subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","submitter":{"id":8236,"url":"http://patchwork.ozlabs.org/api/people/8236/","name":"Romain Izard","email":"romain.izard.pro@gmail.com"},"content":"2017-09-18 12:00 GMT+02:00 Boris Brezillon :\n> Hi Romain,\n>\n> On Fri, 15 Sep 2017 16:04:07 +0200\n> Romain Izard wrote:\n>\n>> It is not normal for the PMECC to fail when trying to fix ECC errors.\n>> Report these cases as errors.\n>\n> I'm not sure we want to have ECC error messages at this level. ECC\n> errors are rather unusual but not impossible, and sometimes it's even\n> not a real error (I'm thinking of bitflips in erased pages for\n> example, which are not necessarily detected/fixed in hardware).\n>\n> If we decide to print error messages when unfixable bitflips are\n> detected, it should be done in the nand-controller driver (somewhere\n> along those lines [1]).\n>\n> Regards,\n>\n> Boris\n>\n> [1]http://elixir.free-electrons.com/linux/latest/source/drivers/mtd/nand/atmel/nand-controller.c#L827\n>\n>>\n>> Signed-off-by: Romain Izard \n>> ---\n>> drivers/mtd/nand/atmel/pmecc.c | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c\n>> index 8d1208f38025..2a23f1ff945f 100644\n>> --- a/drivers/mtd/nand/atmel/pmecc.c\n>> +++ b/drivers/mtd/nand/atmel/pmecc.c\n>> @@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)\n>> * Number of roots does not match the degree of smu\n>> * unable to correct error.\n>> */\n>> + dev_err(pmecc->dev,\n>> + \"PMECC: Impossible to calculate error location.\\n\");\n>> return -EBADMSG;\n>> }\n>>\n>> @@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,\n>> ptr = ecc + byte - sectorsize;\n>> area = \"ECC\";\n>> } else {\n>> - dev_dbg(pmecc->dev,\n>> + dev_err(pmecc->dev,\n>> \"Invalid errpos value (%d, max is %d)\\n\",\n>> errpos, (sectorsize + eccbytes) * 8);\n>> return -EINVAL;\n>\n\nOk, I will drop this patch.\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-pwm\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mobile-devices.fr header.i=@mobile-devices.fr\n\theader.b=\"ncVrtRfv\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XqO9p0rv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyWP66ms8z9t42\n\tfor ;\n\tThu, 21 Sep 2017 19:23:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751832AbdIUJXF (ORCPT );\n\tThu, 21 Sep 2017 05:23:05 -0400","from mail-qt0-f171.google.com ([209.85.216.171]:46048 \"EHLO\n\tmail-qt0-f171.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751724AbdIUJXD (ORCPT\n\t); Thu, 21 Sep 2017 05:23:03 -0400","by mail-qt0-f171.google.com with SMTP id t46so5295325qtj.2\n\tfor ; Thu, 21 Sep 2017 02:23:03 -0700 (PDT)","by 10.200.48.120 with HTTP; Thu, 21 Sep 2017 02:22:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mobile-devices.fr; s=google;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=c6X7dVqosB2yW1uzf9F6jergbkgC2nFFJvtWgvnJX/8=;\n\tb=ncVrtRfvzt/Nb31nIMMG1/rrAGcD6wNBfSNXVDyVklbWSXXY+VNcgCe9WDTbf7HyVO\n\tYjgKfRlX2cCITChs2aQ1H2LRMElumFJi2eY++1d1+wOpS17bPTkWBBXv/V9IH1bY5Q/t\n\tyxHJP6tSb8UM8zd6OVTkSicGp816nVCyTc+DU=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=c6X7dVqosB2yW1uzf9F6jergbkgC2nFFJvtWgvnJX/8=;\n\tb=XqO9p0rvrIPDSw/Q16GnZiVe9ISKsdmopYx5DhRpcOWGEZNgMARwZ+EOn9/2HHEtqM\n\tzUwMdqO8G1+WnTholBc5QIBAndgG9N+9bUwNaakTMbnH/C1oftH1ircAorxc0TPYXAB0\n\tbcohRfaUGwjRm0o0RxOTu/4TDGelp9kH658WNDkczLPNfHrxUwVAwXd2IXzhXQOlf/sF\n\tktgRwFlfYVP2F3R8gV08atrfPdcXjKpyl0iHi047gsuJIuaGxOFRpFbItx0AzI9lG+kx\n\tq7yI5o0WNviP5d768SwPlghIJS9hJ1iR6s9a9lG65g2tyJy89DgY/HZ2stuUQNOLNLcg\n\tac9Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=c6X7dVqosB2yW1uzf9F6jergbkgC2nFFJvtWgvnJX/8=;\n\tb=ueOXVtGcGnE+7hxlAZbrbHtgz7tZ2SHZ3qrhnvXMhVroI+EOF54POGotBJctjyuvGB\n\tR5r0QcuLY7VLDd6KYjWZxNV2/777mcafc9CmOLiXrSy82yX4K6ED3R1NXHMEh3xLk1J6\n\trgaYD8qRI5Gf6C92ebJ0/yh4YokbHvjqvDSs8emZc3Hl1ODXOHkq1IjV189yKxzZ8TFA\n\tVPUtLnIwslPOUkiMkfmbSxKblXlLnWyiRMUV+tl584xPOU4EuyvmXUFtA3+D81SOdez5\n\tXPgBs+eVi8NEqvsZSc6D0U+o/5zm2EeY5Bw07cUexqJx+d+w0rOvFMQN0oKBXliI24wF\n\tXGPQ==","X-Gm-Message-State":"AHPjjUi1D+EIam9nj/TayYqfRprpbU268ayeo1v8qEuCRKi8TmRhgRDr\n\t36fIjwcpXIxhFxXMhMSrINbTFPJuF9M80KFF3tKigg==","X-Google-Smtp-Source":"AOwi7QBa08wLJpC1KuwCqMB2ZOyG6KnMfw7GRokjfDY56VHJ68fKkoT+6AiAJfwwDilYqvgUyefAujgvanJKrGeN/PA=","X-Received":"by 10.237.62.79 with SMTP id m15mr2280325qtf.244.1505985782749; \n\tThu, 21 Sep 2017 02:23:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918120051.298bdabf@bbrezillon>","References":"<20170915140411.31716-1-romain.izard.pro@gmail.com>\n\t<20170915140411.31716-6-romain.izard.pro@gmail.com>\n\t<20170918120051.298bdabf@bbrezillon>","From":"Romain Izard ","Date":"Thu, 21 Sep 2017 11:22:42 +0200","X-Google-Sender-Auth":"duAPxT4kaog8s8NZhWo0-mJIgx0","Message-ID":"","Subject":"Re: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors","To":"Boris Brezillon ","Cc":"Nicolas Ferre ,\n\tAlexandre Belloni ,\n\tMichael Turquette ,\n\tStephen Boyd ,\n\tLudovic Desroches ,\n\tWenyou Yang , Josh Wu ,\n\tDavid Woodhouse ,\n\tBrian Norris ,\n\tMarek Vasut ,\n\tCyrille Pitchen ,\n\tThierry Reding ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tAlan Stern ,\n\tlinux-pwm@vger.kernel.org, linux-usb@vger.kernel.org,\n\tLKML ,\n\tlinux-mtd ,\n\tlinux-serial@vger.kernel.org, linux-clk@vger.kernel.org,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pwm@vger.kernel.org"}}]