[{"id":1769274,"web_url":"http://patchwork.ozlabs.org/comment/1769274/","msgid":"<20170915155044.e3jbkdbdbkaq7zun@ast-mbp>","list_archive_url":null,"date":"2017-09-15T15:50:46","subject":"Re: [PATCH net] bpf/verifier: reject BPF_ALU64|BPF_END","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Fri, Sep 15, 2017 at 02:37:38PM +0100, Edward Cree wrote:\n> Neither ___bpf_prog_run nor the JITs accept it.\n> Also adds a new test case.\n> \n> Fixes: 17a5267067f3 (\"bpf: verifier (add verifier core)\")\n> Signed-off-by: Edward Cree \n\nGood catch. Thanks!\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"o0th6jM5\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv0HG630nz9sPs\n\tfor ;\n\tSat, 16 Sep 2017 01:50:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751365AbdIOPuq (ORCPT );\n\tFri, 15 Sep 2017 11:50:46 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:37681 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751152AbdIOPup (ORCPT\n\t); Fri, 15 Sep 2017 11:50:45 -0400","by mail-pf0-f193.google.com with SMTP id e69so1405773pfg.4\n\tfor ; Fri, 15 Sep 2017 08:50:45 -0700 (PDT)","from ast-mbp ([2620:10d:c090:180::1:e750])\n\tby smtp.gmail.com with ESMTPSA id\n\tq28sm3311631pfj.77.2017.09.15.08.50.43\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 08:50:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=NhmIU29x77ZvrWHes/5RSlydIXCk0c1z5bfGtGoWauM=;\n\tb=o0th6jM5J/gFzJ0YT0uuq/iHIkhf7nuvv177eefcG/cq6ULZIs1oRyh6mdgcSaH5XW\n\tWZ8q/cGVnQzSdAdJ4D5LDCPVVMX9YzWxcVOpF8sVKwzWsIlQKd3FUQlGBlH8MUAfhQXr\n\t47tSIaxuy/Ic7ZGTsmtxcoKf65N0uZoQfj/9vUe8BCWFcLmthA4D9AmUJmSWwAqxLD4i\n\t79Kbgy5CMp9IIXDpaOfC9FNVLoeFGfu8BJA9XOexRhgquaBBX4cKHCsgB1diKFHYREzp\n\t4VPAqFxHs1kzZLTUZde07oo596SpYhSrilIJ9jYOUjnhBw5Fg6hDg90jRJLpqXNIeN2j\n\t+r6A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=NhmIU29x77ZvrWHes/5RSlydIXCk0c1z5bfGtGoWauM=;\n\tb=BPx/mPAgr5Uo6u6kVYAuO8xBzonSj7ferS+Qn5353JviTUr1XXGyXXbQJrgu2CZkXD\n\tt2L/2eEDea879bAF7vq6jspRm+wQSckCg6lMiOd8aL0JSSV8p1kc6rGhtwZXl7vesPl9\n\tRaeVG9L9E+Dc8qWk0QIUHdZOz9p74skF4pIKnSmr4XkIThvi569xcp9PGkM4Whjh0M6d\n\thus9M6TvoLq2HCj4jGGUrtHObSC1+QMaxLUFVvUFngw+BFIUkfCvdXVG8PBvMWM06d8F\n\ttNM2FK7JC3TGiWkkpEceWhY3redUYaI5Xjaj4EipIcy+5R4abvKMe74zQ9uL62gyZFPI\n\tPa2w==","X-Gm-Message-State":"AHPjjUhKoTqDgYA1xfp6oaeDykTxDNuFC2Jvrq2PrPrMl/Tt6dtvfAH4\n\txC61qGyoNNrz3E4152M=","X-Google-Smtp-Source":"ADKCNb6XIqFjdoj9azJ46FUGw731T7G++RB7Tj0fPFQ7lVecE7FCizMUwIRlQb4KTSj80p4XzCu1Fw==","X-Received":"by 10.98.57.129 with SMTP id u1mr24843764pfj.197.1505490644910; \n\tFri, 15 Sep 2017 08:50:44 -0700 (PDT)","Date":"Fri, 15 Sep 2017 08:50:46 -0700","From":"Alexei Starovoitov ","To":"Edward Cree ","Cc":"David Miller , netdev ,\n\tDaniel Borkmann ","Subject":"Re: [PATCH net] bpf/verifier: reject BPF_ALU64|BPF_END","Message-ID":"<20170915155044.e3jbkdbdbkaq7zun@ast-mbp>","References":"<8c3d5513-6171-3e68-56df-1efd0e87f071@solarflare.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<8c3d5513-6171-3e68-56df-1efd0e87f071@solarflare.com>","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769344,"web_url":"http://patchwork.ozlabs.org/comment/1769344/","msgid":"<59BC1597.20407@iogearbox.net>","list_archive_url":null,"date":"2017-09-15T18:01:59","subject":"Re: [PATCH net] bpf/verifier: reject BPF_ALU64|BPF_END","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/15/2017 03:37 PM, Edward Cree wrote:\n> Neither ___bpf_prog_run nor the JITs accept it.\n> Also adds a new test case.\n>\n> Fixes: 17a5267067f3 (\"bpf: verifier (add verifier core)\")\n> Signed-off-by: Edward Cree \n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv3Bp1Zg4z9sPs\n\tfor ;\n\tSat, 16 Sep 2017 04:02:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751785AbdIOSCH (ORCPT );\n\tFri, 15 Sep 2017 14:02:07 -0400","from www62.your-server.de ([213.133.104.62]:49563 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751773AbdIOSCG (ORCPT\n\t); Fri, 15 Sep 2017 14:02:06 -0400","from [12.145.98.253] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dsuwE-0007Ko-0v; Fri, 15 Sep 2017 20:02:02 +0200"],"Message-ID":"<59BC1597.20407@iogearbox.net>","Date":"Fri, 15 Sep 2017 20:01:59 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Edward Cree , David Miller ","CC":"netdev ","Subject":"Re: [PATCH net] bpf/verifier: reject BPF_ALU64|BPF_END","References":"<8c3d5513-6171-3e68-56df-1efd0e87f071@solarflare.com>","In-Reply-To":"<8c3d5513-6171-3e68-56df-1efd0e87f071@solarflare.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23836/Fri Sep 15 18:37:43 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769482,"web_url":"http://patchwork.ozlabs.org/comment/1769482/","msgid":"<20170915.150200.294158435331592497.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-15T22:02:00","subject":"Re: [PATCH net] bpf/verifier: reject BPF_ALU64|BPF_END","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Edward Cree \nDate: Fri, 15 Sep 2017 14:37:38 +0100\n\n> Neither ___bpf_prog_run nor the JITs accept it.\n> Also adds a new test case.\n> \n> Fixes: 17a5267067f3 (\"bpf: verifier (add verifier core)\")\n> Signed-off-by: Edward Cree \n\nApplied and queued up for -stable.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv8Wd2brWz9ryT\n\tfor ;\n\tSat, 16 Sep 2017 08:02:05 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751494AbdIOWCC (ORCPT );\n\tFri, 15 Sep 2017 18:02:02 -0400","from shards.monkeyblade.net ([184.105.139.130]:58124 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751213AbdIOWCB (ORCPT\n\t); Fri, 15 Sep 2017 18:02:01 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 52D45133F6436;\n\tFri, 15 Sep 2017 15:02:01 -0700 (PDT)"],"Date":"Fri, 15 Sep 2017 15:02:00 -0700 (PDT)","Message-Id":"<20170915.150200.294158435331592497.davem@davemloft.net>","To":"ecree@solarflare.com","Cc":"netdev@vger.kernel.org, daniel@iogearbox.net","Subject":"Re: [PATCH net] bpf/verifier: reject BPF_ALU64|BPF_END","From":"David Miller ","In-Reply-To":"<8c3d5513-6171-3e68-56df-1efd0e87f071@solarflare.com>","References":"<8c3d5513-6171-3e68-56df-1efd0e87f071@solarflare.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 15 Sep 2017 15:02:01 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]