[{"id":1769181,"web_url":"http://patchwork.ozlabs.org/comment/1769181/","msgid":"<53a49b18-5b56-d931-b6f1-15df77186dfc@redhat.com>","list_archive_url":null,"date":"2017-09-15T13:17:45","subject":"Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 15.09.2017 15:15, Greg Kurz wrote:\n> It never got used since its introduction (commit 7c43bca004af).\n> \n> Signed-off-by: Greg Kurz \n> ---\n> target/ppc/kvm.c | 5 -----\n> target/ppc/kvm_ppc.h | 6 ------\n> 2 files changed, 11 deletions(-)\n> \n> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\n> index 1deaf106d2b9..00d7029b8d7a 100644\n> --- a/target/ppc/kvm.c\n> +++ b/target/ppc/kvm.c\n> @@ -2448,11 +2448,6 @@ bool kvmppc_has_cap_epr(void)\n> return cap_epr;\n> }\n> \n> -bool kvmppc_has_cap_htab_fd(void)\n> -{\n> - return cap_htab_fd;\n> -}\n> -\n> bool kvmppc_has_cap_fixup_hcalls(void)\n> {\n> return cap_fixup_hcalls;\n> diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h\n> index f780e6ec7b72..08aab46c5a56 100644\n> --- a/target/ppc/kvm_ppc.h\n> +++ b/target/ppc/kvm_ppc.h\n> @@ -51,7 +51,6 @@ uint64_t kvmppc_rma_size(uint64_t current_size, unsigned int hash_shift);\n> #endif /* !CONFIG_USER_ONLY */\n> bool kvmppc_has_cap_epr(void);\n> int kvmppc_define_rtas_kernel_token(uint32_t token, const char *function);\n> -bool kvmppc_has_cap_htab_fd(void);\n> int kvmppc_get_htab_fd(bool write);\n> int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns);\n> int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index,\n> @@ -246,11 +245,6 @@ static inline int kvmppc_define_rtas_kernel_token(uint32_t token,\n> return -1;\n> }\n> \n> -static inline bool kvmppc_has_cap_htab_fd(void)\n> -{\n> - return false;\n> -}\n> -\n> static inline int kvmppc_get_htab_fd(bool write)\n> {\n> return -1;\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtx1K0l24z9sRm\n\tfor ;\n\tFri, 15 Sep 2017 23:23:33 +1000 (AEST)","from localhost ([::1]:53392 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsqah-0000qT-5p\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 09:23:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42803)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsqVG-0004vu-6x\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 09:17:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsqVC-0004jK-UQ\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 09:17:54 -0400","from mx1.redhat.com ([209.132.183.28]:52502)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsqVC-0004ix-OM; Fri, 15 Sep 2017 09:17:50 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E9DD55D687;\n\tFri, 15 Sep 2017 13:17:48 +0000 (UTC)","from [10.36.116.76] (ovpn-116-76.ams2.redhat.com [10.36.116.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 84BC562463;\n\tFri, 15 Sep 2017 13:17:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E9DD55D687","To":"Greg Kurz , qemu-devel@nongnu.org","References":"<150548133297.5945.7401220081077343726.stgit@bahia.lan>\n\t<150548135159.5945.17545667206379508322.stgit@bahia.lan>","From":"Thomas Huth ","Message-ID":"<53a49b18-5b56-d931-b6f1-15df77186dfc@redhat.com>","Date":"Fri, 15 Sep 2017 15:17:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<150548135159.5945.17545667206379508322.stgit@bahia.lan>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 15 Sep 2017 13:17:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , qemu-ppc@nongnu.org,\n\tDavid Gibson ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1769839,"web_url":"http://patchwork.ozlabs.org/comment/1769839/","msgid":"<20170918001126.GA15823@umbus>","list_archive_url":null,"date":"2017-09-18T00:11:26","subject":"Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Fri, Sep 15, 2017 at 03:15:51PM +0200, Greg Kurz wrote:\n> It never got used since its introduction (commit 7c43bca004af).\n> \n> Signed-off-by: Greg Kurz \n\nApplied to ppc-for-2.11, thanks.\n\n> ---\n> target/ppc/kvm.c | 5 -----\n> target/ppc/kvm_ppc.h | 6 ------\n> 2 files changed, 11 deletions(-)\n> \n> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c\n> index 1deaf106d2b9..00d7029b8d7a 100644\n> --- a/target/ppc/kvm.c\n> +++ b/target/ppc/kvm.c\n> @@ -2448,11 +2448,6 @@ bool kvmppc_has_cap_epr(void)\n> return cap_epr;\n> }\n> \n> -bool kvmppc_has_cap_htab_fd(void)\n> -{\n> - return cap_htab_fd;\n> -}\n> -\n> bool kvmppc_has_cap_fixup_hcalls(void)\n> {\n> return cap_fixup_hcalls;\n> diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h\n> index f780e6ec7b72..08aab46c5a56 100644\n> --- a/target/ppc/kvm_ppc.h\n> +++ b/target/ppc/kvm_ppc.h\n> @@ -51,7 +51,6 @@ uint64_t kvmppc_rma_size(uint64_t current_size, unsigned int hash_shift);\n> #endif /* !CONFIG_USER_ONLY */\n> bool kvmppc_has_cap_epr(void);\n> int kvmppc_define_rtas_kernel_token(uint32_t token, const char *function);\n> -bool kvmppc_has_cap_htab_fd(void);\n> int kvmppc_get_htab_fd(bool write);\n> int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns);\n> int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index,\n> @@ -246,11 +245,6 @@ static inline int kvmppc_define_rtas_kernel_token(uint32_t token,\n> return -1;\n> }\n> \n> -static inline bool kvmppc_has_cap_htab_fd(void)\n> -{\n> - return false;\n> -}\n> -\n> static inline int kvmppc_get_htab_fd(bool write)\n> {\n> return -1;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"h+XeN6jy\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwV3Q59RTz9sDB\n\tfor ;\n\tMon, 18 Sep 2017 12:15:46 +1000 (AEST)","from localhost ([::1]:34301 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtlb6-0000rK-Nm\n\tfor incoming@patchwork.ozlabs.org; Sun, 17 Sep 2017 22:15:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55182)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtlaV-0000o3-PP\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 22:15:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtlaU-0005GA-Is\n\tfor qemu-devel@nongnu.org; Sun, 17 Sep 2017 22:15:07 -0400","from ozlabs.org ([2401:3900:2:1::2]:57103)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtlaT-0005EX-Qo; Sun, 17 Sep 2017 22:15:06 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xwV2X0V8Qz9sBZ; Mon, 18 Sep 2017 12:14:59 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505700900;\n\tbh=Z2KonG1pKIdl6lRc5x48J/fLGXuTc3LAgbRuiPl0xGY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h+XeN6jykN/PtKiNqe7xOp43pXzzPyb3aSyOXgcS+G+KBV0yx9aHiso2aLuGQ3EzA\n\tks3ZSgD4KbXRSvHWziLbpUx0SlVRXwElpxVKMi0mzgwpV3xfj+LlNh2Q78MXOAInX9\n\tJ3qquP9Wo5Dyuf5xAgdeGLhnCSVUIrwt+TA5FvvY=","Date":"Mon, 18 Sep 2017 10:11:26 +1000","From":"David Gibson ","To":"Greg Kurz ","Message-ID":"<20170918001126.GA15823@umbus>","References":"<150548133297.5945.7401220081077343726.stgit@bahia.lan>\n\t<150548135159.5945.17545667206379508322.stgit@bahia.lan>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"HcAYCG3uE/tztfnV\"","Content-Disposition":"inline","In-Reply-To":"<150548135159.5945.17545667206379508322.stgit@bahia.lan>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Alexey Kardashevskiy , Thomas Huth ,\n\tqemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]