[{"id":1771552,"web_url":"http://patchwork.ozlabs.org/comment/1771552/","msgid":"<87d16mm1uj.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-20T04:27:16","subject":"Re: [Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Akshay Adiga writes:\n> p9_stop_api's are used to set SPR state on a core wakeup form a deeper\n> low power state. p9_stop_api uses low level platform formware and\n> self-restore microcode to restore the sprs to requested values.\n>\n> Code is taken from :\n> https://github.com/open-power/hostboot/tree/master/src/import/chips/p9/procedures/utils/stopreg\n\nSo, this introduces at least one warning from Coverity.\n\nCan you head to https://scan.coverity.com/projects/open-power-skiboot\nand sign up/request access so I can assign it to you?\n\nwe probably need to push the fixes upstream to hostboot too.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxmtY4KGrz9s82\n\tfor ;\n\tWed, 20 Sep 2017 14:27:33 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxmtY1GyVzDqTc\n\tfor ;\n\tWed, 20 Sep 2017 14:27:33 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxmtP2RmdzDqR8\n\tfor ; Wed, 20 Sep 2017 14:27:25 +1000 (AEST)","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8K4NxFd108838\n\tfor ; Wed, 20 Sep 2017 00:27:22 -0400","from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d3brrh8e5-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 20 Sep 2017 00:27:22 -0400","from localhost\n\tby e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 20 Sep 2017 00:27:22 -0400","from b01cxnp23034.gho.pok.ibm.com (9.57.198.29)\n\tby e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 20 Sep 2017 00:27:19 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8K4RJEK41549912; Wed, 20 Sep 2017 04:27:19 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2D52EAE03C;\n\tWed, 20 Sep 2017 00:27:50 -0400 (EDT)","from birb.localdomain (unknown [9.185.16.148])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id A2D0BAE03B;\n\tWed, 20 Sep 2017 00:27:49 -0400 (EDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid 1A1104F0F8F; Wed, 20 Sep 2017 14:27:16 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"Akshay Adiga , skiboot@lists.ozlabs.org","In-Reply-To":"<1505478062-1623-2-git-send-email-akshay.adiga@linux.vnet.ibm.com>","References":"<1505478062-1623-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<1505478062-1623-2-git-send-email-akshay.adiga@linux.vnet.ibm.com>","Date":"Wed, 20 Sep 2017 14:27:16 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17092004-2213-0000-0000-0000021E1C36","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007765; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000230; SDB=6.00919584; UDB=6.00462003;\n\tIPR=6.00699809; \n\tBA=6.00005598; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017217;\n\tXFM=3.00000015; UTC=2017-09-20 04:27:21","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092004-2214-0000-0000-0000579A7C30","Message-Id":"<87d16mm1uj.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-20_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709200060","Subject":"Re: [Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1771587,"web_url":"http://patchwork.ozlabs.org/comment/1771587/","msgid":"<20170920155404.16133ed2@firefly.ozlabs.ibm.com>","list_archive_url":null,"date":"2017-09-20T05:54:04","subject":"Re: [Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api","submitter":{"id":9347,"url":"http://patchwork.ozlabs.org/api/people/9347/","name":"Balbir Singh","email":"bsingharora@gmail.com"},"content":"On Wed, 20 Sep 2017 14:27:16 +1000\nStewart Smith wrote:\n\n> Akshay Adiga writes:\n> > p9_stop_api's are used to set SPR state on a core wakeup form a deeper\n> > low power state. p9_stop_api uses low level platform formware and\n> > self-restore microcode to restore the sprs to requested values.\n> >\n> > Code is taken from :\n> > https://github.com/open-power/hostboot/tree/master/src/import/chips/p9/procedures/utils/stopreg \n> \n> So, this introduces at least one warning from Coverity.\n> \n> Can you head to https://scan.coverity.com/projects/open-power-skiboot\n> and sign up/request access so I can assign it to you?\n> \n> we probably need to push the fixes upstream to hostboot too.\n\nThe warnings seem to indicate a condition can never be met,\nthey seem reasonable enough that we can remove some dead-code.\n\nBalbir Singh.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxppr5mJ4z9s81\n\tfor ;\n\tWed, 20 Sep 2017 15:54:28 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxppr4XsMzDqT0\n\tfor ;\n\tWed, 20 Sep 2017 15:54:28 +1000 (AEST)","from mail-pg0-x244.google.com (mail-pg0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c05::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxppk380fzDqBd\n\tfor ; Wed, 20 Sep 2017 15:54:21 +1000 (AEST)","by mail-pg0-x244.google.com with SMTP id v5so1092792pgn.4\n\tfor ; Tue, 19 Sep 2017 22:54:21 -0700 (PDT)","from firefly.ozlabs.ibm.com ([122.99.82.10])\n\tby smtp.gmail.com with ESMTPSA id\n\ta19sm5964793pfj.88.2017.09.19.22.54.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 22:54:19 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CCEi/PDN\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CCEi/PDN\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::244; helo=mail-pg0-x244.google.com;\n\tenvelope-from=bsingharora@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CCEi/PDN\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+V4JP5SjQdNjNO/g7Qi9MudKASxxy5cE7o7YAwUvPLQ=;\n\tb=CCEi/PDNojqF0BVZls9EDTBrwHKi8FFE37BymUVRB8z3r/bed2Odwz2sp0vPWGCBLH\n\tFQTEcNfGUaHq4Iitm6j+5NNadBYAahT7rTvnsEtpqUscRFG9LrNET31ekb4okh1+3xeH\n\tHchPrV07Oli0X88oRFHnLo88yAJFmJ4NyWaDHERGnxnEp3h3WaGlNW2tYdi31GvmT4vc\n\t7IbKofjHFCwEzeqmm4iwo727WjWjK/ulID53sSfK/HI2kXlmZtm2jFtFJmt3qeIOi+vt\n\tVpZQitVfAhyrjSYtVNcPNj78Tmlflnr/KYQJSJY8jRC+VIOiP7lq/2vDWJ+S3TuzHd5s\n\th1Lg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+V4JP5SjQdNjNO/g7Qi9MudKASxxy5cE7o7YAwUvPLQ=;\n\tb=CEBU1hvBwH7w7elge0ph00d5PysC2PElfToTI2KP0XwABSgjdk0fmzhFvylcp4jThP\n\t4E474mYnmxZTmj59/AxUXWSWMppKFWbRD3R65iZS4E+f8/QlxCMYaqnu7L86FU7XRYhK\n\tTtfZGPWpGGokgiSlR5h+XYzeo7CJtF19c31D8Y/eREfuD2kWBT3mSNlL6K0gDhDG8UE6\n\t/GDm5w5KxydHOGqGrzG47ZhLvzv0UwgGdHMAn9g0DA9ITpiF797Wfi6WchSDFq2IVv1Q\n\tTTuiE6URB0R3p49/LzwHjxZFoaDbU3yeKspboveHsQA0cbS3Mpw5HDjgFOUK5QubUbDn\n\t8fgQ==","X-Gm-Message-State":"AHPjjUguz1D8lrizNwDe7XKj4FexanaFo84bgsc4fVt1ih5UCEwzi7Jn\n\tq6iC14bM+JDK8RBEQWYYiPA=","X-Google-Smtp-Source":"AOwi7QBdfi9bNaDFsoFtXYW6cpvFyvBuPCJlIGymSKZjjTAyMCLf8UHMRyMqf/gbgGpXIhzeBsOcYA==","X-Received":"by 10.84.131.98 with SMTP id 89mr975974pld.256.1505886860045;\n\tTue, 19 Sep 2017 22:54:20 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:54:04 +1000","From":"Balbir Singh ","To":"Stewart Smith ","Message-ID":"<20170920155404.16133ed2@firefly.ozlabs.ibm.com>","In-Reply-To":"<87d16mm1uj.fsf@linux.vnet.ibm.com>","References":"<1505478062-1623-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<1505478062-1623-2-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<87d16mm1uj.fsf@linux.vnet.ibm.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Subject":"Re: [Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com,\n\tskiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1772626,"web_url":"http://patchwork.ozlabs.org/comment/1772626/","msgid":"<37af63cf-42f5-909b-52a8-3e814ef41b5f@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-21T09:47:51","subject":"Re: [Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api","submitter":{"id":68766,"url":"http://patchwork.ozlabs.org/api/people/68766/","name":"Akshay Adiga","email":"akshay.adiga@linux.vnet.ibm.com"},"content":"I have requested for access. Assign it to me. I will look at the problem.\nOn 09/20/2017 09:57 AM, Stewart Smith wrote:\n> Akshay Adiga writes:\n> > p9_stop_api's are used to set SPR state on a core wakeup form a deeper\n> > low power state. p9_stop_api uses low level platform formware and\n> > self-restore microcode to restore the sprs to requested values.\n> >\n> > Code is taken from :\n> > https://github.com/open-power/hostboot/tree/master/src/import/chips/p9/procedures/utils/stopreg\n>\n> So, this introduces at least one warning from Coverity.\n>\n> Can you head to https://scan.coverity.com/projects/open-power-skiboot\n> and sign up/request access so I can assign it to you?\n>\n> we probably need to push the fixes upstream to hostboot too.\n>\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyWy1690pz9s76\n\tfor ;\n\tThu, 21 Sep 2017 19:48:09 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xyWy14gVkzDr5S\n\tfor ;\n\tThu, 21 Sep 2017 19:48:09 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xyWxw39kSzDqT0\n\tfor ; Thu, 21 Sep 2017 19:48:03 +1000 (AEST)","from pps.filterd (m0098421.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8L9jL5l030029\n\tfor ; Thu, 21 Sep 2017 05:48:00 -0400","from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d4asgh3kv-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 21 Sep 2017 05:47:59 -0400","from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 21 Sep 2017 19:47:57 +1000","from d23relay08.au.ibm.com (202.81.31.227)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tThu, 21 Sep 2017 19:47:56 +1000","from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8L9ltXE39846140\n\tfor ; Thu, 21 Sep 2017 19:47:55 +1000","from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8L9ltRT030488\n\tfor ; Thu, 21 Sep 2017 19:47:56 +1000","from aksadiga.ibm (aksadiga.in.ibm.com [9.124.35.84])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8L9lq94030414; Thu, 21 Sep 2017 19:47:53 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=akshay.adiga@linux.vnet.ibm.com; receiver=)","From":"Akshay Adiga ","To":"Stewart Smith ","References":"<1505478062-1623-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<1505478062-1623-2-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<87d16mm1uj.fsf@linux.vnet.ibm.com>","Date":"Thu, 21 Sep 2017 15:17:51 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.4.0","MIME-Version":"1.0","In-Reply-To":"<87d16mm1uj.fsf@linux.vnet.ibm.com>","X-TM-AS-MML":"disable","x-cbid":"17092109-1617-0000-0000-0000020042C7","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092109-1618-0000-0000-0000484FACE3","Message-Id":"<37af63cf-42f5-909b-52a8-3e814ef41b5f@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-21_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=2\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709210133","Subject":"Re: [Skiboot] [PATCH v5 1/8] SLW: Add support for p9_stop_api","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com,\n\tskiboot@lists.ozlabs.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]