[{"id":1774356,"web_url":"http://patchwork.ozlabs.org/comment/1774356/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:12:19","subject":"Re: [U-Boot] [PATCH v6 08/10] fdtdec: sort include files","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Jean-Jacques,\n\nOn 15 September 2017 at 04:57, Jean-Jacques Hiblot wrote:\n> Sort include files in accordance to U-Boot coding style.\n>\n> Signed-off-by: Jean-Jacques Hiblot \n> ---\n> lib/fdtdec.c | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/lib/fdtdec.c b/lib/fdtdec.c\n> index 630e040..f26d2eb 100644\n> --- a/lib/fdtdec.c\n> +++ b/lib/fdtdec.c\n> @@ -4,16 +4,16 @@\n> */\n>\n> #ifndef USE_HOSTCC\n> -#include \n> #include \n> +#include \n> #include \n> +#include \n\nActually that should go at the end where it is now.\n\nSee:\n\nhttps://www.denx.de/wiki/U-Boot/CodingStyle\n\n> #include \n> -#include \n> -#include \n> -#include \n> #include \n> +#include \n> +#include \n> +#include \n> #include \n> -#include \n> #include \n>\n> DECLARE_GLOBAL_DATA_PTR;\n> --\n> 1.9.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"aJTdONqz\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AYer/lPY\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0p3v3yjmz9sRq\n\tfor ;\n\tMon, 25 Sep 2017 12:31:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 401DAC221C7; Mon, 25 Sep 2017 02:13:18 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 602B1C21EEE;\n\tMon, 25 Sep 2017 02:12:58 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 41EAAC22156; Mon, 25 Sep 2017 02:12:44 +0000 (UTC)","from mail-qt0-f178.google.com (mail-qt0-f178.google.com\n\t[209.85.216.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 3AF86C22180\n\tfor ; Mon, 25 Sep 2017 02:12:41 +0000 (UTC)","by mail-qt0-f178.google.com with SMTP id x54so5527895qth.12\n\tfor ; Sun, 24 Sep 2017 19:12:41 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:12:19 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Rn0Gq5onWxMaY7bn9mzEJx7CSFDRLwzqo5FIiJzu5/A=;\n\tb=aJTdONqzUQOkGVn7uZXnE80Uxf6XLIEUCj8p4cLN8VzT8CU8slhy9vsl/Z4q+Bo3G1\n\tJ0kfPOeSuVbrWhBzgDwhU90XuhwcsNeFnXENXh9+/SlqdRxp/vcAnxMCOtjfOtQgVCBC\n\tzM1/gl8HPlfCk1aV+t8mvYXu2+iE80A0fUoZXwIWi672JpWhgUmVAdxOmZvS9mQvxrsC\n\tUlI5n2qPfIooFMHWijqiRSzAN/jMYZbbm9JedpGTbCsOJf4Rtl0psBXbG15nTg2i8E6T\n\tUDFWAYtOMar7lzd+nEjeBFO/mFn4XrCei89srpsc/hH/jJJMqYzjEqpQOQAJXND5mvgZ\n\tq6sg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Rn0Gq5onWxMaY7bn9mzEJx7CSFDRLwzqo5FIiJzu5/A=;\n\tb=AYer/lPYnIRjn9r2718qHruOD+WXMO7LCcKti+i/qhC/eH800EEUKWOgkSmYk6TnTk\n\tZHuOAd9ze9iRU6XKX0nNfMwvm76qABav723DmOYp0z3MPGJAjled4/2FpZCIMG5hNRiA\n\tkdV64dFzpE9D+dGrC/4JRVIEPEogmyz3IK+N0="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Rn0Gq5onWxMaY7bn9mzEJx7CSFDRLwzqo5FIiJzu5/A=;\n\tb=OO4c9i6gWP6fLnSqYHQPu4D8pU3GTx/0prFBxvPy7fku0Ui2RqXIA3E0vXQEWsqNfM\n\tj9hnTf19DH/vhqC3Q0FLMtk4XC9/pUBuHEXy6fVE+gF0h8KYX1ogqlIOAU1kL8pH+quJ\n\t3pYFydwJWEQe7Z/g771KdeQFbBiYa/7Q1JuNWd3heVFj4UI8Aq8uuSS6bb9Z5ZLR2i8l\n\taKlQab65znVN1s9qdE5DTXot3ym//STjK33re8Z4SIiD12ZLap1vQdxUBaFD4Bhy7PE7\n\tdxqEqQ0LUKyvHNc/rBy2FDIDeXmywcWAtAjQ+Ezddj0a8sJgs8FE7BY+DKCrbWbOfcql\n\t3PPw==","X-Gm-Message-State":"AHPjjUiRGe9JrW4VXyEV9veOdXeS8vPeZihUWZi9lzr9qiVW0FZ0eLb6\n\tnVVZ6hiwYRrnSTZcSS6KDRtYWoX/sXDXC27Vx6k1qQ==","X-Google-Smtp-Source":"AOwi7QAQtAkWMmBpv8uPh+PrNT05AJ/Tw4EczCh3LiKs/eVxKDN42W6AVRmLk9JmmsX5xDQ3KbzetRZJtomgq+n3l2g=","X-Received":"by 10.200.23.252 with SMTP id r57mr9336819qtk.76.1506305560007; \n\tSun, 24 Sep 2017 19:12:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505473053-32520-9-git-send-email-jjhiblot@ti.com>","References":"<1505473053-32520-1-git-send-email-jjhiblot@ti.com>\n\t<1505473053-32520-9-git-send-email-jjhiblot@ti.com>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:12:19 -0400","X-Google-Sender-Auth":"tCykkj2V_8s4IK5CLq4J6wK0nP4","Message-ID":"","To":"Jean-Jacques Hiblot ","Cc":"Tom Rini , Franklin ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v6 08/10] fdtdec: sort include files","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1778206,"web_url":"http://patchwork.ozlabs.org/comment/1778206/","msgid":"<39460660-cded-b73e-9773-b2877b3a2ae5@ti.com>","list_archive_url":null,"date":"2017-10-02T08:50:10","subject":"Re: [U-Boot] [PATCH v6 08/10] fdtdec: sort include files","submitter":{"id":70508,"url":"http://patchwork.ozlabs.org/api/people/70508/","name":"Jean-Jacques Hiblot","email":"jjhiblot@ti.com"},"content":"Hi Simon,\n\n\nOn 25/09/2017 04:12, Simon Glass wrote:\n> Hi Jean-Jacques,\n>\n> On 15 September 2017 at 04:57, Jean-Jacques Hiblot wrote:\n>> Sort include files in accordance to U-Boot coding style.\n>>\n>> Signed-off-by: Jean-Jacques Hiblot \n>> ---\n>> lib/fdtdec.c | 10 +++++-----\n>> 1 file changed, 5 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c\n>> index 630e040..f26d2eb 100644\n>> --- a/lib/fdtdec.c\n>> +++ b/lib/fdtdec.c\n>> @@ -4,16 +4,16 @@\n>> */\n>>\n>> #ifndef USE_HOSTCC\n>> -#include \n>> #include \n>> +#include \n>> #include \n>> +#include \n> Actually that should go at the end where it is now.\n>\n> See:\n>\n> https://www.denx.de/wiki/U-Boot/CodingStyle\nWell I wasn't sure if dm/* should go at the end. I thought that maybe \nasm/*, arch/* and linux/* were 'special' cases. This impression was \nreinforced because in the example asm/* goes before arch/*, which does \nnot follow the alphabetical order.\nSo before I make the change in the patch, what would be the right place \nfor dm/of_extra.h ? just before #include ?\n\nThanks,\nJean-Jacques\n\n>\n>> #include \n>> -#include \n>> -#include \n>> -#include \n>> #include \n>> +#include \n>> +#include \n>> +#include \n>> #include \n>> -#include \n>> #include \n>>\n>> DECLARE_GLOBAL_DATA_PTR;\n>> --\n>> 1.9.1\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"MPoOQptP\";\n\tdkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5G8Q1mGNz9t4Z\n\tfor ;\n\tMon, 2 Oct 2017 19:50:28 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 7B3AAC21CA5; Mon, 2 Oct 2017 08:50:21 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E0ABAC21CA5;\n\tMon, 2 Oct 2017 08:50:18 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 42556C21CA5; Mon, 2 Oct 2017 08:50:17 +0000 (UTC)","from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77])\n\tby lists.denx.de (Postfix) with ESMTPS id 87811C21C41\n\tfor ; Mon, 2 Oct 2017 08:50:16 +0000 (UTC)","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v928oCes008558; \n\tMon, 2 Oct 2017 03:50:12 -0500","from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v928oC32030025; \n\tMon, 2 Oct 2017 03:50:12 -0500","from DLEE112.ent.ti.com (157.170.170.23) by DLEE101.ent.ti.com\n\t(157.170.170.31) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 2 Oct 2017 03:50:12 -0500","from dlep33.itg.ti.com (157.170.170.75) by DLEE112.ent.ti.com\n\t(157.170.170.23) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 2 Oct 2017 03:50:12 -0500","from [172.22.129.181] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v928oBSN024442;\n\tMon, 2 Oct 2017 03:50:11 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1506934212;\n\tbh=04krjyxZ38fDVFkSIVqWh6PSQ+ZtUpa8XhyzEV2Y/ws=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=MPoOQptP+YLXeiIvOi3uB5eL7zJ2nFdw6062AzkN9ooWHwSr+Ewj8buaAuPsX0Fut\n\tJGrxJBLFf0veDGccGWL2c3PiYJjyPe+1u86yk6PeA9LpRHsl9RKD555hT1PLRmm9Kk\n\t41pbRGqCk+2s5/mPrUZALEgIOjE8ML3ztLYr3MhA=","To":"Simon Glass ","References":"<1505473053-32520-1-git-send-email-jjhiblot@ti.com>\n\t<1505473053-32520-9-git-send-email-jjhiblot@ti.com>\n\t","From":"Jean-Jacques Hiblot ","Message-ID":"<39460660-cded-b73e-9773-b2877b3a2ae5@ti.com>","Date":"Mon, 2 Oct 2017 10:50:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Cc":"Tom Rini , Franklin ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v6 08/10] fdtdec: sort include files","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1782130,"web_url":"http://patchwork.ozlabs.org/comment/1782130/","msgid":"<20171007130721.GL25966@bill-the-cat>","list_archive_url":null,"date":"2017-10-07T13:07:21","subject":"Re: [U-Boot] [U-Boot,v6,08/10] fdtdec: sort include files","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Sep 15, 2017 at 12:57:31PM +0200, Jean-Jacques Hiblot wrote:\n\n> Sort include files in accordance to U-Boot coding style.\n> \n> Signed-off-by: Jean-Jacques Hiblot \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"FEfiMX3/\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y8Ryq0bBnz9t6Z\n\tfor ;\n\tSun, 8 Oct 2017 00:23:15 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid CB3EDC21E79; Sat, 7 Oct 2017 13:16:07 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 0845EC21EA8;\n\tSat, 7 Oct 2017 13:11:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid A295DC21E6F; Sat, 7 Oct 2017 13:07:29 +0000 (UTC)","from mail-qt0-f180.google.com (mail-qt0-f180.google.com\n\t[209.85.216.180])\n\tby lists.denx.de (Postfix) with ESMTPS id EB157C21E76\n\tfor ; Sat, 7 Oct 2017 13:07:24 +0000 (UTC)","by mail-qt0-f180.google.com with SMTP id k31so625822qta.6\n\tfor ; Sat, 07 Oct 2017 06:07:24 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:6821:3a00:ff9f:889e])\n\tby smtp.gmail.com with ESMTPSA id\n\tc17sm226547ywk.103.2017.10.07.06.07.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 07 Oct 2017 06:07:23 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=rp/jIl6SBKHROzAyGdXqBNBc+NAOidq+NsKhaXkP+eQ=;\n\tb=FEfiMX3/GPW96YeBxZKShRKM/12Zw7RTtnUVSX0U1hYkAXZhtysfAXV7H6VUWLXYP5\n\tFXrfT/4aU6muYXxs494GI6VSXzQbL3CitSy7LZ5hp7PmTGDoVfdTGBLyHRLXVPIfYMMh\n\tuZox7Od41j1YhxG/5ZKDfAlMGm8+lZyFaoSBA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=rp/jIl6SBKHROzAyGdXqBNBc+NAOidq+NsKhaXkP+eQ=;\n\tb=h0S6RdRdF1LcwoCrn/BefgG5SiIhPLvQX+3mXONXxUDagfFadFkueEUAvj+k9WXCwK\n\ty7znkj15aV6LG0X19hLD5UlXx8E4NJS2TCUXnG402IfSqVrA4ZbzeMMYtWSdpmxlqGm2\n\t3DMam6AFv1t3zIqeNUIE6TwYYsjcf/YQZSe+ZTAiqC1rs7MPIvwDu3pC8Xh110Pg5dVU\n\tLxa86EriTE0LVRabJBwtcz6W2gP09JCMvb1WcCXEttjk+bsMWj5XL3D4ZYz9MGUaPZFO\n\t2O09Zc5PaQr/78mau3u+om8R/HZ+YmviP9DtZQIHSOxbzLqrekAnLz2gfreAI+UW6KjI\n\thf6A==","X-Gm-Message-State":"AMCzsaWr/BLCz4rJ3JjLJrOEHvSNPo69Hrsn/5QeeT8lGt4184B062kT\n\tmIeucVJ/E0/QpCcvgG/ZcT6G7A==","X-Google-Smtp-Source":"AOwi7QCQNbhRr5j7kS1T1V5IUpN3SkDWS5NMqJxm7/SP9xIKxt4RD8NpSzZzaOpRb6jHRodpgCUoMQ==","X-Received":"by 10.37.48.67 with SMTP id w64mr4031336ybw.296.1507381643912;\n\tSat, 07 Oct 2017 06:07:23 -0700 (PDT)","Date":"Sat, 7 Oct 2017 09:07:21 -0400","From":"Tom Rini ","To":"Jean-Jacques Hiblot ","Message-ID":"<20171007130721.GL25966@bill-the-cat>","References":"<1505473053-32520-9-git-send-email-jjhiblot@ti.com>","MIME-Version":"1.0","In-Reply-To":"<1505473053-32520-9-git-send-email-jjhiblot@ti.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Cc":"u-boot@lists.denx.de, fcooper@ti.com","Subject":"Re: [U-Boot] [U-Boot,v6,08/10] fdtdec: sort include files","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8134793877109636992==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]