[{"id":1769097,"web_url":"http://patchwork.ozlabs.org/comment/1769097/","msgid":"<ec1f4dd5-a3e7-5b1d-adf0-eaee60db7dfe@canonical.com>","list_archive_url":null,"date":"2017-09-15T10:15:23","subject":"ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to detect\n\twhen to use esm ppa","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 15.09.2017 11:37, Po-Hsu Lin wrote:\n> Both Precise and Trusty HWE kernel are running on series Precise.\n> Use this as a better criteria, since the old if statement does not\n> work for Precise kernel, there is no package called precise.\n> \n> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>\nAcked-by: Stefan Bader <stefan.bader@canonical.com>\n\n> ---\n\nIt sounds sensible. Personally it would help me to have a quick explanation\nabout how this breaks things.\n\nThanks,\nStefan\n\n>  stable/wfl/bug.py | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/stable/wfl/bug.py b/stable/wfl/bug.py\n> index 632cbc05..f897a139 100644\n> --- a/stable/wfl/bug.py\n> +++ b/stable/wfl/bug.py\n> @@ -847,12 +847,12 @@ class WorkflowBug():\n>  \n>          if ppa:\n>              msg['pocket'] = 'ppa'\n> -            if s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n> +            if s.series in ['precise']:\n>                  msg['ppa'] = 'ppa:canonical-kernel-esm/ppa'\n>              else:\n>                  msg['ppa'] = 'ppa:canonical-kernel-team/ppa'\n>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n> -        elif s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n> +        elif s.series in ['precise']:\n>              msg['pocket'] = 'ppa'\n>              msg['ppa']    = 'ppa:canonical-kernel-esm/proposed'\n>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n>","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtrrJ71T8z9sxR;\n\tFri, 15 Sep 2017 20:15:28 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1dsnef-0000Fj-AN; Fri, 15 Sep 2017 10:15:25 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <stefan.bader@canonical.com>)\n\tid 1dsned-0000FT-SM\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 10:15:23 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <stefan.bader@canonical.com>)\n\tid 1dsned-0004w9-K8\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 10:15:23 +0000"],"Subject":"ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to detect\n\twhen to use esm ppa","To":"kernel-team@lists.ubuntu.com","References":"<20170915093704.4714-1-po-hsu.lin@canonical.com>","From":"Stefan Bader <stefan.bader@canonical.com>","Message-ID":"<ec1f4dd5-a3e7-5b1d-adf0-eaee60db7dfe@canonical.com>","Date":"Fri, 15 Sep 2017 12:15:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170915093704.4714-1-po-hsu.lin@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Content-Type":"multipart/mixed;\n\tboundary=\"===============7457962611324777210==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}},{"id":1769101,"web_url":"http://patchwork.ozlabs.org/comment/1769101/","msgid":"<CAMy_GT8q7DxjzFQmTrFGZpxN291mDdssUCD9vROe9CvgfFRn9Q@mail.gmail.com>","list_archive_url":null,"date":"2017-09-15T10:23:30","subject":"Re: ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to\n\tdetect when to use esm ppa","submitter":{"id":70488,"url":"http://patchwork.ozlabs.org/api/people/70488/","name":"Po-Hsu Lin","email":"po-hsu.lin@canonical.com"},"content":"On Fri, Sep 15, 2017 at 6:15 PM, Stefan Bader\n<stefan.bader@canonical.com> wrote:\n> On 15.09.2017 11:37, Po-Hsu Lin wrote:\n>> Both Precise and Trusty HWE kernel are running on series Precise.\n>> Use this as a better criteria, since the old if statement does not\n>> work for Precise kernel, there is no package called precise.\n>>\n>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>\n> Acked-by: Stefan Bader <stefan.bader@canonical.com>\n>\n>> ---\n>\n> It sounds sensible. Personally it would help me to have a quick explanation\n> about how this breaks things.\n\nFor T-hwe, the old method is good as the package name is\n'linux-lts-trusty', but for Precise, the package name is 'linux'.\nSo I guess it's a typo for s.pkg_name in ['precise'] here, which\nshould be s.series in ['precise']\n\nAnd this can be trimmed down to just check the series. As they both\nrun on Precise.\n\n>\n> Thanks,\n> Stefan\n>\n>>  stable/wfl/bug.py | 4 ++--\n>>  1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/stable/wfl/bug.py b/stable/wfl/bug.py\n>> index 632cbc05..f897a139 100644\n>> --- a/stable/wfl/bug.py\n>> +++ b/stable/wfl/bug.py\n>> @@ -847,12 +847,12 @@ class WorkflowBug():\n>>\n>>          if ppa:\n>>              msg['pocket'] = 'ppa'\n>> -            if s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n>> +            if s.series in ['precise']:\n>>                  msg['ppa'] = 'ppa:canonical-kernel-esm/ppa'\n>>              else:\n>>                  msg['ppa'] = 'ppa:canonical-kernel-team/ppa'\n>>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n>> -        elif s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n>> +        elif s.series in ['precise']:\n>>              msg['pocket'] = 'ppa'\n>>              msg['ppa']    = 'ppa:canonical-kernel-esm/proposed'\n>>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n>>\n>\n>\n>\n> --\n> kernel-team mailing list\n> kernel-team@lists.ubuntu.com\n> https://lists.ubuntu.com/mailman/listinfo/kernel-team\n>","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xts1m0FKLz9t2V;\n\tFri, 15 Sep 2017 20:23:39 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1dsnmY-00016R-2U; Fri, 15 Sep 2017 10:23:34 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <po-hsu.lin@canonical.com>)\n\tid 1dsnmW-000168-LL\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 10:23:32 +0000","from mail-pg0-f72.google.com ([74.125.83.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <po-hsu.lin@canonical.com>)\n\tid 1dsnmW-00058o-9z\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 10:23:32 +0000","by mail-pg0-f72.google.com with SMTP id v82so4076418pgb.5\n\tfor <kernel-team@lists.ubuntu.com>;\n\tFri, 15 Sep 2017 03:23:32 -0700 (PDT)","by 10.100.151.129 with HTTP; Fri, 15 Sep 2017 03:23:30 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=zgB6loWw6fXQDFFmtku6hyDgnVeaFVWeqHJ9suSoKq0=;\n\tb=dp7aQm+iqv3WGT6P258Y2/xASaNab2FbHfZ3HYGni3VC7uiHUSy1uQEQPuapOCWAdr\n\t/xyakzhH8hov3vQH5DWwrSwgsYDGLb3bMrGNJa65C8ISwnrjjMBsib5qboIqcdbmf/Zy\n\tdx2hg7n1meCx3EXRf2gQ+iB7AZcI+dedIQAI+j09RvdbuSs+KX7eCPol8Yf9tlQqcOiE\n\tCrMEWhEw/kcuqS3mstc4qmVgqz1uko4s6C5rDv/Pe6YF2w9zvwbk5bT6jGS18jZEgO85\n\tu+RuS1mv/zfOE0YrM7U0n9wmqhkJ595EZ5YMtnNLkfrEj+YgcQXq9ip7i03e+L9Rv7Uc\n\t5pmA==","X-Gm-Message-State":"AHPjjUhAf5PCRoP3zn52rRczos5+5vn00j93o0u3mNBPf5byuBFAgK5Y\n\ttkz0oEyATglfoKCeIDCE0mh1mV16jWlOa0bWNQxUK9vvuUFDOXjrdLMKpUOEJaYAMOzHb54SiI/\n\tPQBk2h3vXNmjwcZ42I8RJ3YckUYTu6vs+ZNJFL/WR02VDTQpB1FKe8dNc","X-Received":["by 10.84.193.131 with SMTP id f3mr2960632pld.90.1505471011073;\n\tFri, 15 Sep 2017 03:23:31 -0700 (PDT)","by 10.84.193.131 with SMTP id f3mr2960621pld.90.1505471010863;\n\tFri, 15 Sep 2017 03:23:30 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QC4B8eFWi34yRn0tNzTTExHBA2f8bj8AIPXP7yBDaOhoKML4BfG3VACYENHWF4h8zZiXz8PO7PDeAbGiECjw54=","MIME-Version":"1.0","In-Reply-To":"<ec1f4dd5-a3e7-5b1d-adf0-eaee60db7dfe@canonical.com>","References":"<20170915093704.4714-1-po-hsu.lin@canonical.com>\n\t<ec1f4dd5-a3e7-5b1d-adf0-eaee60db7dfe@canonical.com>","From":"\"Po-Hsu Lin (Sam)\" <po-hsu.lin@canonical.com>","Date":"Fri, 15 Sep 2017 18:23:30 +0800","Message-ID":"<CAMy_GT8q7DxjzFQmTrFGZpxN291mDdssUCD9vROe9CvgfFRn9Q@mail.gmail.com>","Subject":"Re: ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to\n\tdetect when to use esm ppa","To":"Stefan Bader <stefan.bader@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Cc":"Kernel team list <kernel-team@lists.ubuntu.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}},{"id":1770716,"web_url":"http://patchwork.ozlabs.org/comment/1770716/","msgid":"<CAMy_GT-WEGEyxR+tBr2o8PYiN0tcOhAy4bA2pj3bqUofsCtGNw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-19T07:55:47","subject":"Re: ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to\n\tdetect when to use esm ppa","submitter":{"id":70488,"url":"http://patchwork.ozlabs.org/api/people/70488/","name":"Po-Hsu Lin","email":"po-hsu.lin@canonical.com"},"content":"On Fri, Sep 15, 2017 at 8:16 PM, Stefan Bader\n<stefan.bader@canonical.com> wrote:\n> On 15.09.2017 12:23, Po-Hsu Lin (Sam) wrote:\n>> On Fri, Sep 15, 2017 at 6:15 PM, Stefan Bader\n>> <stefan.bader@canonical.com> wrote:\n>>> On 15.09.2017 11:37, Po-Hsu Lin wrote:\n>>>> Both Precise and Trusty HWE kernel are running on series Precise.\n>>>> Use this as a better criteria, since the old if statement does not\n>>>> work for Precise kernel, there is no package called precise.\n>>>>\n>>>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>\n>>> Acked-by: Stefan Bader <stefan.bader@canonical.com>\n>>>\n>>>> ---\n>>>\n>>> It sounds sensible. Personally it would help me to have a quick explanation\n>>> about how this breaks things.\n>>\n>> For T-hwe, the old method is good as the package name is\n>> 'linux-lts-trusty', but for Precise, the package name is 'linux'.\n>> So I guess it's a typo for s.pkg_name in ['precise'] here, which\n>> should be s.series in ['precise']\n>>\n>> And this can be trimmed down to just check the series. As they both\n>> run on Precise.\n>\n> Sorry I was not very clear here. I understand the fix within the range that the\n> patch shows. What I am not understanding because I did not yet look more deeply\n> into all of the connections is what the high level effect would be. Its wfl, so\n> I assume something that shankbot does. Though I believe the parts which move\n> status after upload and to ask for copies were ok. So maybe handling some of the\n> testing states? All?\n>\n> So just to help me (or any other person that looks at a patch but maybe is not\n> to deep into the background story) I think it help to know what was the reason\n> to start looking for a fix in the first place.\n>\n> -Stefan\nDiscussed with Stefan on the IRC, but just in case someone else is\ncurious about it:\n\nThe reason why we need this is because we have updated the Precise ESM\nkernel in the last SRU cycle due to the embargoed CVE. And this bug is\npreventing our SUTs in Precise test pool to get the correct kernel to\ntest from the ppa. This patch is expected to fix this issue.\n\nThanks!\nSam\n\n>>\n>>>\n>>> Thanks,\n>>> Stefan\n>>>\n>>>>  stable/wfl/bug.py | 4 ++--\n>>>>  1 file changed, 2 insertions(+), 2 deletions(-)\n>>>>\n>>>> diff --git a/stable/wfl/bug.py b/stable/wfl/bug.py\n>>>> index 632cbc05..f897a139 100644\n>>>> --- a/stable/wfl/bug.py\n>>>> +++ b/stable/wfl/bug.py\n>>>> @@ -847,12 +847,12 @@ class WorkflowBug():\n>>>>\n>>>>          if ppa:\n>>>>              msg['pocket'] = 'ppa'\n>>>> -            if s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n>>>> +            if s.series in ['precise']:\n>>>>                  msg['ppa'] = 'ppa:canonical-kernel-esm/ppa'\n>>>>              else:\n>>>>                  msg['ppa'] = 'ppa:canonical-kernel-team/ppa'\n>>>>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n>>>> -        elif s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n>>>> +        elif s.series in ['precise']:\n>>>>              msg['pocket'] = 'ppa'\n>>>>              msg['ppa']    = 'ppa:canonical-kernel-esm/proposed'\n>>>>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n>>>>\n>>>\n>>>\n>>>\n>>> --\n>>> kernel-team mailing list\n>>> kernel-team@lists.ubuntu.com\n>>> https://lists.ubuntu.com/mailman/listinfo/kernel-team\n>>>\n>\n>","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxFYY0dz0z9s82;\n\tTue, 19 Sep 2017 17:56:01 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1duDNo-0002e4-62; Tue, 19 Sep 2017 07:55:52 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <po-hsu.lin@canonical.com>)\n\tid 1duDNm-0002d1-AE\n\tfor kernel-team@lists.ubuntu.com; Tue, 19 Sep 2017 07:55:50 +0000","from mail-pg0-f72.google.com ([74.125.83.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <po-hsu.lin@canonical.com>)\n\tid 1duDNl-0004Zf-Uj\n\tfor kernel-team@lists.ubuntu.com; Tue, 19 Sep 2017 07:55:50 +0000","by mail-pg0-f72.google.com with SMTP id 6so5186465pgh.0\n\tfor <kernel-team@lists.ubuntu.com>;\n\tTue, 19 Sep 2017 00:55:49 -0700 (PDT)","by 10.100.151.129 with HTTP; Tue, 19 Sep 2017 00:55:47 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to;\n\tbh=tFJ5L6QKE/u5OdWnC3tPWH6sWqOjeSTgwCuGlnP22iM=;\n\tb=D2lS5++99nNk8uScdd3M6s7RYTNnmI/QremBWkxkfOl4acbI703I49wJVizBE0EhyN\n\tddVlo3Np+eSP+yow8i/V3qdFLN3Sde53N8cE7lVdOT5hxujymiHOuOb/loZ8ME4Q9qAn\n\t0q4+8CsOA+TX0P8DaVi3itTeIpQoDNv/tWFvDmCw6UAWJHtK1ZXI7W3FJHi1aQEBfz1s\n\t+CVuoAeJJrT8mpPuiWVr3tgleYoVgGgN1c7e/jQ6S1KzpAXQ130zP1rA0EynxOSOYHyL\n\t31OU56xkrjcgrko0yRrspRyRGfk19kZje4/rf+mdqKgzMQttSehLraoM3Zp8IMSaNor5\n\t5tBA==","X-Gm-Message-State":"AHPjjUhW+4DSBxNtE5/Oi1PEKZAluzCoaJu+28c4UuJQ5ES6P9qCj8Vg\n\tSfR1OQiJpyBc75K0if56H6dQLiSpU5pa2kaKL2VL8sv+aVKRgPhlEoKYXfbJbt0LKsmfIrJc7j4\n\tnoNyt6xviwrl8zudufe5Lh4/liH7t/aeFAKznxcvsWpZYIXTsuZsy/70h","X-Received":["by 10.99.154.82 with SMTP id e18mr526893pgo.211.1505807748680;\n\tTue, 19 Sep 2017 00:55:48 -0700 (PDT)","by 10.99.154.82 with SMTP id e18mr526881pgo.211.1505807748353;\n\tTue, 19 Sep 2017 00:55:48 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QD9bW34ZXyWecr45ZC/vRhrcldkKbg8H0NaBZnwyE8fTX+qcYRu+OkxEggfDA40qDHThg61KPtSEYYn+eoayWs=","MIME-Version":"1.0","In-Reply-To":"<44a0e5df-8827-c59d-e1ba-a1df910fd436@canonical.com>","References":"<20170915093704.4714-1-po-hsu.lin@canonical.com>\n\t<ec1f4dd5-a3e7-5b1d-adf0-eaee60db7dfe@canonical.com>\n\t<CAMy_GT8q7DxjzFQmTrFGZpxN291mDdssUCD9vROe9CvgfFRn9Q@mail.gmail.com>\n\t<44a0e5df-8827-c59d-e1ba-a1df910fd436@canonical.com>","From":"\"Po-Hsu Lin (Sam)\" <po-hsu.lin@canonical.com>","Date":"Tue, 19 Sep 2017 15:55:47 +0800","Message-ID":"<CAMy_GT-WEGEyxR+tBr2o8PYiN0tcOhAy4bA2pj3bqUofsCtGNw@mail.gmail.com>","Subject":"Re: ACK/cmnt: [kteam-tools][PATCH] wfl/bug.py: change the way to\n\tdetect when to use esm ppa","To":"Stefan Bader <stefan.bader@canonical.com>, \n\tKernel team list <kernel-team@lists.ubuntu.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}},{"id":1770884,"web_url":"http://patchwork.ozlabs.org/comment/1770884/","msgid":"<20170919111736.dkf76gvp2rbwwiio@brain>","list_archive_url":null,"date":"2017-09-19T11:17:36","subject":"[Acked] [kteam-tools][PATCH] wfl/bug.py: change the way to detect\n\twhen to use esm ppa","submitter":{"id":1457,"url":"http://patchwork.ozlabs.org/api/people/1457/","name":"Andy Whitcroft","email":"apw@canonical.com"},"content":"On Fri, Sep 15, 2017 at 05:37:04PM +0800, Po-Hsu Lin wrote:\n> Both Precise and Trusty HWE kernel are running on series Precise.\n> Use this as a better criteria, since the old if statement does not\n> work for Precise kernel, there is no package called precise.\n> \n> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>\n> ---\n>  stable/wfl/bug.py | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/stable/wfl/bug.py b/stable/wfl/bug.py\n> index 632cbc05..f897a139 100644\n> --- a/stable/wfl/bug.py\n> +++ b/stable/wfl/bug.py\n> @@ -847,12 +847,12 @@ class WorkflowBug():\n>  \n>          if ppa:\n>              msg['pocket'] = 'ppa'\n> -            if s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n> +            if s.series in ['precise']:\n>                  msg['ppa'] = 'ppa:canonical-kernel-esm/ppa'\n>              else:\n>                  msg['ppa'] = 'ppa:canonical-kernel-team/ppa'\n>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n> -        elif s.pkg_name in ['linux-lts-trusty'] or s.pkg_name in ['precise']:\n> +        elif s.series in ['precise']:\n>              msg['pocket'] = 'ppa'\n>              msg['ppa']    = 'ppa:canonical-kernel-esm/proposed'\n>              msg['key']    = 'kernel.published.ppa.%s' % s.series\n> -- \n\nOh dear ... that is a proper brown paper bag jobbie isn't it.  Looks\nmuch saner.  I suspect this should have been originally:\n\n    if  s.pkg_name in ['linux-lts-trusty'] or s.series in ['precise']:\n\nAnd that because s.series used to be trusty for that linux-lts-trusty\nbecause our code was a bit mad.  Anyhow, it was clearly broken before,\nand likely better with this change.\n\nAcked-by: Andy Whitcroft <apw@canonical.com>\n\n-apw","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxL2L2mLgz9sBZ;\n\tTue, 19 Sep 2017 21:17:46 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1duGX4-0008VM-HB; Tue, 19 Sep 2017 11:17:38 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <apw@canonical.com>) id 1duGX3-0008TY-3r\n\tfor kernel-team@lists.ubuntu.com; Tue, 19 Sep 2017 11:17:37 +0000","from 1.general.apw.uk.vpn ([10.172.192.78] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.76) (envelope-from <apw@canonical.com>)\n\tid 1duGX2-0006dc-Re; Tue, 19 Sep 2017 11:17:36 +0000"],"Date":"Tue, 19 Sep 2017 12:17:36 +0100","From":"Andy Whitcroft <apw@canonical.com>","To":"Po-Hsu Lin <po-hsu.lin@canonical.com>","Subject":"[Acked] [kteam-tools][PATCH] wfl/bug.py: change the way to detect\n\twhen to use esm ppa","Message-ID":"<20170919111736.dkf76gvp2rbwwiio@brain>","References":"<20170915093704.4714-1-po-hsu.lin@canonical.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170915093704.4714-1-po-hsu.lin@canonical.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}},{"id":1783621,"web_url":"http://patchwork.ozlabs.org/comment/1783621/","msgid":"<9b0598ed-f08e-4127-e907-495077710ccd@canonical.com>","list_archive_url":null,"date":"2017-10-10T10:58:31","subject":"APPLIED: [kteam-tools][PATCH] wfl/bug.py: change the way to detect\n\twhen to use esm ppa","submitter":{"id":71419,"url":"http://patchwork.ozlabs.org/api/people/71419/","name":"Kleber Sacilotto de Souza","email":"kleber.souza@canonical.com"},"content":"Applied to kteam-tools/master branch. Thanks.","headers":{"Return-Path":"<kernel-team-bounces@lists.ubuntu.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=<UNKNOWN>)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3yBDcl1hbVz9tY0;\n\tTue, 10 Oct 2017 21:58:47 +1100 (AEDT)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from <kernel-team-bounces@lists.ubuntu.com>)\n\tid 1e1sFA-0001um-Nl; Tue, 10 Oct 2017 10:58:36 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from <kleber.souza@canonical.com>)\n\tid 1e1sF9-0001uG-8t\n\tfor kernel-team@lists.ubuntu.com; Tue, 10 Oct 2017 10:58:35 +0000","from mail-wm0-f70.google.com ([74.125.82.70])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <kleber.souza@canonical.com>)\n\tid 1e1sF9-0004Da-1e\n\tfor kernel-team@lists.ubuntu.com; Tue, 10 Oct 2017 10:58:35 +0000","by mail-wm0-f70.google.com with SMTP id u78so33469488wmd.4\n\tfor <kernel-team@lists.ubuntu.com>;\n\tTue, 10 Oct 2017 03:58:35 -0700 (PDT)","from ?IPv6:2a02:8109:a540:7e8:2414:1dff:26fb:d463?\n\t([2a02:8109:a540:7e8:2414:1dff:26fb:d463])\n\tby smtp.gmail.com with ESMTPSA id\n\tm19sm8396903wmd.16.2017.10.10.03.58.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 10 Oct 2017 03:58:33 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=TVmqng9H26uJUXbZ13m9BUiu7SiYqtnwpIDkw5OlQ2k=;\n\tb=kC90FSsIwy3PNsi1OnkPpJzCkaDENATMTJ3180ymdUwt6ngSSghsImLn4UWuye+6GB\n\t30hm64+jbvotDt8A5mVCS/oBTRuJhTVClBzJ0Snvs27Y7mWOvwMzgaQcLdu4LV4Sfpv+\n\t1LVEukWYEJ0GsJMRn5F7VHtikeRG2t9Fx7lwOSk2pTzHjAd1YqCsq7IlSn/gCHsTK2al\n\tfBbWXDr+YoJAO7uEijcO4yVMRvGkuvpPbK8Lb4irJSlm2roRFj7c+iNKuHJmqB/MDT8q\n\tx/DcIaN8tE5z8qi7RbRzdupm0cKaCvYN3FC4cGKT2cLJ3+muuVmGbPKpbfv9/Y4vusxK\n\tsnCw==","X-Gm-Message-State":"AMCzsaWuTXTR3jKigErrIaDkuEpSTZtbHe6KUW5CGPTgQmuFWitgxQId\n\t+Df5iMDAnjU/fNXTfG1ng4rP9CAZm8y/Q3SFsviAKqt5UtljX7I/RI5L3JBcUOYFRcRR6aYDn9Q\n\txqOftVsoyBrq+gu9pk3LMNrnQrPhiGv+70Eegr+D/5w==","X-Received":["by 10.223.169.143 with SMTP id\n\tb15mr13772166wrd.127.1507633114496; \n\tTue, 10 Oct 2017 03:58:34 -0700 (PDT)","by 10.223.169.143 with SMTP id\n\tb15mr13772157wrd.127.1507633114233; \n\tTue, 10 Oct 2017 03:58:34 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QBCQRzj3HC62GJ4tWMQnhhkrK2fRFi/NONUOQvAh7V+tSgofUdkkC3sgB8SCm60KsItqJU9jQ==","Subject":"APPLIED: [kteam-tools][PATCH] wfl/bug.py: change the way to detect\n\twhen to use esm ppa","To":"Po-Hsu Lin <po-hsu.lin@canonical.com>, kernel-team@lists.ubuntu.com","References":"<20170915093704.4714-1-po-hsu.lin@canonical.com>","From":"Kleber Souza <kleber.souza@canonical.com>","Message-ID":"<9b0598ed-f08e-4127-e907-495077710ccd@canonical.com>","Date":"Tue, 10 Oct 2017 12:58:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20170915093704.4714-1-po-hsu.lin@canonical.com>","Content-Language":"en-US","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions <kernel-team.lists.ubuntu.com>","List-Unsubscribe":"<https://lists.ubuntu.com/mailman/options/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe>","List-Archive":"<https://lists.ubuntu.com/archives/kernel-team>","List-Post":"<mailto:kernel-team@lists.ubuntu.com>","List-Help":"<mailto:kernel-team-request@lists.ubuntu.com?subject=help>","List-Subscribe":"<https://lists.ubuntu.com/mailman/listinfo/kernel-team>,\n\t<mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" <kernel-team-bounces@lists.ubuntu.com>"}}]