[{"id":1769062,"web_url":"http://patchwork.ozlabs.org/comment/1769062/","msgid":"<23a47b4e-2260-e711-15e9-07027a2f9529@redhat.com>","list_archive_url":null,"date":"2017-09-15T08:59:27","subject":"Re: [Qemu-devel] [PATCH qemu v2 03/13] memory: Open code FlatView\n\trendering","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On 15/09/2017 10:40, Alexey Kardashevskiy wrote:\n> + /*\n> + * FIXME: this is cut-n-paste from address_space_update_topology_pass,\n> + * simplify it\n> + */\n> + iold = inew = 0;\n> + while (iold < old_view->nr || inew < new_view->nr) {\n> + if (iold < old_view->nr) {\n> + frold = &old_view->ranges[iold];\n> + } else {\n> + frold = NULL;\n> + }\n> + if (inew < new_view->nr) {\n> + frnew = &new_view->ranges[inew];\n> + } else {\n> + frnew = NULL;\n> + }\n> +\n> + if (frold\n> + && (!frnew\n> + || int128_lt(frold->addr.start, frnew->addr.start)\n> + || (int128_eq(frold->addr.start, frnew->addr.start)\n> + && !flatrange_equal(frold, frnew)))) {\n> + ++iold;\n> + } else if (frold && frnew && flatrange_equal(frold, frnew)) {\n> + /* In both and unchanged (except logging may have changed) */\n> + MemoryRegionSection mrs = section_from_flat_range(frnew, as);\n> +\n> + mem_add(as, &mrs);\n> +\n> + ++iold;\n> + ++inew;\n> + } else {\n> + /* In new */\n> + MemoryRegionSection mrs = section_from_flat_range(frnew, as);\n> +\n> + mem_add(as, &mrs);\n> +\n> + ++inew;\n> + }\n> + }\n\nThis indeed is just\n\n for (i = 0; i < new_view->nr; i++) {\n MemoryRegionSection mrs =\n section_from_flat_range(&new_view->ranges[i], as);\n mem_add(as, &mrs);\n }\n\n:)\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtqFD62DBz9sPs\n\tfor ;\n\tFri, 15 Sep 2017 19:03:28 +1000 (AEST)","from localhost ([::1]:52079 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsmX0-0005nL-VF\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 05:03:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45941)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsmTG-0001Us-1O\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:59:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsmTD-0000q7-0f\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:59:34 -0400","from mx1.redhat.com ([209.132.183.28]:52276)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsmTC-0000ph-Qn\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 04:59:30 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C648A5D686;\n\tFri, 15 Sep 2017 08:59:29 +0000 (UTC)","from [10.36.117.159] (ovpn-117-159.ams2.redhat.com [10.36.117.159])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 2E31069AD6;\n\tFri, 15 Sep 2017 08:59:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C648A5D686","To":"Alexey Kardashevskiy , qemu-devel@nongnu.org","References":"<20170915084030.40988-1-aik@ozlabs.ru>\n\t<20170915084030.40988-4-aik@ozlabs.ru>","From":"Paolo Bonzini ","Message-ID":"<23a47b4e-2260-e711-15e9-07027a2f9529@redhat.com>","Date":"Fri, 15 Sep 2017 10:59:27 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170915084030.40988-4-aik@ozlabs.ru>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 15 Sep 2017 08:59:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v2 03/13] memory: Open code FlatView\n\trendering","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]