[{"id":1769063,"web_url":"http://patchwork.ozlabs.org/comment/1769063/","msgid":"<485a3d8c-d44c-be20-6700-324d142d95cf@redhat.com>","list_archive_url":null,"date":"2017-09-15T09:02:33","subject":"Re: [Qemu-devel] [PATCH qemu v2 04/13] memory: Move FlatView\n\tallocation to a helper","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On 15/09/2017 10:40, Alexey Kardashevskiy wrote:\n> -static void flatview_init(FlatView *view)\n> +static FlatView *flatview_alloc(void)\n> {\n> + FlatView *view;\n> +\n> + view = g_new0(FlatView, 1);\n> view->ref = 1;\n> - view->ranges = NULL;\n> - view->nr = 0;\n> - view->nr_allocated = 0;\n> +\n> + return view;\n> }\n\nMaybe flatview_new for consistency with other functions? Otherwise\ndefinitely a good idea.\n\nPaolo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=pbonzini@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtqLr2VSgz9sPs\n\tfor ;\n\tFri, 15 Sep 2017 19:08:20 +1000 (AEST)","from localhost ([::1]:52112 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsmbi-0002I4-Ap\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 05:08:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47535)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsmWH-0005MK-NQ\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 05:02:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsmWC-0002Q9-Pu\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 05:02:41 -0400","from mx1.redhat.com ([209.132.183.28]:34178)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsmWC-0002PT-K9\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 05:02:36 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 90F8283F40;\n\tFri, 15 Sep 2017 09:02:35 +0000 (UTC)","from [10.36.117.159] (ovpn-117-159.ams2.redhat.com [10.36.117.159])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id E75395C896;\n\tFri, 15 Sep 2017 09:02:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 90F8283F40","To":"Alexey Kardashevskiy , qemu-devel@nongnu.org","References":"<20170915084030.40988-1-aik@ozlabs.ru>\n\t<20170915084030.40988-5-aik@ozlabs.ru>","From":"Paolo Bonzini ","Message-ID":"<485a3d8c-d44c-be20-6700-324d142d95cf@redhat.com>","Date":"Fri, 15 Sep 2017 11:02:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170915084030.40988-5-aik@ozlabs.ru>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 15 Sep 2017 09:02:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v2 04/13] memory: Move FlatView\n\tallocation to a helper","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]