[{"id":1769641,"web_url":"http://patchwork.ozlabs.org/comment/1769641/","msgid":"","list_archive_url":null,"date":"2017-09-16T21:04:48","subject":"Re: [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power\n\tcontrollers","submitter":{"id":68283,"url":"http://patchwork.ozlabs.org/api/people/68283/","name":"Julien Chauveau","email":"chauveau.julien@gmail.com"},"content":"Hello Heiko,\n\nThere are a few copy/paste errors in the documentation.\n\n\nLe 15/09/2017 à 10:33, Heiko Stuebner a écrit :\n> Add the compatible values for the power-domain controllers found on\n> rk3066 and rk3188.\n>\n> Signed-off-by: Heiko Stuebner \n> ---\n> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt\n> index 301d2a9bc1b8..1c42c5b7ca6a 100644\n> --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt\n> +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt\n> @@ -5,6 +5,8 @@ powered up/down by software based on different application scenes to save power.\n> \n> Required properties for power domain controller:\n> - compatible: Should be one of the following.\n> +\t\"rockchip,rk3066-power-controller\" - for RK3288 SoCs.\n> +\t\"rockchip,rk3188-power-controller\" - for RK3288 SoCs.\nThese should be for RK3066 and RK3188.\n> \t\"rockchip,rk3288-power-controller\" - for RK3288 SoCs.\n> \t\"rockchip,rk3328-power-controller\" - for RK3328 SoCs.\n> \t\"rockchip,rk3366-power-controller\" - for RK3366 SoCs.\n> @@ -17,6 +19,8 @@ Required properties for power domain controller:\n> \n> Required properties for power domain sub nodes:\n> - reg: index of the power domain, should use macros in:\n> +\t\"include/dt-bindings/power/rk3066-power.h\" - for RK3288 type power domain.\n> +\t\"include/dt-bindings/power/rk3188-power.h\" - for RK3288 type power domain.\nSame here.\n> \t\"include/dt-bindings/power/rk3288-power.h\" - for RK3288 type power domain.\n> \t\"include/dt-bindings/power/rk3328-power.h\" - for RK3328 type power domain.\n> \t\"include/dt-bindings/power/rk3366-power.h\" - for RK3366 type power domain.\nJulien\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ck0swZIu\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvlCD6ZWjz9sPr\n\tfor ;\n\tSun, 17 Sep 2017 07:04:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751290AbdIPVEz (ORCPT\n\t);\n\tSat, 16 Sep 2017 17:04:55 -0400","from mail-wr0-f194.google.com ([209.85.128.194]:37840 \"EHLO\n\tmail-wr0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751278AbdIPVEy (ORCPT\n\t); Sat, 16 Sep 2017 17:04:54 -0400","by mail-wr0-f194.google.com with SMTP id u48so3040276wrf.4\n\tfor ;\n\tSat, 16 Sep 2017 14:04:54 -0700 (PDT)","from MacBook-Pro-de-Julien.local\n\t(ANantes-654-1-133-180.w83-204.abo.wanadoo.fr. [83.204.120.180])\n\tby smtp.gmail.com with ESMTPSA id\n\tx15sm3614160wma.32.2017.09.16.14.04.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 16 Sep 2017 14:04:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding:content-language; \n\tbh=yqigItrYFNckCFfWs44CJ7ji8LLRN4RTz90netzKyZ0=;\n\tb=ck0swZIuS+iY1K8Rt7A1l6q1HJrC4O4/mFW00Cpva0gxkoDpJrn4Ma0GSEdx4H5ZLi\n\tiISC0xlni2yAY5UTFV9SAzglqJsAy1mhE9JVXYAlR/ikFK0PrdADmpmBoMN+8MSjAg3B\n\tbl6M375pM5cbpf+Nhl3PF4buH26ak3XXdM7TnE21b7wwGR2V/RJzL2y+m52gBQ0C/nrS\n\t0dk6gjgSXOQcmVYqiT4H6q6pM2M6ksKGhd39s5o5KYGU+d5939YNObM9glY2shKqul1Y\n\twPW10XoFTAf5w1JRiT59AcX20Xk5oTGABhwlstyWPnvcdx7ajO/+tj3W+GErzf0Wb6/4\n\tN6Gw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding\n\t:content-language;\n\tbh=yqigItrYFNckCFfWs44CJ7ji8LLRN4RTz90netzKyZ0=;\n\tb=uguLpeNgIUW29AsIQBzi5bKV7bt7rjT75vV9UVU/deiY9lL6SElb86/7WvDU9zqIUS\n\tXvVnpC3CXsDpDU1/KyhB/x33q0t/uWdOL2fN4AK2DHU8AsbI/iijKMmpDo+7YAC8J2hh\n\tLtFsaIAyqRxGkh8asRE29xqlJFF74PJMPgvQo3cuAlDKq5oMFzeo8CrV9HZ0eQWbnbqW\n\tOgbgOmBtycVtmYAReJ3DyqLfZKJQH7EBNGLs2IpBW6E531iXypJty3qG8qGLbO7O6a1o\n\tGTT6pXOxu8Y1+GCeXtqt/iHSDsd2BBGcf78CT5uu6oeTuZDrASz35lBOezb9TsI4itBY\n\t5s9A==","X-Gm-Message-State":"AHPjjUj3K/nFWh2hB6R4A1gHjnFdK84FfzJDc9h9CWPT4ZmEpgsKT7S4\n\toCVqUfYTJDrHorDqoF/LLw==","X-Google-Smtp-Source":"ADKCNb4a6a79EXn74IyIS/bv0v+oFlrkbskx2cKaE1o79orcl3dT8aqQtXDuOCYkYAWo3a9lgqrS2Q==","X-Received":"by 10.223.131.99 with SMTP id 90mr24908082wrd.198.1505595893532; \n\tSat, 16 Sep 2017 14:04:53 -0700 (PDT)","Subject":"Re: [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power\n\tcontrollers","To":"Heiko Stuebner , linux-rockchip@lists.infradead.org","Cc":"linux-arm-kernel@lists.infradead.org, kever.yang@rock-chips.com,\n\tdevicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com","References":"<20170915083357.11296-1-heiko@sntech.de>\n\t<20170915083357.11296-6-heiko@sntech.de>","From":"Julien Chauveau ","Message-ID":"","Date":"Sat, 16 Sep 2017 23:04:48 +0200","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915083357.11296-6-heiko@sntech.de>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"8bit","Content-Language":"fr","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1769887,"web_url":"http://patchwork.ozlabs.org/comment/1769887/","msgid":"<13237503.R9C4DGAk4Y@phil>","list_archive_url":null,"date":"2017-09-18T06:29:54","subject":"Re: [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power\n\tcontrollers","submitter":{"id":10645,"url":"http://patchwork.ozlabs.org/api/people/10645/","name":"Heiko Stuebner","email":"heiko@sntech.de"},"content":"Am Samstag, 16. September 2017, 23:04:48 CEST schrieb Julien Chauveau:\n> Hello Heiko,\n> \n> There are a few copy/paste errors in the documentation.\n> \n> \n> Le 15/09/2017 à 10:33, Heiko Stuebner a écrit :\n> > Add the compatible values for the power-domain controllers found on\n> > rk3066 and rk3188.\n> >\n> > Signed-off-by: Heiko Stuebner \n> > ---\n> > Documentation/devicetree/bindings/soc/rockchip/power_domain.txt | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt\n> > index 301d2a9bc1b8..1c42c5b7ca6a 100644\n> > --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt\n> > +++ b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt\n> > @@ -5,6 +5,8 @@ powered up/down by software based on different application scenes to save power.\n> > \n> > Required properties for power domain controller:\n> > - compatible: Should be one of the following.\n> > +\t\"rockchip,rk3066-power-controller\" - for RK3288 SoCs.\n> > +\t\"rockchip,rk3188-power-controller\" - for RK3288 SoCs.\n> These should be for RK3066 and RK3188.\n> > \t\"rockchip,rk3288-power-controller\" - for RK3288 SoCs.\n> > \t\"rockchip,rk3328-power-controller\" - for RK3328 SoCs.\n> > \t\"rockchip,rk3366-power-controller\" - for RK3366 SoCs.\n> > @@ -17,6 +19,8 @@ Required properties for power domain controller:\n> > \n> > Required properties for power domain sub nodes:\n> > - reg: index of the power domain, should use macros in:\n> > +\t\"include/dt-bindings/power/rk3066-power.h\" - for RK3288 type power domain.\n> > +\t\"include/dt-bindings/power/rk3188-power.h\" - for RK3288 type power domain.\n> Same here.\n\nbah ... thanks for noticing. Will fix in a v2 shortly.\n\n\nThanks\nHeiko\n\n> > \t\"include/dt-bindings/power/rk3288-power.h\" - for RK3288 type power domain.\n> > \t\"include/dt-bindings/power/rk3328-power.h\" - for RK3328 type power domain.\n> > \t\"include/dt-bindings/power/rk3366-power.h\" - for RK3366 type power domain.\n> Julien\n> \n> \n\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwbj55jlbz9s7c\n\tfor ;\n\tMon, 18 Sep 2017 16:30:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750886AbdIRGaO convert rfc822-to-8bit (ORCPT\n\t);\n\tMon, 18 Sep 2017 02:30:14 -0400","from gloria.sntech.de ([95.129.55.99]:47104 \"EHLO gloria.sntech.de\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750711AbdIRGaN (ORCPT );\n\tMon, 18 Sep 2017 02:30:13 -0400","from x2f7f952.dyn.telefonica.de ([2.247.249.82] helo=phil.localnet)\n\tby gloria.sntech.de with esmtpsa\n\t(TLS1.1:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dtpZB-0003pG-AO; Mon, 18 Sep 2017 08:30:01 +0200"],"From":"Heiko Stuebner ","To":"Julien Chauveau ","Cc":"linux-rockchip@lists.infradead.org,\n\tlinux-arm-kernel@lists.infradead.org, kever.yang@rock-chips.com,\n\tdevicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com","Subject":"Re: [PATCH 5/9] dt-bindings: add compatibles for rk3066/rk3188 power\n\tcontrollers","Date":"Mon, 18 Sep 2017 08:29:54 +0200","Message-ID":"<13237503.R9C4DGAk4Y@phil>","User-Agent":"KMail/5.2.3 (Linux/4.11.0-1-amd64; KDE/5.28.0; x86_64; ; )","In-Reply-To":"","References":"<20170915083357.11296-1-heiko@sntech.de>\n\t<20170915083357.11296-6-heiko@sntech.de>\n\t","MIME-Version":"1.0","Content-Transfer-Encoding":"8BIT","Content-Type":"text/plain; charset=\"iso-8859-1\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]