[{"id":1774349,"web_url":"http://patchwork.ozlabs.org/comment/1774349/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:11:42","subject":"Re: [U-Boot] [PATCH 04/10] efi_loader: implement queueing of the\n\tnotification function","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Heinrich,\n\nOn 15 September 2017 at 02:06, Heinrich Schuchardt wrote:\n> For the correct implementation of the task priority level (TPL)\n> calling the notification function must be queued.\n>\n> Add a status field 'queued' to events.\n>\n> In function efi_signal_event set status queued if a notification\n> function exists and reset it after we have called the function.\n> A later patch will add a check of the TPL here.\n>\n> In efi_create_event and efi_close_event unset the queued status.\n>\n> In function efi_wait_for_event and efi_check_event\n> queue the notification function.\n>\n> In efi_timer_check call the efi_notify_event\n> if the status queued is set.\n> For all timer events set status signaled.\n>\n> In efi_console_timer_notify set the signaled state of the\n> WaitForKey event.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> include/efi_loader.h | 4 +++-\n> lib/efi_loader/efi_boottime.c | 40 ++++++++++++++++++++++++++++++----------\n> lib/efi_loader/efi_console.c | 4 +++-\n> 3 files changed, 36 insertions(+), 12 deletions(-)\n>\n> diff --git a/include/efi_loader.h b/include/efi_loader.h\n> index f74b33d589..25398ba40c 100644\n> --- a/include/efi_loader.h\n> +++ b/include/efi_loader.h\n> @@ -131,7 +131,8 @@ struct efi_object {\n> * @nofify_function: Function to call when the event is triggered\n> * @notify_context: Data to be passed to the notify function\n> * @trigger_type: Type of timer, see efi_set_timer\n> - * @signaled: The notify function was already called\n> + * @queued: The notification functionis queued\n\nfunctions\n\nWhat does this actually mean? Can you expand the comment a bit? I'm\nnot sure what a value of (for example) 3 would mean. Or if it is just\n*whether* the function is queued, then you could use a bool.\n\n> + * @signaled: The event occured\n\noccurred","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"v+poGWV8\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Jb7uEjkn\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0nwH4B5Hz9s7M\n\tfor ;\n\tMon, 25 Sep 2017 12:24:31 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 5523CC2219F; Mon, 25 Sep 2017 02:13:03 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8C423C21E11;\n\tMon, 25 Sep 2017 02:12:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1BCC2C22180; Mon, 25 Sep 2017 02:12:08 +0000 (UTC)","from mail-qt0-f176.google.com (mail-qt0-f176.google.com\n\t[209.85.216.176])\n\tby lists.denx.de (Postfix) with ESMTPS id B073FC2216B\n\tfor ; Mon, 25 Sep 2017 02:12:04 +0000 (UTC)","by mail-qt0-f176.google.com with SMTP id i50so5551833qtf.0\n\tfor ; Sun, 24 Sep 2017 19:12:04 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:11:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Y21by292cqvcQqti7vX+hUSTvCccTLinvhStZ1fIr/g=;\n\tb=v+poGWV83+6F99Bh70VHvPrGQgeXaoPMK1hyAroD3aYuFgsgrt3n8HIBKSSGwzgqXK\n\toeQAynvqOkcU+OS+JjcY9UBv0pqMHshblzMNjiQ0Q4BwaCZRQRbUQ4kAdRSiNdquD1vZ\n\taTEqrxOZ37y+i0c1M4Gs9jbYUwZxCQ6jQEuE7Rigavvp5lD20MOkLJ42ymmPz2WhtjLp\n\tQHF5LuZOxkc/nEcXKnBk9ajICLnqSbFVhLIjEsE1dlBcrMWqNrUwR9X3mw8oc+3bXuRX\n\tPML2Aplbm/JmE9pVW7xtmlxrhE1rov5Pvw5yC6Srsk11B5Y9N4KOevnPhLmN+Syf5ghO\n\tfQng==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Y21by292cqvcQqti7vX+hUSTvCccTLinvhStZ1fIr/g=;\n\tb=Jb7uEjkncPP+LG9d04nICehAFnV+43noEPq2YmWDnkGCe35MopfuaPn5iKlpT7DY43\n\texqh5UW4SnWLSairJcZh0PjH3JG4u9eFzztTPG0HdGCYDQ7IF3TSBxJjLaumAhyBxCnq\n\tIIOtlJjXPsgMnoy1rCgfsqPAPsI2Oh1BM0+uU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Y21by292cqvcQqti7vX+hUSTvCccTLinvhStZ1fIr/g=;\n\tb=dodDCLi8aZm9wUdSlEg+HafvsS7RncqbaOgECHDOllOLaeYStsdUsTHzf5Xqyyg5cR\n\tRmjnOKp2Ufm58XsHw4cvD+SfsOEc5H9CAMHwiJAAMRMicapNyhFNviQwnfzner8K4f08\n\tExu3qBE5T9ErzrpC0ZvbkscrfFwMw12odIFfjjKBrKlWCBRycI+OhX10Gc+zRp3hxrMh\n\tOSMLEB9avfWIqA0juW17hh9EdlwWkHYZC0XHv7DGOcixQpmarc6W3wPo9L6B5F61zWlv\n\tgoiqSDY1SlOwpuD96mxS+PFFa1lBFXN8U+1v8D1KwZ6C+V7FU9QJ2fa5GAnuE545BbHj\n\tsv0A==","X-Gm-Message-State":"AHPjjUg910otqnRn/bh/N/i500qxwmQkl8nZ7jmeMT0hWrjfeztUGVSJ\n\tI8Xym30ctX0ESZmGHglTDhjJm5OvS6sEV7+oEGbi5Q==","X-Google-Smtp-Source":"AOwi7QBBCJlXX9kWs9MBShYvnSPTGFNlRj8tu75cpxcfVzCZ1W/5jXuLnIwSJDyyUhVqM6kc0J9zT6UuaIkX+veSgWc=","X-Received":"by 10.237.37.182 with SMTP id x51mr8838534qtc.5.1506305523206;\n\tSun, 24 Sep 2017 19:12:03 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170915080619.25250-5-xypron.glpk@gmx.de>","References":"<20170915080619.25250-1-xypron.glpk@gmx.de>\n\t<20170915080619.25250-5-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:11:42 -0400","X-Google-Sender-Auth":"TzTM9w33Va5Hdr7zzp2q76bv5os","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"=?utf-8?q?=C5=81ukasz_Majewski?= ,\n\tAndy Shevchenko , U-Boot Mailing List\n\t, Fabio Estevam ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH 04/10] efi_loader: implement queueing of the\n\tnotification function","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1774436,"web_url":"http://patchwork.ozlabs.org/comment/1774436/","msgid":"","list_archive_url":null,"date":"2017-09-25T06:08:22","subject":"Re: [U-Boot] [PATCH 04/10] efi_loader: implement queueing of the\n\tnotification function","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/25/2017 04:11 AM, Simon Glass wrote:\n> Hi Heinrich,\n> \n> On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:\n>> For the correct implementation of the task priority level (TPL)\n>> calling the notification function must be queued.\n>>\n>> Add a status field 'queued' to events.\n>>\n>> In function efi_signal_event set status queued if a notification\n>> function exists and reset it after we have called the function.\n>> A later patch will add a check of the TPL here.\n>>\n>> In efi_create_event and efi_close_event unset the queued status.\n>>\n>> In function efi_wait_for_event and efi_check_event\n>> queue the notification function.\n>>\n>> In efi_timer_check call the efi_notify_event\n>> if the status queued is set.\n>> For all timer events set status signaled.\n>>\n>> In efi_console_timer_notify set the signaled state of the\n>> WaitForKey event.\n>>\n>> Signed-off-by: Heinrich Schuchardt \n>> ---\n>> include/efi_loader.h | 4 +++-\n>> lib/efi_loader/efi_boottime.c | 40 ++++++++++++++++++++++++++++++----------\n>> lib/efi_loader/efi_console.c | 4 +++-\n>> 3 files changed, 36 insertions(+), 12 deletions(-)\n>>\n>> diff --git a/include/efi_loader.h b/include/efi_loader.h\n>> index f74b33d589..25398ba40c 100644\n>> --- a/include/efi_loader.h\n>> +++ b/include/efi_loader.h\n>> @@ -131,7 +131,8 @@ struct efi_object {\n>> * @nofify_function: Function to call when the event is triggered\n>> * @notify_context: Data to be passed to the notify function\n>> * @trigger_type: Type of timer, see efi_set_timer\n>> - * @signaled: The notify function was already called\n>> + * @queued: The notification functionis queued\n> \n> functions\n\nfunction is\n\n> \n> What does this actually mean? Can you expand the comment a bit? I'm\n> not sure what a value of (for example) 3 would mean. Or if it is just\n> *whether* the function is queued, then you could use a bool.\n\nYes\nbool is_signaled\nbool is_queued\nwould make sense.\n\nRegards\n\nHeinrich\n\n> \n>> + * @signaled: The event occured\n> \n> occurred\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0tvQ5Rm1z9t67\n\tfor ;\n\tMon, 25 Sep 2017 16:09:06 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7EAC5C21C40; Mon, 25 Sep 2017 06:08:59 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F2727C21D74;\n\tMon, 25 Sep 2017 06:08:56 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 95419C21D74; Mon, 25 Sep 2017 06:08:55 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lists.denx.de (Postfix) with ESMTPS id 46B11C21C34\n\tfor ; Mon, 25 Sep 2017 06:08:55 +0000 (UTC)","from [192.168.123.31] ([84.118.154.110]) by mail.gmx.com (mrgmx003\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id\n\t0Mfn40-1dkJK727sq-00NAOa; Mon, 25 Sep 2017 08:08:31 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Simon Glass ","References":"<20170915080619.25250-1-xypron.glpk@gmx.de>\n\t<20170915080619.25250-5-xypron.glpk@gmx.de>\n\t","From":"Heinrich Schuchardt ","Message-ID":"","Date":"Mon, 25 Sep 2017 08:08:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Provags-ID":"V03:K0:ORQDi8xcbBGdYsUB7hF5BtkHBpgpXRGp6QYxrY9+RQlhxF3GUJh\n\t6B1jMj4cHj3oQwVtw9cmgS4CSI3ub93H83mW/TB/kjRMezmvs++JCc6IG4vCSXj67TDTVkq\n\te+fD8kAy4p3MjJIFoevFI2Nhel2p1rVgXdUj6cnA3jbwQHl3sEnQ/nrUY3KCTFRZ7Z9tdAa\n\t7vll1hqHk6s4UAXi1hT9g==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:cv3vmqk/9Ho=:i2ihGSqMX582qvC4u923oo\n\trMOmlPgn0Yy9I2VP4Z3KMIzN2cjUTN9FNBNfWkuyAxsPzcltaBfmCvhDqTowb9gBc34UOpT1P\n\tuLw8Rfbp6alRdbxJnl9ov8IIrvyo2YDfsUrivZZF51yU6QjZAjWGJOOv1daaKqQTP3BF6r7lT\n\tRH6j6Kq57gcclggG3WgVOtzuacgUq9llPJHO03NTWqyLBdItf1/fF4AJ9RK+neJuHE6qp/NQd\n\tUBu4OaoI3mon6XXO1sjO81bIeQTNmEYflWX1R4icZOz0KHsV/3aOFffDBobRgVKzVLFE7jnt/\n\t/ata2jqhapbSsN5mE6ezsIwi57VLomHfdYioyVao0o82Q4GSX1aUqawkOYCca+ayOJ6yeRU4B\n\tRZ8EhjDQ3wXaTl6m/KZq2XzNRp0B9XsfZ3o1lqMuQDY4wJSKcsBsMseJj6rdJS9En2cQc3jMD\n\tz4NLmuARWryvX1ksJxFc3eD+Pk3HmsaUdkWlJNnswUY4pjWTwLLYiKnYEU3+TMko8YI7l086N\n\temv1gIzSXc84hBQAZu7UScbmVQfYc+waClqR3cmWKmIKjWuLCr4fY2fmcOidAZ1ND9RK6kDQy\n\tQsLEjBA/RIFHlfhQWyPCvVoQMzONGFydJvAUO6azgv2UpTJOASCiURxs0G+N2DqUk6/mt+6L8\n\tI6efHVFe88iXuyCknsMZzt9pnYWS3Wr9oQcFQStwJ+0wMzeazbOigOAqVN6xzbPLabUHDL6y5\n\tcnzAROUDsgMKedIwbKOrFn7b8Mu2vkKYZ7HKIRvrHdLXdCVsmSZ19XT4DHm6Fxc/VCB322BBQ\n\tzmBYTOQ442a1rREabuYitAD0pg7DrY88ATCxZOagb+DTVZO+Y0=","Cc":"=?utf-8?q?=C5=81ukasz_Majewski?= ,\n\tAndy Shevchenko , U-Boot Mailing List\n\t, Fabio Estevam ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH 04/10] efi_loader: implement queueing of the\n\tnotification function","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]