[{"id":1774337,"web_url":"http://patchwork.ozlabs.org/comment/1774337/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:11:46","subject":"Re: [U-Boot] [PATCH 05/10] efi_loader: efi_set_timer: reset\n\tsignaled state","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:\n> We should be able to call efi_set_timer repeatedly.\n> So let us reset the signaled state here.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> lib/efi_loader/efi_boottime.c | 1 +\n> 1 file changed, 1 insertion(+)\n\nReviewed-by: Simon Glass \n\nWondering if that should be a bool.\n\n>\n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 408b4a9097..73793cd986 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -363,6 +363,7 @@ efi_status_t efi_set_timer(struct efi_event *event, enum efi_timer_delay type,\n> }\n> event->trigger_type = type;\n> event->trigger_time = trigger_time;\n> + event->signaled = 0;\n> return EFI_SUCCESS;\n> }\n> return EFI_INVALID_PARAMETER;\n> --\n> 2.11.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"gm5RndNZ\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"OQ8uIAv5\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0ng60QVTz9t4B\n\tfor ;\n\tMon, 25 Sep 2017 12:13:06 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C8A87C2215F; Mon, 25 Sep 2017 02:12:47 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 381E0C21E11;\n\tMon, 25 Sep 2017 02:12:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid ACD62C21E11; Mon, 25 Sep 2017 02:12:14 +0000 (UTC)","from mail-qk0-f172.google.com (mail-qk0-f172.google.com\n\t[209.85.220.172])\n\tby lists.denx.de (Postfix) with ESMTPS id 8C8FEC22176\n\tfor ; Mon, 25 Sep 2017 02:12:08 +0000 (UTC)","by mail-qk0-f172.google.com with SMTP id s132so5377079qke.7\n\tfor ; Sun, 24 Sep 2017 19:12:08 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:11:46 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=viRC7EPNWhfByCnOQ3RTUoJvsGEd4KOHiGCt1cKC/po=;\n\tb=gm5RndNZDBU222rHdSEwFfxpzZ6/Y9gaJs1QNppb0fayuJcamBrlj1buzCWo/fm8PC\n\taczFU388aIFG7Exym5t6fW5AN4g2pd/mPgel6Ib4wxIDUL2rVOECMXPk8HCT6uDKsrx8\n\tpOHEuw7FcBjhU62OqZKLIIIJpNjzI8vs7XtU/6UY/xqetaaTR4thJNVLc6mVoqKWhDn4\n\tzE3K4VVoyqcIGuqgFNe59xZ4eIxryJlBOnRcQTSMBaQITb751X+eZI8wGz3szuChqkxa\n\tkPZS8DobIeG6i5zvvMMTYrv0HNCym2SGxCqrN6b0AAm3dxdBtHWQk5PdvviBTTNYaPip\n\t1M+A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=viRC7EPNWhfByCnOQ3RTUoJvsGEd4KOHiGCt1cKC/po=;\n\tb=OQ8uIAv5yWVNln7S4LzouwIiU6SIQtWXjR1zBvPo4XBgDIyWjeCIbfrLTaoCOMELKt\n\tHNy+S19VeLMhE6Q9saAgy3Bba1n4yZOPB+VCYXtYQZH3yX0SkqgB6r9/6xXOWhEdmTcW\n\t1mEwgrHj40HwWAh1GADLqOSJiUD/WsUviM74g="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=viRC7EPNWhfByCnOQ3RTUoJvsGEd4KOHiGCt1cKC/po=;\n\tb=aXp2xFgfAfH1YLCpuoMTVwCx+N9UjU8uAwoDfcuAGsUpLkp4x+pKoEpc1F4EAiR1eV\n\tJToTtz5SGdsot9HKUXCeaQyPWwP5z9f0K+m+NcBxTUPJUtOcGwzF8dvPjoRBD8Sr2R+x\n\t8gVL2lN+XDtY7poy3p/4l+8ly3VYRf1oOg4Ef33TTS7I9oKD4rB5HcIUWsagRr2ENb8l\n\tHYoEGNLvz6vs1Nveuc0xLT5fsi9EhUhnAIfwwVOe6Hz3LcYdY1UcnQMqhsqRGT3PmJ+x\n\tGtmNuHrPhfzyYmetfZCNAswRsKYyvjqKcNiW7hGDZzTnQDpt+FCfPcc22YSt0wX5/VKu\n\t8t5Q==","X-Gm-Message-State":"AHPjjUjAa1Pa5ZFKTuD5qOKCyRxjIzkavpC9XdaGPy7qUqpg+5tZ/sZN\n\t6hA4YwinOv2QI9ukUQXGtPrEJtvtmnHS1Yr86qeZSw==","X-Google-Smtp-Source":"AOwi7QAcKV5Zib69bHRnODAbKj5j8kiQvx0ecPLyj343fORmOrz4U39Iq8gue3DaKQE3ZDeCIcgJQ+UclFMi9ioVkPw=","X-Received":"by 10.55.76.205 with SMTP id z196mr8655716qka.252.1506305527205; \n\tSun, 24 Sep 2017 19:12:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170915080619.25250-6-xypron.glpk@gmx.de>","References":"<20170915080619.25250-1-xypron.glpk@gmx.de>\n\t<20170915080619.25250-6-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:11:46 -0400","X-Google-Sender-Auth":"2y9dsPUJT2lDRW1UqdxlVHyiHtw","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"=?utf-8?q?=C5=81ukasz_Majewski?= ,\n\tAndy Shevchenko , U-Boot Mailing List\n\t, Fabio Estevam ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH 05/10] efi_loader: efi_set_timer: reset\n\tsignaled state","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]