[{"id":1774336,"web_url":"http://patchwork.ozlabs.org/comment/1774336/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:11:36","subject":"Re: [U-Boot] [PATCH 02/10] efi_selftest: provide an EFI selftest\n\tapplication","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 15 September 2017 at 02:06, Heinrich Schuchardt wrote:\n> A testing framework for the EFI API is provided.\n> It can be executed with the 'bootefi selftest' command.\n>\n> It is coded in a way that at a later stage we may turn it\n> into a standalone EFI application. The current build system\n> does not allow this yet.\n>\n> All tests use a driver model and are run in three phases:\n> setup, execute, teardown.\n>\n> A test may be setup and executed at boottime,\n> it may be setup at boottime and executed at runtime,\n> or it may be setup and executed at runtime.\n>\n> After executing all tests the system is reset.\n>\n> Signed-off-by: Heinrich Schuchardt \n> ---\n> MAINTAINERS | 5 +-\n> cmd/Kconfig | 2 +\n> cmd/bootefi.c | 25 +++-\n> include/efi_loader.h | 9 ++\n> include/efi_selftest.h | 91 +++++++++++++\n> lib/Makefile | 1 +\n> lib/efi_selftest/Kconfig | 7 +\n> lib/efi_selftest/Makefile | 17 +++\n> lib/efi_selftest/efi_selftest.c | 219 ++++++++++++++++++++++++++++++++\n> lib/efi_selftest/efi_selftest_console.c | 187 +++++++++++++++++++++++++++\n> 10 files changed, 558 insertions(+), 5 deletions(-)\n> create mode 100644 include/efi_selftest.h\n> create mode 100644 lib/efi_selftest/Kconfig\n> create mode 100644 lib/efi_selftest/Makefile\n> create mode 100644 lib/efi_selftest/efi_selftest.c\n> create mode 100644 lib/efi_selftest/efi_selftest_console.c\n\nReviewed-by: Simon Glass \n\nOne comment: for the error strings, you should not split them even if\nthat means that you violate the 80col rule. Otherwise people get\nconfused when they search for the message and cannot find it in the\ncode.\n\n- Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"e6n2cQcr\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"lUhKEkgo\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0nft3lBnz9t3t\n\tfor ;\n\tMon, 25 Sep 2017 12:12:54 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 33A5CC21EEE; Mon, 25 Sep 2017 02:12:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6601BC21F49;\n\tMon, 25 Sep 2017 02:12:06 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 97D99C22165; Mon, 25 Sep 2017 02:12:02 +0000 (UTC)","from mail-qk0-f181.google.com (mail-qk0-f181.google.com\n\t[209.85.220.181])\n\tby lists.denx.de (Postfix) with ESMTPS id 321E4C21F49\n\tfor ; Mon, 25 Sep 2017 02:11:59 +0000 (UTC)","by mail-qk0-f181.google.com with SMTP id d70so5371834qkc.11\n\tfor ; Sun, 24 Sep 2017 19:11:59 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:11:36 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=hrCe0KwCSDeL48UoFV9udMkXnDKvWskEbeC7RhuJA/U=;\n\tb=e6n2cQcrm5dnBrfVbOYpBizXcgiBCQsouIaSHN3Sqyltt3Js8i47btCvyeN2MgH+iv\n\tNVeaxraib0TKzI7ecJMBbEoABN0DoknjbNY3625iNuIshsBQJZtkDOVtcPEXda3rePD1\n\tCG+QYbK4kAI6M8C2+MvoTlvJu5lOrVDlwryF5KVsUjeBYPMd5Wbu1EylJAK/igTeDErN\n\tzGWZAbbvJqzeow7nEjNzAuCIichdUNplb6VqvBWa+Z8pPDTxTGZJJ0ZfqPAeYigoOmV+\n\tDb5StFsZzBVNwwbeGmCk5j+vAEMN6tX/5kPQmwcpiLmOCPsWYqsSbeNy9N+kX6k08Toc\n\tccug==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=hrCe0KwCSDeL48UoFV9udMkXnDKvWskEbeC7RhuJA/U=;\n\tb=lUhKEkgoMPizbVGMYmzlO96nYddTdxbq7xYj9dCWHL3CU2uc45xZKpUW7i5dr8sYgH\n\t92eQUyjHcyWE3Q8j5laoLlzyRMjHFuxX88boWxVB4vXKTGkpsIMfgbelhpiZ7XGixOPE\n\tTE0WvnakmOOp9TtxNgCggLmybxJbYtjkli/n4="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=hrCe0KwCSDeL48UoFV9udMkXnDKvWskEbeC7RhuJA/U=;\n\tb=XdmTMGHNng6ltJKfMyzojku90flOvtrCgIBneo6i5iggPVNyVLsnH5ztlYY4UXcNQH\n\t1RnJq+J0PLz6KgKo672tDXkrgDaIZsP5XDcloL5luhJXvw1WUBOc2vaYuobzMN39p582\n\t1zk5Li5WJ8Oa+qNuShA8Ip6ddSowSJTC641j31z83Eicf7mnFUauWHcjE0c7q3IaoeL+\n\trsOqZolFNjF/3/W/hK7Su2rcZrouf5Gt5lfrAositg9BS8L3CJs7m1DadC5irQIpovqB\n\t7IXnv1ckZUnJi7jd8c87JNX10adjBqd6VxutWO/UEFVCOsVLQFo01HDLsrbhOQqj8cj8\n\tg2gg==","X-Gm-Message-State":"AHPjjUhrfmoBLIQjymfQZksecTuhd/apN4fSeTiUEYQXeAF7CmQ6Wo5b\n\tbOu3pYJVPvb7GUJjlaZj4gWCchvK4V/8KucgK7C6nQ==","X-Google-Smtp-Source":"AOwi7QBq6fXlQQ1iicO5RDrcCLacwZf4Mtn1mh51uV1dh5W6CHsw0ToDHCRpTL+zStdIX3b0OJi46TpOOVwG+9X+UK0=","X-Received":"by 10.55.33.216 with SMTP id f85mr8790329qki.176.1506305517744; \n\tSun, 24 Sep 2017 19:11:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170915080619.25250-3-xypron.glpk@gmx.de>","References":"<20170915080619.25250-1-xypron.glpk@gmx.de>\n\t<20170915080619.25250-3-xypron.glpk@gmx.de>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:11:36 -0400","X-Google-Sender-Auth":"rS7ZX_JpM5wza_vLMh672-xY8wM","Message-ID":"","To":"Heinrich Schuchardt ","Cc":"=?utf-8?q?=C5=81ukasz_Majewski?= ,\n\tAndy Shevchenko , U-Boot Mailing List\n\t, Fabio Estevam ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH 02/10] efi_selftest: provide an EFI selftest\n\tapplication","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]