[{"id":1769039,"web_url":"http://patchwork.ozlabs.org/comment/1769039/","msgid":"<20170915083227.GF5432@drishya.in.ibm.com>","list_archive_url":null,"date":"2017-09-15T08:32:27","subject":"Re: [Skiboot] [PATCH v4 5/8] SLW: Configure self-restore for HRMOR","submitter":{"id":497,"url":"http://patchwork.ozlabs.org/api/people/497/","name":"Vaidyanathan Srinivasan","email":"svaidy@linux.vnet.ibm.com"},"content":"* Akshay Adiga [2017-09-15 13:04:33]:\n\n> Make a stop api call using libpore to restore HRMOR register. HRMOR needs\n> to be cleared so that when thread exits stop, they arrives at linux\n> system_reset vector (0x100).\n> \n> Signed-off-by: Akshay Adiga \n\nReviewed-by: Vaidyanathan Srinivasan \n\n> ---\n> hw/slw.c | 29 +++++++++++++++++++++++++++++\n> 1 file changed, 29 insertions(+)\n> \n> diff --git a/hw/slw.c b/hw/slw.c\n> index a1ed7ba..39aa4d0 100644\n> --- a/hw/slw.c\n> +++ b/hw/slw.c\n> @@ -1254,12 +1254,41 @@ static void slw_patch_regs(struct proc_chip *chip)\n> static void slw_init_chip_p9(struct proc_chip *chip)\n> {\n> \tstruct cpu_thread *c;\n> +\tint rc;\n> \n> \tprlog(PR_DEBUG, \"SLW: Init chip 0x%x\\n\", chip->id);\n> \n> \t/* At power ON setup inits for power-mgt */\n> \tfor_each_available_core_in_chip(c, chip->id)\n> \t\tslw_set_overrides_p9(chip, c);\n> +\n> +\tif (!chip->homer_base) {\n> +\t\tlog_simple_error(&e_info(OPAL_RC_SLW_REG),\n> +\t\t\t\t \"SLW: HOMER base not set %x\\n\",\n> +\t\t\t\t chip->id);\n> +\t\treturn;\n> +\t}\n> +\n> +\tprlog(PR_NOTICE, \"SLW: Configuring self-restore for HRMOR\\n\");\n> +\n> +\t/* Should this be for_each_present_cpu() ? */\n> +\tfor_each_available_cpu(c) {\n> +\t\tif (c->chip_id != chip->id)\n> +\t\t\tcontinue;\n> +\n> +\t\t/*\n> +\t\t * Clear HRMOR. Need to update only for thread\n> +\t\t * 0 of each core. Doing it anyway for all threads\n> +\t\t */\n> +\t\trc = p9_stop_save_cpureg((void *)chip->homer_base,\n> +\t\t\t\t\t\tP9_STOP_SPR_HRMOR, 0,\n> +\t\t\t\t\t c->pir);\n> +\t\tif (rc) {\n> +\t\t\tlog_simple_error(&e_info(OPAL_RC_SLW_REG),\n> +\t\t\t\t \"SLW: Failed to set HRMOR for CPU %x,RC=0x%x\\n\",\n> +\t\t\t\t c->pir, rc);\n> +\t\t}\n> +\t}\n> }\n> static void slw_init_chip(struct proc_chip *chip)\n> {\n> -- \n> 2.5.5\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtpYp6b6Xz9sPr\n\tfor ;\n\tFri, 15 Sep 2017 18:32:46 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xtpYp5pgszDrX7\n\tfor ;\n\tFri, 15 Sep 2017 18:32:46 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xtpYl0J6rzDrWR\n\tfor ; Fri, 15 Sep 2017 18:32:42 +1000 (AEST)","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8F8TkmN048242\n\tfor ; Fri, 15 Sep 2017 04:32:40 -0400","from e23smtp02.au.ibm.com (e23smtp02.au.ibm.com [202.81.31.144])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d086bgm9j-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 15 Sep 2017 04:32:40 -0400","from localhost\n\tby e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 15 Sep 2017 18:32:36 +1000","from d23relay09.au.ibm.com (202.81.31.228)\n\tby e23smtp02.au.ibm.com (202.81.31.208) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 15 Sep 2017 18:32:34 +1000","from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8F8WXXK38535224\n\tfor ; Fri, 15 Sep 2017 18:32:33 +1000","from d23av06.au.ibm.com (localhost [127.0.0.1])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8F8WXfl024507\n\tfor ; Fri, 15 Sep 2017 18:32:33 +1000","from drishya.in.ibm.com ([9.102.2.33])\n\tby d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8F8WRWU024398\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Fri, 15 Sep 2017 18:32:30 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=svaidy@linux.vnet.ibm.com; receiver=)","Date":"Fri, 15 Sep 2017 14:02:27 +0530","From":"Vaidyanathan Srinivasan ","To":"Akshay Adiga ","References":"<1505460876-7303-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<1505460876-7303-6-git-send-email-akshay.adiga@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505460876-7303-6-git-send-email-akshay.adiga@linux.vnet.ibm.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-TM-AS-MML":"disable","x-cbid":"17091508-0004-0000-0000-0000022F1841","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091508-0005-0000-0000-00005E1830E9","Message-Id":"<20170915083227.GF5432@drishya.in.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-15_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709150129","Subject":"Re: [Skiboot] [PATCH v4 5/8] SLW: Configure self-restore for HRMOR","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"svaidy@linux.vnet.ibm.com","Cc":"ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com,\n\tskiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]