[{"id":1769035,"web_url":"http://patchwork.ozlabs.org/comment/1769035/","msgid":"<20170915082516.GD5432@drishya.in.ibm.com>","list_archive_url":null,"date":"2017-09-15T08:25:16","subject":"Re: [Skiboot] [PATCH v4 3/8] libpore: Build fix for p9_stop_api","submitter":{"id":497,"url":"http://patchwork.ozlabs.org/api/people/497/","name":"Vaidyanathan Srinivasan","email":"svaidy@linux.vnet.ibm.com"},"content":"* Akshay Adiga [2017-09-15 13:04:31]:\n\n> Build fix for \"declaration-after-statement\".\n> \n> Signed-off-by: Akshay Adiga \n\nReviewed-by: Vaidyanathan Srinivasan \n\n> ---\n> libpore/p9_stop_data_struct.H | 2 +-\n> libpore/p9_stop_util.C | 3 ++-\n> 2 files changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/libpore/p9_stop_data_struct.H b/libpore/p9_stop_data_struct.H\n> index 2201021..d1b5054 100644\n> --- a/libpore/p9_stop_data_struct.H\n> +++ b/libpore/p9_stop_data_struct.H\n> @@ -35,7 +35,7 @@\n> #ifndef __STOP_DATA_STRUCT_\n> #define __STOP_DATA_STRUCT_\n> \n> -#ifndef _AIX\n> +#if !(defined _AIX) && !(defined __SKIBOOT__)\n> #include \n> #endif\n> \n> diff --git a/libpore/p9_stop_util.C b/libpore/p9_stop_util.C\n> index 6fb8d67..c351b58 100644\n> --- a/libpore/p9_stop_util.C\n> +++ b/libpore/p9_stop_util.C\n> @@ -50,6 +50,7 @@ namespace stopImageSection\n> */\n> static StopReturnCode_t isFusedMode( void* const i_pImage, bool* o_fusedMode )\n> {\n> + uint64_t cpmrCheckWord;\n> StopReturnCode_t l_rc = STOP_SAVE_SUCCESS;\n> *o_fusedMode = false;\n> \n> @@ -66,7 +67,7 @@ static StopReturnCode_t isFusedMode( void* const i_pImage, bool* o_fusedMode )\n> }\n> \n> \n> - uint64_t cpmrCheckWord = SWIZZLE_8_BYTE(pHomer->cpmrMagicWord);\n> + cpmrCheckWord = SWIZZLE_8_BYTE(pHomer->cpmrMagicWord);\n> cpmrCheckWord = cpmrCheckWord >> 32;\n> \n> if( CPMR_REGION_CHECK_WORD != cpmrCheckWord )\n> -- \n> 2.5.5\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtpPX691hz9sPr\n\tfor ;\n\tFri, 15 Sep 2017 18:25:36 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xtpPX5CYMzDrWv\n\tfor ;\n\tFri, 15 Sep 2017 18:25:36 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xtpPR1H75zDrWP\n\tfor ; Fri, 15 Sep 2017 18:25:30 +1000 (AEST)","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8F8OmQp119895\n\tfor ; Fri, 15 Sep 2017 04:25:28 -0400","from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d0a0xkef5-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 15 Sep 2017 04:25:28 -0400","from localhost\n\tby e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 15 Sep 2017 18:25:26 +1000","from d23relay09.au.ibm.com (202.81.31.228)\n\tby e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 15 Sep 2017 18:25:24 +1000","from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8F8PN6l41091314\n\tfor ; Fri, 15 Sep 2017 18:25:23 +1000","from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8F8PNI7013600\n\tfor ; Fri, 15 Sep 2017 18:25:23 +1000","from drishya.in.ibm.com ([9.102.2.33])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8F8PGos013367\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Fri, 15 Sep 2017 18:25:20 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=svaidy@linux.vnet.ibm.com; receiver=)","Date":"Fri, 15 Sep 2017 13:55:16 +0530","From":"Vaidyanathan Srinivasan ","To":"Akshay Adiga ","References":"<1505460876-7303-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<1505460876-7303-4-git-send-email-akshay.adiga@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505460876-7303-4-git-send-email-akshay.adiga@linux.vnet.ibm.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-TM-AS-MML":"disable","x-cbid":"17091508-0012-0000-0000-0000025E0B50","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091508-0013-0000-0000-0000077C1513","Message-Id":"<20170915082516.GD5432@drishya.in.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-15_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709150127","Subject":"Re: [Skiboot] [PATCH v4 3/8] libpore: Build fix for p9_stop_api","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"svaidy@linux.vnet.ibm.com","Cc":"ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com,\n\tskiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]