[{"id":1769037,"web_url":"http://patchwork.ozlabs.org/comment/1769037/","msgid":"<20170915082414.GC5432@drishya.in.ibm.com>","list_archive_url":null,"date":"2017-09-15T08:24:14","subject":"Re: [Skiboot] [PATCH v4 2/8] Add glibc style endianess check in CCAN","submitter":{"id":497,"url":"http://patchwork.ozlabs.org/api/people/497/","name":"Vaidyanathan Srinivasan","email":"svaidy@linux.vnet.ibm.com"},"content":"* Akshay Adiga [2017-09-15 13:04:30]:\n\n> CCAN adds support for glibc style in the following commit :\n> https://github.com/rustyrussell/ccan/commit/759ac0f0564104d5028acd47c3e9fdb858c96d1d\n> \n> Signed-off-by: Akshay Adiga \n\nReviewed-by: Vaidyanathan Srinivasan \n\n\n> ---\n> ccan/endian/endian.h | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/ccan/endian/endian.h b/ccan/endian/endian.h\n> index 0c99cc8..6732e8a 100644\n> --- a/ccan/endian/endian.h\n> +++ b/ccan/endian/endian.h\n> @@ -103,13 +103,22 @@ static inline uint64_t bswap_64(uint64_t val)\n> }\n> #endif\n> \n> +/* Needed for Glibc like endiness check */\n> +#define\t__LITTLE_ENDIAN\t1234\n> +#define\t__BIG_ENDIAN\t4321\n> +\n> /* Sanity check the defines. We don't handle weird endianness. */\n> #if !HAVE_LITTLE_ENDIAN && !HAVE_BIG_ENDIAN\n> #error \"Unknown endian\"\n> #elif HAVE_LITTLE_ENDIAN && HAVE_BIG_ENDIAN\n> #error \"Can't compile for both big and little endian.\"\n> +#elif HAVE_LITTLE_ENDIAN\n> +#define __BYTE_ORDER\t__LITTLE_ENDIAN\n> +#elif HAVE_BIG_ENDIAN\n> +#define __BYTE_ORDER\t__BIG_ENDIAN\n> #endif\n> \n> +\n> #ifdef __CHECKER__\n> /* sparse needs forcing to remove bitwise attribute from ccan/short_types */\n> #define ENDIAN_CAST __attribute__((force))\n> -- \n> 2.5.5\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtpVN455Dz9sBZ\n\tfor ;\n\tFri, 15 Sep 2017 18:29:48 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xtpVN2vHDzDrX7\n\tfor ;\n\tFri, 15 Sep 2017 18:29:48 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xtpVH6ZdSzDrWP\n\tfor ; Fri, 15 Sep 2017 18:29:43 +1000 (AEST)","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8F8TZTW079417\n\tfor ; Fri, 15 Sep 2017 04:29:41 -0400","from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d08freyf8-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 15 Sep 2017 04:29:40 -0400","from localhost\n\tby e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 15 Sep 2017 18:24:24 +1000","from d23relay07.au.ibm.com (202.81.31.226)\n\tby e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 15 Sep 2017 18:24:21 +1000","from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])\n\tby d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8F8OLYb32047310\n\tfor ; Fri, 15 Sep 2017 18:24:21 +1000","from d23av04.au.ibm.com (localhost [127.0.0.1])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8F8ONVV030015\n\tfor ; Fri, 15 Sep 2017 18:24:23 +1000","from drishya.in.ibm.com ([9.102.2.33])\n\tby d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8F8OGra029899\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NO); Fri, 15 Sep 2017 18:24:20 +1000"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=svaidy@linux.vnet.ibm.com; receiver=)","Date":"Fri, 15 Sep 2017 13:54:14 +0530","From":"Vaidyanathan Srinivasan ","To":"Akshay Adiga ","References":"<1505460876-7303-1-git-send-email-akshay.adiga@linux.vnet.ibm.com>\n\t<1505460876-7303-3-git-send-email-akshay.adiga@linux.vnet.ibm.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1505460876-7303-3-git-send-email-akshay.adiga@linux.vnet.ibm.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-TM-AS-MML":"disable","x-cbid":"17091508-0012-0000-0000-0000025E0B4D","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091508-0013-0000-0000-0000077C150A","Message-Id":"<20170915082414.GC5432@drishya.in.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-15_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709150129","Subject":"Re: [Skiboot] [PATCH v4 2/8] Add glibc style endianess check in CCAN","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"svaidy@linux.vnet.ibm.com","Cc":"ego@linux.vnet.ibm.com, shriyak@linux.vnet.ibm.com,\n\tskiboot@lists.ozlabs.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]