[{"id":1786944,"web_url":"http://patchwork.ozlabs.org/comment/1786944/","msgid":"<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>","list_archive_url":null,"date":"2017-10-15T03:24:17","subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"content":"On 03/10/17 13:10, Alexey Kardashevskiy wrote:\n> On 15/09/17 16:35, Alexey Kardashevskiy wrote:\n>> This moves pci_dev->name initialization earlier so\n>> pci_dev->bus_master_as could get a name instead of an empty string.\n>>\n>> Signed-off-by: Alexey Kardashevskiy \n>> Reviewed-by: Philippe Mathieu-Daudé \n> \n> Ping?\n\nPing?\n\n\n> \n> \n>> ---\n>> Changes:\n>> v2:\n>> * fixed mistype in the commit log\n>> * added \"rb\"\n>> ---\n>> hw/pci/pci.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c\n>> index 21e203b056..353195d154 100644\n>> --- a/hw/pci/pci.c\n>> +++ b/hw/pci/pci.c\n>> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n>> \n>> pci_dev->devfn = devfn;\n>> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);\n>> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n>> \n>> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),\n>> \"bus master container\", UINT64_MAX);\n>> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n>> if (qdev_hotplug) {\n>> pci_init_bus_master(pci_dev);\n>> }\n>> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n>> pci_dev->irq_state = 0;\n>> pci_config_alloc(pci_dev);\n>> \n>>\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ozlabs-ru.20150623.gappssmtp.com\n\theader.i=@ozlabs-ru.20150623.gappssmtp.com\n\theader.b=\"CFTf8YN5\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yF6Q72qsRz9sNr\n\tfor ;\n\tSun, 15 Oct 2017 14:29:35 +1100 (AEDT)","from localhost ([::1]:55972 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e3ZcL-00072z-Dj\n\tfor incoming@patchwork.ozlabs.org; Sat, 14 Oct 2017 23:29:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49488)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e3ZXR-0003Qg-Hj\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:24:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e3ZXO-0007Sv-CC\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:24:29 -0400","from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:56727)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1e3ZXO-0007MV-3l\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:24:26 -0400","by mail-pf0-x241.google.com with SMTP id b85so13262034pfj.13\n\tfor ; Sat, 14 Oct 2017 20:24:22 -0700 (PDT)","from [192.168.10.22] (124-171-134-237.dyn.iinet.net.au.\n\t[124.171.134.237]) by smtp.googlemail.com with ESMTPSA id\n\tv126sm8356129pfv.43.2017.10.14.20.24.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 14 Oct 2017 20:24:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ozlabs-ru.20150623.gappssmtp.com; s=20150623;\n\th=subject:from:to:cc:references:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=OIJ+eLwxbuZDh5yxKuIcoKGvXPHi5cWrGhxjOl9Cgp4=;\n\tb=CFTf8YN5T1pXwm/uyYTuiNpVPxRsh4dzDKDWbKM5alZtkQCV9Odu/QbcvYB2nHEeov\n\tgsxr/2CvG+HQPAeAJkakbjf8Q7BRLwbJGjAO3lG+7X6GkMi7vhuJ0hwc2g84s3UW9jfr\n\tHh0Bh4BD5iYInFTy+V5WWqmShJhAi+Hrf/uON2VJR/h+Ashgye4oc9nV1DLxScw4gqM5\n\tHk9kqQo0fqOp0f6OSvLlZ9rIO+BHMXo2tmn1coat9wNUwRzfBZ3WAq3OQlzG4/t+fLbQ\n\t0TEG6a3YD85e1UxhG8BOmHcW1iOLWuBUR1EsUa+8OFlMx/rHeS7HvQI8Xy25iz3ZnayE\n\tN1HA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:references:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=OIJ+eLwxbuZDh5yxKuIcoKGvXPHi5cWrGhxjOl9Cgp4=;\n\tb=QK9P3blHRk8a0aiz6mafELkAWW1ISpXRGts8x0o5KGGi94NrKGrXSEHD/Ev2DkyAzA\n\t/+vJyDw8UlG1JjiYVnN6cljV6MQUpTJAtNM2DkvK1M5tRV5e8YKcxAyOI5BXUmYXyHNA\n\tNV4lLyeIZmxlbQCpRR3MgzM7vCK6RWXt+IwC9WeuKe4Y/rpUG+dXLvOO5jPhvJm9ncK1\n\tCCZkiGtrIbzXzKAXhjDixvjj9nf63UzvrNq8XK8HxsPNGtJBkgGlgzLaZEiUhjmwUPfx\n\tHJJHcDDbC2KAa7wCBn/iH4JKgPYSK3Y31XzgZncX8c/mGaekK+fsvOJrRVkEeSa3iwBk\n\tJkpQ==","X-Gm-Message-State":"AMCzsaVNatr39LzwBAfgsyhiTSWaq48SR+6VmVaNkuU1X/LEPNmsJA/l\n\tRfPJmQTZNpNh8xG/b86mhwEcGQ==","X-Google-Smtp-Source":"AOwi7QAEZQv3eDajzYfAszDu5R3QpTb1C6Dj0QWEPiFy8lx3jhOGJjEuwcxq07L0CI9A8uRZOq5z2w==","X-Received":"by 10.98.63.142 with SMTP id z14mr5321188pfj.147.1508037862020; \n\tSat, 14 Oct 2017 20:24:22 -0700 (PDT)","From":"Alexey Kardashevskiy ","To":"qemu-devel@nongnu.org","References":"<20170915063552.33868-1-aik@ozlabs.ru>\n\t<2e1b8655-5d47-965c-3d54-1ac1a531afe8@ozlabs.ru>","Message-ID":"<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>","Date":"Sun, 15 Oct 2017 14:24:17 +1100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<2e1b8655-5d47-965c-3d54-1ac1a531afe8@ozlabs.ru>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-AU","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::241","Subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"Michael S. Tsirkin\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1786945,"web_url":"http://patchwork.ozlabs.org/comment/1786945/","msgid":"<20171015063012-mutt-send-email-mst@kernel.org>","list_archive_url":null,"date":"2017-10-15T03:31:13","subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","submitter":{"id":2235,"url":"http://patchwork.ozlabs.org/api/people/2235/","name":"Michael S. Tsirkin","email":"mst@redhat.com"},"content":"On Sun, Oct 15, 2017 at 02:24:17PM +1100, Alexey Kardashevskiy wrote:\n> On 03/10/17 13:10, Alexey Kardashevskiy wrote:\n> > On 15/09/17 16:35, Alexey Kardashevskiy wrote:\n> >> This moves pci_dev->name initialization earlier so\n> >> pci_dev->bus_master_as could get a name instead of an empty string.\n> >>\n> >> Signed-off-by: Alexey Kardashevskiy \n> >> Reviewed-by: Philippe Mathieu-Daudé \n> > \n> > Ping?\n> \n> Ping?\n\nI can't find v2 in either qemu or my personal mailbox.\n\n> \n> > \n> > \n> >> ---\n> >> Changes:\n> >> v2:\n> >> * fixed mistype in the commit log\n> >> * added \"rb\"\n> >> ---\n> >> hw/pci/pci.c | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c\n> >> index 21e203b056..353195d154 100644\n> >> --- a/hw/pci/pci.c\n> >> +++ b/hw/pci/pci.c\n> >> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n> >> \n> >> pci_dev->devfn = devfn;\n> >> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);\n> >> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n> >> \n> >> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),\n> >> \"bus master container\", UINT64_MAX);\n> >> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n> >> if (qdev_hotplug) {\n> >> pci_init_bus_master(pci_dev);\n> >> }\n> >> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n> >> pci_dev->irq_state = 0;\n> >> pci_config_alloc(pci_dev);\n> >> \n> >>\n> > \n> > \n> \n> \n> -- \n> Alexey","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mst@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yF6gG5qKNz9sPk\n\tfor ;\n\tSun, 15 Oct 2017 14:40:58 +1100 (AEDT)","from localhost ([::1]:56029 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e3ZnM-0007tw-SD\n\tfor incoming@patchwork.ozlabs.org; Sat, 14 Oct 2017 23:40:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51023)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e3Ze3-0000ny-Mx\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:31:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e3Zdz-0002W1-Kw\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:31:19 -0400","from mx1.redhat.com ([209.132.183.28]:41038)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e3Zdz-0002Vp-Ev\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:31:15 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 72E3B5AFED;\n\tSun, 15 Oct 2017 03:31:14 +0000 (UTC)","from redhat.com (ovpn-120-178.rdu2.redhat.com [10.10.120.178])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EEC5B60602;\n\tSun, 15 Oct 2017 03:31:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 72E3B5AFED","Date":"Sun, 15 Oct 2017 06:31:13 +0300","From":"\"Michael S. Tsirkin\" ","To":"Alexey Kardashevskiy ","Message-ID":"<20171015063012-mutt-send-email-mst@kernel.org>","References":"<20170915063552.33868-1-aik@ozlabs.ru>\n\t<2e1b8655-5d47-965c-3d54-1ac1a531afe8@ozlabs.ru>\n\t<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tSun, 15 Oct 2017 03:31:14 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1786946,"web_url":"http://patchwork.ozlabs.org/comment/1786946/","msgid":"","list_archive_url":null,"date":"2017-10-15T03:38:46","subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"content":"On 15/10/17 14:31, Michael S. Tsirkin wrote:\n> On Sun, Oct 15, 2017 at 02:24:17PM +1100, Alexey Kardashevskiy wrote:\n>> On 03/10/17 13:10, Alexey Kardashevskiy wrote:\n>>> On 15/09/17 16:35, Alexey Kardashevskiy wrote:\n>>>> This moves pci_dev->name initialization earlier so\n>>>> pci_dev->bus_master_as could get a name instead of an empty string.\n>>>>\n>>>> Signed-off-by: Alexey Kardashevskiy \n>>>> Reviewed-by: Philippe Mathieu-Daudé \n>>>\n>>> Ping?\n>>\n>> Ping?\n> \n> I can't find v2 in either qemu or my personal mailbox.\n\n\nFew weeks ago qemu-devel@ list admins were playing with list-id, may be\nthat's why it missed your inbox.\n\nIt hit patchwork though: https://patchwork.ozlabs.org/patch/814085/\n\n\n> \n>>\n>>>\n>>>\n>>>> ---\n>>>> Changes:\n>>>> v2:\n>>>> * fixed mistype in the commit log\n>>>> * added \"rb\"\n>>>> ---\n>>>> hw/pci/pci.c | 2 +-\n>>>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c\n>>>> index 21e203b056..353195d154 100644\n>>>> --- a/hw/pci/pci.c\n>>>> +++ b/hw/pci/pci.c\n>>>> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n>>>> \n>>>> pci_dev->devfn = devfn;\n>>>> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);\n>>>> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n>>>> \n>>>> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),\n>>>> \"bus master container\", UINT64_MAX);\n>>>> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n>>>> if (qdev_hotplug) {\n>>>> pci_init_bus_master(pci_dev);\n>>>> }\n>>>> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n>>>> pci_dev->irq_state = 0;\n>>>> pci_config_alloc(pci_dev);\n>>>> \n>>>>\n>>>\n>>>\n>>\n>>\n>> -- \n>> Alexey","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ozlabs-ru.20150623.gappssmtp.com\n\theader.i=@ozlabs-ru.20150623.gappssmtp.com\n\theader.b=\"DPBy27mt\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yF6kX4vfPz9sPk\n\tfor ;\n\tSun, 15 Oct 2017 14:43:48 +1100 (AEDT)","from localhost ([::1]:56039 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e3Zq6-0001lb-Qm\n\tfor incoming@patchwork.ozlabs.org; Sat, 14 Oct 2017 23:43:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53052)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e3ZlQ-0006hZ-Lr\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:38:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e3ZlM-0006U8-QO\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:38:56 -0400","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:56455)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1e3ZlM-0006T2-KK\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:38:52 -0400","by mail-pg0-x244.google.com with SMTP id m18so4187029pgd.13\n\tfor ; Sat, 14 Oct 2017 20:38:52 -0700 (PDT)","from [192.168.10.22] (124-171-134-237.dyn.iinet.net.au.\n\t[124.171.134.237]) by smtp.googlemail.com with ESMTPSA id\n\t74sm11073831pft.184.2017.10.14.20.38.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 14 Oct 2017 20:38:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ozlabs-ru.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=3geCP6DQpIVB9VVzmrk3HiCucL360odNNfe1LZFPKU8=;\n\tb=DPBy27mtaz6iYHJcC9ZDOY76+BkBHwwxXrhLUVGN4yGSzyWfCpElW7u8pPwnCBHUJB\n\tKehRdYMxPiAw6I2iwEp7/LIXi0EczcUiHUnX2PbEtjsDUwp2DIOUrUhzqyIa4BhlgtDH\n\tByNOiSZKGRfUMCWvVQYQnQRUZ0vgFCDoDKJZnoRhTBohzVJ7Iig1kxod9YpGbE0ukAlq\n\thVerB66oHDm80ZtA+x1K5SBfThLsA05DU2wX0tejlD7QJNOML7NE1oA39G6LlcJz8spo\n\twc8LfuthMJWmUkcH7KpeKynar9RkmwNJ3TgUkJoGc30NUXw/8OD35TF2+FdgqCeGTunP\n\tkpHw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=3geCP6DQpIVB9VVzmrk3HiCucL360odNNfe1LZFPKU8=;\n\tb=FOwAH7hK6V456kI5vTjXMP59XyN8/8hSSdAlW/6O6KCBXinssSoarp6agqhiDVbqMC\n\thHaAyY45Or3PgiXGIAn1MINQfMEFMhFolUoFynsAkUInPE3UxjJi2ut+2+pZb9EXzbTw\n\tLwF4yzDZ2MpQQt5VXbMP9UE0i96r6KMbmWC/YUDfniHJZplR3qrGFkhdYoElIQ2NXUQg\n\tyLoguCdBJZq1fOHhYOfyRQaSfOW0nzgn9yn4P0Qi/aIijuw/Ex81IubwByY1APfoDo9D\n\tSm2IZOQQtPPUYHtkzt9FCr09bRRgXwreUfeLwspx8nMSJf01Y6JJM4dQe6EnvyS6xWzi\n\tPGDQ==","X-Gm-Message-State":"AMCzsaWag63+u7usMMsEH6TLA+UzTw7PIQ6muFW9uC206AXt19YrBvqh\n\tq1T67DTTkceW5AIbJT+NDyr1Xw==","X-Google-Smtp-Source":"AOwi7QAOLSiVGQgNmzmnmrZVQvAsYxF8f5EGU8xBWNqemABNCmmRVtRJ5SQ9qryHL8Qb1T5pOFcqkg==","X-Received":"by 10.101.70.15 with SMTP id v15mr5023807pgq.446.1508038731516; \n\tSat, 14 Oct 2017 20:38:51 -0700 (PDT)","To":"\"Michael S. Tsirkin\" ","References":"<20170915063552.33868-1-aik@ozlabs.ru>\n\t<2e1b8655-5d47-965c-3d54-1ac1a531afe8@ozlabs.ru>\n\t<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>\n\t<20171015063012-mutt-send-email-mst@kernel.org>","From":"Alexey Kardashevskiy ","Message-ID":"","Date":"Sun, 15 Oct 2017 14:38:46 +1100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20171015063012-mutt-send-email-mst@kernel.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-AU","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::244","Subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1786947,"web_url":"http://patchwork.ozlabs.org/comment/1786947/","msgid":"<20171015064519-mutt-send-email-mst@kernel.org>","list_archive_url":null,"date":"2017-10-15T03:45:39","subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","submitter":{"id":2235,"url":"http://patchwork.ozlabs.org/api/people/2235/","name":"Michael S. Tsirkin","email":"mst@redhat.com"},"content":"On Sun, Oct 15, 2017 at 02:24:17PM +1100, Alexey Kardashevskiy wrote:\n> On 03/10/17 13:10, Alexey Kardashevskiy wrote:\n> > On 15/09/17 16:35, Alexey Kardashevskiy wrote:\n> >> This moves pci_dev->name initialization earlier so\n> >> pci_dev->bus_master_as could get a name instead of an empty string.\n> >>\n> >> Signed-off-by: Alexey Kardashevskiy \n> >> Reviewed-by: Philippe Mathieu-Daudé \n> > \n> > Ping?\n> \n> Ping?\n\nPls repost while you CC me. Thanks!\n\n> \n> > \n> > \n> >> ---\n> >> Changes:\n> >> v2:\n> >> * fixed mistype in the commit log\n> >> * added \"rb\"\n> >> ---\n> >> hw/pci/pci.c | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/hw/pci/pci.c b/hw/pci/pci.c\n> >> index 21e203b056..353195d154 100644\n> >> --- a/hw/pci/pci.c\n> >> +++ b/hw/pci/pci.c\n> >> @@ -1020,6 +1020,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n> >> \n> >> pci_dev->devfn = devfn;\n> >> pci_dev->requester_id_cache = pci_req_id_cache_get(pci_dev);\n> >> + pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n> >> \n> >> memory_region_init(&pci_dev->bus_master_container_region, OBJECT(pci_dev),\n> >> \"bus master container\", UINT64_MAX);\n> >> @@ -1029,7 +1030,6 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,\n> >> if (qdev_hotplug) {\n> >> pci_init_bus_master(pci_dev);\n> >> }\n> >> - pstrcpy(pci_dev->name, sizeof(pci_dev->name), name);\n> >> pci_dev->irq_state = 0;\n> >> pci_config_alloc(pci_dev);\n> >> \n> >>\n> > \n> > \n> \n> \n> -- \n> Alexey","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mst@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yF6nK2HLbz9sPk\n\tfor ;\n\tSun, 15 Oct 2017 14:46:13 +1100 (AEDT)","from localhost ([::1]:56052 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e3ZsR-0003WR-FG\n\tfor incoming@patchwork.ozlabs.org; Sat, 14 Oct 2017 23:46:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54750)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e3Zry-0003Us-Kp\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:45:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e3Zrx-00028S-Ng\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:45:42 -0400","from mx1.redhat.com ([209.132.183.28]:60600)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e3Zrx-00027w-Hq\n\tfor qemu-devel@nongnu.org; Sat, 14 Oct 2017 23:45:41 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 76FAC83F43;\n\tSun, 15 Oct 2017 03:45:40 +0000 (UTC)","from redhat.com (ovpn-120-178.rdu2.redhat.com [10.10.120.178])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 072805D9CC;\n\tSun, 15 Oct 2017 03:45:39 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 76FAC83F43","Date":"Sun, 15 Oct 2017 06:45:39 +0300","From":"\"Michael S. Tsirkin\" ","To":"Alexey Kardashevskiy ","Message-ID":"<20171015064519-mutt-send-email-mst@kernel.org>","References":"<20170915063552.33868-1-aik@ozlabs.ru>\n\t<2e1b8655-5d47-965c-3d54-1ac1a531afe8@ozlabs.ru>\n\t<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<03c58335-8ca2-a812-5259-a5a41b9e0a87@ozlabs.ru>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tSun, 15 Oct 2017 03:45:40 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name\n\tbefore use","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]