[{"id":1769090,"web_url":"http://patchwork.ozlabs.org/comment/1769090/","msgid":"<9659eb97-6d10-d204-02a5-9359e2a09b8f@kaod.org>","list_archive_url":null,"date":"2017-09-15T07:25:37","subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/15/2017 08:18 AM, Joel Stanley wrote:\n> Signed-off-by: Joel Stanley <joel@jms.id.au>\n\nWe could fill the eeprom_buf with some valid data if needed.\n\nReviewed-by: Cédric Le Goater <clg@kaod.org>\n\n> ---\n>  hw/arm/aspeed.c | 16 ++++++++++++++++\n>  1 file changed, 16 insertions(+)\n> \n> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c\n> index 9ef5fb3b6ddc..2f596959649a 100644\n> --- a/hw/arm/aspeed.c\n> +++ b/hw/arm/aspeed.c\n> @@ -253,6 +253,7 @@ static void aspeed_board_init(MachineState *machine,\n>  \n>  static void palmetto_bmc_i2c_init(AspeedBoardState *bmc)\n>  {\n> +    uint8_t *eeprom_buf = g_malloc0(256 * 1024);\n>      AspeedSoCState *soc = &bmc->soc;\n>      DeviceState *dev;\n>  \n> @@ -260,6 +261,13 @@ static void palmetto_bmc_i2c_init(AspeedBoardState *bmc)\n>       * enough to provide basic RTC features. Alarms will be missing */\n>      i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 0), \"ds1338\", 0x68);\n>  \n> +    /* 256KB EEPROM */\n> +    dev = qdev_create((BusState *) aspeed_i2c_get_bus(DEVICE(&soc->i2c), 0),\n> +                      \"smbus-eeprom\");\n> +    qdev_prop_set_uint8(dev, \"address\", 0x50);\n> +    qdev_prop_set_ptr(dev, \"data\", eeprom_buf);\n> +    qdev_init_nofail(dev);\n> +\n>      /* add a TMP423 temperature sensor */\n>      dev = i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 2),\n>                             \"tmp423\", 0x4c);\n> @@ -295,7 +303,15 @@ static const TypeInfo palmetto_bmc_type = {\n>  \n>  static void ast2500_evb_i2c_init(AspeedBoardState *bmc)\n>  {\n> +    uint8_t *eeprom_buf = g_malloc0(8 * 1024);\n>      AspeedSoCState *soc = &bmc->soc;\n> +    DeviceState *dev;\n> +\n> +    dev = qdev_create((BusState *) aspeed_i2c_get_bus(DEVICE(&soc->i2c), 3),\n> +                      \"smbus-eeprom\");\n> +    qdev_prop_set_uint8(dev, \"address\", 0x50);\n> +    qdev_prop_set_ptr(dev, \"data\", eeprom_buf);\n> +    qdev_init_nofail(dev);\n>  \n>      /* The AST2500 EVB expects a LM75 but a TMP105 is compatible */\n>      i2c_create_slave(aspeed_i2c_get_bus(DEVICE(&soc->i2c), 7), \"tmp105\", 0x4d);\n>","headers":{"Return-Path":"<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtrJl6clHz9sxR\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 19:51:35 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xtrJl5S9PzDrZ1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 19:51:35 +1000 (AEST)","from 15.mo1.mail-out.ovh.net (15.mo1.mail-out.ovh.net\n\t[188.165.38.232])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xtrJf251YzDrYB\n\tfor <openbmc@lists.ozlabs.org>; Fri, 15 Sep 2017 19:51:28 +1000 (AEST)","from player795.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 04FE394A09\n\tfor <openbmc@lists.ozlabs.org>; Fri, 15 Sep 2017 09:25:40 +0200 (CEST)","from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: postmaster@kaod.org)\n\tby player795.ha.ovh.net (Postfix) with ESMTPSA id C19F2120087;\n\tFri, 15 Sep 2017 09:25:37 +0200 (CEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=kaod.org\n\t(client-ip=188.165.38.232; helo=15.mo1.mail-out.ovh.net;\n\tenvelope-from=clg@kaod.org; receiver=<UNKNOWN>)","X-Greylist":"delayed 8400 seconds by postgrey-1.36 at bilbo;\n\tFri, 15 Sep 2017 19:51:30 AEST","Subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","To":"Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>","References":"<20170915061830.1527-1-joel@jms.id.au>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Message-ID":"<9659eb97-6d10-d204-02a5-9359e2a09b8f@kaod.org>","Date":"Fri, 15 Sep 2017 09:25:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170915061830.1527-1-joel@jms.id.au>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Ovh-Tracer-Id":"9256023138316421890","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrgeejgdejkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC <openbmc.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/openbmc/>","List-Post":"<mailto:openbmc@lists.ozlabs.org>","List-Help":"<mailto:openbmc-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>","Cc":"openbmc@lists.ozlabs.org","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1769844,"web_url":"http://patchwork.ozlabs.org/comment/1769844/","msgid":"<CACPK8Xe3_XNjoLF5CzmY8dDFbg8ivs1Fm4nLXbpNonds85rW+Q@mail.gmail.com>","list_archive_url":null,"date":"2017-09-18T03:26:29","subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Fri, Sep 15, 2017 at 4:55 PM, Cédric Le Goater <clg@kaod.org> wrote:\n> On 09/15/2017 08:18 AM, Joel Stanley wrote:\n>> Signed-off-by: Joel Stanley <joel@jms.id.au>\n>\n> We could fill the eeprom_buf with some valid data if needed.\n\n\n\nThat's a good idea.\n\nWhen I use this I see the following error:\n\n# pwd\n/sys/devices/platform/ahb/ahb:apb/ahb:apb:i2c@1e78a000/1e78a100.i2c-bus\n# hexdump -C i2c-0/0-0050/eeprom\nhexdump: i2c-0/0-0050/eeprom: Operation timed out\n00000000  74 65 73 74 20 64 61 74  61 0a 00 00 00 00 00     |test data......|\n0000000f\n\nA strace shows three reads, with the first succeeding and the second\ntwo failing:\n\n# strace hexdump -C i2c-0/0-0050/eeprom\nexecve(\"/usr/bin/hexdump\", [\"hexdump\", \"-C\", \"i2c-0/0-0050/eeprom\"],\n[/* 12 vars */]) = 0\nset_tls(0x76fad764, 0x3c, 0x76fac47c, 0x24, 0x76fad698) = 0\nset_tid_address(0x76fad6b4)             = 581\ngetuid32()                              = 0\nopen(\"i2c-0/0-0050/eeprom\", O_RDONLY|O_LARGEFILE) = 3\ndup2(3, 0)                              = 0\nclose(3)                                = 0\nreadv(0, [{iov_base=\"test data\\n\\0\\0\\0\\0\\0\", iov_len=15},\n{iov_base=\"\", iov_len=1024}], 2) = 15\nreadv(0, 0x7e898cd4, 2)                 = -1 ETIMEDOUT (Operation timed out)\nreadv(0, 0x7e898cd4, 2)                 = -1 ETIMEDOUT (Operation timed out)\nwrite(2, \"hexdump: i2c-0/0-0050/eeprom: Op\"..., 50hexdump:\ni2c-0/0-0050/eeprom: Operation timed out\n) = 50\nioctl(1, TIOCGWINSZ, {ws_row=0, ws_col=0, ws_xpixel=0, ws_ypixel=0}) = 0\nwritev(1, [{iov_base=\"00000000  74 65 73 74 20 64 61 7\"...,\niov_len=76}, {iov_base=\"|\\n\", iov_len=2}], 200000000  74 65 73 74 20\n64 61 74  61 0a 00 00 00 00 00     |test data......|\n) = 78\nwritev(1, [{iov_base=\"0000000f\", iov_len=8}, {iov_base=\"\\n\",\niov_len=1}], 20000000f\n) = 9\nexit_group(0)                           = ?\n+++ exited with 0 +++\n\nAny ideas there?\n\nCheers,\n\nJoel","headers":{"Return-Path":"<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwWdd0wsxz9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 13:27:01 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwWdc6KRzzDrXT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 13:27:00 +1000 (AEST)","from mail-lf0-x243.google.com (mail-lf0-x243.google.com\n\t[IPv6:2a00:1450:4010:c07::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwWdW2Y6CzDrWM\n\tfor <openbmc@lists.ozlabs.org>; Mon, 18 Sep 2017 13:26:54 +1000 (AEST)","by mail-lf0-x243.google.com with SMTP id m199so3822495lfe.5\n\tfor <openbmc@lists.ozlabs.org>; Sun, 17 Sep 2017 20:26:53 -0700 (PDT)","by 10.25.103.82 with HTTP; Sun, 17 Sep 2017 20:26:29 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E8kz+z+o\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E8kz+z+o\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2a00:1450:4010:c07::243; helo=mail-lf0-x243.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E8kz+z+o\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=0j9CSQMqTN2sBKkGwWCpJqtpLixtUMI1I48OF00v1AA=;\n\tb=E8kz+z+o2aPhh8oCm7O3Fq55/WezaC7O1GuQs3clCxUNdsMvbOKRYDrj3y8avs5kse\n\tG/OJQzIzYcxHTrgHJ/lUpPb78benq11apBv9ngFTGOx73idVQDZCpR7l58knv/N1KXEg\n\t6Kd4To6W4Vi5BSkCCkMEUOwTXd/Q+V92+utsEKVwkwi2mr/1PRJRrUnKYZkTSBtQyLH5\n\trKgox0PFwG71HruFGQdefDXs0GzJo27tL6eSwwgbV9eeZpZudD2UYegK9JVYX/QDKRnb\n\tlcsk4/jZbL77y4hqDPvo/LtU79liTJJqWziPMezxzJJMKWh5gPyATzQ+/DMf8MXHI2wo\n\tqiJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=0j9CSQMqTN2sBKkGwWCpJqtpLixtUMI1I48OF00v1AA=;\n\tb=MaQJNFzdkRoaS8HDsC4+gM4UhVvlsEhm39yVm0PMqyEP7fSitqxPdNs4m58Q1X61OV\n\tHJzBFIT8dcQwDXoZdUzcgdf6cE7zZMO7G3R9AlE2ulbzzj7a52DEBtEDRro1aW5j9zsu\n\t9T2jsSIG5p6n/jgG3ekE/Bj41lVCq6sFMj0Fl1H3iNZT8mXw4nIkJrHdIDSUe+cv1ske\n\tvr0PWkVNIYGOVEqqUoQspSUNRnOZPG9zEUKd3S/S29ViEjLsAIPp/EmOFGaQ1GmOy4k0\n\tdKWPd8gf8RNxgyEgkeFdsn/ducx4811KoDX9HQ0xmQqZ3WIvspnO69Yy3R4MKMKl+j15\n\tL/aQ==","X-Gm-Message-State":"AHPjjUgxKyBMDG9gNvTrDxnMR1/na5S1QOBVNVDzVTJt0a4RDGai7j5v\n\tFr3cvPoWbPBMDdAr3vyS40kH4xIZ0xQuQIJA60w=","X-Google-Smtp-Source":"AOwi7QASbqa35ps1RUz1fYz70r5KYHg23gaORBiQQclQqVaxG8XMc9/2WnVxYMsq1p3hFqyoCE3UIHUNJkVWP/uzk2I=","X-Received":"by 10.25.100.18 with SMTP id y18mr2843060lfb.257.1505705210361; \n\tSun, 17 Sep 2017 20:26:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<9659eb97-6d10-d204-02a5-9359e2a09b8f@kaod.org>","References":"<20170915061830.1527-1-joel@jms.id.au>\n\t<9659eb97-6d10-d204-02a5-9359e2a09b8f@kaod.org>","From":"Joel Stanley <joel@jms.id.au>","Date":"Mon, 18 Sep 2017 12:56:29 +0930","X-Google-Sender-Auth":"m0p92TG1KtTek5hNh53cNuh9fqs","Message-ID":"<CACPK8Xe3_XNjoLF5CzmY8dDFbg8ivs1Fm4nLXbpNonds85rW+Q@mail.gmail.com>","Subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC <openbmc.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/openbmc/>","List-Post":"<mailto:openbmc@lists.ozlabs.org>","List-Help":"<mailto:openbmc-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>","Cc":"Andrew Jeffery <andrew@aj.id.au>,\n\tOpenBMC Maillist <openbmc@lists.ozlabs.org>","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1769984,"web_url":"http://patchwork.ozlabs.org/comment/1769984/","msgid":"<860fa7c3-1d04-6df5-61dd-2a991414197c@kaod.org>","list_archive_url":null,"date":"2017-09-18T07:59:44","subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","submitter":{"id":68548,"url":"http://patchwork.ozlabs.org/api/people/68548/","name":"Cédric Le Goater","email":"clg@kaod.org"},"content":"On 09/18/2017 05:26 AM, Joel Stanley wrote:\n> On Fri, Sep 15, 2017 at 4:55 PM, Cédric Le Goater <clg@kaod.org> wrote:\n>> On 09/15/2017 08:18 AM, Joel Stanley wrote:\n>>> Signed-off-by: Joel Stanley <joel@jms.id.au>\n>>\n>> We could fill the eeprom_buf with some valid data if needed.\n> \n> \n> \n> That's a good idea.\n> \n> When I use this I see the following error:\n> \n> # pwd\n> /sys/devices/platform/ahb/ahb:apb/ahb:apb:i2c@1e78a000/1e78a100.i2c-bus\n\nhmm, the address is I2C bus 3.\n\n> # hexdump -C i2c-0/0-0050/eeprom\n\nBut you use bus 0 ? weird.\n\n> hexdump: i2c-0/0-0050/eeprom: Operation timed out\n> 00000000  74 65 73 74 20 64 61 74  61 0a 00 00 00 00 00     |test data......|\n> 0000000f\n> \n> A strace shows three reads, with the first succeeding and the second\n> two failing:\n> \n> # strace hexdump -C i2c-0/0-0050/eeprom\n> execve(\"/usr/bin/hexdump\", [\"hexdump\", \"-C\", \"i2c-0/0-0050/eeprom\"],\n> [/* 12 vars */]) = 0\n> set_tls(0x76fad764, 0x3c, 0x76fac47c, 0x24, 0x76fad698) = 0\n> set_tid_address(0x76fad6b4)             = 581\n> getuid32()                              = 0\n> open(\"i2c-0/0-0050/eeprom\", O_RDONLY|O_LARGEFILE) = 3\n> dup2(3, 0)                              = 0\n> close(3)                                = 0\n> readv(0, [{iov_base=\"test data\\n\\0\\0\\0\\0\\0\", iov_len=15},\n> {iov_base=\"\", iov_len=1024}], 2) = 15\n> readv(0, 0x7e898cd4, 2)                 = -1 ETIMEDOUT (Operation timed out)\n> readv(0, 0x7e898cd4, 2)                 = -1 ETIMEDOUT (Operation timed out)\n> write(2, \"hexdump: i2c-0/0-0050/eeprom: Op\"..., 50hexdump:\n> i2c-0/0-0050/eeprom: Operation timed out\n> ) = 50\n> ioctl(1, TIOCGWINSZ, {ws_row=0, ws_col=0, ws_xpixel=0, ws_ypixel=0}) = 0\n> writev(1, [{iov_base=\"00000000  74 65 73 74 20 64 61 7\"...,\n> iov_len=76}, {iov_base=\"|\\n\", iov_len=2}], 200000000  74 65 73 74 20\n> 64 61 74  61 0a 00 00 00 00 00     |test data......|\n> ) = 78\n> writev(1, [{iov_base=\"0000000f\", iov_len=8}, {iov_base=\"\\n\",\n> iov_len=1}], 20000000f\n> ) = 9\n> exit_group(0)                           = ?\n> +++ exited with 0 +++\n> \n> Any ideas there?\n\n\nIf I use your patch adding the eeprom to bus 0 on the palmetto machine, I don't \nsee any issues while reading the contents.\n\n  hexdump -C  /sys/devices/platform/ahb/ahb:apb/ahb:apb:i2c@1e78a000/1e78a040.i2c-bus/i2c-0/0-0050/eeprom\n  00000000  00 80 80 80 80 80 80 80  80 80 80 80 80 80 80 80  |................|\n  00000010  80 80 80 80 80 80 80 80  80 80 80 80 80 80 80 80  |................|\n  *\n  ...\n  00007f80  80 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|\n  00007f90  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|\n  *\n  00008000\n\n\nCheers,\n\nC.","headers":{"Return-Path":"<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfYc0fjZz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 18:39:00 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwfYb6n6NzDqZ0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 18:38:59 +1000 (AEST)","from 6.mo1.mail-out.ovh.net (6.mo1.mail-out.ovh.net\n\t[46.105.43.205])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwfW01MtyzDqYd\n\tfor <openbmc@lists.ozlabs.org>; Mon, 18 Sep 2017 18:36:43 +1000 (AEST)","from player169.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 9036791D90\n\tfor <openbmc@lists.ozlabs.org>; Mon, 18 Sep 2017 09:59:54 +0200 (CEST)","from zorba.kaod.org (LFbn-1-2231-173.w90-76.abo.wanadoo.fr\n\t[90.76.52.173]) (Authenticated sender: postmaster@kaod.org)\n\tby player169.ha.ovh.net (Postfix) with ESMTPSA id 2A27F580087;\n\tMon, 18 Sep 2017 09:59:49 +0200 (CEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=kaod.org\n\t(client-ip=46.105.43.205; helo=6.mo1.mail-out.ovh.net;\n\tenvelope-from=clg@kaod.org; receiver=<UNKNOWN>)","Subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","To":"Joel Stanley <joel@jms.id.au>","References":"<20170915061830.1527-1-joel@jms.id.au>\n\t<9659eb97-6d10-d204-02a5-9359e2a09b8f@kaod.org>\n\t<CACPK8Xe3_XNjoLF5CzmY8dDFbg8ivs1Fm4nLXbpNonds85rW+Q@mail.gmail.com>","From":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Message-ID":"<860fa7c3-1d04-6df5-61dd-2a991414197c@kaod.org>","Date":"Mon, 18 Sep 2017 09:59:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<CACPK8Xe3_XNjoLF5CzmY8dDFbg8ivs1Fm4nLXbpNonds85rW+Q@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-Ovh-Tracer-Id":"9005228933207526146","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrheefgdekiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC <openbmc.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/openbmc/>","List-Post":"<mailto:openbmc@lists.ozlabs.org>","List-Help":"<mailto:openbmc-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>","Cc":"Andrew Jeffery <andrew@aj.id.au>,\n\tOpenBMC Maillist <openbmc@lists.ozlabs.org>","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}},{"id":1770136,"web_url":"http://patchwork.ozlabs.org/comment/1770136/","msgid":"<CACPK8XdV21+rY5zoKxhYReBVdm2PHz+ibqMpJ3rm6HVS4AyhGA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-18T12:49:32","subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/people/48628/","name":"Joel Stanley","email":"joel@jms.id.au"},"content":"On Mon, Sep 18, 2017 at 5:29 PM, Cédric Le Goater <clg@kaod.org> wrote:\n> On 09/18/2017 05:26 AM, Joel Stanley wrote:\n>> On Fri, Sep 15, 2017 at 4:55 PM, Cédric Le Goater <clg@kaod.org> wrote:\n>>> On 09/15/2017 08:18 AM, Joel Stanley wrote:\n>>>> Signed-off-by: Joel Stanley <joel@jms.id.au>\n>>>\n>>> We could fill the eeprom_buf with some valid data if needed.\n>>\n>>\n>>\n>> That's a good idea.\n>>\n>> When I use this I see the following error:\n>>\n>> # pwd\n>> /sys/devices/platform/ahb/ahb:apb/ahb:apb:i2c@1e78a000/1e78a100.i2c-bus\n>\n> hmm, the address is I2C bus 3.\n>\n>> # hexdump -C i2c-0/0-0050/eeprom\n>\n> But you use bus 0 ? weird.\n\nThe devicetree I was using lacked aliases. I fixed this (so bus 3\nshows up at i2c-0), and I get the same results.\n\nPalmetto worked fine for me, so it's just the EVB produces this behaviour.\n\nCheers,\n\nJoel","headers":{"Return-Path":"<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","openbmc@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","openbmc@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwm7K2c93z9s7F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 22:50:05 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwm7K0dV3zDrXy\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 22:50:05 +1000 (AEST)","from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com\n\t[IPv6:2a00:1450:4010:c07::22c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwm793KZszDrW1\n\tfor <openbmc@lists.ozlabs.org>; Mon, 18 Sep 2017 22:49:56 +1000 (AEST)","by mail-lf0-x22c.google.com with SMTP id y187so416061lfc.8\n\tfor <openbmc@lists.ozlabs.org>; Mon, 18 Sep 2017 05:49:56 -0700 (PDT)","by 10.25.103.82 with HTTP; Mon, 18 Sep 2017 05:49:32 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vOMJajcr\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vOMJajcr\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2a00:1450:4010:c07::22c; helo=mail-lf0-x22c.google.com;\n\tenvelope-from=joel.stan@gmail.com; receiver=<UNKNOWN>)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"vOMJajcr\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=5tnQNZ7mmi68mtkfmcQfA3WeeyX2mEhizqh3ahorQVw=;\n\tb=vOMJajcrAB8rvK0uQY3zfiXcKQFCafhndWSZjbr6QDP4YEa4fUuTPzL2gNaJ9Yo+aP\n\tKYL17sejjUr6lZkCcCVIjLuXPNJUf8MxPAIBAejTWrnZrmywxU3H66B8EgtsPV/+kFFs\n\tIJu7OMenrubZmSDDsQ9IyMVHX1OXK/lPNwi2yMWviOuTvnrtNJQA6CgAvj5xrRKYBOqJ\n\tY2t6YIlTkoOynebdKLwhmsc2oRVGokYn4z2evj9xWVda35iguFbQDP4Fev8m76Xv7clC\n\t+1WqoreDuhjPlUF64Hn+rSiTBCXxrjI61/tfg+gizrsjJnJF71GZPLX4EkMgUCI3txpM\n\tG0OQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=5tnQNZ7mmi68mtkfmcQfA3WeeyX2mEhizqh3ahorQVw=;\n\tb=F3CrIcRsdB924Cy10Um9amQ6J4eZsNjmgL1vzIuuiqHWTXEfjQ248LkmR0X0IKX/g+\n\tZgC0ffEvsmMAvwJoSPnGZgy9gJExPDJh3wepYuAQPVweRSNDSkMa79Dbu0Azg8IVes8k\n\tiS9HFNL+dq4KrmjMo4955pU6v/KOynydNkscj8VE65FvLIBPUb5KPpO+rFMrvfXmzspT\n\ta9+oBgv2p5llA6pWxlh6lYc45K9J3H8FQtl2mJxPRWo3/sU1GHKqUUicvBuh0wJ0XYY0\n\tA938ROFSgw98N8gNo+U41zOvFfNmXNqm5kcgwYRRhtQNE2BY8jpHWmNqdna29EiRrnsA\n\tTxFg==","X-Gm-Message-State":"AHPjjUhK7ozm2VtfnLeZn7xn6f8kOy3YDp31ALeberXW53pXxmPHJ0/w\n\tSxr6zwJXrXjvSIYPLXHqeQKK0K+dqeFYM4x5fVc=","X-Google-Smtp-Source":"AOwi7QBnEAWDydDZA7jZTWwirFOnmKRqVPdaF+aTu6aAscRhx2hV9XGNsYy4WtcWLp7EH7gPRsv0u/DDarOwVPYcUFY=","X-Received":"by 10.25.181.5 with SMTP id e5mr3303497lff.42.1505738992636; Mon,\n\t18 Sep 2017 05:49:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<860fa7c3-1d04-6df5-61dd-2a991414197c@kaod.org>","References":"<20170915061830.1527-1-joel@jms.id.au>\n\t<9659eb97-6d10-d204-02a5-9359e2a09b8f@kaod.org>\n\t<CACPK8Xe3_XNjoLF5CzmY8dDFbg8ivs1Fm4nLXbpNonds85rW+Q@mail.gmail.com>\n\t<860fa7c3-1d04-6df5-61dd-2a991414197c@kaod.org>","From":"Joel Stanley <joel@jms.id.au>","Date":"Mon, 18 Sep 2017 22:19:32 +0930","X-Google-Sender-Auth":"rJfdYCIFG2ruH0u7nMyXBLg0uHM","Message-ID":"<CACPK8XdV21+rY5zoKxhYReBVdm2PHz+ibqMpJ3rm6HVS4AyhGA@mail.gmail.com>","Subject":"Re: [PATCH qemu] arm: aspeed: Add palmetto and evb EEPROM I2C\n\tdevices","To":"=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"openbmc@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Development list for OpenBMC <openbmc.lists.ozlabs.org>","List-Unsubscribe":"<https://lists.ozlabs.org/options/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>","List-Archive":"<http://lists.ozlabs.org/pipermail/openbmc/>","List-Post":"<mailto:openbmc@lists.ozlabs.org>","List-Help":"<mailto:openbmc-request@lists.ozlabs.org?subject=help>","List-Subscribe":"<https://lists.ozlabs.org/listinfo/openbmc>,\n\t<mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>","Cc":"Andrew Jeffery <andrew@aj.id.au>,\n\tOpenBMC Maillist <openbmc@lists.ozlabs.org>","Errors-To":"openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"openbmc\"\n\t<openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>"}}]