[{"id":1769164,"web_url":"http://patchwork.ozlabs.org/comment/1769164/","msgid":"<20170915125533.GD4529@localhost.localdomain>","list_archive_url":null,"date":"2017-09-15T12:55:33","subject":"Re: [PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill\n\treturns err","submitter":{"id":65333,"url":"http://patchwork.ozlabs.org/api/people/65333/","name":"Marcelo Ricardo Leitner","email":"marcelo.leitner@gmail.com"},"content":"On Fri, Sep 15, 2017 at 11:02:48AM +0800, Xin Long wrote:\n> sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill\n> returns err, in which case it shouldn't mark sk dumped by setting\n> cb->args[3] as 1 in sctp_sock_dump().\n> \n> Otherwise, it could cause some asocs to have no parent's sk dumped\n> in 'ss --sctp'.\n> \n> So this patch is to not set cb->args[3] when inet_sctp_diag_fill()\n> returns err in sctp_sock_dump().\n> \n> Fixes: 8f840e47f190 (\"sctp: add the sctp_diag.c file\")\n> Signed-off-by: Xin Long \n\nAcked-by: Marcelo Ricardo Leitner \n\n> ---\n> net/sctp/sctp_diag.c | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c\n> index 7008a99..22ed01a 100644\n> --- a/net/sctp/sctp_diag.c\n> +++ b/net/sctp/sctp_diag.c\n> @@ -309,7 +309,6 @@ static int sctp_sock_dump(struct sctp_transport *tsp, void *p)\n> \t\t\t\t\tcb->nlh->nlmsg_seq,\n> \t\t\t\t\tNLM_F_MULTI, cb->nlh,\n> \t\t\t\t\tcommp->net_admin) < 0) {\n> -\t\t\tcb->args[3] = 1;\n> \t\t\terr = 1;\n> \t\t\tgoto release;\n> \t\t}\n> -- \n> 2.1.0\n> \n> --\n> To unsubscribe from this list: send the line \"unsubscribe linux-sctp\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=fail (p=none dis=none) header.from=gmail.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=marcelo.leitner@gmail.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtwPF0hnFz9s4s\n\tfor ;\n\tFri, 15 Sep 2017 22:55:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751483AbdIOMzn (ORCPT );\n\tFri, 15 Sep 2017 08:55:43 -0400","from mx1.redhat.com ([209.132.183.28]:48068 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751335AbdIOMzm (ORCPT );\n\tFri, 15 Sep 2017 08:55:42 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 01DFBC052426;\n\tFri, 15 Sep 2017 12:55:37 +0000 (UTC)","from localhost.localdomain (ovpn-116-12.gru2.redhat.com\n\t[10.97.116.12])\n\tby smtp.corp.redhat.com (Postfix) with SMTP id A802862463;\n\tFri, 15 Sep 2017 12:55:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 01DFBC052426","DKIM-Filter":"OpenDKIM Filter v2.11.0 mx1.redhat.com 01DFBC052426","Date":"Fri, 15 Sep 2017 09:55:33 -0300","From":"Marcelo Ricardo Leitner ","To":"Xin Long ","Cc":"network dev , linux-sctp@vger.kernel.org,\n\tdavem@davemloft.net, Neil Horman ","Subject":"Re: [PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill\n\treturns err","Message-ID":"<20170915125533.GD4529@localhost.localdomain>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 15 Sep 2017 12:55:42 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769170,"web_url":"http://patchwork.ozlabs.org/comment/1769170/","msgid":"<20170915125952.GB6031@hmswarspite.think-freely.org>","list_archive_url":null,"date":"2017-09-15T12:59:52","subject":"Re: [PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill\n\treturns err","submitter":{"id":411,"url":"http://patchwork.ozlabs.org/api/people/411/","name":"Neil Horman","email":"nhorman@tuxdriver.com"},"content":"On Fri, Sep 15, 2017 at 11:02:48AM +0800, Xin Long wrote:\n> sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill\n> returns err, in which case it shouldn't mark sk dumped by setting\n> cb->args[3] as 1 in sctp_sock_dump().\n> \n> Otherwise, it could cause some asocs to have no parent's sk dumped\n> in 'ss --sctp'.\n> \n> So this patch is to not set cb->args[3] when inet_sctp_diag_fill()\n> returns err in sctp_sock_dump().\n> \n> Fixes: 8f840e47f190 (\"sctp: add the sctp_diag.c file\")\n> Signed-off-by: Xin Long \n> ---\n> net/sctp/sctp_diag.c | 1 -\n> 1 file changed, 1 deletion(-)\n> \nAcked-by: Neil Horman ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtwV92zrSz9s4s\n\tfor ;\n\tFri, 15 Sep 2017 23:00:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751424AbdIOM76 (ORCPT );\n\tFri, 15 Sep 2017 08:59:58 -0400","from charlotte.tuxdriver.com ([70.61.120.58]:52631 \"EHLO\n\tsmtp.tuxdriver.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751184AbdIOM75 (ORCPT\n\t); Fri, 15 Sep 2017 08:59:57 -0400","from [2606:a000:111b:41f4:2201:d2d7:1fb:4ffb] (helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256)\n\t(Exim 4.63) (envelope-from )\n\tid 1dsqDp-0000TX-94; Fri, 15 Sep 2017 08:59:55 -0400"],"Date":"Fri, 15 Sep 2017 08:59:52 -0400","From":"Neil Horman ","To":"Xin Long ","Cc":"network dev , linux-sctp@vger.kernel.org,\n\tdavem@davemloft.net, Marcelo Ricardo Leitner ","Subject":"Re: [PATCH net] sctp: do not mark sk dumped when inet_sctp_diag_fill\n\treturns err","Message-ID":"<20170915125952.GB6031@hmswarspite.think-freely.org>","References":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Spam-Score":"-2.9 (--)","X-Spam-Status":"No","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769477,"web_url":"http://patchwork.ozlabs.org/comment/1769477/","msgid":"<20170915.145134.235758682095715785.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-15T21:51:34","subject":"Re: [PATCH net] sctp: do not mark sk dumped when\n\tinet_sctp_diag_fill returns err","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Xin Long \nDate: Fri, 15 Sep 2017 11:02:48 +0800\n\n> sctp_diag would not actually dump out sk/asoc if inet_sctp_diag_fill\n> returns err, in which case it shouldn't mark sk dumped by setting\n> cb->args[3] as 1 in sctp_sock_dump().\n> \n> Otherwise, it could cause some asocs to have no parent's sk dumped\n> in 'ss --sctp'.\n> \n> So this patch is to not set cb->args[3] when inet_sctp_diag_fill()\n> returns err in sctp_sock_dump().\n> \n> Fixes: 8f840e47f190 (\"sctp: add the sctp_diag.c file\")\n> Signed-off-by: Xin Long \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xv8HZ2ghrz9sNc\n\tfor ;\n\tSat, 16 Sep 2017 07:51:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751660AbdIOVvg (ORCPT );\n\tFri, 15 Sep 2017 17:51:36 -0400","from shards.monkeyblade.net ([184.105.139.130]:57886 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751563AbdIOVvf (ORCPT\n\t); Fri, 15 Sep 2017 17:51:35 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9B120133F6557;\n\tFri, 15 Sep 2017 14:51:34 -0700 (PDT)"],"Date":"Fri, 15 Sep 2017 14:51:34 -0700 (PDT)","Message-Id":"<20170915.145134.235758682095715785.davem@davemloft.net>","To":"lucien.xin@gmail.com","Cc":"netdev@vger.kernel.org, linux-sctp@vger.kernel.org,\n\tmarcelo.leitner@gmail.com, nhorman@tuxdriver.com","Subject":"Re: [PATCH net] sctp: do not mark sk dumped when\n\tinet_sctp_diag_fill returns err","From":"David Miller ","In-Reply-To":"","References":"","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 15 Sep 2017 14:51:34 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]