[{"id":1768930,"web_url":"http://patchwork.ozlabs.org/comment/1768930/","msgid":"<CA+=Sn1ntSpFFppQXkQOpESJ=KgRRLOUs034HvOASD46EZ1svUw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-15T03:20:27","subject":"Re: [RFC][AARCH64][PATCH 2/5]: Add number of hw prefetchers\n\tavailable to cpu_prefetch_tune","submitter":{"id":40,"url":"http://patchwork.ozlabs.org/api/people/40/","name":"Andrew Pinski","email":"pinskia@gmail.com"},"content":"On Thu, Sep 14, 2017 at 6:28 PM, Kugan Vivekanandarajah\n<kugan.vivekanandarajah@linaro.org> wrote:\n> This patch adds number of hw prefetchers available to\n> cpu_prefetch_tune so it can be used in loop unrolling decisions.\n\nCan you explain the difference between this and num_slots\n(PARAM_SIMULTANEOUS_PREFETCHES)?  Because it seems like they should be\nthe same here.\n\nThanks,\nAndrew\n\n>\n> Thanks,\n> Kugan\n>\n> gcc/ChangeLog:\n>\n> 2017-09-12  Kugan Vivekanandarajah  <kuganv@linaro.org>\n>\n>     * config/aarch64/aarch64-protos.h (struct cpu_prefetch_tune): Add\n>       new field hw_prefetchers_avail.\n>     * config/aarch64/aarch64.c: Add values for hw_prefetchers_avail.","headers":{"Return-Path":"<gcc-patches-return-462194-incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462194-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"I+Br5+R5\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtgdh3Ffcz9ryv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Sep 2017 13:20:39 +1000 (AEST)","(qmail 74724 invoked by alias); 15 Sep 2017 03:20:31 -0000","(qmail 74701 invoked by uid 89); 15 Sep 2017 03:20:31 -0000","from mail-io0-f195.google.com (HELO mail-io0-f195.google.com)\n\t(209.85.223.195) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 15 Sep 2017 03:20:30 +0000","by mail-io0-f195.google.com with SMTP id e9so2345775iod.5 for\n\t<gcc-patches@gcc.gnu.org>; Thu, 14 Sep 2017 20:20:29 -0700 (PDT)","by 10.157.27.244 with HTTP; Thu, 14 Sep 2017 20:20:27 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-type; q=dns; s=default; b=PSmNlg/LmU0yG9Z\n\t2MQiLjMwp514Eq1xlNRf5lMlGSUUCToUe7AjLOrQr1EXEQ309+qseTpU6CwLWq/y\n\tq88t+8bXz0NrGEbMeUvD3ffYZl2YnSxJyImTSBGRcjl9NrlSCcYf5fd87hl0YWZC\n\thp/993UFqtIeuUsudHhYQ1OHfR0k=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-type; s=default; bh=cMt/02N6w2Qoj8Kl9BuXw\n\tAksFf0=; b=I+Br5+R5tbeNzxvwZPlVCmXlKUkhldBCHMioKMLSGGkEW17YCvN1o\n\tyrXECyxR38g4NwAKlFwe6ZGxF7FiqigUqRFFL9OF7m7BNJU6srL1iDHfcxHQO+84\n\tJBBiFaJltLmlzOigc+cC/6g2C4AwpgKub8+gxNt511ezGq1CJ1xcko=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"<gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>","List-Archive":"<http://gcc.gnu.org/ml/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-help@gcc.gnu.org>","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.9 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=H*RU:209.85.223.195,\n\tHx-spam-relays-external:209.85.223.195","X-HELO":"mail-io0-f195.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=isl7lKEold6TyNCAg30ny7dGNN3JYwSbWOlm5YrWty4=;\n\tb=JhIbB7sU9vIYwq+QzrDC9CNBP51CBxqP3Sr3zSAovrVxusuy/ueXvNkffCFa4kTnOB\n\t+JIc1Og1s1rHygIWvFkE4gtvLNXTceYPR0vkIfkZBa2G+dGgDnhhrKTu85tClrPYcMt4\n\t+kUj7XBdEoFkcBTlHM+8FlmZmI9BIZ0xUl79evS2ZUG3byLhZX8xNksXyEetVc984XnK\n\tL6cxVhvtStQBnaVUqRhKWttuQF2M27avsiUotouaPqfLMKSHkZJyw8fffDtoI40um7FI\n\trlokxtgubLf53flN10KT/6zUV6ZfYwpP/h64T7zN4eb2CLpKqd3/dXWjniIkqBsC/RX1\n\tDKOw==","X-Gm-Message-State":"AHPjjUj30uh4A3tUBarGNcAGg02xZJ/xYB9sX5YjkAd9xRQmh35kVXjj\t6OXK0NuveIo3XUgoTQ/PjMPtIBq3YWD9ENTLT3M=","X-Google-Smtp-Source":"AOwi7QCfg3NjGbclLFDr1pCncieQ36vQPOPY2rFAf05pV2+CsK1xWefZr6b87I8koySjtvsvRiNuFfzGqGh/K+/rRao=","X-Received":"by 10.202.58.131 with SMTP id h125mr5531363oia.203.1505445628195;\n\tThu, 14 Sep 2017 20:20:28 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAELXzTORASUv0UGqNwWByWNNDY5xiiZA3Pt-TJfd+S1MWbgdNw@mail.gmail.com>","References":"<CAELXzTORASUv0UGqNwWByWNNDY5xiiZA3Pt-TJfd+S1MWbgdNw@mail.gmail.com>","From":"Andrew Pinski <pinskia@gmail.com>","Date":"Thu, 14 Sep 2017 20:20:27 -0700","Message-ID":"<CA+=Sn1ntSpFFppQXkQOpESJ=KgRRLOUs034HvOASD46EZ1svUw@mail.gmail.com>","Subject":"Re: [RFC][AARCH64][PATCH 2/5]: Add number of hw prefetchers\n\tavailable to cpu_prefetch_tune","To":"Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>","Cc":"\"gcc-patches@gcc.gnu.org\" <gcc-patches@gcc.gnu.org>","Content-Type":"text/plain; charset=\"UTF-8\"","X-IsSubscribed":"yes"}},{"id":1769652,"web_url":"http://patchwork.ozlabs.org/comment/1769652/","msgid":"<CAELXzTP8_tCbcwoH2Y9f7EeeuSDcqTMZW5M2+bT=egJrCAPB0w@mail.gmail.com>","list_archive_url":null,"date":"2017-09-16T22:51:07","subject":"Re: [RFC][AARCH64][PATCH 2/5]: Add number of hw prefetchers\n\tavailable to cpu_prefetch_tune","submitter":{"id":25768,"url":"http://patchwork.ozlabs.org/api/people/25768/","name":"Kugan Vivekanandarajah","email":"kugan.vivekanandarajah@linaro.org"},"content":"Hi Andrew,\n\nOn 15 September 2017 at 13:20, Andrew Pinski <pinskia@gmail.com> wrote:\n> On Thu, Sep 14, 2017 at 6:28 PM, Kugan Vivekanandarajah\n> <kugan.vivekanandarajah@linaro.org> wrote:\n>> This patch adds number of hw prefetchers available to\n>> cpu_prefetch_tune so it can be used in loop unrolling decisions.\n>\n> Can you explain the difference between this and num_slots\n> (PARAM_SIMULTANEOUS_PREFETCHES)?  Because it seems like they should be\n> the same here.\n>\nI kept it different for two reason.\n\n1. I am not sure if this would have the same effect on all the\nmicro-architecture. Keeping it separate allows each microarchitecture\nto enable prefetch loop arrays and aiding hw prefetcher (my goal here)\nby limiting prefetch streams.\n\n2. The params used for ARAM_SIMULTANEOUS_PREFETCHES seems to be a\nvalue determined by experimentation rather than based on functional\nunits in hardware. This also allows tuning them speretaterly.\n\nThanks,\nKugan","headers":{"Return-Path":"<gcc-patches-return-462319-incoming=patchwork.ozlabs.org@gcc.gnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462319-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"UW2JTHik\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvnZ120byz9t16\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 08:51:19 +1000 (AEST)","(qmail 109277 invoked by alias); 16 Sep 2017 22:51:11 -0000","(qmail 109266 invoked by uid 89); 16 Sep 2017 22:51:11 -0000","from mail-qk0-f178.google.com (HELO mail-qk0-f178.google.com)\n\t(209.85.220.178) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tSat, 16 Sep 2017 22:51:09 +0000","by mail-qk0-f178.google.com with SMTP id a128so4699498qkc.5 for\n\t<gcc-patches@gcc.gnu.org>; Sat, 16 Sep 2017 15:51:09 -0700 (PDT)","by 10.237.37.211 with HTTP; Sat, 16 Sep 2017 15:51:07 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-type; q=dns; s=default; b=jAvpuE5hgsu2TYm\n\tcJUGcWOCaWWgdAxiIXXyuyeheUkSKytCpAs/qEVJWkWxks9+9jd26VhWf7kw6ZqX\n\tMq0C3SeyhOTDMy1gonfxDV3l6ii3ti6FCiel/R7EQWm9oONZpefdcmVtAlHin13u\n\tckU8mt6q5f1vX/4WxGih0JAWszKo=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-type; s=default; bh=bN986rpo6PxrMBF2OrxO2\n\t7fw8rM=; b=UW2JTHikIowttdc8XK7Ol9PJvGX1uPM74awi3oiExRYZptvn1bVfo\n\t/HNamwoIEKnQ0exQEbdr9BBTmqRh7jLhsGbqQ6Qeard6/r4iVPFDpAuwFyVzM6Lg\n\tODQCR82ObZU3Awh+7yxBxnAzsiMJdT+CnaJ8eU6dT/764ajEW59DHg=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"<gcc-patches.gcc.gnu.org>","List-Unsubscribe":"<mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>","List-Archive":"<http://gcc.gnu.org/ml/gcc-patches/>","List-Post":"<mailto:gcc-patches@gcc.gnu.org>","List-Help":"<mailto:gcc-patches-help@gcc.gnu.org>","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.1 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=","X-HELO":"mail-qk0-f178.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=sSbyZaLVis4C4HHfg1ajJPeUYrcw4f7ahw/ws2JtxeE=;\n\tb=TSBD/qrCRusNEhhHK502Imwz1n50jpSullEKyqG9TmAzZ+lqw8tWgBSh9orQZ24DFA\n\tNIZcQhx7payjPlxkJpXqhR4f+k0JP4Mewy/31loO4eHo0kIHbtcknj0dx+OtaGl5leOf\n\tkOf5VXJDcS3zyJpF697Kyrzd2SEHjbhUlC8BApMa8+tX+8Vo9ANO1doISmf6A+q+1Kx7\n\tHNoarxs0JYbCt9U5IA3aMIC0vXeWJYUf04OrkfGJQLLRr9LCxYKJfoPwhicG7QGV0FGy\n\tyQAZYDfUk46pXQSsr+WuMSJwIFYMZgepOZNecoNJG+oijUeNqAZOoRrgn/FItEz4ivH9\n\tJ81g==","X-Gm-Message-State":"AHPjjUhUY24Dpj7vVx8ozjJ5iFgD7Tow974b2P4TarZeBKwW+g3ZW1Zb\tevnXA5UJrwi4aAjKRJAB1xslqIcwIXhjxMRumrwFR3ddL1E=","X-Google-Smtp-Source":"AOwi7QBl1pDF7+H9EpMRgdoVJpLJC2blmzoskKRDmNlBVV+cl2l88BYl3T/iLzRWGBQG8XeSeYY54sAE5PakW3LsXLg=","X-Received":"by 10.55.40.196 with SMTP id o65mr14714250qko.325.1505602268020;\n\tSat, 16 Sep 2017 15:51:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CA+=Sn1ntSpFFppQXkQOpESJ=KgRRLOUs034HvOASD46EZ1svUw@mail.gmail.com>","References":"<CAELXzTORASUv0UGqNwWByWNNDY5xiiZA3Pt-TJfd+S1MWbgdNw@mail.gmail.com>\n\t<CA+=Sn1ntSpFFppQXkQOpESJ=KgRRLOUs034HvOASD46EZ1svUw@mail.gmail.com>","From":"Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>","Date":"Sun, 17 Sep 2017 08:51:07 +1000","Message-ID":"<CAELXzTP8_tCbcwoH2Y9f7EeeuSDcqTMZW5M2+bT=egJrCAPB0w@mail.gmail.com>","Subject":"Re: [RFC][AARCH64][PATCH 2/5]: Add number of hw prefetchers\n\tavailable to cpu_prefetch_tune","To":"Andrew Pinski <pinskia@gmail.com>","Cc":"\"gcc-patches@gcc.gnu.org\" <gcc-patches@gcc.gnu.org>","Content-Type":"text/plain; charset=\"UTF-8\"","X-IsSubscribed":"yes"}}]