[{"id":1951136,"web_url":"http://patchwork.ozlabs.org/comment/1951136/","msgid":"","list_archive_url":null,"date":"2018-07-10T20:57:09","subject":"Re: [U-Boot] [PATCH v2 8/8] test/py: vboot: Remove stderr redirect\n\tfrom openssl command","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 14 September 2017 at 15:34, Paul Burton wrote:\n> The openssl command specified in test_with_algo() ultimately ends up\n> being run by RunAndLog::run(), which uses it to construct a Popen object\n> with the default shell=False. The stderr redirect in the command is\n> therefore simply passed to openssl as an argument. With at least openssl\n> 1.1.0f this causes openssl, and therefore test_vboot, to fail with:\n>\n> genpkey: Use -help for summary.\n> Exit code: 1\n>\n> Any stderr output ought to be captured & stored in the RunAndLog\n> object's output field and returned from run() via run_and_log() to\n> test_with_algo() which then ignores it anyway, so we can drop the\n> shell-like redirection with no ill effects. With this fix test_vboot now\n> passes for me.\n>\n> Signed-off-by: Paul Burton \n> Reviewed-by: Stephen Warren \n>\n> ---\n>\n> Changes in v2:\n> - Place the % operator at the end of the last string line, not the start of the next.\n>\n> test/py/tests/test_vboot.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n\nApplied to u-boot-dm, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org; dmarc=fail (p=none dis=none)\n\theader.from=chromium.org","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"okAT4mqe\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"gCeJHLBt\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 41QF416q26z9s37\n\tfor ;\n\tWed, 11 Jul 2018 07:01:21 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 12C10C21E07; Tue, 10 Jul 2018 20:59:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1BCBDC21E53;\n\tTue, 10 Jul 2018 20:58:08 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8833EC21DF3; Tue, 10 Jul 2018 20:57:36 +0000 (UTC)","from mail-oi0-f67.google.com (mail-oi0-f67.google.com\n\t[209.85.218.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 2FDB3C21E2F\n\tfor ; Tue, 10 Jul 2018 20:57:32 +0000 (UTC)","by mail-oi0-f67.google.com with SMTP id b15-v6so45269815oib.10\n\tfor ; Tue, 10 Jul 2018 13:57:32 -0700 (PDT)","by 2002:ac9:3c0c:0:0:0:0:0 with HTTP; Tue, 10 Jul 2018 13:57:09\n\t-0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=gxIyavU18x+ToLLX2iUmeO3hIxYQHDaTdqs9m7XY8Rs=;\n\tb=okAT4mqeG+yNbga9a5GabxANuV4wpT8McWYtQW2WoxR8w2me76wGYfUrKqpAVE8avU\n\tURGUjePZmxCY1XYsi9F9pvID/JQdJkJeS34SuxGCxGg/IysGHQRzTLLfunOM8sbyfUgL\n\t6PEPYYb5ccVfHa2Xbr4YGRlT3OMEh5RTRBMqgjNrgEQTzlIxFFW3iI71AXzCPjTPTxVC\n\twUVFF9Ff5CNDTPME3fIaSIZR8cjW9V9kaxZzkXknUwLEkgrzXYZbbs+yvsGu5hvG7jio\n\tikzD2H6z/nrGWdQhrCKtuv8o7FNqEcJRuKGVUyhK81cb80qSHPOg1Wshd9EyKDA51NjD\n\tUjwQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=gxIyavU18x+ToLLX2iUmeO3hIxYQHDaTdqs9m7XY8Rs=;\n\tb=gCeJHLBtLtzUZB833UMD8OvU/gv45MsnevGamgCIRebLTFIehw/FCYZcBgW/omjOGu\n\tmja3mKdyFhyU2AEJhwbmGm7M8FolFR8RQGVmKj3RUos9/uWlyCP8FuZLlPB36eZo44zz\n\tr5Vo+zj9EnHZOxWZ1J8lwtxcvVx6eqFMvfoB8="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=gxIyavU18x+ToLLX2iUmeO3hIxYQHDaTdqs9m7XY8Rs=;\n\tb=TbN7rLH8y0UDbqn9aytrimsobRkDgseFQjJhpSRe2udyz6YaHuTWG75PKb+kFqMDJX\n\tTb4pZAbrYJPmCAXDxB2qqgHKmf1+ggjN6iqPmefkASU917Vjo9YjtHPleU9RiXwCUTz7\n\tadXt9c/8A5hSknUj/iVDEiQjbN2/+/pzNuO+NAt3cg2zDk0/zG254xICtsyRmoeWDXtH\n\tS5M0AUYuxgnK1HE9AXu0Kww//7X85T50Rbq+QvMYvONL71zDsWmbJHBG1/Sd+TjXmHrP\n\tNlbmOVBdEfRLMcRXNhDoK+P7iOkzxWtFK71tHc7yi8sK5aDf6RIXXo09NJjqTc3eMiRh\n\ttXyg==","X-Gm-Message-State":"APt69E29qpG0/GL77/70T1MYG3OkEZJUMEpOgCsmITClK9YRJq5DmFEx\n\tZk79zI41mbcR0OQGS2xM7Tu4fdle/N1cPNlB7qoiYGMC","X-Google-Smtp-Source":"AAOMgpcCgbkBWkUTv0dK+UR09QGDPExKA0BByoOmhBJnwy15ZGZL8tn7xpcs+hmpoAtbHJn+2qqyY5rk7dvha8mTVJQ=","X-Received":"by 2002:aca:b641:: with SMTP id\n\tg62-v6mr32558739oif.71.1531256250553; \n\tTue, 10 Jul 2018 13:57:30 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170914213450.28754-9-paul.burton@imgtec.com>","References":"<20170914213450.28754-1-paul.burton@imgtec.com>\n\t<20170914213450.28754-9-paul.burton@imgtec.com>","From":"Simon Glass ","Date":"Tue, 10 Jul 2018 14:57:09 -0600","X-Google-Sender-Auth":"Msof3TqNN7j4vyrS7aq_aHd7JJM","Message-ID":"","To":"Paul Burton ","Cc":"U-Boot Mailing List ,\n\tStephen Warren ","Subject":"Re: [U-Boot] [PATCH v2 8/8] test/py: vboot: Remove stderr redirect\n\tfrom openssl command","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]