[{"id":1769791,"web_url":"http://patchwork.ozlabs.org/comment/1769791/","msgid":"","list_archive_url":null,"date":"2017-09-17T17:54:45","subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi York,\n\nOn 14 September 2017 at 13:01, York Sun wrote:\n> This partially reverts commit 15eb1d43bf470b85e9031c2fce7e0ce7b27dd321\n> which intended to move assignment of board info earlier, into\n> board_init_r(). However, function preload_console_init() is called\n> either from spl_board_init() or from board_init_f(). For the latter\n> case, the board info assignment is much earlier than board_init_r().\n> Moving such assignment to board_init_r() would be moving it later.\n>\n> Signed-off-by: York Sun \n> CC: Lokesh Vutla \n> CC: Ravi Babu \n> CC: Lukasz Majewski \n> CC: Tom Rini \n>\n> ---\n>\n> Changes in v2:\n> New patch to fix spl after rebasing to latest master.\n>\n> common/spl/spl.c | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n>\n> diff --git a/common/spl/spl.c b/common/spl/spl.c\n> index ce9819e..98b0ca0 100644\n> --- a/common/spl/spl.c\n> +++ b/common/spl/spl.c\n> @@ -365,7 +365,10 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n> struct spl_image_info spl_image;\n>\n> debug(\">>spl:board_init_r()\\n\");\n> - gd->bd = &bdata;\n> +\n> + if (!gd->bd)\n> + gd->bd = &bdata;\n> +\n> #ifdef CONFIG_SPL_OS_BOOT\n> dram_init_banksize();\n> #endif\n> @@ -450,6 +453,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n> */\n> void preloader_console_init(void)\n> {\n> + if (!gd->bd)\n> + gd->bd = &bdata;\n> +\n\nIt seems odd that enabling the console sets this data.\n\nWhat was the impact of moving it later for your board?\n\n\n> gd->baudrate = CONFIG_BAUDRATE;\n>\n> serial_init(); /* serial communications setup */\n> --\n> 2.7.4\n>\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"XLIheqjd\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"TYT2s9q0\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwM9W3yvXz9s76\n\tfor ;\n\tMon, 18 Sep 2017 07:05:35 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 54F38C21D64; Sun, 17 Sep 2017 21:05:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 31F97C21EEE;\n\tSun, 17 Sep 2017 17:57:05 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 18150C21EEE; Sun, 17 Sep 2017 17:57:04 +0000 (UTC)","from mail-qt0-f170.google.com (mail-qt0-f170.google.com\n\t[209.85.216.170])\n\tby lists.denx.de (Postfix) with ESMTPS id EEF9BC21E08\n\tfor ; Sun, 17 Sep 2017 17:55:06 +0000 (UTC)","by mail-qt0-f170.google.com with SMTP id x54so5766384qth.12\n\tfor ; Sun, 17 Sep 2017 10:55:06 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 17 Sep 2017 10:54:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=xoQtv6XASsQk1KdLbFgNX3xBJNj/fsYfwRARFmLFxSg=;\n\tb=XLIheqjd0QK99DfxFIcpKq+RUfYT1UT1FP8pXpqDFm0UJHMCE8kjnL5IXjsH/Je5Gi\n\tWe5FKbhPsZEljG57jffsGcKsQc27UnAsx5v9kRP34Qlufw8uX1DqgIdWkE4dq4ap2cAk\n\thkg7iwfbdzDqQvqtQDc0YmcjJ1D41/28IIOBtOVYmZkCeioKY6O/izJaRVt47tc8/x7X\n\t8tA4A13m/Lr2ZeP9brc8bd/BdQORKlw/zy16CnILNIab6MAJ1u5DQ2pSoErYMQtJqZ9u\n\tSWwiPX0MNUjcek6oSLtn1AlYb76R1ncLzTsNnKiq3mNXxvT7Ni5gsWh2ZhLcLkThVcVh\n\tYklw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=xoQtv6XASsQk1KdLbFgNX3xBJNj/fsYfwRARFmLFxSg=;\n\tb=TYT2s9q0r9J1jyHmgt9vvfsRqy9xH/Tc7NGKDOnur+VnC2R4fldk6IQzctfLAHGo0d\n\tELXgvxezQEnBnPsCAYdsmXemfht+h9DJh72qwzp6AeAQcFWcq3phtJ+/WvSWkdOSSDeq\n\tTXzYscYVraMr8Sd4wv6TDRjMqirATngAQaVCM="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=xoQtv6XASsQk1KdLbFgNX3xBJNj/fsYfwRARFmLFxSg=;\n\tb=GYG0d9txGqZ9XK7dlCTIJeiNcUVI9A9hjz2taczDUMB7e9S/QzPRiRKGQTktQ8uxKz\n\tyyJiNn2FLfSe/26ohiDIy0RoGDOPpfL4VB34LJcl6YAXKRN4W5Sd5DZlGPMGIkvWthj7\n\t1UYolw9McGcLTnWaRtd+Y6CiRfYi52c79f0A6Jve2iYxSAJDjvS3TtDOxUA3x3VJGZ4n\n\taBJSZhJE1MF7iI0HtXLvQd4CXOKBQKXUpv/cOirwq1Usmb0kKCxxVvvY3A08zmbqZUKF\n\ty5+OrIT2sn4HcBzruMksIqoZrkn8cs7VD1EbS1muiWn04+QvaXr9mUrycbQRiTg1uu3d\n\touZg==","X-Gm-Message-State":"AHPjjUht7XLW2okmhNY4geJfPygJ/TDg+dQbWf74byrcHDCMfJOH0hwH\n\tKkyMhz+Imz4aaENUdbwAhjzCQRB9WxWBKLy4yt5NWQ==","X-Google-Smtp-Source":"AOwi7QCtq6uqiXn1RAqjCrWVrftVtpm4pf5xrGrqQAu57npa+FKu8TeK8gGr4cH3mN5044wHPYKDxc82zaDlnVBKBEw=","X-Received":"by 10.200.52.241 with SMTP id x46mr38443843qtb.38.1505670905755; \n\tSun, 17 Sep 2017 10:55:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505415699-3401-2-git-send-email-york.sun@nxp.com>","References":"<1505415699-3401-1-git-send-email-york.sun@nxp.com>\n\t<1505415699-3401-2-git-send-email-york.sun@nxp.com>","From":"Simon Glass ","Date":"Sun, 17 Sep 2017 11:54:45 -0600","X-Google-Sender-Auth":"Sx8oomM5YZG2Wg6w7G12IT-HJzY","Message-ID":"","To":"York Sun ","Cc":"Tom Rini , Stefan Agner , \n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1770266,"web_url":"http://patchwork.ozlabs.org/comment/1770266/","msgid":"","list_archive_url":null,"date":"2017-09-18T15:46:34","subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 09/17/2017 10:55 AM, Simon Glass wrote:\n> Hi York,\n> \n> On 14 September 2017 at 13:01, York Sun wrote:\n>> This partially reverts commit 15eb1d43bf470b85e9031c2fce7e0ce7b27dd321\n>> which intended to move assignment of board info earlier, into\n>> board_init_r(). However, function preload_console_init() is called\n>> either from spl_board_init() or from board_init_f(). For the latter\n>> case, the board info assignment is much earlier than board_init_r().\n>> Moving such assignment to board_init_r() would be moving it later.\n>>\n>> Signed-off-by: York Sun \n>> CC: Lokesh Vutla \n>> CC: Ravi Babu \n>> CC: Lukasz Majewski \n>> CC: Tom Rini \n>>\n>> ---\n>>\n>> Changes in v2:\n>> New patch to fix spl after rebasing to latest master.\n>>\n>> common/spl/spl.c | 8 +++++++-\n>> 1 file changed, 7 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/common/spl/spl.c b/common/spl/spl.c\n>> index ce9819e..98b0ca0 100644\n>> --- a/common/spl/spl.c\n>> +++ b/common/spl/spl.c\n>> @@ -365,7 +365,10 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n>> struct spl_image_info spl_image;\n>>\n>> debug(\">>spl:board_init_r()\\n\");\n>> - gd->bd = &bdata;\n>> +\n>> + if (!gd->bd)\n>> + gd->bd = &bdata;\n>> +\n>> #ifdef CONFIG_SPL_OS_BOOT\n>> dram_init_banksize();\n>> #endif\n>> @@ -450,6 +453,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n>> */\n>> void preloader_console_init(void)\n>> {\n>> + if (!gd->bd)\n>> + gd->bd = &bdata;\n>> +\n> \n> It seems odd that enabling the console sets this data.\n> \n> What was the impact of moving it later for your board?\n> \n\ngd->bd is used to track the dram bank information. With this moved \nlater, I cannot track the secure memory reserved. I need this available \nbefore memory is initialized.\n\nYork","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"AAfsvTTB\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwr3n3fLCz9s5L\n\tfor ;\n\tTue, 19 Sep 2017 01:47:17 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 353DDC21F14; Mon, 18 Sep 2017 15:47:03 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 18ED8C21F4D;\n\tMon, 18 Sep 2017 15:46:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6AE01C21F62; Mon, 18 Sep 2017 15:46:36 +0000 (UTC)","from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30074.outbound.protection.outlook.com [40.107.3.74])\n\tby lists.denx.de (Postfix) with ESMTPS id E8C13C21F4D\n\tfor ; Mon, 18 Sep 2017 15:46:35 +0000 (UTC)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB3230.eurprd04.prod.outlook.com (10.170.227.27) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.11; Mon, 18 Sep 2017 15:46:34 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::6943:4a49:ab20:5920]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::6943:4a49:ab20:5920%13]) with mapi id 15.20.0056.016;\n\tMon, 18 Sep 2017 15:46:34 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=EyYY6r/y+dQhq02QsAUXRK+ewts0fSNHpEDr85UPUtk=;\n\tb=AAfsvTTB2epXfqdPSsh9sfVuRREqVW6iK6Fdx+9r9mkYblIi7FR4jgrVr7hSdyoVB31hkDHEoZu6dh/fJekT9qr6O8/gUsR5QCeY4yPGHa5AKfoONJD+8T52H2Ly/k3L16bxe51DAXkWPr0ZZGaA/TEXaTBQtiyb7uHugX5/QnQ=","From":"York Sun ","To":"Simon Glass ","Thread-Topic":"[PATCH v2 1/7] spl: fix assignment of board info to global data","Thread-Index":"AQHTLYv24PZk+ELH/0+uA5vJUQwFjg==","Date":"Mon, 18 Sep 2017 15:46:34 +0000","Message-ID":"","References":"<1505415699-3401-1-git-send-email-york.sun@nxp.com>\n\t<1505415699-3401-2-git-send-email-york.sun@nxp.com>\n\t","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"AAfsvTTB\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[24.56.243.53]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB3230;\n\t6:dNn6SB/MS5n5L2od/J1tTV3yCzZ0yhQQz5AXNf+6AWyGCWyPVqLHHZWwnCxzeprbhGmJwGMnE9sf37sip/OHWNSmDuo7mrAIPFHFrNCMregargcwQwoE5Tmox7MqaU9Ddx79Ps/iodE6oLvcwx+DveqKTvZtHJ6/OlAIqtrb9hgtnov+848MfRhMYAK+efGl2ueBJvrrdk7EFpmimKEz1XxAxY2++CojKNLip4AKD+MW1irzS8WzgsUQ5AcGRM6NJq+LmBdHxhtpWdyzQpmZ5cwLZ/ilJJHSvfTSUF4oCUjqSJsV43Vj5lh7ORMuRJj/LuuePMlThV6dpPrc29NhrA==;\n\t5:benQpMs2w/3EFTOR5LU5gjUegGNZIp/uK039c6ZM0lnr69qp7Y6G2Lzcfl8VIIZoOVX05GiWkRu0AUDVkvRWFBFbynAtaDzlA723fpmuVy/oi5iNp/nPcnGuXW/0KTD4KfgwGmMEi+AmIg94xTC8Yg==;\n\t24:FZPiqkOgWogYbRRjs7W8ST6MzxIqmCkovWpL4JsEoIFd6fak3aF7Mkg+E/8/vlj52RdxTPjBSC1FPWmcDfREL8Yyb9blcxmXDskUMJ8SGow=;\n\t7:0TcSuth7crrofZH4EjpPbCpoFbx9ygyBFTKw5UJ7gY8sozY12zyCNHpCAfuW2WZfszoh5nIgXeeOCTCER6hvL4mLgY/bnqaRnRQpRNqkqDT8w3pAkKP+YUbumRavNIX95BHKAgic2Yr663WI7DCBLOg0SUPR/TXWKH2F4R25RfMwB/xau1VPrJBY5PuVsnUV8AL1M3QQVx4Pjpfn19kjXVwZ9N2W6yQQXvoOaVHQfYc=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-ms-office365-filtering-correlation-id":"a8dd95ae-c588-4184-6aa7-08d4feac7097","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB3230; ","x-ms-traffictypediagnostic":"VI1PR04MB3230:","x-exchange-antispam-report-test":"UriScan:(31051911155226)(185117386973197);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB3230; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB3230; ","x-forefront-prvs":"04347F8039","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(376002)(346002)(199003)(189002)(24454002)(377454003)(8936002)(6916009)(101416001)(478600001)(53546010)(6436002)(43066003)(305945005)(3450700001)(3280700002)(68736007)(5250100002)(3660700001)(7736002)(25786009)(54356999)(76176999)(50986999)(14454004)(86362001)(7696004)(2900100001)(575784001)(33656002)(2906002)(74316002)(4326008)(229853002)(6246003)(110136004)(106356001)(39060400002)(6116002)(102836003)(3846002)(7416002)(8676002)(316002)(9686003)(66066001)(54906002)(99286003)(55016002)(105586002)(53936002)(81156014)(81166006)(5660300001)(189998001)(97736004)(6506006);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB3230;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"18 Sep 2017 15:46:34.1633\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB3230","Cc":"Tom Rini , Stefan Agner , \n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"York Sun ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1771978,"web_url":"http://patchwork.ozlabs.org/comment/1771978/","msgid":"","list_archive_url":null,"date":"2017-09-20T15:20:06","subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","submitter":{"id":67822,"url":"http://patchwork.ozlabs.org/api/people/67822/","name":"York Sun","email":"york.sun@nxp.com"},"content":"On 09/18/2017 08:47 AM, York Sun wrote:\n> On 09/17/2017 10:55 AM, Simon Glass wrote:\n>> Hi York,\n>>\n>> On 14 September 2017 at 13:01, York Sun wrote:\n>>> This partially reverts commit 15eb1d43bf470b85e9031c2fce7e0ce7b27dd321\n>>> which intended to move assignment of board info earlier, into\n>>> board_init_r(). However, function preload_console_init() is called\n>>> either from spl_board_init() or from board_init_f(). For the latter\n>>> case, the board info assignment is much earlier than board_init_r().\n>>> Moving such assignment to board_init_r() would be moving it later.\n>>>\n>>> Signed-off-by: York Sun \n>>> CC: Lokesh Vutla \n>>> CC: Ravi Babu \n>>> CC: Lukasz Majewski \n>>> CC: Tom Rini \n>>>\n>>> ---\n>>>\n>>> Changes in v2:\n>>> New patch to fix spl after rebasing to latest master.\n>>>\n>>> common/spl/spl.c | 8 +++++++-\n>>> 1 file changed, 7 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/common/spl/spl.c b/common/spl/spl.c\n>>> index ce9819e..98b0ca0 100644\n>>> --- a/common/spl/spl.c\n>>> +++ b/common/spl/spl.c\n>>> @@ -365,7 +365,10 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n>>> struct spl_image_info spl_image;\n>>>\n>>> debug(\">>spl:board_init_r()\\n\");\n>>> - gd->bd = &bdata;\n>>> +\n>>> + if (!gd->bd)\n>>> + gd->bd = &bdata;\n>>> +\n>>> #ifdef CONFIG_SPL_OS_BOOT\n>>> dram_init_banksize();\n>>> #endif\n>>> @@ -450,6 +453,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n>>> */\n>>> void preloader_console_init(void)\n>>> {\n>>> + if (!gd->bd)\n>>> + gd->bd = &bdata;\n>>> +\n>>\n>> It seems odd that enabling the console sets this data.\n>>\n\nI don't know the history of this line. But it seems this the common \nfunction called by board_init_f from various board level spl file.\n\n>> What was the impact of moving it later for your board?\n>>\n> \n> gd->bd is used to track the dram bank information. With this moved\n> later, I cannot track the secure memory reserved. I need this available\n> before memory is initialized.\n\nThe intention of 15eb1d43b was to move it earlier. But it turns out \nfunction preloader_console_init() is called from different places. Some \nare very early in board_init_f(). I guess we can add a new function just \nto set gd->bd if it is empty, and call this function when needed. What's \nyour suggestion here?\n\nYork","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"L2oO7WUr\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy3Ms2Zbcz9s7B\n\tfor ;\n\tThu, 21 Sep 2017 01:20:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B14BAC21F6C; Wed, 20 Sep 2017 15:20:14 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 403DDC21DA2;\n\tWed, 20 Sep 2017 15:20:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 94ED8C21DA2; Wed, 20 Sep 2017 15:20:10 +0000 (UTC)","from EUR01-HE1-obe.outbound.protection.outlook.com\n\t(mail-he1eur01on0045.outbound.protection.outlook.com [104.47.0.45])\n\tby lists.denx.de (Postfix) with ESMTPS id E6A6DC21D99\n\tfor ; Wed, 20 Sep 2017 15:20:09 +0000 (UTC)","from VI1PR04MB2078.eurprd04.prod.outlook.com (10.166.43.18) by\n\tVI1PR04MB1374.eurprd04.prod.outlook.com (10.163.166.17) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Wed, 20 Sep 2017 15:20:06 +0000","from VI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::6943:4a49:ab20:5920]) by\n\tVI1PR04MB2078.eurprd04.prod.outlook.com\n\t([fe80::6943:4a49:ab20:5920%13]) with mapi id 15.20.0056.018;\n\tWed, 20 Sep 2017 15:20:06 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=9XgUVbu0BHDRydfAyqbH54NMtORmR7N8eaOUAKkGhH0=;\n\tb=L2oO7WUr3s55M0LLmPYgagnn7mKLMaOxxBkYQZkEHP3tclTva+dgw4SEyR6PCSjxz7F3bgnOz4Pmrdfl9OM6LgaCkqWYqFrfw7MLHJsefFspMwpD1eniMr8qYuoU/zzz2194of0lf2ofQmfF/MZbThDYTP3twWpQJhz1xTGeVKo=","From":"York Sun ","To":"Simon Glass ","Thread-Topic":"[U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","Thread-Index":"AQHTLYv24PZk+ELH/0+uA5vJUQwFjg==","Date":"Wed, 20 Sep 2017 15:20:06 +0000","Message-ID":"","References":"<1505415699-3401-1-git-send-email-york.sun@nxp.com>\n\t<1505415699-3401-2-git-send-email-york.sun@nxp.com>\n\t\n\t","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"L2oO7WUr\";\n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=york.sun@nxp.com; "],"x-originating-ip":"[75.145.19.30]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; VI1PR04MB1374;\n\t6:gI4hhj5xubEHsXTj8L2lD92OWZwx2bthewhM9AsA2qQaaS76NUmdvxPhdOiOfr54f02sG0cfk9si1L2DI75jl3hVrqHbt2KIou2GMaLnFQi4CQzRdh6bf2Q8fowxDwpMsMOdZU0qK/Y5H2L51ebYaSeqvwTQflaoXYGpiArpHRF14LA5YTbz8SGmHkTSdjtLAXIszXhNJUR9L0d04yKkKZyxfwqsokfWD4BRF/2/Vqq1eBYea2bA+O/t/Ln1sGBJEjF+N5L/wfsO+wY/r5c/JkcE8OWMlSR0Av8FNGmzu+RYVeyWYv/SU0JIiVfTBvnTYJz50mH8mulu4xF2d+5Q3A==;\n\t5:l947EZUF4CV6j94GksCpS2RI8IX3CuP37qLyy+zB6NuFsOn4AHZxICLWApZZsWo92WZ6dnX4eR58Jon9rSnTkxb/OsqXuxFRibDLz8WKUNPEH3+GutSajF2ib2fELVZhfswFRMmo3STL4yiQaQvycw==;\n\t24:galVKBWm1dZxPo5eEQpyi5J9GV7B75GsdYKjJmGaqHlt6sQMpg94YCZgFA7f2C86F3uYgoPmtpJ/gR/eSdNsgWAOIziK2YO7tguOtG1grTQ=;\n\t7:JlLtUPPxhO1Jc4dBpFc3lPENyhQdZPeDoHMCWiWSMQnQczvO3UF17Ad3kWcCoRv8frD9baf6h1MOpiqlfqRXWUSAJ5IPfiRIkSyg8ZWE9+RfjGLL/zUFPVZXJ99bQCHkp3/ecb2LK9DFQZL05zZbIW7wa1y/5Tr8uQtkHblYw/Rp32VMEtq6rV1Jt2Razj2jAERlecvQ3znXW49+d+SrLqwxy91AFDXMNx7VJ4vB4Z0=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ld-processed":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr","x-ms-office365-filtering-correlation-id":"26048f12-a3f3-4579-0e31-08d5003b1341","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:VI1PR04MB1374; ","x-ms-traffictypediagnostic":"VI1PR04MB1374:","x-exchange-antispam-report-test":"UriScan:(31051911155226)(185117386973197);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:VI1PR04MB1374; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:VI1PR04MB1374; ","x-forefront-prvs":"04362AC73B","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(346002)(376002)(377454003)(24454002)(189002)(199003)(2906002)(33656002)(575784001)(93886005)(2900100001)(68736007)(86362001)(3660700001)(3450700001)(53546010)(3280700002)(6916009)(53936002)(55016002)(3846002)(9686003)(99286003)(229853002)(14454004)(6436002)(6506006)(6116002)(4326008)(102836003)(7696004)(6246003)(8676002)(25786009)(81166006)(66066001)(97736004)(5660300001)(105586002)(81156014)(5250100002)(189998001)(43066003)(106356001)(54356999)(305945005)(316002)(76176999)(74316002)(101416001)(7736002)(54906003)(50986999)(8936002)(478600001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1374;\n\tH:VI1PR04MB2078.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"20 Sep 2017 15:20:06.7800\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"VI1PR04MB1374","Cc":"Tom Rini , Stefan Agner , \n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"York Sun ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1774372,"web_url":"http://patchwork.ozlabs.org/comment/1774372/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:13:35","subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi York,\n\nOn 20 September 2017 at 09:20, York Sun wrote:\n> On 09/18/2017 08:47 AM, York Sun wrote:\n>> On 09/17/2017 10:55 AM, Simon Glass wrote:\n>>> Hi York,\n>>>\n>>> On 14 September 2017 at 13:01, York Sun wrote:\n>>>> This partially reverts commit 15eb1d43bf470b85e9031c2fce7e0ce7b27dd321\n>>>> which intended to move assignment of board info earlier, into\n>>>> board_init_r(). However, function preload_console_init() is called\n>>>> either from spl_board_init() or from board_init_f(). For the latter\n>>>> case, the board info assignment is much earlier than board_init_r().\n>>>> Moving such assignment to board_init_r() would be moving it later.\n>>>>\n>>>> Signed-off-by: York Sun \n>>>> CC: Lokesh Vutla \n>>>> CC: Ravi Babu \n>>>> CC: Lukasz Majewski \n>>>> CC: Tom Rini \n>>>>\n>>>> ---\n>>>>\n>>>> Changes in v2:\n>>>> New patch to fix spl after rebasing to latest master.\n>>>>\n>>>> common/spl/spl.c | 8 +++++++-\n>>>> 1 file changed, 7 insertions(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/common/spl/spl.c b/common/spl/spl.c\n>>>> index ce9819e..98b0ca0 100644\n>>>> --- a/common/spl/spl.c\n>>>> +++ b/common/spl/spl.c\n>>>> @@ -365,7 +365,10 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n>>>> struct spl_image_info spl_image;\n>>>>\n>>>> debug(\">>spl:board_init_r()\\n\");\n>>>> - gd->bd = &bdata;\n>>>> +\n>>>> + if (!gd->bd)\n>>>> + gd->bd = &bdata;\n>>>> +\n>>>> #ifdef CONFIG_SPL_OS_BOOT\n>>>> dram_init_banksize();\n>>>> #endif\n>>>> @@ -450,6 +453,9 @@ void board_init_r(gd_t *dummy1, ulong dummy2)\n>>>> */\n>>>> void preloader_console_init(void)\n>>>> {\n>>>> + if (!gd->bd)\n>>>> + gd->bd = &bdata;\n>>>> +\n>>>\n>>> It seems odd that enabling the console sets this data.\n>>>\n>\n> I don't know the history of this line. But it seems this the common\n> function called by board_init_f from various board level spl file.\n>\n>>> What was the impact of moving it later for your board?\n>>>\n>>\n>> gd->bd is used to track the dram bank information. With this moved\n>> later, I cannot track the secure memory reserved. I need this available\n>> before memory is initialized.\n>\n> The intention of 15eb1d43b was to move it earlier. But it turns out\n> function preloader_console_init() is called from different places. Some\n> are very early in board_init_f(). I guess we can add a new function just\n> to set gd->bd if it is empty, and call this function when needed. What's\n> your suggestion here?\n\nYes I think an explicit function is best.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Ac05TtPN\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hlGAqgsa\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0pHy3B3vz9t30\n\tfor ;\n\tMon, 25 Sep 2017 12:41:34 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1C497C22200; Mon, 25 Sep 2017 02:23:21 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 794F6C22187;\n\tMon, 25 Sep 2017 02:23:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5B493C2217C; Mon, 25 Sep 2017 02:14:03 +0000 (UTC)","from mail-qk0-f170.google.com (mail-qk0-f170.google.com\n\t[209.85.220.170])\n\tby lists.denx.de (Postfix) with ESMTPS id 5F2E7C22180\n\tfor ; Mon, 25 Sep 2017 02:13:57 +0000 (UTC)","by mail-qk0-f170.google.com with SMTP id g128so5365114qke.13\n\tfor ; Sun, 24 Sep 2017 19:13:57 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:13:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=TQV7fQJTpBhD9sEQ4PbvA0zWp57FJQYPHR6h3DwzUC8=;\n\tb=Ac05TtPNIuEul31PRHplj3YxbsxqhvL9QOqru5fl39EHko2JH8wxiIYEK/KHNWuv3f\n\tsL8cgba6M9fon0OhZT0sABMLmGbf0DVpwUs0edgPTWs2FRxsfA2k+B66LYxDaLSRv+Oq\n\th5tvdgORB1b9r4XP446pJIXTOzqZ8EOluXfHNaQYdXlAgB+jSizmknliRuwJgEevtHbN\n\tAKC9rHUnEEkcTTyp/9eiVU8//lfWwMGGIzC6ylAwXJvQlPmN+CZ2TczCWUIVRAPl2RYJ\n\ttRmWeH9vrvCrsT2ISUqwMX6CNkIZUbiUgpCXfawuIXRC9IIGAj8/0LwJRyDjJitqOv+8\n\tS9Ew==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=TQV7fQJTpBhD9sEQ4PbvA0zWp57FJQYPHR6h3DwzUC8=;\n\tb=hlGAqgsaEiFHGTjogYHqLLtY8aK3HX+msuqlxri4uZhN8/FWKOT05Rn3Bd6lSHGc+o\n\tyD+6J4q6ggf/bYyX83U30x/b7MxW1cbgOPjVd5EmxZzG1T+W5I9WP80+RUAnopeAJE60\n\t+4XeXbdtzO7tiyCnJ5Yg+QNKI2RH185tc9dXw="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=TQV7fQJTpBhD9sEQ4PbvA0zWp57FJQYPHR6h3DwzUC8=;\n\tb=Frept9978/ZG3jyv/71M2OtY5Wyos0fHDFfiFhy3x9GCS+OsEAM4AH9LZeaAFz9jNC\n\tB0iOaqe3HurLpGgoMJlJMtMxPKJG9Beif6Sy99y8EV5IlqsjL8znjZudKQMZsSI/Kbg1\n\tMA0XB3n+IIaFuQNaQN28j8cYcqud2ozu5pwl4XDVk0LVaC8ynaZxuysPF9m/9jgi4FxU\n\tSqj5Zyaj4Bdpy46iJyNKYWXbLsGIv43T4JhabtjGLNf7N8rwUW+e1+luK9fAVlMlAZ+N\n\t/UEAySqz3meb+SaIIdYxfr7AIhkeaLMnVpLbUdUnSK0j3DNaukOSK6ZeRcbsY2IcRZ5Y\n\t7DnQ==","X-Gm-Message-State":"AHPjjUh6+Jsv5mt6DJSVqL+amBbS+1Va58+x3r3ma+VY/QN8gIMJXtJG\n\trdP0ywzGPkGBFdwcqkWT7omVTXE8I5bfMHUV3FdSkg==","X-Google-Smtp-Source":"AOwi7QC26bNUHabjwsibtpO8xZGX+mOEC5AD19N+Yw+no54npfHdQVmnRAfJWXadODxAa8Jya1L5zyKO6E/nwBli2gE=","X-Received":"by 10.55.146.198 with SMTP id u189mr8118322qkd.317.1506305636106;\n\tSun, 24 Sep 2017 19:13:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1505415699-3401-1-git-send-email-york.sun@nxp.com>\n\t<1505415699-3401-2-git-send-email-york.sun@nxp.com>\n\t\n\t\n\t","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:13:35 -0400","X-Google-Sender-Auth":"6mAW9uepHn80k-VgXBYjsWdaG0I","Message-ID":"","To":"York Sun ","Cc":"Tom Rini , Stefan Agner , \n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2 1/7] spl: fix assignment of board info to\n\tglobal data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]