[{"id":1768520,"web_url":"http://patchwork.ozlabs.org/comment/1768520/","msgid":"<20170914131955.380099a8@bahia.lan>","list_archive_url":null,"date":"2017-09-14T11:19:55","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/","name":"Greg Kurz","email":"groug@kaod.org"},"content":"On Thu, 14 Sep 2017 06:40:06 -0400\nPradeep Jagadeesh wrote:\n\n> This patch factors out code to use the ThrottleLimits\n> strurcture.\n> \n> Signed-off-by: Pradeep Jagadeesh \n> Reviewed-by: Greg Kurz \n> Reviewed-by: Eric Blake \n> Reviewed-by: Alberto Garcia \n> Reviewed-by: Markus Armbruster \n> ---\n> qapi/block-core.json | 78 +++-------------------------------------------------\n\nUhhh... what happened here ? Where did the lines go ? I've never reviewed this\npatch before...\n\n> 1 file changed, 4 insertions(+), 74 deletions(-)\n> \n> diff --git a/qapi/block-core.json b/qapi/block-core.json\n> index bb11815..d0ccfda 100644\n> --- a/qapi/block-core.json\n> +++ b/qapi/block-core.json\n> @@ -1826,84 +1826,13 @@\n> #\n> # @device: Block device name (deprecated, use @id instead)\n> #\n> -# @id: The name or QOM path of the guest device (since: 2.8)\n> -#\n> -# @bps: total throughput limit in bytes per second\n> -#\n> -# @bps_rd: read throughput limit in bytes per second\n> -#\n> -# @bps_wr: write throughput limit in bytes per second\n> -#\n> -# @iops: total I/O operations per second\n> -#\n> -# @iops_rd: read I/O operations per second\n> -#\n> -# @iops_wr: write I/O operations per second\n> -#\n> -# @bps_max: total throughput limit during bursts,\n> -# in bytes (Since 1.7)\n> -#\n> -# @bps_rd_max: read throughput limit during bursts,\n> -# in bytes (Since 1.7)\n> -#\n> -# @bps_wr_max: write throughput limit during bursts,\n> -# in bytes (Since 1.7)\n> -#\n> -# @iops_max: total I/O operations per second during bursts,\n> -# in bytes (Since 1.7)\n> -#\n> -# @iops_rd_max: read I/O operations per second during bursts,\n> -# in bytes (Since 1.7)\n> -#\n> -# @iops_wr_max: write I/O operations per second during bursts,\n> -# in bytes (Since 1.7)\n> -#\n> -# @bps_max_length: maximum length of the @bps_max burst\n> -# period, in seconds. It must only\n> -# be set if @bps_max is set as well.\n> -# Defaults to 1. (Since 2.6)\n> -#\n> -# @bps_rd_max_length: maximum length of the @bps_rd_max\n> -# burst period, in seconds. It must only\n> -# be set if @bps_rd_max is set as well.\n> -# Defaults to 1. (Since 2.6)\n> -#\n> -# @bps_wr_max_length: maximum length of the @bps_wr_max\n> -# burst period, in seconds. It must only\n> -# be set if @bps_wr_max is set as well.\n> -# Defaults to 1. (Since 2.6)\n> -#\n> -# @iops_max_length: maximum length of the @iops burst\n> -# period, in seconds. It must only\n> -# be set if @iops_max is set as well.\n> -# Defaults to 1. (Since 2.6)\n> -#\n> -# @iops_rd_max_length: maximum length of the @iops_rd_max\n> -# burst period, in seconds. It must only\n> -# be set if @iops_rd_max is set as well.\n> -# Defaults to 1. (Since 2.6)\n> -#\n> -# @iops_wr_max_length: maximum length of the @iops_wr_max\n> -# burst period, in seconds. It must only\n> -# be set if @iops_wr_max is set as well.\n> -# Defaults to 1. (Since 2.6)\n> -#\n> -# @iops_size: an I/O size in bytes (Since 1.7)\n> -#\n> # @group: throttle group name (Since 2.4)\n> #\n> # Since: 1.1\n> ##\n> { 'struct': 'BlockIOThrottle',\n> - 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',\n> - 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',\n> - '*bps_max': 'int', '*bps_rd_max': 'int',\n> - '*bps_wr_max': 'int', '*iops_max': 'int',\n> - '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n> - '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n> - '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n> - '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n> - '*iops_size': 'int', '*group': 'str' } }\n> + 'base': 'ThrottleLimits',\n> + 'data': { '*device': 'str', '*group': 'str' } }\n> \n> ##\n> # @ThrottleLimits:\n> @@ -1913,6 +1842,7 @@\n> # transaction. All fields are optional. When setting limits, if a field is\n> # missing the current value is not changed.\n> #\n> +# @id: device id\n> # @iops-total: limit total I/O operations per second\n> # @iops-total-max: I/O operations burst\n> # @iops-total-max-length: length of the iops-total-max burst period, in seconds\n> @@ -1942,7 +1872,7 @@\n> # Since: 2.11\n> ##\n> { 'struct': 'ThrottleLimits',\n> - 'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n> + 'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' : 'int',\n> '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n> '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n> '*iops-write' : 'int', '*iops-write-max' : 'int',","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtGL00c7pz9rvt\n\tfor ;\n\tThu, 14 Sep 2017 21:20:40 +1000 (AEST)","from localhost ([::1]:46990 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsSCE-00053W-3k\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 07:20:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43456)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsSBj-00052D-2N\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 07:20:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsSBf-0005B9-Tp\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 07:20:07 -0400","from 3.mo2.mail-out.ovh.net ([46.105.58.226]:50357)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsSBf-00059l-Kh\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 07:20:03 -0400","from player770.ha.ovh.net (b6.ovh.net [213.186.33.56])\n\tby mo2.mail-out.ovh.net (Postfix) with ESMTP id 4D0FBAC03F\n\tfor ; Thu, 14 Sep 2017 13:20:02 +0200 (CEST)","from bahia.lan (gar31-1-82-66-74-139.fbx.proxad.net [82.66.74.139])\n\t(Authenticated sender: groug@kaod.org)\n\tby player770.ha.ovh.net (Postfix) with ESMTPSA id BFB673C0085;\n\tThu, 14 Sep 2017 13:19:56 +0200 (CEST)"],"Date":"Thu, 14 Sep 2017 13:19:55 +0200","From":"Greg Kurz ","To":"Pradeep Jagadeesh ","Message-ID":"<20170914131955.380099a8@bahia.lan>","In-Reply-To":"<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tboundary=\"Sig_/JCL6l=3LiFeOHgNZhMwiIl2\";\n\tprotocol=\"application/pgp-signature\"","X-Ovh-Tracer-Id":"7341430344400280027","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrgeeigdegtdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"46.105.58.226","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia ,\n\tjani kokkonen , \n\tPradeep Jagadeesh , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768525,"web_url":"http://patchwork.ozlabs.org/comment/1768525/","msgid":"<5c139703-11ee-e7e2-9db2-201a208bf1d0@huawei.com>","list_archive_url":null,"date":"2017-09-14T11:23:08","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 9/14/2017 1:19 PM, Greg Kurz wrote:\n> On Thu, 14 Sep 2017 06:40:06 -0400\n> Pradeep Jagadeesh wrote:\n>\n>> This patch factors out code to use the ThrottleLimits\n>> strurcture.\n>>\n>> Signed-off-by: Pradeep Jagadeesh \n>> Reviewed-by: Greg Kurz \n>> Reviewed-by: Eric Blake \n>> Reviewed-by: Alberto Garcia \n>> Reviewed-by: Markus Armbruster \n>> ---\n>> qapi/block-core.json | 78 +++-------------------------------------------------\n>\n> Uhhh... what happened here ? Where did the lines go ? I've never reviewed this\n> patch before...\n\nI did rebase the code on 2.10\nNow I am using the ThrottleLimits structure that was introduced IN 2.10.\nThis is same as the IOThrottle structure.\nSo, many things got changed in this version.\n\n-Pradeep\n\n>\n>> 1 file changed, 4 insertions(+), 74 deletions(-)\n>>\n>> diff --git a/qapi/block-core.json b/qapi/block-core.json\n>> index bb11815..d0ccfda 100644\n>> --- a/qapi/block-core.json\n>> +++ b/qapi/block-core.json\n>> @@ -1826,84 +1826,13 @@\n>> #\n>> # @device: Block device name (deprecated, use @id instead)\n>> #\n>> -# @id: The name or QOM path of the guest device (since: 2.8)\n>> -#\n>> -# @bps: total throughput limit in bytes per second\n>> -#\n>> -# @bps_rd: read throughput limit in bytes per second\n>> -#\n>> -# @bps_wr: write throughput limit in bytes per second\n>> -#\n>> -# @iops: total I/O operations per second\n>> -#\n>> -# @iops_rd: read I/O operations per second\n>> -#\n>> -# @iops_wr: write I/O operations per second\n>> -#\n>> -# @bps_max: total throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_rd_max: read throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_wr_max: write throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_max: total I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_rd_max: read I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_wr_max: write I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_max_length: maximum length of the @bps_max burst\n>> -# period, in seconds. It must only\n>> -# be set if @bps_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @bps_rd_max_length: maximum length of the @bps_rd_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @bps_rd_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @bps_wr_max_length: maximum length of the @bps_wr_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @bps_wr_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_max_length: maximum length of the @iops burst\n>> -# period, in seconds. It must only\n>> -# be set if @iops_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_rd_max_length: maximum length of the @iops_rd_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @iops_rd_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_wr_max_length: maximum length of the @iops_wr_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @iops_wr_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_size: an I/O size in bytes (Since 1.7)\n>> -#\n>> # @group: throttle group name (Since 2.4)\n>> #\n>> # Since: 1.1\n>> ##\n>> { 'struct': 'BlockIOThrottle',\n>> - 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',\n>> - 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',\n>> - '*bps_max': 'int', '*bps_rd_max': 'int',\n>> - '*bps_wr_max': 'int', '*iops_max': 'int',\n>> - '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n>> - '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n>> - '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n>> - '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n>> - '*iops_size': 'int', '*group': 'str' } }\n>> + 'base': 'ThrottleLimits',\n>> + 'data': { '*device': 'str', '*group': 'str' } }\n>>\n>> ##\n>> # @ThrottleLimits:\n>> @@ -1913,6 +1842,7 @@\n>> # transaction. All fields are optional. When setting limits, if a field is\n>> # missing the current value is not changed.\n>> #\n>> +# @id: device id\n>> # @iops-total: limit total I/O operations per second\n>> # @iops-total-max: I/O operations burst\n>> # @iops-total-max-length: length of the iops-total-max burst period, in seconds\n>> @@ -1942,7 +1872,7 @@\n>> # Since: 2.11\n>> ##\n>> { 'struct': 'ThrottleLimits',\n>> - 'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n>> + 'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' : 'int',\n>> '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n>> '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n>> '*iops-write' : 'int', '*iops-write-max' : 'int',\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtGQb5VMyz9rvt\n\tfor ;\n\tThu, 14 Sep 2017 21:24:37 +1000 (AEST)","from localhost ([::1]:47002 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsSG2-0007kc-Lq\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 07:24:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45526)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsSFg-0007jb-BB\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 07:24:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsSFd-00011c-6w\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 07:24:12 -0400","from lhrrgout.huawei.com ([194.213.3.17]:23711)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from ) id 1dsSFc-0000uC-O0\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 07:24:09 -0400","from 172.18.7.190 (EHLO lhreml702-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DOO41094; Thu, 14 Sep 2017 11:23:17 +0000 (GMT)","from [127.0.0.1] (10.210.169.26) by lhreml702-cah.china.huawei.com\n\t(10.201.108.43) with Microsoft SMTP Server id 14.3.301.0;\n\tThu, 14 Sep 2017 12:23:09 +0100"],"To":"Greg Kurz , Pradeep Jagadeesh ","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<20170914131955.380099a8@bahia.lan>","From":"Pradeep Jagadeesh ","Message-ID":"<5c139703-11ee-e7e2-9db2-201a208bf1d0@huawei.com>","Date":"Thu, 14 Sep 2017 13:23:08 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170914131955.380099a8@bahia.lan>","Content-Type":"text/plain; charset=\"windows-1252\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.169.26]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020204.59BA66A8.001F, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"4268f6fa8a22ff0045e64975302c5b7e","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia ,\n\tjani kokkonen , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770290,"web_url":"http://patchwork.ozlabs.org/comment/1770290/","msgid":"<20170918160434.cfkm7jlg3oig25qj@postretch>","list_archive_url":null,"date":"2017-09-18T16:04:34","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":71571,"url":"http://patchwork.ozlabs.org/api/people/71571/","name":"Manos Pitsidianakis","email":"el13635@mail.ntua.gr"},"content":"On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote:\n>This patch factors out code to use the ThrottleLimits\n>strurcture.\n>\n>Signed-off-by: Pradeep Jagadeesh \n>Reviewed-by: Greg Kurz \n>Reviewed-by: Eric Blake \n>Reviewed-by: Alberto Garcia \n>Reviewed-by: Markus Armbruster \n>---\n> qapi/block-core.json | 78 +++-------------------------------------------------\n> 1 file changed, 4 insertions(+), 74 deletions(-)\n>\n>diff --git a/qapi/block-core.json b/qapi/block-core.json\n>index bb11815..d0ccfda 100644\n>--- a/qapi/block-core.json\n>+++ b/qapi/block-core.json\n>@@ -1826,84 +1826,13 @@\n> #\n> # @device: Block device name (deprecated, use @id instead)\n> #\n>-# @id: The name or QOM path of the guest device (since: 2.8)\n>-#\n>-# @bps: total throughput limit in bytes per second\n>-#\n>-# @bps_rd: read throughput limit in bytes per second\n>-#\n>-# @bps_wr: write throughput limit in bytes per second\n>-#\n>-# @iops: total I/O operations per second\n>-#\n>-# @iops_rd: read I/O operations per second\n>-#\n>-# @iops_wr: write I/O operations per second\n>-#\n>-# @bps_max: total throughput limit during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @bps_rd_max: read throughput limit during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @bps_wr_max: write throughput limit during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @iops_max: total I/O operations per second during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @iops_rd_max: read I/O operations per second during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @iops_wr_max: write I/O operations per second during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @bps_max_length: maximum length of the @bps_max burst\n>-# period, in seconds. It must only\n>-# be set if @bps_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @bps_rd_max_length: maximum length of the @bps_rd_max\n>-# burst period, in seconds. It must only\n>-# be set if @bps_rd_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @bps_wr_max_length: maximum length of the @bps_wr_max\n>-# burst period, in seconds. It must only\n>-# be set if @bps_wr_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_max_length: maximum length of the @iops burst\n>-# period, in seconds. It must only\n>-# be set if @iops_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_rd_max_length: maximum length of the @iops_rd_max\n>-# burst period, in seconds. It must only\n>-# be set if @iops_rd_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_wr_max_length: maximum length of the @iops_wr_max\n>-# burst period, in seconds. It must only\n>-# be set if @iops_wr_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_size: an I/O size in bytes (Since 1.7)\n>-#\n> # @group: throttle group name (Since 2.4)\n\nBlockIOThrottle and ThrottleLimits are not directly compatible, for \nexample here we have iops_rd_max_length as a name,\n\n> #\n> # Since: 1.1\n> ##\n> { 'struct': 'BlockIOThrottle',\n>- 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',\n>- 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',\n>- '*bps_max': 'int', '*bps_rd_max': 'int',\n>- '*bps_wr_max': 'int', '*iops_max': 'int',\n>- '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n>- '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n>- '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n>- '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n>- '*iops_size': 'int', '*group': 'str' } }\n>+ 'base': 'ThrottleLimits',\n>+ 'data': { '*device': 'str', '*group': 'str' } }\n>\n> ##\n> # @ThrottleLimits:\n>@@ -1913,6 +1842,7 @@\n> # transaction. All fields are optional. When setting limits, if a field is\n> # missing the current value is not changed.\n> #\n>+# @id: device id\n> # @iops-total: limit total I/O operations per second\n> # @iops-total-max: I/O operations burst\n> # @iops-total-max-length: length of the iops-total-max burst period, in seconds\n>@@ -1942,7 +1872,7 @@\n> # Since: 2.11\n> ##\n> { 'struct': 'ThrottleLimits',\n>- 'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n>+ 'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' : 'int',\n> '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n> '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n> '*iops-write' : 'int', '*iops-write-max' : 'int',\n\nAnd here it's iops-read-max-length. This breaks the block layer's old \nthrottling API. Do we want the old API replaced for 2.11? I don't know \nwhich maintainer is responsible for this, so I CC'd armbru.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwrvT5BwRz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:25:09 +1000 (AEST)","from localhost ([::1]:37696 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtyr4-0002Tn-AU\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 12:25:06 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39271)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtyYO-0002db-1d\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:05:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtyYK-0001pW-Rx\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:05:48 -0400","from smtp1.ntua.gr ([2001:648:2000:de::183]:44173)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtyYK-0001kt-AQ\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:05:44 -0400","from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60])\n\t(authenticated bits=0)\n\tby smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v8IG4ZLi075959\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Mon, 18 Sep 2017 19:04:38 +0300 (EEST)\n\t(envelope-from el13635@mail.ntua.gr)"],"X-Authentication-Warning":"smtp1.ntua.gr: Host carp0.noc.ntua.gr\n\t[147.102.222.60] claimed to be mail.ntua.gr","Date":"Mon, 18 Sep 2017 19:04:34 +0300","From":"Manos Pitsidianakis ","To":"Pradeep Jagadeesh ","Message-ID":"<20170918160434.cfkm7jlg3oig25qj@postretch>","Mail-Followup-To":"Manos Pitsidianakis ,\n\tPradeep Jagadeesh ,\n\teric blake , greg kurz ,\n\tjani kokkonen ,\n\talberto garcia ,\n\tPradeep Jagadeesh ,\n\tqemu-devel@nongnu.org, Markus Armbruster ","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"qsst5tvyn4hjp5bc\"","Content-Disposition":"inline","In-Reply-To":"<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","User-Agent":"NeoMutt/20170609-57-1e93be (1.8.3)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:648:2000:de::183","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia , Markus Armbruster ,\n\tqemu-devel@nongnu.org, greg kurz ,\n\tPradeep Jagadeesh ,\n\tjani kokkonen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770297,"web_url":"http://patchwork.ozlabs.org/comment/1770297/","msgid":"<20170918162503.gudmrjtvpytqf64m@postretch>","list_archive_url":null,"date":"2017-09-18T16:25:03","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":71571,"url":"http://patchwork.ozlabs.org/api/people/71571/","name":"Manos Pitsidianakis","email":"el13635@mail.ntua.gr"},"content":"On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote:\n>This patch factors out code to use the ThrottleLimits\n>strurcture.\n>\n>Signed-off-by: Pradeep Jagadeesh \n>Reviewed-by: Greg Kurz \n>Reviewed-by: Eric Blake \n>Reviewed-by: Alberto Garcia \n>Reviewed-by: Markus Armbruster \n>---\n> qapi/block-core.json | 78 +++-------------------------------------------------\n> 1 file changed, 4 insertions(+), 74 deletions(-)\n>\n>diff --git a/qapi/block-core.json b/qapi/block-core.json\n>index bb11815..d0ccfda 100644\n>--- a/qapi/block-core.json\n>+++ b/qapi/block-core.json\n>@@ -1826,84 +1826,13 @@\n> #\n> # @device: Block device name (deprecated, use @id instead)\n> #\n>-# @id: The name or QOM path of the guest device (since: 2.8)\n>-#\n>-# @bps: total throughput limit in bytes per second\n>-#\n>-# @bps_rd: read throughput limit in bytes per second\n>-#\n>-# @bps_wr: write throughput limit in bytes per second\n>-#\n>-# @iops: total I/O operations per second\n>-#\n>-# @iops_rd: read I/O operations per second\n>-#\n>-# @iops_wr: write I/O operations per second\n>-#\n>-# @bps_max: total throughput limit during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @bps_rd_max: read throughput limit during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @bps_wr_max: write throughput limit during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @iops_max: total I/O operations per second during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @iops_rd_max: read I/O operations per second during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @iops_wr_max: write I/O operations per second during bursts,\n>-# in bytes (Since 1.7)\n>-#\n>-# @bps_max_length: maximum length of the @bps_max burst\n>-# period, in seconds. It must only\n>-# be set if @bps_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @bps_rd_max_length: maximum length of the @bps_rd_max\n>-# burst period, in seconds. It must only\n>-# be set if @bps_rd_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @bps_wr_max_length: maximum length of the @bps_wr_max\n>-# burst period, in seconds. It must only\n>-# be set if @bps_wr_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_max_length: maximum length of the @iops burst\n>-# period, in seconds. It must only\n>-# be set if @iops_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_rd_max_length: maximum length of the @iops_rd_max\n>-# burst period, in seconds. It must only\n>-# be set if @iops_rd_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_wr_max_length: maximum length of the @iops_wr_max\n>-# burst period, in seconds. It must only\n>-# be set if @iops_wr_max is set as well.\n>-# Defaults to 1. (Since 2.6)\n>-#\n>-# @iops_size: an I/O size in bytes (Since 1.7)\n>-#\n> # @group: throttle group name (Since 2.4)\n> #\n> # Since: 1.1\n> ##\n> { 'struct': 'BlockIOThrottle',\n>- 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',\n>- 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',\n>- '*bps_max': 'int', '*bps_rd_max': 'int',\n>- '*bps_wr_max': 'int', '*iops_max': 'int',\n>- '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n>- '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n>- '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n>- '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n>- '*iops_size': 'int', '*group': 'str' } }\n>+ 'base': 'ThrottleLimits',\n>+ 'data': { '*device': 'str', '*group': 'str' } }\n>\n> ##\n> # @ThrottleLimits:\n>@@ -1913,6 +1842,7 @@\n> # transaction. All fields are optional. When setting limits, if a field is\n> # missing the current value is not changed.\n> #\n>+# @id: device id\n> # @iops-total: limit total I/O operations per second\n> # @iops-total-max: I/O operations burst\n> # @iops-total-max-length: length of the iops-total-max burst period, in seconds\n>@@ -1942,7 +1872,7 @@\n> # Since: 2.11\n> ##\n> { 'struct': 'ThrottleLimits',\n>- 'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n>+ 'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' : 'int',\n> '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n> '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n> '*iops-write' : 'int', '*iops-write-max' : 'int',\n>-- \n>1.8.3.1\n>\n\nWhy is id needed? ThrottleLimits is not per group, not per device. And \nas I mentioned in another reply, this changes the block_set_io_throttle \ncommand which is not simple refactoring.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xws1K6WGKz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:30:13 +1000 (AEST)","from localhost ([::1]:37731 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtyw0-0007Gl-0V\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 12:30:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47523)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtyrn-0003oR-Qm\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:25:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtyrm-0002FV-JR\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:25:51 -0400","from smtp1.ntua.gr ([2001:648:2000:de::183]:45241)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtyrm-0002Ea-20\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 12:25:50 -0400","from mail.ntua.gr (carp0.noc.ntua.gr [147.102.222.60])\n\t(authenticated bits=0)\n\tby smtp1.ntua.gr (8.15.2/8.15.2) with ESMTPSA id v8IGP3uE088736\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=NOT); Mon, 18 Sep 2017 19:25:04 +0300 (EEST)\n\t(envelope-from el13635@mail.ntua.gr)"],"X-Authentication-Warning":"smtp1.ntua.gr: Host carp0.noc.ntua.gr\n\t[147.102.222.60] claimed to be mail.ntua.gr","Date":"Mon, 18 Sep 2017 19:25:03 +0300","From":"Manos Pitsidianakis ","To":"Pradeep Jagadeesh ","Message-ID":"<20170918162503.gudmrjtvpytqf64m@postretch>","Mail-Followup-To":"Manos Pitsidianakis ,\n\tPradeep Jagadeesh ,\n\teric blake , greg kurz ,\n\tjani kokkonen ,\n\talberto garcia ,\n\tPradeep Jagadeesh ,\n\tqemu-devel@nongnu.org","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5rrrjgusejvmn7uv\"","Content-Disposition":"inline","In-Reply-To":"<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","User-Agent":"NeoMutt/20170609-57-1e93be (1.8.3)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2001:648:2000:de::183","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia , qemu-devel@nongnu.org,\n\tgreg kurz ,\n\tPradeep Jagadeesh ,\n\tjani kokkonen ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770335,"web_url":"http://patchwork.ozlabs.org/comment/1770335/","msgid":"<23a3b68e-efa5-5daa-363e-f697e3d8ae2f@redhat.com>","list_archive_url":null,"date":"2017-09-18T17:10:13","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/14/2017 05:40 AM, Pradeep Jagadeesh wrote:\n> This patch factors out code to use the ThrottleLimits\n> strurcture.\n\ns/strurcture/structure/\n\n> \n> Signed-off-by: Pradeep Jagadeesh \n> Reviewed-by: Greg Kurz \n> Reviewed-by: Eric Blake \n\nEchoing the sentiments made elsewhere - this is a significant rewrite\nfrom the earlier version, so you WANT reviewers to look at it fresh\nrather than assuming that previous reviews still apply.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwswR2p0Mz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 03:11:03 +1000 (AEST)","from localhost ([::1]:37957 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtzZV-0007Yq-ES\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 13:11:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35660)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtzYq-0007Xo-HB\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:10:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtzYm-0003Sm-GW\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:10:20 -0400","from mx1.redhat.com ([209.132.183.28]:43328)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtzYm-0003SH-7D\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 13:10:16 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DB3BCC0587F8;\n\tMon, 18 Sep 2017 17:10:14 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D21F75C1A3;\n\tMon, 18 Sep 2017 17:10:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DB3BCC0587F8","To":"Pradeep Jagadeesh , greg kurz ","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<23a3b68e-efa5-5daa-363e-f697e3d8ae2f@redhat.com>","Date":"Mon, 18 Sep 2017 12:10:13 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"6BESh3RGtQM7O6LMFRvvI50BSjP6jT2FP\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tMon, 18 Sep 2017 17:10:15 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jani kokkonen ,\n\talberto garcia , \n\tPradeep Jagadeesh , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770733,"web_url":"http://patchwork.ozlabs.org/comment/1770733/","msgid":"","list_archive_url":null,"date":"2017-09-19T08:07:50","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 9/18/2017 6:25 PM, Manos Pitsidianakis wrote:\n> On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote:\n>> This patch factors out code to use the ThrottleLimits\n>> strurcture.\n>>\n>> Signed-off-by: Pradeep Jagadeesh \n>> Reviewed-by: Greg Kurz \n>> Reviewed-by: Eric Blake \n>> Reviewed-by: Alberto Garcia \n>> Reviewed-by: Markus Armbruster \n>> ---\n>> qapi/block-core.json | 78\n>> +++-------------------------------------------------\n>> 1 file changed, 4 insertions(+), 74 deletions(-)\n>>\n>> diff --git a/qapi/block-core.json b/qapi/block-core.json\n>> index bb11815..d0ccfda 100644\n>> --- a/qapi/block-core.json\n>> +++ b/qapi/block-core.json\n>> @@ -1826,84 +1826,13 @@\n>> #\n>> # @device: Block device name (deprecated, use @id instead)\n>> #\n>> -# @id: The name or QOM path of the guest device (since: 2.8)\n>> -#\n>> -# @bps: total throughput limit in bytes per second\n>> -#\n>> -# @bps_rd: read throughput limit in bytes per second\n>> -#\n>> -# @bps_wr: write throughput limit in bytes per second\n>> -#\n>> -# @iops: total I/O operations per second\n>> -#\n>> -# @iops_rd: read I/O operations per second\n>> -#\n>> -# @iops_wr: write I/O operations per second\n>> -#\n>> -# @bps_max: total throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_rd_max: read throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_wr_max: write throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_max: total I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_rd_max: read I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_wr_max: write I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_max_length: maximum length of the @bps_max burst\n>> -# period, in seconds. It must only\n>> -# be set if @bps_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @bps_rd_max_length: maximum length of the @bps_rd_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @bps_rd_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @bps_wr_max_length: maximum length of the @bps_wr_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @bps_wr_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_max_length: maximum length of the @iops burst\n>> -# period, in seconds. It must only\n>> -# be set if @iops_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_rd_max_length: maximum length of the @iops_rd_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @iops_rd_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_wr_max_length: maximum length of the @iops_wr_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @iops_wr_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_size: an I/O size in bytes (Since 1.7)\n>> -#\n>> # @group: throttle group name (Since 2.4)\n>> #\n>> # Since: 1.1\n>> ##\n>> { 'struct': 'BlockIOThrottle',\n>> - 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd':\n>> 'int',\n>> - 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int',\n>> 'iops_wr': 'int',\n>> - '*bps_max': 'int', '*bps_rd_max': 'int',\n>> - '*bps_wr_max': 'int', '*iops_max': 'int',\n>> - '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n>> - '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n>> - '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n>> - '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n>> - '*iops_size': 'int', '*group': 'str' } }\n>> + 'base': 'ThrottleLimits',\n>> + 'data': { '*device': 'str', '*group': 'str' } }\n>>\n>> ##\n>> # @ThrottleLimits:\n>> @@ -1913,6 +1842,7 @@\n>> # transaction. All fields are optional. When setting limits, if a\n>> field is\n>> # missing the current value is not changed.\n>> #\n>> +# @id: device id\n>> # @iops-total: limit total I/O operations per second\n>> # @iops-total-max: I/O operations burst\n>> # @iops-total-max-length: length of the iops-total-max burst period,\n>> in seconds\n>> @@ -1942,7 +1872,7 @@\n>> # Since: 2.11\n>> ##\n>> { 'struct': 'ThrottleLimits',\n>> - 'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n>> + 'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' :\n>> 'int',\n>> '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n>> '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n>> '*iops-write' : 'int', '*iops-write-max' : 'int',\n>> --\n>> 1.8.3.1\n>>\n>\n> Why is id needed? ThrottleLimits is not per group, not per device. And\n> as I mentioned in another reply, this changes the block_set_io_throttle\n> command which is not simple refactoring.\nWhen you use qmp/hmp interface the id is used to set/get throttle \nconfiguration. So, I thought if id is part of the throttle config, it \nwill be useful. Now I will try to move it to just for fsdeviothrottle.\n\n-Pradeep","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxFt0139bz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 18:10:16 +1000 (AEST)","from localhost ([::1]:40699 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duDbi-0007Ba-8S\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 04:10:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57532)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duDbF-0007A1-2o\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 04:09:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duDbC-0004c4-9d\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 04:09:45 -0400","from lhrrgout.huawei.com ([194.213.3.17]:24114)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from ) id 1duDbB-0004Zq-Tq\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 04:09:42 -0400","from 172.18.7.190 (EHLO LHREML714-CAH.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DOV87434; Tue, 19 Sep 2017 08:08:06 +0000 (GMT)","from [127.0.0.1] (10.210.170.36) by LHREML714-CAH.china.huawei.com\n\t(10.201.108.37) with Microsoft SMTP Server id 14.3.301.0;\n\tTue, 19 Sep 2017 09:07:57 +0100"],"To":"Manos Pitsidianakis , Pradeep Jagadeesh\n\t, eric blake , greg kurz\n\t, jani kokkonen ,\n\talberto garcia , ","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<20170918162503.gudmrjtvpytqf64m@postretch>","From":"Pradeep Jagadeesh ","Message-ID":"","Date":"Tue, 19 Sep 2017 10:07:50 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170918162503.gudmrjtvpytqf64m@postretch>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.170.36]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020203.59C0D067.0128, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"4268f6fa8a22ff0045e64975302c5b7e","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770813,"web_url":"http://patchwork.ozlabs.org/comment/1770813/","msgid":"<7d5e2b72-808b-2a71-b285-35c16a273f94@huawei.com>","list_archive_url":null,"date":"2017-09-19T10:06:26","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 9/18/2017 7:10 PM, Eric Blake wrote:\n> On 09/14/2017 05:40 AM, Pradeep Jagadeesh wrote:\n>> This patch factors out code to use the ThrottleLimits\n>> strurcture.\n>\n> s/strurcture/structure/\n>\n>>\n>> Signed-off-by: Pradeep Jagadeesh \n>> Reviewed-by: Greg Kurz \n>> Reviewed-by: Eric Blake \n>\n> Echoing the sentiments made elsewhere - this is a significant rewrite\n> from the earlier version, so you WANT reviewers to look at it fresh\n> rather than assuming that previous reviews still apply.\n>\nOK, but shall I send them as V12 or V01 again?\n\n-Pradeep","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxJT72dwzz9ryr\n\tfor ;\n\tTue, 19 Sep 2017 20:07:19 +1000 (AEST)","from localhost ([::1]:41208 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duFQx-0007mK-WC\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 06:07:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38841)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duFQX-0007hX-Qc\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 06:06:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duFQT-0004QP-ET\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 06:06:49 -0400","from lhrrgout.huawei.com ([194.213.3.17]:24115)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from ) id 1duFQT-0004Pz-5M\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 06:06:45 -0400","from 172.18.7.190 (EHLO lhreml702-cah.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DVT37383; Tue, 19 Sep 2017 10:06:38 +0000 (GMT)","from [127.0.0.1] (10.210.170.36) by lhreml702-cah.china.huawei.com\n\t(10.201.108.43) with Microsoft SMTP Server id 14.3.301.0;\n\tTue, 19 Sep 2017 11:06:27 +0100"],"To":"Eric Blake , Pradeep Jagadeesh\n\t, greg kurz ","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<23a3b68e-efa5-5daa-363e-f697e3d8ae2f@redhat.com>","From":"Pradeep Jagadeesh ","Message-ID":"<7d5e2b72-808b-2a71-b285-35c16a273f94@huawei.com>","Date":"Tue, 19 Sep 2017 12:06:26 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<23a3b68e-efa5-5daa-363e-f697e3d8ae2f@redhat.com>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.170.36]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020205.59C0EC2F.0001, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"4c91aa62f722c0578e5e08d79cfbc55b","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jani kokkonen ,\n\talberto garcia , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770991,"web_url":"http://patchwork.ozlabs.org/comment/1770991/","msgid":"<906dd6d0-5012-22d2-c0fa-b21eaf7b24bf@redhat.com>","list_archive_url":null,"date":"2017-09-19T13:10:18","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/19/2017 05:06 AM, Pradeep Jagadeesh wrote:\n> On 9/18/2017 7:10 PM, Eric Blake wrote:\n>> On 09/14/2017 05:40 AM, Pradeep Jagadeesh wrote:\n>>> This patch factors out code to use the ThrottleLimits\n>>> strurcture.\n>>\n>> s/strurcture/structure/\n>>\n>>>\n>>> Signed-off-by: Pradeep Jagadeesh \n>>> Reviewed-by: Greg Kurz \n>>> Reviewed-by: Eric Blake \n>>\n>> Echoing the sentiments made elsewhere - this is a significant rewrite\n>> from the earlier version, so you WANT reviewers to look at it fresh\n>> rather than assuming that previous reviews still apply.\n>>\n> OK, but shall I send them as V12 or V01 again?\n\nv12 is fine - you really are revising the patches a twelfth time.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxNfY4S6dz9sBZ\n\tfor ;\n\tTue, 19 Sep 2017 23:15:49 +1000 (AEST)","from localhost ([::1]:42794 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duINP-0000H6-BZ\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 09:15:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60307)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duIII-0004lO-6v\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:10:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duIIA-0000p6-4b\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:10:30 -0400","from mx1.redhat.com ([209.132.183.28]:35330)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duII9-0000oj-Rt\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:10:22 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 7A49990901;\n\tTue, 19 Sep 2017 13:10:20 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 696BB5D6A4;\n\tTue, 19 Sep 2017 13:10:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 7A49990901","To":"Pradeep Jagadeesh ,\n\tPradeep Jagadeesh , greg kurz ","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<23a3b68e-efa5-5daa-363e-f697e3d8ae2f@redhat.com>\n\t<7d5e2b72-808b-2a71-b285-35c16a273f94@huawei.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<906dd6d0-5012-22d2-c0fa-b21eaf7b24bf@redhat.com>","Date":"Tue, 19 Sep 2017 08:10:18 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<7d5e2b72-808b-2a71-b285-35c16a273f94@huawei.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"JUHWSErOiGEscIHhe5mGK7r0JctKSCUdG\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 19 Sep 2017 13:10:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"jani kokkonen ,\n\talberto garcia , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771034,"web_url":"http://patchwork.ozlabs.org/comment/1771034/","msgid":"<20170919131405.301817a8@bahia.lab.toulouse-stg.fr.ibm.com>","list_archive_url":null,"date":"2017-09-19T13:32:31","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/","name":"Greg Kurz","email":"groug@kaod.org"},"content":"On Tue, 19 Sep 2017 12:06:26 +0200\nPradeep Jagadeesh wrote:\n\n> On 9/18/2017 7:10 PM, Eric Blake wrote:\n> > On 09/14/2017 05:40 AM, Pradeep Jagadeesh wrote: \n> >> This patch factors out code to use the ThrottleLimits\n> >> strurcture. \n> >\n> > s/strurcture/structure/\n> > \n> >>\n> >> Signed-off-by: Pradeep Jagadeesh \n> >> Reviewed-by: Greg Kurz \n> >> Reviewed-by: Eric Blake \n> >\n> > Echoing the sentiments made elsewhere - this is a significant rewrite\n> > from the earlier version, so you WANT reviewers to look at it fresh\n> > rather than assuming that previous reviews still apply.\n> > \n> OK, but shall I send them as V12 or V01 again?\n> \n\nThe version is rather tied to the whole patchset than to each\nindividual patch. The next round will be the 12th, so all\npatches should have v12 in the Subject.\n\n> -Pradeep\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxPLx6dtjz9sPk\n\tfor ;\n\tTue, 19 Sep 2017 23:47:21 +1000 (AEST)","from localhost ([::1]:43006 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duIrv-0008HB-GU\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 09:47:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47448)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duIe6-0006HD-79\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:33:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duIe2-0002Ym-Qm\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:33:02 -0400","from 15.mo1.mail-out.ovh.net ([188.165.38.232]:35701)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duIe2-0002XQ-LR\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 09:32:58 -0400","from player691.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id EE63193E4E\n\tfor ; Tue, 19 Sep 2017 15:32:56 +0200 (CEST)","from bahia.lab.toulouse-stg.fr.ibm.com\n\t(deibp9eh1--blueice1n3.emea.ibm.com [195.212.29.165])\n\t(Authenticated sender: groug@kaod.org)\n\tby player691.ha.ovh.net (Postfix) with ESMTPSA id 3A582260079;\n\tTue, 19 Sep 2017 15:32:50 +0200 (CEST)"],"Date":"Tue, 19 Sep 2017 15:32:31 +0200","From":"Greg Kurz ","To":"Pradeep Jagadeesh ","Message-ID":"<20170919131405.301817a8@bahia.lab.toulouse-stg.fr.ibm.com>","In-Reply-To":"<7d5e2b72-808b-2a71-b285-35c16a273f94@huawei.com>","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<23a3b68e-efa5-5daa-363e-f697e3d8ae2f@redhat.com>\n\t<7d5e2b72-808b-2a71-b285-35c16a273f94@huawei.com>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Ovh-Tracer-Id":"2055611758559468027","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"-100","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrheejgdeijecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"188.165.38.232","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alberto garcia ,\n\tjani kokkonen , \n\tqemu-devel@nongnu.org, Pradeep Jagadeesh ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771919,"web_url":"http://patchwork.ozlabs.org/comment/1771919/","msgid":"<23bb8481-7854-70aa-de7c-8f3d18270ebb@huawei.com>","list_archive_url":null,"date":"2017-09-20T08:46:09","subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","submitter":{"id":69883,"url":"http://patchwork.ozlabs.org/api/people/69883/","name":"Pradeep Jagadeesh","email":"pradeep.jagadeesh@huawei.com"},"content":"On 9/18/2017 6:04 PM, Manos Pitsidianakis wrote:\n> On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote:\n>> This patch factors out code to use the ThrottleLimits\n>> strurcture.\n>>\n>> Signed-off-by: Pradeep Jagadeesh \n>> Reviewed-by: Greg Kurz \n>> Reviewed-by: Eric Blake \n>> Reviewed-by: Alberto Garcia \n>> Reviewed-by: Markus Armbruster \n>> ---\n>> qapi/block-core.json | 78\n>> +++-------------------------------------------------\n>> 1 file changed, 4 insertions(+), 74 deletions(-)\n>>\n>> diff --git a/qapi/block-core.json b/qapi/block-core.json\n>> index bb11815..d0ccfda 100644\n>> --- a/qapi/block-core.json\n>> +++ b/qapi/block-core.json\n>> @@ -1826,84 +1826,13 @@\n>> #\n>> # @device: Block device name (deprecated, use @id instead)\n>> #\n>> -# @id: The name or QOM path of the guest device (since: 2.8)\n>> -#\n>> -# @bps: total throughput limit in bytes per second\n>> -#\n>> -# @bps_rd: read throughput limit in bytes per second\n>> -#\n>> -# @bps_wr: write throughput limit in bytes per second\n>> -#\n>> -# @iops: total I/O operations per second\n>> -#\n>> -# @iops_rd: read I/O operations per second\n>> -#\n>> -# @iops_wr: write I/O operations per second\n>> -#\n>> -# @bps_max: total throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_rd_max: read throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_wr_max: write throughput limit during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_max: total I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_rd_max: read I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @iops_wr_max: write I/O operations per second during bursts,\n>> -# in bytes (Since 1.7)\n>> -#\n>> -# @bps_max_length: maximum length of the @bps_max burst\n>> -# period, in seconds. It must only\n>> -# be set if @bps_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @bps_rd_max_length: maximum length of the @bps_rd_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @bps_rd_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @bps_wr_max_length: maximum length of the @bps_wr_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @bps_wr_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_max_length: maximum length of the @iops burst\n>> -# period, in seconds. It must only\n>> -# be set if @iops_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_rd_max_length: maximum length of the @iops_rd_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @iops_rd_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_wr_max_length: maximum length of the @iops_wr_max\n>> -# burst period, in seconds. It must only\n>> -# be set if @iops_wr_max is set as well.\n>> -# Defaults to 1. (Since 2.6)\n>> -#\n>> -# @iops_size: an I/O size in bytes (Since 1.7)\n>> -#\n>> # @group: throttle group name (Since 2.4)\n>\n> BlockIOThrottle and ThrottleLimits are not directly compatible, for\n> example here we have iops_rd_max_length as a name,\n>\n>> #\n>> # Since: 1.1\n>> ##\n>> { 'struct': 'BlockIOThrottle',\n>> - 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd':\n>> 'int',\n>> - 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int',\n>> 'iops_wr': 'int',\n>> - '*bps_max': 'int', '*bps_rd_max': 'int',\n>> - '*bps_wr_max': 'int', '*iops_max': 'int',\n>> - '*iops_rd_max': 'int', '*iops_wr_max': 'int',\n>> - '*bps_max_length': 'int', '*bps_rd_max_length': 'int',\n>> - '*bps_wr_max_length': 'int', '*iops_max_length': 'int',\n>> - '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',\n>> - '*iops_size': 'int', '*group': 'str' } }\n>> + 'base': 'ThrottleLimits',\n>> + 'data': { '*device': 'str', '*group': 'str' } }\n>>\n>> ##\n>> # @ThrottleLimits:\n>> @@ -1913,6 +1842,7 @@\n>> # transaction. All fields are optional. When setting limits, if a\n>> field is\n>> # missing the current value is not changed.\n>> #\n>> +# @id: device id\n>> # @iops-total: limit total I/O operations per second\n>> # @iops-total-max: I/O operations burst\n>> # @iops-total-max-length: length of the iops-total-max burst period,\n>> in seconds\n>> @@ -1942,7 +1872,7 @@\n>> # Since: 2.11\n>> ##\n>> { 'struct': 'ThrottleLimits',\n>> - 'data': { '*iops-total' : 'int', '*iops-total-max' : 'int',\n>> + 'data': { '*id' : 'str', '*iops-total' : 'int', '*iops-total-max' :\n>> 'int',\n>> '*iops-total-max-length' : 'int', '*iops-read' : 'int',\n>> '*iops-read-max' : 'int', '*iops-read-max-length' : 'int',\n>> '*iops-write' : 'int', '*iops-write-max' : 'int',\n>\n> And here it's iops-read-max-length. This breaks the block layer's old\n> throttling API. Do we want the old API replaced for 2.11? I don't know\n> which maintainer is responsible for this, so I CC'd armbru.\n\nI do not think its going to break. It just exist we neither try to set \nthat or to query.\n\n-Pradeep","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy2DY4Ncjz9s82\n\tfor ;\n\tThu, 21 Sep 2017 00:29:01 +1000 (AEST)","from localhost ([::1]:48454 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dufzn-0008GJ-ML\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 10:28:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49842)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dufRe-0000Pf-1I\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:53:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dufRZ-000507-Lr\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:53:42 -0400","from lhrrgout.huawei.com ([194.213.3.17]:24224)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from ) id 1dufRZ-0004zF-1N\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 09:53:37 -0400","from 172.18.7.190 (EHLO LHREML713-CAH.china.huawei.com)\n\t([172.18.7.190])\n\tby lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued)\n\twith ESMTP id DVV81981; Wed, 20 Sep 2017 08:46:18 +0000 (GMT)","from [127.0.0.1] (10.210.172.123) by LHREML713-CAH.china.huawei.com\n\t(10.201.108.36) with Microsoft SMTP Server id 14.3.301.0;\n\tWed, 20 Sep 2017 09:46:09 +0100"],"To":"Manos Pitsidianakis , Pradeep Jagadeesh\n\t, eric blake , greg kurz\n\t, jani kokkonen ,\n\talberto garcia\n\t, , Markus Armbruster\n\t","References":"<1505385610-35529-1-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<1505385610-35529-3-git-send-email-pradeep.jagadeesh@huawei.com>\n\t<20170918160434.cfkm7jlg3oig25qj@postretch>","From":"Pradeep Jagadeesh ","Message-ID":"<23bb8481-7854-70aa-de7c-8f3d18270ebb@huawei.com>","Date":"Wed, 20 Sep 2017 10:46:09 +0200","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170918160434.cfkm7jlg3oig25qj@postretch>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.210.172.123]","X-CFilter-Loop":"Reflected","X-Mirapoint-Virus-RAPID-Raw":"score=unknown(0),\n\trefid=str=0001.0A020205.59C22ADD.0044, ss=1, re=0.000, recu=0.000,\n\treip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0,\n\tso=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32","X-Mirapoint-Loop-Id":"9be952b4f0406151db4f3f0b038e8cb9","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic]\n\t[fuzzy]","X-Received-From":"194.213.3.17","Subject":"Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]