[{"id":1777205,"web_url":"http://patchwork.ozlabs.org/comment/1777205/","msgid":"<20170928175748.23b7wkjiqavpunvj@thunk.org>","list_archive_url":null,"date":"2017-09-28T17:57:48","subject":"Re: [PATCH v2 3/4] ext4: Add iomap support for inline data","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Tso","email":"tytso@mit.edu"},"content":"On Thu, Sep 14, 2017 at 11:50:46AM +0200, Andreas Gruenbacher wrote:\n> +int ext4_inline_data_iomap(struct inode *inode, struct iomap *iomap)\n> +{\n> +\t__u64 addr;\n> +\tint error = -EAGAIN;\n> +\tstruct ext4_iloc iloc;\n> +\n> +\tdown_read(&EXT4_I(inode)->xattr_sem);\n> +\tif (!ext4_has_inline_data(inode))\n> +\t\tgoto out;\n\t....\n> +out:\n> +\tup_read(&EXT4_I(inode)->xattr_sem);\n> +\treturn error;\n> +}\n\n\nIf we race with the inline data flag getting cleared,\next4_iomap_begin() will return with -EAGAIN. As near as I can tell,\nthis will get reflected all the way up to userspace, instead of having\nthe retry happen in the kernel. Is this intentional?\n\nIt looks like a user visible change, no?\n\n\t\t\t\t\t\t- Ted","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=thunk.org header.i=@thunk.org\n\theader.b=\"io7itUO0\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y32Tz5pJnz9t66\n\tfor ;\n\tFri, 29 Sep 2017 03:57:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752469AbdI1R54 (ORCPT );\n\tThu, 28 Sep 2017 13:57:56 -0400","from imap.thunk.org ([74.207.234.97]:43328 \"EHLO imap.thunk.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752467AbdI1R5z (ORCPT );\n\tThu, 28 Sep 2017 13:57:55 -0400","from root (helo=callcc.thunk.org)\n\tby imap.thunk.org with local-esmtp (Exim 4.89)\n\t(envelope-from )\n\tid 1dxd4H-0003vU-DS; Thu, 28 Sep 2017 17:57:49 +0000","by callcc.thunk.org (Postfix, from userid 15806)\n\tid AFA2AC003C1; Thu, 28 Sep 2017 13:57:48 -0400 (EDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org;\n\ts=ef5046eb;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=WpBKBk8cHusobQ8YE1+jOAtVR8y4FH9Kc/g5AeUSmo0=;\n\tb=io7itUO0khz+EldXecl/izw0Je\n\t/6qREi34gfQuWTwrcZJhp7u51wcofAcYvU2yFC/xtI+jqQWbVUP0AoK9gIOOwwX9CAygcQP60NhLk\n\teiguFsU9S8UxnKH/0KhB7RNgjhRYg7xN6zMFiF4Ru+BnWdeJgDsdFSi19O1oAAIvvuM8=;","Date":"Thu, 28 Sep 2017 13:57:48 -0400","From":"Theodore Ts'o ","To":"Andreas Gruenbacher ","Cc":"linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,\n\tlinux-xfs@vger.kernel.org, Jan Kara ,\n\tChristoph Hellwig ","Subject":"Re: [PATCH v2 3/4] ext4: Add iomap support for inline data","Message-ID":"<20170928175748.23b7wkjiqavpunvj@thunk.org>","References":"<20170914095047.23935-1-agruenba@redhat.com>\n\t<20170914095047.23935-4-agruenba@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170914095047.23935-4-agruenba@redhat.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"tytso@thunk.org","X-SA-Exim-Scanned":"No (on imap.thunk.org); SAEximRunCond expanded to false","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1778382,"web_url":"http://patchwork.ozlabs.org/comment/1778382/","msgid":"","list_archive_url":null,"date":"2017-10-02T14:39:59","subject":"Re: [PATCH v2 3/4] ext4: Add iomap support for inline data","submitter":{"id":67290,"url":"http://patchwork.ozlabs.org/api/people/67290/","name":"Andreas Gruenbacher","email":"agruenba@redhat.com"},"content":"On Thu, Sep 28, 2017 at 7:57 PM, Theodore Ts'o wrote:\n> On Thu, Sep 14, 2017 at 11:50:46AM +0200, Andreas Gruenbacher wrote:\n>> +int ext4_inline_data_iomap(struct inode *inode, struct iomap *iomap)\n>> +{\n>> + __u64 addr;\n>> + int error = -EAGAIN;\n>> + struct ext4_iloc iloc;\n>> +\n>> + down_read(&EXT4_I(inode)->xattr_sem);\n>> + if (!ext4_has_inline_data(inode))\n>> + goto out;\n> ....\n>> +out:\n>> + up_read(&EXT4_I(inode)->xattr_sem);\n>> + return error;\n>> +}\n>\n>\n> If we race with the inline data flag getting cleared,\n> ext4_iomap_begin() will return with -EAGAIN.\n\nActually, in that case, ext4_iomap_begin will treat the file as non-inline.\nIt will not return -EAGAIN.\n\n> As near as I can tell,\n> this will get reflected all the way up to userspace, instead of having\n> the retry happen in the kernel. Is this intentional?\n>\n> It looks like a user visible change, no?\n\nThat would be a bug.\n\nThanks,\nAndreas","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5Pvl4NGrz9t6n\n\tfor ;\n\tTue, 3 Oct 2017 01:40:03 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751279AbdJBOkB (ORCPT );\n\tMon, 2 Oct 2017 10:40:01 -0400","from mail-ua0-f181.google.com ([209.85.217.181]:55415 \"EHLO\n\tmail-ua0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751336AbdJBOkA (ORCPT\n\t); Mon, 2 Oct 2017 10:40:00 -0400","by mail-ua0-f181.google.com with SMTP id b11so3370729uae.12\n\tfor ;\n\tMon, 02 Oct 2017 07:39:59 -0700 (PDT)","by 10.176.9.232 with HTTP; Mon, 2 Oct 2017 07:39:59 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=s6THGTyc9wESi7qYntox4hbKqtaGDY6PepTblkWob88=;\n\tb=uZ18Ah7LRBm+fnbkQ76JIFgycfAk2G9mLP6wgte6C+TJfCHo1tz1L7Oa8BdFyW6Qh0\n\tS212dlXQ+flwmmaC+mCxcJDLrzjWyNQ3IKW6pLg54UGqSWvfHWg6aKy2gR0UTaDsrVJ2\n\ttRLFEE9N3dLjz/AfeYJOP0uRNBXvjiHMmtYY7DdvxQP0HcAKxjByQaO4c+JMF5aQbJVx\n\tCRznkEsKgijyrhXaAyOmeF4vnoK6w8mMHe7T+8YpnDe3D7eNkpeM+leau4DtxBZ9zGP+\n\thLSjz14vUWcEf+6TwXQhHuhoM0Z8AfvHhZu275UU5uQd9BCXc7YkwA11l6CU1wzwDflm\n\taAjg==","X-Gm-Message-State":"AHPjjUhuzxCmjADtyiTyjiitwLMK/5WgrtL4imD3gqhMk2YkqPKNGhWY\n\t+V7PlBWa68+ChM6cWdaDButlsxCoNB9FMMGk14Jaog==","X-Google-Smtp-Source":"AOwi7QBZJ/te+HArZ+HRUd0HbRtcSRUzz8TNAFl7RrCHcnIJclcxB9OF34NmqBb1iKQa+KW4OCZ+wHs2ueygQWaqIvs=","X-Received":"by 10.176.74.129 with SMTP id s1mr9512620uae.191.1506955199505; \n\tMon, 02 Oct 2017 07:39:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170928175748.23b7wkjiqavpunvj@thunk.org>","References":"<20170914095047.23935-1-agruenba@redhat.com>\n\t<20170914095047.23935-4-agruenba@redhat.com>\n\t<20170928175748.23b7wkjiqavpunvj@thunk.org>","From":"Andreas Gruenbacher ","Date":"Mon, 2 Oct 2017 16:39:59 +0200","Message-ID":"","Subject":"Re: [PATCH v2 3/4] ext4: Add iomap support for inline data","To":"\"Theodore Ts'o\" ","Cc":"linux-fsdevel ,\n\tlinux-ext4 ,\n\tlinux-xfs@vger.kernel.org, Jan Kara ,\n\tChristoph Hellwig ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}},{"id":1778398,"web_url":"http://patchwork.ozlabs.org/comment/1778398/","msgid":"<20171002150208.bcuv2wqqs3cpyyvz@thunk.org>","list_archive_url":null,"date":"2017-10-02T15:02:08","subject":"Re: [PATCH v2 3/4] ext4: Add iomap support for inline data","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Tso","email":"tytso@mit.edu"},"content":"On Mon, Oct 02, 2017 at 04:39:59PM +0200, Andreas Gruenbacher wrote:\n> > If we race with the inline data flag getting cleared,\n> > ext4_iomap_begin() will return with -EAGAIN.\n> \n> Actually, in that case, ext4_iomap_begin will treat the file as non-inline.\n> It will not return -EAGAIN.\n\nAh, thanks, I missed that.\n\n\t\t\t\t\t- Ted","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ext4-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=thunk.org header.i=@thunk.org\n\theader.b=\"cOInTmv+\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5QPQ0Mzvz9t6s\n\tfor ;\n\tTue, 3 Oct 2017 02:02:18 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751355AbdJBPCO (ORCPT );\n\tMon, 2 Oct 2017 11:02:14 -0400","from imap.thunk.org ([74.207.234.97]:53230 \"EHLO imap.thunk.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751250AbdJBPCN (ORCPT );\n\tMon, 2 Oct 2017 11:02:13 -0400","from root (helo=callcc.thunk.org)\n\tby imap.thunk.org with local-esmtp (Exim 4.89)\n\t(envelope-from )\n\tid 1dz2ET-0006mA-IO; Mon, 02 Oct 2017 15:02:09 +0000","by callcc.thunk.org (Postfix, from userid 15806)\n\tid EA0FBC0038A; Mon, 2 Oct 2017 11:02:08 -0400 (EDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org;\n\ts=ef5046eb;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=wrltW9SahCW9gHQCfKgYmt7KC5slKeUr2BGmLk8njb4=;\n\tb=cOInTmv+cu5eOdy1lE2ge2dD6t\n\ty7YLWHD4kcVWG+AeJs1FsCFd4YfOVVSgITDFbJzQ7XgXu0fPIhbvX4OSr+wDp4SX11jKHDUx0GdLx\n\tS68zvtI1oL9RlnR/pswjxasvaN1/6hvwJWi9Gc8qVz4PjHcn9M96wRBtG1GufH/Uh4nA=;","Date":"Mon, 2 Oct 2017 11:02:08 -0400","From":"Theodore Ts'o ","To":"Andreas Gruenbacher ","Cc":"linux-fsdevel ,\n\tlinux-ext4 ,\n\tlinux-xfs@vger.kernel.org, Jan Kara ,\n\tChristoph Hellwig ","Subject":"Re: [PATCH v2 3/4] ext4: Add iomap support for inline data","Message-ID":"<20171002150208.bcuv2wqqs3cpyyvz@thunk.org>","References":"<20170914095047.23935-1-agruenba@redhat.com>\n\t<20170914095047.23935-4-agruenba@redhat.com>\n\t<20170928175748.23b7wkjiqavpunvj@thunk.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","X-SA-Exim-Connect-IP":"","X-SA-Exim-Mail-From":"tytso@thunk.org","X-SA-Exim-Scanned":"No (on imap.thunk.org); SAEximRunCond expanded to false","Sender":"linux-ext4-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ext4@vger.kernel.org"}}]