[{"id":1771397,"web_url":"http://patchwork.ozlabs.org/comment/1771397/","msgid":"<0888aa23-a2a9-6080-d6c0-7522c86b5eb4@redhat.com>","list_archive_url":null,"date":"2017-09-19T21:05:48","subject":"Re: [Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper\n\tfor QMP","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/14/2017 02:50 AM, Peter Xu wrote:\n> In monitor_qmp_read(), we have the hack to temporarily replace the\n> cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher\n> routine since the Monitor pointer can be passed in to that using the new\n> JSON Parser opaque field now.\n> \n> This does not make much sense as a single patch. However, this will be\n> a big step for the next patch, when the QMP dispatcher routine will be\n> splitted from the QMP parser.\n\nEnglish is weird: 'split' is the word for present, past, and past\nparticiple tenses; there is no word 'splitted'.\n\n> \n> Signed-off-by: Peter Xu \n> ---\n> monitor.c | 19 ++++++++++---------\n> 1 file changed, 10 insertions(+), 9 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxb5f0VqGz9sMN\n\tfor ;\n\tWed, 20 Sep 2017 07:06:28 +1000 (AEST)","from localhost ([::1]:45435 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duPis-00024U-CX\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 17:06:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43640)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duPiT-000246-Mq\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 17:06:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duPiP-0006oD-1v\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 17:06:01 -0400","from mx1.redhat.com ([209.132.183.28]:45318)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duPiO-0006nk-PQ\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 17:05:56 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AE7C580468;\n\tTue, 19 Sep 2017 21:05:55 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 40E9060BE6;\n\tTue, 19 Sep 2017 21:05:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AE7C580468","To":"Peter Xu , qemu-devel@nongnu.org","References":"<1505375436-28439-1-git-send-email-peterx@redhat.com>\n\t<1505375436-28439-7-git-send-email-peterx@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<0888aa23-a2a9-6080-d6c0-7522c86b5eb4@redhat.com>","Date":"Tue, 19 Sep 2017 16:05:48 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505375436-28439-7-git-send-email-peterx@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"JT29wFHwrSO0T8mDcjdn8eSkF4St9ts7l\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tTue, 19 Sep 2017 21:05:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper\n\tfor QMP","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Fam Zheng , Juan\n\tQuintela , Markus Armbruster ,\n\tmdroth@linux.vnet.ibm.com, \tStefan Hajnoczi ,\n\t=?utf-8?q?Marc-Andr=C3=A9_Lure?= =?utf-8?q?au?=\n\t, \tPaolo Bonzini ,\n\t\"Dr . David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1771588,"web_url":"http://patchwork.ozlabs.org/comment/1771588/","msgid":"<20170920055449.GV3617@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-20T05:54:49","subject":"Re: [Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper\n\tfor QMP","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Tue, Sep 19, 2017 at 04:05:48PM -0500, Eric Blake wrote:\n> On 09/14/2017 02:50 AM, Peter Xu wrote:\n> > In monitor_qmp_read(), we have the hack to temporarily replace the\n> > cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher\n> > routine since the Monitor pointer can be passed in to that using the new\n> > JSON Parser opaque field now.\n> > \n> > This does not make much sense as a single patch. However, this will be\n> > a big step for the next patch, when the QMP dispatcher routine will be\n> > splitted from the QMP parser.\n> \n> English is weird: 'split' is the word for present, past, and past\n> participle tenses; there is no word 'splitted'.\n\nFixed.\n\n> \n> > \n> > Signed-off-by: Peter Xu \n> > ---\n> > monitor.c | 19 ++++++++++---------\n> > 1 file changed, 10 insertions(+), 9 deletions(-)\n> > \n> \n> Reviewed-by: Eric Blake \n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxpr70SmZz9s81\n\tfor ;\n\tWed, 20 Sep 2017 15:55:31 +1000 (AEST)","from localhost ([::1]:46845 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duXyq-0004ww-Sj\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 01:55:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46178)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duXyX-0004uz-IE\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 01:55:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duXyS-0004cI-9P\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 01:55:09 -0400","from mx1.redhat.com ([209.132.183.28]:52906)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duXyS-0004Rr-2q\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 01:55:04 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 565EF5D68C;\n\tWed, 20 Sep 2017 05:55:02 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 08DC8600CA;\n\tWed, 20 Sep 2017 05:54:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 565EF5D68C","Date":"Wed, 20 Sep 2017 13:54:49 +0800","From":"Peter Xu ","To":"Eric Blake ","Message-ID":"<20170920055449.GV3617@pxdev.xzpeter.org>","References":"<1505375436-28439-1-git-send-email-peterx@redhat.com>\n\t<1505375436-28439-7-git-send-email-peterx@redhat.com>\n\t<0888aa23-a2a9-6080-d6c0-7522c86b5eb4@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<0888aa23-a2a9-6080-d6c0-7522c86b5eb4@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 20 Sep 2017 05:55:02 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper\n\tfor QMP","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Laurent Vivier , Fam Zheng ,\n\tmdroth@linux.vnet.ibm.com, Juan Quintela ,\n\tMarkus Armbruster , qemu-devel@nongnu.org, Stefan\n\tHajnoczi , =?utf-8?q?Marc-Andr=C3=A9?=\n\tLureau ,\n\tPaolo Bonzini , \"Dr . David Alan Gilbert\"\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]