[{"id":1768559,"web_url":"http://patchwork.ozlabs.org/comment/1768559/","msgid":"<20170914123824.us56wefi3di345mh@dell>","list_archive_url":null,"date":"2017-09-14T12:38:24","subject":"Re: [patch v5 2/2] dt-bindings: mfd: Add Device Tree bindings for\n\tMellanox programmable devices","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Thu, 14 Sep 2017, Vadim Pasternak wrote:\n\n> The mlxreg a multifunction device driver handling LEDs, events, exposing\n> through sysfs reset signal, and reset causes info. These components share\n> a common register space.\n> \n> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>\n> ---\n> v4->v5:\n>  Comments pointed out by Rob:\n>  - Avoid duplications in reg;\n>  - Remove unnecessary details in description;\n>  - Do not use names like phandels;\n>  Changes added by Vadim:\n>  - Combine hotplug nodes interrupt aggregation, register offset and mask\n>    properties into hotplug-spec properties;\n>  - Combine reset, cause, etc subnodes register offset, mask and effective\n>    bit properties into attr-spec properties;\n> v3->v4:\n>  Comments pointed out by Rob:\n>  - Make a separate patch /devicetree/bindings/vendor-prefixes.txt;\n>  - Add .txt to Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core\n>    and send it within this series;\n>  - Modify \"compatible\" property;\n>  - Modify explanation for \"deferred\" property;\n>  - Describe each subnode by its own section;\n>  - Don't use underscore in attribute names;\n> ---\n>  .../bindings/mfd/mellanox,mlxreg-core.txt          | 165 +++++++++++++++++++++\n>  1 file changed, 165 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt\n\nWow!  I have never seen a binding like this before.\n\n> diff --git a/Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt b/Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt\n> new file mode 100644\n> index 0000000..1e3cce5\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt\n> @@ -0,0 +1,165 @@\n> +Mellanox programmable device control.\n> +-------------------------------------\n> +This binding defines the device control interface over for Mellanox BMC based\n> +switches.\n> +\n> +Required properties:\n> +- compatible =  \"mellanox,mlxreg-i2c\" or\n> +\t\t\"mellanox,mlxreg-i2c-16\"\n> +\n> +- #address-cells : must be 1;\n> +- #size-cells : must be 0;\n> +- reg : I2C address;\n> +\n> +Optional properties:\n> +- interrupt-parent : phandle of parent interrupt controller;\n> +- interrupts : interrupt line;\n> +- deferred : I2C deferred bus phandle;\n> +\t     I2C bus activation order enforce for the cases when hot-plug\n> +\t     devices are attached to I2C bus, which is initialized after the\n> +\t     I2C bus, where programmable device is attached;\n\nDependencies aren't usually expressed in DT.\n\nWhy can't this be done pragmatically?\n\nUsually we try to interrogate a device that we depend on and if it's\nnot present, we return -EPROBE_DEFER and try again latter.\n\n> +- hotplug-spec <aggr mask>:\n> +\t- aggr : interrupt top aggregation register offset;\n> +\t- mask : interrupt top aggregation register mask;\n\nWhat is this?  Are you describing register layout in DT?\n\nYou should use the 'reg' property to describe registers.\n\nBit masks are usually defined in C.\n\n> +Optional nodes and their properties:\n> + - psu : power supply unit nodes:\n> +\tRequired properties:\n> +\t- hotplug-spec <aggr reg mask>:\n> +\t\t- aggr : effective bit in aggregation interrupt mask;\n> +\t\t- reg : interrupt status register offset for all group members;\n> +\t\t- mask : interrupt register mask;\n> +\t- hotplugs - list of relevant dynamic device nodes;\n\nWhat is a dynamic device node?\n\nI think I saw the code for this?  Are you attempting to 'enable' and\n'disable' nodes on-the-fly?  That's not really what the status\nproperty is for.  Usually we disable nodes in DTS(I) files which cover\nmany devices, then enable them in more specific device files if they\nare located on that device.\n\nThey are not to be used as a flag you just toggle on and off.  That's\na hack.\n\n> + - fan : fan unit nodes:\n> +\tRequired properties:\n> +\t- hotplug-spec <aggr reg mask>:\n> +\t\t- aggr : effective bit in aggregation interrupt mask;\n> +\t\t- reg : interrupt status register offset for all group members;\n> +\t\t- mask : interrupt register mask;\n> +\t- hotplugs - list of relevant dynamic device nodes;\n> + - pwr : power cable nodes:\n> +\tRequired properties:\n> +\t- hotplug-spec <aggr reg mask>:\n> +\t\t- aggr : effective bit in aggregation interrupt mask;\n> +\t\t- reg : interrupt status register offset for all group members;\n> +\t\t- mask : interrupt register mask;\n> +\t- hotplugs : list of relevant dynamic device nodes;\n> + - host : host side nodes (CPU host side for BMC):\n> +\tRequired properties:\n> +\t- hotplug-spec <aggr reg mask>:\n> +\t\t- aggr : effective bit in aggregation interrupt mask;\n> +\t\t- reg : interrupt status register offset for all group members;\n> +\t\t- mask : interrupt register mask;\n> +\t- hotplugs : list of relevant dynamic device nodes;\n> + - asic : asic nodes:\n> +\tRequired properties:\n> +\t- hotplug-spec <aggr reg mask>:\n> +\t\t- aggr : effective bit in aggregation interrupt mask;\n> +\t\t- reg : interrupt status register offsets array per group member;\n> +\t\t- mask : interrupt register mask;\n> +\t- hotplugs : list of relevant device nodes;\n> + - reset : reset nodes for system reset operations:\n> +\tRequired properties:\n> +\t- reset control subnodes:\n> +\t\tRequired properties:\n> +\t\t- attr-spec <reg mask>:\n\nThis property is not defined, but again, 'reg' is the correct property\nto use.  Masks are usually defined in C code.\n\n> +\t\t\t- reg : register offset;\n> +\t\t\t- mask : attribute mask;\n> + - cause - reset cause nodes for reading system reset cause:\n> +\tRequired properties:\n> +\t- cause info subnodes:\n> +\t\tRequired properties:\n> +\t\t- attr-spec <reg mask>:\n> +\t\t\t- reg : register offset;\n> +\t\t\t- mask : attribute mask;\n> + - mux - mux nodes:\n> +\tRequired properties:\n> +\t- mux control subnodes for hardware select operations:\n> +\t\tRequired properties:\n> +\t\t- attr-spec <reg mask bit>:\n> +\t\t\t- reg : register offset;\n> +\t\t\t- mask : attribute mask;\n> +\t\t\t- bit : effective bit;\n> +\t\tOptional property:\n> +\t\t- hotplugs : dynamic device node selected by mux;\n> + - gprw - general purpose read-write register nodes:\n> +\tRequired properties:\n> +\t- general purpose read-write register subnodes:\n> +\t\tRequired properties:\n> +\t\t- attr-spec <reg mask>:\n> +\t\t\t- reg : register offset;\n> +\t\t\t- mask : attribute mask;\n> + - gpro - general purpose read only register nodes:\n> +\tRequired properties:\n> +\t- general purpose read only register subnodes:\n> +\t\tRequired properties:\n> +\t\t- attr-spec <reg mask>:\n> +\t\t\t- reg : register offset.\n> +\t\t\t- mask : attribute mask.\n> + - led - led nodes for led operations control:\n> +\tRequired properties:\n> +\t- led control nodes:\n> +\t\tRequired properties:\n> +\t\t- attr-spec <reg mask>:\n> +\t\t\t- reg : register offset;\n> +\t\t\t- mask : attribute mask;\n> +\n> +Example:\n> +\tmlxcpld-mng-ctrl@71 {\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <0>;\n> +\t\tinterrupt-parent = <&gpio>;\n> +\t\tinterrupts = <ASPEED_GPIO(S, 1) 2>;\n> +\t\tcompatible = \"mellanox,mlxcpld-ctrl-i2c\";\n> +\t\treg = <0x71>;\n> +\t\tdeferred = <&i2c6>;\n> +\t\thotplug-spec = <0x3a 0x4c>;\n> +\n> +\t\tpwr: {\n> +\t\t\thotplug-spec = <0x08 0x64 0x03>;\n> +\t\t\thotplugs = <&psu1_ctrl &psu2_ctrl>;\n> +\t\t};\n> +\n> +\t\tmux {\n> +\t\t\tspi_burn_bios_ci {\n> +\t\t\t\tattr-spec = <0x32 0xfe 0x00>;\n> +\t\t\t\thotplugs = <&spi2>;\n> +\t\t\t};\n> +\t\t};\n> +\n> +\t\tled {\n> +\t\t\tstatus-green {\n> +\t\t\t\tattr-spec = <0x20 0xf0>;\n> +\t\t\t};\n> +\t\t\tstatus-red {\n> +\t\t\t\tattr-spec = <0x20 0xf0>;\n> +\t\t\t};\n> +\t\t};\n> +\n> +\t\treset {\n> +\t\t\tsys_power_cycle {\n> +\t\t\t\tattr-spec = <0x30 0xfb>;\n> +\t\t\t};\n> +\t\t};\n> +\n> +\t\tcause {\n> +\t\t\tac_power_cycle {\n> +\t\t\t\tattr-spec = <0x1d 0xfe>;\n> +\t\t\t};\n> +\t\t\tsys_pwr_cycle: {\n> +\t\t\t\tattr-spec = <0x1e 0xfb>;\n> +\t\t\t};\n> +\t\t};\n> +\n> +\t\tgpro {\n> +\t\t\tcpld_mng_version {\n> +\t\t\t\tattr-spec <0x00 0xff 0xff>;\n> +\t\t\t};\n> +\t\t};\n> +\n> +\t\tgprw {\n> +\t\t\tsw_reset_cause {\n> +\t\t\t\tattr-spec = <0x37 0x0f 0x0f>;\n> +\t\t\t};\n> +\t\t};\n> +\t};","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"N+cMNebp\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtJ3s4vTbz9sP1\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 22:38:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751681AbdINMib (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 14 Sep 2017 08:38:31 -0400","from mail-wr0-f177.google.com ([209.85.128.177]:47094 \"EHLO\n\tmail-wr0-f177.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751629AbdINMi3 (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 14 Sep 2017 08:38:29 -0400","by mail-wr0-f177.google.com with SMTP id o42so5783318wrb.3\n\tfor <devicetree@vger.kernel.org>;\n\tThu, 14 Sep 2017 05:38:28 -0700 (PDT)","from dell ([2.27.167.120]) by smtp.gmail.com with ESMTPSA id\n\ti8sm12828007wra.56.2017.09.14.05.38.26\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 14 Sep 2017 05:38:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=BDW1Tuf0KX8mj//45k4j9LWDh0AeSuYsuUJBsrGTWUQ=;\n\tb=N+cMNebprGySU25B+ub+6/3rbXy9w7e4EG0MhkD0W0IK7gWCn9jdl1eE6TrDDRdoIk\n\tANhXc6bGSNc0oqdR6h77DeREGyYBuuZCaAPDQN+2yYjYKh/zeKgh0/tphDbcLvfZki5I\n\tlNENC9L5DkVqd8KrypmjCMs5Xih6A6Bf3C9To=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=BDW1Tuf0KX8mj//45k4j9LWDh0AeSuYsuUJBsrGTWUQ=;\n\tb=DiM+x376VLBThjQy/ORn6kMnK8G+Exk8NABZMDByJ2QuOIA9dV/1hYn5OYTW8Xy0OL\n\tvQZfe817ECYdV6XSLAenRn2RW08n6K4RAsJBAvFMh91xgBVrD2bScQv4BDwYtJ4KI4zs\n\tqBC4t/qAR2bwfSGskph7biBOgKbfjRqM5+LySBEfTAtqJHsJQo+gNtkcovjawBk7vPLj\n\tHeQs0ZkE7du9O+7qDJu00qCo/ha1Awa2ItpdiKZK0iU0g6/UR2xPVJByj286ULJZmBfy\n\tKa6Po26Q1dj5/N5eZmP3gYEpWPzahNMTtcBJd5WuYuwszzbunckETZkPznT2IPbsEOqt\n\tsTBg==","X-Gm-Message-State":"AHPjjUhGvDYV7zylISHvdFoSOgWZHwPVJHU29Vx8FTFYiVTAEeSvyrCM\n\taLPcYXNmnbyzmaFDJ4+8vA==","X-Google-Smtp-Source":"AOwi7QBq3Xv1byqjdTfUsVinCDxAPNlBWCY9VvEjHZ+q6//m4LsfAzZR3QzSVu6ewu3jSLxztwXDgw==","X-Received":"by 10.223.199.196 with SMTP id y4mr8664335wrg.181.1505392707558; \n\tThu, 14 Sep 2017 05:38:27 -0700 (PDT)","Date":"Thu, 14 Sep 2017 13:38:24 +0100","From":"Lee Jones <lee.jones@linaro.org>","To":"Vadim Pasternak <vadimp@mellanox.com>","Cc":"robh+dt@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,\n\tjacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,\n\tjiri@resnulli.us, gregkh@linuxfoundation.org,\n\tandy.shevchenko@gmail.com, platform-driver-x86@vger.kernel.org","Subject":"Re: [patch v5 2/2] dt-bindings: mfd: Add Device Tree bindings for\n\tMellanox programmable devices","Message-ID":"<20170914123824.us56wefi3di345mh@dell>","References":"<1505371738-128683-1-git-send-email-vadimp@mellanox.com>\n\t<1505371738-128683-3-git-send-email-vadimp@mellanox.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<1505371738-128683-3-git-send-email-vadimp@mellanox.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1768567,"web_url":"http://patchwork.ozlabs.org/comment/1768567/","msgid":"<20170914125140.2a7cwmgm7pzk6zuk@dell>","list_archive_url":null,"date":"2017-09-14T12:51:40","subject":"Re: [patch v5 2/2] dt-bindings: mfd: Add Device Tree bindings for\n\tMellanox programmable devices","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Thu, 14 Sep 2017, Lee Jones wrote:\n\n> On Thu, 14 Sep 2017, Vadim Pasternak wrote:\n> \n> > The mlxreg a multifunction device driver handling LEDs, events, exposing\n> > through sysfs reset signal, and reset causes info. These components share\n> > a common register space.\n> > \n> > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>\n> > ---\n> > v4->v5:\n> >  Comments pointed out by Rob:\n> >  - Avoid duplications in reg;\n> >  - Remove unnecessary details in description;\n> >  - Do not use names like phandels;\n> >  Changes added by Vadim:\n> >  - Combine hotplug nodes interrupt aggregation, register offset and mask\n> >    properties into hotplug-spec properties;\n> >  - Combine reset, cause, etc subnodes register offset, mask and effective\n> >    bit properties into attr-spec properties;\n> > v3->v4:\n> >  Comments pointed out by Rob:\n> >  - Make a separate patch /devicetree/bindings/vendor-prefixes.txt;\n> >  - Add .txt to Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core\n> >    and send it within this series;\n> >  - Modify \"compatible\" property;\n> >  - Modify explanation for \"deferred\" property;\n> >  - Describe each subnode by its own section;\n> >  - Don't use underscore in attribute names;\n> > ---\n> >  .../bindings/mfd/mellanox,mlxreg-core.txt          | 165 +++++++++++++++++++++\n> >  1 file changed, 165 insertions(+)\n> >  create mode 100644 Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt\n> \n> Wow!  I have never seen a binding like this before.\n> \n> > diff --git a/Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt b/Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt\n> > new file mode 100644\n> > index 0000000..1e3cce5\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/mfd/mellanox,mlxreg-core.txt\n> > @@ -0,0 +1,165 @@\n> > +Mellanox programmable device control.\n> > +-------------------------------------\n> > +This binding defines the device control interface over for Mellanox BMC based\n> > +switches.\n> > +\n> > +Required properties:\n> > +- compatible =  \"mellanox,mlxreg-i2c\" or\n> > +\t\t\"mellanox,mlxreg-i2c-16\"\n> > +\n> > +- #address-cells : must be 1;\n> > +- #size-cells : must be 0;\n> > +- reg : I2C address;\n> > +\n> > +Optional properties:\n> > +- interrupt-parent : phandle of parent interrupt controller;\n> > +- interrupts : interrupt line;\n> > +- deferred : I2C deferred bus phandle;\n> > +\t     I2C bus activation order enforce for the cases when hot-plug\n> > +\t     devices are attached to I2C bus, which is initialized after the\n> > +\t     I2C bus, where programmable device is attached;\n> \n> Dependencies aren't usually expressed in DT.\n> \n> Why can't this be done pragmatically?\n> \n> Usually we try to interrogate a device that we depend on and if it's\n> not present, we return -EPROBE_DEFER and try again latter.\n\nActually, thinking about this.  Are these hierarchical?\n\nIf so, they would be better represented as a sub-node.","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"TNbOU1in\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtJM80CKsz9sPt\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 22:51:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751380AbdINMvq (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tThu, 14 Sep 2017 08:51:46 -0400","from mail-wm0-f53.google.com ([74.125.82.53]:46900 \"EHLO\n\tmail-wm0-f53.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751131AbdINMvp (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Thu, 14 Sep 2017 08:51:45 -0400","by mail-wm0-f53.google.com with SMTP id i189so134353wmf.1\n\tfor <devicetree@vger.kernel.org>;\n\tThu, 14 Sep 2017 05:51:44 -0700 (PDT)","from dell ([2.27.167.120]) by smtp.gmail.com with ESMTPSA id\n\td6sm9480782wrb.32.2017.09.14.05.51.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 14 Sep 2017 05:51:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=9Czvs+K/8cAHNtPbPeYRT3Lyeiq2FssmXCCAvk9KzkY=;\n\tb=TNbOU1innt4gjKw+UtnwQg2hUkInRvy4bDdKBqJWKTkHbj5gv7nXJOl5Lw40QzGkDx\n\t0rvS2egAC4YR/tmRRTOvVK43Qqh6KxFEBNGBYv1d9jw+ofTq2YGyLUHlKd7MdY72sNPG\n\tGFqh/7PaBsHNoP4j0W8WrKJ3klRr8nv+OAP6A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=9Czvs+K/8cAHNtPbPeYRT3Lyeiq2FssmXCCAvk9KzkY=;\n\tb=LUmi1B3L6aEair/2cL6j3eQXCmVBI0kc/g4LFax6CwHn1U2/mHuupuT9lAN+m//j/j\n\toEiNzkDDgCkunmmI/UwVRl2ebM7fQJxgvfcxc1oxKRaM4GLgl8TiECzG3uCj6ccql8WR\n\tfIBqRIbSj9nulo30pGu2Z2RCsvy8YgwKAdrOIYDx7d77kiE4TODeRbQNndnKjWMlaQWC\n\trrsAklewlrFTF5b/LV0/w9Pwn/73gGOzuVRwKd57tQWfquaZ5h/ZdH/7G5ZHy2f0sec8\n\tuK+/1XumhsWMTeBxWKNSstQ8GAosRehto9Z/pSV7RA/d773fDVbsKH1NebGOQoD1C4jY\n\t13kg==","X-Gm-Message-State":"AHPjjUjUIGsWYf+2p9PGbGca+qS97HaLf5Jr/QMc+RhT8oVb5P4+XWu5\n\t766WBsreB4+3pRdw","X-Google-Smtp-Source":"AOwi7QBqwPDCDwXfn5qb/0h2tzM9cCsj4OaZF868BUjKyE82N30mOteZIWhH3JurDWbIWRq4+Sp1HQ==","X-Received":"by 10.28.153.85 with SMTP id b82mr1671881wme.121.1505393503602; \n\tThu, 14 Sep 2017 05:51:43 -0700 (PDT)","Date":"Thu, 14 Sep 2017 13:51:40 +0100","From":"Lee Jones <lee.jones@linaro.org>","To":"Vadim Pasternak <vadimp@mellanox.com>","Cc":"robh+dt@kernel.org, pavel@ucw.cz, devicetree@vger.kernel.org,\n\tjacek.anaszewski@gmail.com, linux-leds@vger.kernel.org,\n\tjiri@resnulli.us, gregkh@linuxfoundation.org,\n\tandy.shevchenko@gmail.com, platform-driver-x86@vger.kernel.org","Subject":"Re: [patch v5 2/2] dt-bindings: mfd: Add Device Tree bindings for\n\tMellanox programmable devices","Message-ID":"<20170914125140.2a7cwmgm7pzk6zuk@dell>","References":"<1505371738-128683-1-git-send-email-vadimp@mellanox.com>\n\t<1505371738-128683-3-git-send-email-vadimp@mellanox.com>\n\t<20170914123824.us56wefi3di345mh@dell>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170914123824.us56wefi3di345mh@dell>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]