[{"id":1771103,"web_url":"http://patchwork.ozlabs.org/comment/1771103/","msgid":"<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-19T14:46:21","subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Sep 14, 2017 at 11:43:18AM +0800, Sandy Huang wrote:\n> This path add support rv1108 rgb output interface driver.\n> \n> Signed-off-by: Sandy Huang \n> ---\n> .../bindings/display/rockchip/rockchip-rgb.txt | 80 ++++++++++++++++++++++\n> 1 file changed, 80 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n> \n> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n> new file mode 100644\n> index 0000000..4164512\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n> @@ -0,0 +1,80 @@\n> +Rockchip RV1108 RGB interface\n> +================================\n> +\n> +Required properties:\n> +- compatible: matching the soc type:\n> +\t- \"rockchip,rv1108-rgb\";\n> +\n> +Optional properties:\n> +- pinctrl-names: must contain a \"lcdc\" entry.\n> +- pinctrl-0: pin control group to be used for this interface.\n> +\n> +Required nodes:\n> +- rockchip,rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\", \"s888-dummy\"\n\nThis should be a standard property. Any device with a parallel interface \nis going to need something like this.\n\n> +\t- p888: output r8-g8-b8 at each dclk cycle for per-pixel\n> +\t- p666: output r6-g6-b6 at each dclk cycle for per-pixel\n> +\t- p565: output r5-g6-b5 at each dclk cycle for per-pixel\n> +\t- s888: output r8-g8-b8 in three dclk cycle for per-pixel\n> +\t- s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n> +\n> +The rgb has two video ports described by:\n> +\tDocumentation/devicetree/bindings/media/video-interfaces.txt\n> +Their connections are modeled using the OF graph bindings specified in\n> +\tDocumentation/devicetree/bindings/graph.txt.\n> +\n> +- video port 0 for the VOP input, the remote endpoint maybe vopb/vopl/vop\n> +- video port 1 for either a panel or subsequent encoder\n> +\n> +the panel described by:\n> +\tDocumentation/devicetree/bindings/display/panel/simple-panel.txt\n> +Panel other required properties:\n> +- ports for remote rgb output.\n> +\n> +Example:\n> +\n> +panel: panel {\n> +\tcompatible = \"auo,b101ean01\";\n> +\tenable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n> +\n> +\tports {\n> +\t\tpanel_in_rgb: endpoint {\n> +\t\t\tremote-endpoint = <&rgb_out_panel>;\n> +\t\t};\n> +\t};\n> +};\n> +\n> +For Rockchip RV1108:\n> +\n> +\trgb: rgb {\n> +\t\tcompatible = \"rockchip,rv1108-rgb\";\n> +\t\tpinctrl-names = \"lcdc\";\n> +\t\tpinctrl-0 = <&lcdc_ctl>;\n> +\t\trockchip,rgb-mode = \"p888\";\n> +\n> +\t\tports {\n> +\t\t\t#address-cells = <1>;\n> +\t\t\t#size-cells = <0>;\n> +\n> +\t\t\trgb_in: port@0 {\n> +\t\t\t\treg = <0>;\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <0>;\n> +\n> +\t\t\t\trgb_in_vop: endpoint@0 {\n> +\t\t\t\t\treg = <0>;\n\nDon't need reg for a single endpoint.\n\n> +\t\t\t\t\tremote-endpoint = <&vop_out_rgb>;\n> +\t\t\t\t};\n> +\t\t\t};\n> +\n> +\t\t\trgb_out: port@1 {\n> +\t\t\t\treg = <1>;\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <0>;\n> +\n> +\t\t\t\trgb_out_panel: endpoint@0 {\n> +\t\t\t\t\treg = <0>;\n\nditto.\n\n> +\t\t\t\t\tremote-endpoint = <&panel_in_rgb>;\n> +\t\t\t\t};\n> +\t\t\t};\n> +\t\t};\n> +\t};\n> -- \n> 2.7.4\n> \n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxQg80mk7z9s82\n\tfor ;\n\tWed, 20 Sep 2017 00:46:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751488AbdISOq0 (ORCPT\n\t);\n\tTue, 19 Sep 2017 10:46:26 -0400","from mail-io0-f196.google.com ([209.85.223.196]:36391 \"EHLO\n\tmail-io0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751361AbdISOqZ (ORCPT\n\t); Tue, 19 Sep 2017 10:46:25 -0400","by mail-io0-f196.google.com with SMTP id n69so3351963ioi.3;\n\tTue, 19 Sep 2017 07:46:24 -0700 (PDT)","from localhost (rrcs-67-78-118-34.sw.biz.rr.com. [67.78.118.34])\n\tby smtp.gmail.com with ESMTPSA id\n\t68sm338554otr.72.2017.09.19.07.46.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 07:46:23 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=phjJ+Q0TJNiSp0RMkZVugRS1kLbQwRuKu9LksotFaek=;\n\tb=oxj3WTJPXy24fthA3118jAsrljA5BNXd999XbQ/XruX8mJiT9pQtnXxmT75F/ws3BY\n\tl+EhBrz+jbWRY6/DstHpR2xnVSTarG/0rJzjT1Xc+oOaHVzHQecQvuXnj76i8trm8nKq\n\t8DdzA1nsr6ph4jywGt2qt/LU3myfwNGnjttFmLwpHK9+YK5as2m7EZXCOx0iHyn1fTwb\n\tv6TBKkOFw/EaWUx+sVLYkQADLg6152Q/12p7q5GfE8J5f5bi4BPs3XaKCDw8fmvU0qDL\n\tJ5DShmwRo3fRfnLakUBJPYCj8LzJ3itlMJRrJYMvtPJ0b90lNIK7NUmjk7ByGnRsafxe\n\tF6gQ==","X-Gm-Message-State":"AHPjjUh0P1RRVYNxNSSB9WHmv2pWtH1PPaemukV4gNFxvsbQbNXacQmW\n\tWYmqGTxMYYygWflu5L98JhP8dp0=","X-Google-Smtp-Source":"AOwi7QAE+l89I4HlvRjK3kZW8PnEn2c295uxNJOHEDJyhMcAIJ2uuqLo9znb0i890nWveFRe8UNqqg==","X-Received":"by 10.202.80.145 with SMTP id e139mr1693169oib.80.1505832383895; \n\tTue, 19 Sep 2017 07:46:23 -0700 (PDT)","Date":"Tue, 19 Sep 2017 09:46:21 -0500","From":"Rob Herring ","To":"Sandy Huang ","Cc":"Mark Yao , David Airlie ,\n\tMark Rutland , Heiko Stuebner ,\n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","Message-ID":"<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>","References":"<1505360594-196508-1-git-send-email-hjc@rock-chips.com>\n\t<1505360600-196567-1-git-send-email-hjc@rock-chips.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505360600-196567-1-git-send-email-hjc@rock-chips.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771495,"web_url":"http://patchwork.ozlabs.org/comment/1771495/","msgid":"","list_archive_url":null,"date":"2017-09-20T01:51:30","subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":72133,"url":"http://patchwork.ozlabs.org/api/people/72133/","name":"Huang Jiachai","email":"hjc@rock-chips.com"},"content":"Hi rob,\n thanks for you review.\n\n在 2017/9/19 22:46, Rob Herring 写道:\n> On Thu, Sep 14, 2017 at 11:43:18AM +0800, Sandy Huang wrote:\n>> This path add support rv1108 rgb output interface driver.\n>>\n>> Signed-off-by: Sandy Huang \n>> ---\n>> .../bindings/display/rockchip/rockchip-rgb.txt | 80 ++++++++++++++++++++++\n>> 1 file changed, 80 insertions(+)\n>> create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>\n>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>> new file mode 100644\n>> index 0000000..4164512\n>> --- /dev/null\n>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>> @@ -0,0 +1,80 @@\n>> +Rockchip RV1108 RGB interface\n>> +================================\n>> +\n>> +Required properties:\n>> +- compatible: matching the soc type:\n>> +\t- \"rockchip,rv1108-rgb\";\n>> +\n>> +Optional properties:\n>> +- pinctrl-names: must contain a \"lcdc\" entry.\n>> +- pinctrl-0: pin control group to be used for this interface.\n>> +\n>> +Required nodes:\n>> +- rockchip,rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\", \"s888-dummy\"\n> \n> This should be a standard property. Any device with a parallel interface\n> is going to need something like this.\n> \nso, i need to move this property to panel? or just rename \nrockchip,rgb-mode to rgb-mode?\n\n>> +\t- p888: output r8-g8-b8 at each dclk cycle for per-pixel\n>> +\t- p666: output r6-g6-b6 at each dclk cycle for per-pixel\n>> +\t- p565: output r5-g6-b5 at each dclk cycle for per-pixel\n>> +\t- s888: output r8-g8-b8 in three dclk cycle for per-pixel\n>> +\t- s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n>> +\n>> +The rgb has two video ports described by:\n>> +\tDocumentation/devicetree/bindings/media/video-interfaces.txt\n>> +Their connections are modeled using the OF graph bindings specified in\n>> +\tDocumentation/devicetree/bindings/graph.txt.\n>> +\n>> +- video port 0 for the VOP input, the remote endpoint maybe vopb/vopl/vop\n>> +- video port 1 for either a panel or subsequent encoder\n>> +\n>> +the panel described by:\n>> +\tDocumentation/devicetree/bindings/display/panel/simple-panel.txt\n>> +Panel other required properties:\n>> +- ports for remote rgb output.\n>> +\n>> +Example:\n>> +\n>> +panel: panel {\n>> +\tcompatible = \"auo,b101ean01\";\n>> +\tenable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n>> +\n>> +\tports {\n>> +\t\tpanel_in_rgb: endpoint {\n>> +\t\t\tremote-endpoint = <&rgb_out_panel>;\n>> +\t\t};\n>> +\t};\n>> +};\n>> +\n>> +For Rockchip RV1108:\n>> +\n>> +\trgb: rgb {\n>> +\t\tcompatible = \"rockchip,rv1108-rgb\";\n>> +\t\tpinctrl-names = \"lcdc\";\n>> +\t\tpinctrl-0 = <&lcdc_ctl>;\n>> +\t\trockchip,rgb-mode = \"p888\";\n>> +\n>> +\t\tports {\n>> +\t\t\t#address-cells = <1>;\n>> +\t\t\t#size-cells = <0>;\n>> +\n>> +\t\t\trgb_in: port@0 {\n>> +\t\t\t\treg = <0>;\n>> +\t\t\t\t#address-cells = <1>;\n>> +\t\t\t\t#size-cells = <0>;\n>> +\n>> +\t\t\t\trgb_in_vop: endpoint@0 {\n>> +\t\t\t\t\treg = <0>;\n> \n> Don't need reg for a single endpoint.\n> \nok, this will be deleted at next version.\n>> +\t\t\t\t\tremote-endpoint = <&vop_out_rgb>;\n>> +\t\t\t\t};\n>> +\t\t\t};\n>> +\n>> +\t\t\trgb_out: port@1 {\n>> +\t\t\t\treg = <1>;\n>> +\t\t\t\t#address-cells = <1>;\n>> +\t\t\t\t#size-cells = <0>;\n>> +\n>> +\t\t\t\trgb_out_panel: endpoint@0 {\n>> +\t\t\t\t\treg = <0>;\n> \n> ditto.\n> \nok, this will be deleted at next version.\n>> +\t\t\t\t\tremote-endpoint = <&panel_in_rgb>;\n>> +\t\t\t\t};\n>> +\t\t\t};\n>> +\t\t};\n>> +\t};\n>> -- \n>> 2.7.4\n>>\n>>\n> \n> \n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxjQl29Qtz9sPt\n\tfor ;\n\tWed, 20 Sep 2017 11:51:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751462AbdITBvl (ORCPT\n\t);\n\tTue, 19 Sep 2017 21:51:41 -0400","from regular1.263xmail.com ([211.150.99.136]:60366 \"EHLO\n\tregular1.263xmail.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750998AbdITBvk (ORCPT\n\t); Tue, 19 Sep 2017 21:51:40 -0400","from hjc?rock-chips.com (unknown [192.168.167.183])\n\tby regular1.263xmail.com (Postfix) with ESMTP id 2291983;\n\tWed, 20 Sep 2017 09:51:34 +0800 (CST)","from [172.16.10.72] (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id C317537E;\n\tWed, 20 Sep 2017 09:51:29 +0800 (CST)","from [172.16.10.72] (unknown [58.22.7.114])\n\tby smtp.263.net (Postfix) whith ESMTP id 13721I7YGX2;\n\tWed, 20 Sep 2017 09:51:32 +0800 (CST)"],"X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"hjc@rock-chips.com","X-FST-TO":"sandy.huang@rock-chips.com","X-SENDER-IP":"58.22.7.114","X-LOGIN-NAME":"hjc@rock-chips.com","X-UNIQUE-TAG":"","X-ATTACHMENT-NUM":"0","X-SENDER":"hjc@rock-chips.com","X-DNS-TYPE":"0","Subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","To":"Rob Herring ","Cc":"Mark Yao , David Airlie ,\n\tMark Rutland , Heiko Stuebner ,\n\tdri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org","References":"<1505360594-196508-1-git-send-email-hjc@rock-chips.com>\n\t<1505360600-196567-1-git-send-email-hjc@rock-chips.com>\n\t<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>","From":"Sandy Huang ","Message-ID":"","Date":"Wed, 20 Sep 2017 09:51:30 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>","Content-Type":"text/plain; charset=gbk; format=flowed","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1771521,"web_url":"http://patchwork.ozlabs.org/comment/1771521/","msgid":"<6cd1ac0d-bc99-f8f3-15da-799f8623ce65@rock-chips.com>","list_archive_url":null,"date":"2017-09-20T02:57:29","subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":72133,"url":"http://patchwork.ozlabs.org/api/people/72133/","name":"Huang Jiachai","email":"hjc@rock-chips.com"},"content":"在 2017/9/20 9:51, Sandy Huang 写道:\n> Hi rob,\n>     thanks for you review.\n> \n> 在 2017/9/19 22:46, Rob Herring 写道:\n>> On Thu, Sep 14, 2017 at 11:43:18AM +0800, Sandy Huang wrote:\n>>> This path add support rv1108 rgb output interface driver.\n>>>\n>>> Signed-off-by: Sandy Huang \n>>> ---\n>>>   .../bindings/display/rockchip/rockchip-rgb.txt     | 80 \n>>> ++++++++++++++++++++++\n>>>   1 file changed, 80 insertions(+)\n>>>   create mode 100644 \n>>> Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>\n>>> diff --git \n>>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt \n>>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>> new file mode 100644\n>>> index 0000000..4164512\n>>> --- /dev/null\n>>> +++ \n>>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>> @@ -0,0 +1,80 @@\n>>> +Rockchip RV1108 RGB interface\n>>> +================================\n>>> +\n>>> +Required properties:\n>>> +- compatible: matching the soc type:\n>>> +    - \"rockchip,rv1108-rgb\";\n>>> +\n>>> +Optional properties:\n>>> +- pinctrl-names: must contain a \"lcdc\" entry.\n>>> +- pinctrl-0: pin control group to be used for this interface.\n>>> +\n>>> +Required nodes:\n>>> +- rockchip,rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\", \n>>> \"s888-dummy\"\n>>\n>> This should be a standard property. Any device with a parallel interface\n>> is going to need something like this.\n>>\n> so, i need to move this property to panel? or just rename \n> rockchip,rgb-mode to rgb-mode?\n> \n>>> +    - p888: output r8-g8-b8 at each dclk cycle for per-pixel\n>>> +    - p666: output r6-g6-b6 at each dclk cycle for per-pixel\n>>> +    - p565: output r5-g6-b5 at each dclk cycle for per-pixel\n>>> +    - s888: output r8-g8-b8 in three dclk cycle for per-pixel\n>>> +    - s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n>>> +\n>>> +The rgb has two video ports described by:\n>>> +    Documentation/devicetree/bindings/media/video-interfaces.txt\n>>> +Their connections are modeled using the OF graph bindings specified in\n>>> +    Documentation/devicetree/bindings/graph.txt.\n>>> +\n>>> +- video port 0 for the VOP input, the remote endpoint maybe \n>>> vopb/vopl/vop\n>>> +- video port 1 for either a panel or subsequent encoder\n>>> +\n>>> +the panel described by:\n>>> +    Documentation/devicetree/bindings/display/panel/simple-panel.txt\n>>> +Panel other required properties:\n>>> +- ports for remote rgb output.\n>>> +\n>>> +Example:\n>>> +\n>>> +panel: panel {\n>>> +    compatible = \"auo,b101ean01\";\n>>> +    enable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n>>> +\n>>> +    ports {\n>>> +        panel_in_rgb: endpoint {\n>>> +            remote-endpoint = <&rgb_out_panel>;\n>>> +        };\n>>> +    };\n>>> +};\n>>> +\n>>> +For Rockchip RV1108:\n>>> +\n>>> +    rgb: rgb {\n>>> +        compatible = \"rockchip,rv1108-rgb\";\n>>> +        pinctrl-names = \"lcdc\";\n>>> +        pinctrl-0 = <&lcdc_ctl>;\n>>> +        rockchip,rgb-mode = \"p888\";\n>>> +\n>>> +        ports {\n>>> +            #address-cells = <1>;\n>>> +            #size-cells = <0>;\n>>> +\n>>> +            rgb_in: port@0 {\n>>> +                reg = <0>;\n>>> +                #address-cells = <1>;\n>>> +                #size-cells = <0>;\n>>> +\n>>> +                rgb_in_vop: endpoint@0 {\n>>> +                    reg = <0>;\n>>\n>> Don't need reg for a single endpoint.\n>>\n> ok, this will be deleted at next version.\n>>> +                    remote-endpoint = <&vop_out_rgb>;\n>>> +                };\n>>> +            };\n>>> +\n>>> +            rgb_out: port@1 {\n>>> +                reg = <1>;\n>>> +                #address-cells = <1>;\n>>> +                #size-cells = <0>;\n>>> +\n>>> +                rgb_out_panel: endpoint@0 {\n>>> +                    reg = <0>;\n>>\n>> ditto.\n>>\n> ok, this will be deleted at next version.\nsorry,this can't be deleted, because rgb output remote endpoint maybe \npanel or convert chip, the dts node maybe like this:\n\npanel: panel {\n\tstatus = \"disabled\";\n\tports {\n\t\tpanel_in_rgb: endpoint {\n\t\t\tremote-endpoint = <&rgb_out_panel>;\n\t\t};\n\t};\n};\n\nbridge: bridge {\n\tstatus = \"okay\";\n\tports {\n\t\tbridge_in_rgb: endpoint {\n\t\t\tremote-endpoint = <&rgb_out_bridge>;\n\t\t};\n\t};\n};\n\nrgb_out: port@1 {\n\treg = <1>;\n\t#address-cells = <1>;\n\t#size-cells = <0>;\n\trgb_out_panel: endpoint@0 {\n\t\t reg = <0>;\n\t\tremote-endpoint = <&panel_in_rgb>;\n\t};\n\trgb_out_bridge: endpoint@1 {\n\t\t reg = <1>;\n\t\tremote-endpoint = <&bridge_in_rgb>;\n\t};\n };\n\nso rockchip_rgb_bind() @ rockchip_rgb.c use reg id to find the remote \nactived endpoint.\n\nfor_each_child_of_node(port, endpoint) {\n\tof_property_read_u32(endpoint, \"reg\", &endpoint_id);\n\tret = drm_of_find_panel_or_bridge(dev->of_node, 1, endpoint_id, \n&rgb->panel, &rgb->bridge);\n\tif (!ret)\n\t\tbreak;\n}\n\n>>> +                    remote-endpoint = <&panel_in_rgb>;\n>>> +                };\n>>> +            };\n>>> +        };\n>>> +    };\n>>> -- \n>>> 2.7.4\n>>>\n>>>\n>>\n>>\n>>\n> \n> \n> _______________________________________________\n> Linux-rockchip mailing list\n> Linux-rockchip@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/linux-rockchip\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxkv10kjFz9s82\n\tfor ;\n\tWed, 20 Sep 2017 12:57:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750733AbdITC5q (ORCPT\n\t);\n\tTue, 19 Sep 2017 22:57:46 -0400","from regular1.263xmail.com ([211.150.99.140]:41723 \"EHLO\n\tregular1.263xmail.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751016AbdITC5p (ORCPT\n\t); Tue, 19 Sep 2017 22:57:45 -0400","from hjc?rock-chips.com (unknown [192.168.167.243])\n\tby regular1.263xmail.com (Postfix) with ESMTP id F28B64BA2;\n\tWed, 20 Sep 2017 10:57:37 +0800 (CST)","from [172.16.10.72] (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id 271223CB;\n\tWed, 20 Sep 2017 10:57:28 +0800 (CST)","from [172.16.10.72] (unknown [58.22.7.114])\n\tby smtp.263.net (Postfix) whith ESMTP id 28351RVLT7P;\n\tWed, 20 Sep 2017 10:57:36 +0800 (CST)"],"X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"hjc@rock-chips.com","X-FST-TO":"sandy.huang@rock-chips.com","X-SENDER-IP":"58.22.7.114","X-LOGIN-NAME":"hjc@rock-chips.com","X-UNIQUE-TAG":"<43072b398eded7d626b2c883542633c5>","X-ATTACHMENT-NUM":"0","X-SENDER":"hjc@rock-chips.com","X-DNS-TYPE":"0","Subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","From":"Sandy Huang ","To":"Rob Herring ","Cc":"Mark Rutland , devicetree@vger.kernel.org,\n\tHeiko Stuebner ,\n\tDavid Airlie , linux-kernel@vger.kernel.org,\n\tdri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, \n\tlinux-arm-kernel@lists.infradead.org, Mark Yao ","References":"<1505360594-196508-1-git-send-email-hjc@rock-chips.com>\n\t<1505360600-196567-1-git-send-email-hjc@rock-chips.com>\n\t<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>\n\t","Message-ID":"<6cd1ac0d-bc99-f8f3-15da-799f8623ce65@rock-chips.com>","Date":"Wed, 20 Sep 2017 10:57:29 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773081,"web_url":"http://patchwork.ozlabs.org/comment/1773081/","msgid":"","list_archive_url":null,"date":"2017-09-21T19:40:45","subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 19, 2017 at 9:57 PM, Sandy Huang wrote:\n>\n>\n> 在 2017/9/20 9:51, Sandy Huang 写道:\n>>\n>> Hi rob,\n>> thanks for you review.\n>>\n>> 在 2017/9/19 22:46, Rob Herring 写道:\n>>>\n>>> On Thu, Sep 14, 2017 at 11:43:18AM +0800, Sandy Huang wrote:\n>>>>\n>>>> This path add support rv1108 rgb output interface driver.\n>>>>\n>>>> Signed-off-by: Sandy Huang \n>>>> ---\n>>>> .../bindings/display/rockchip/rockchip-rgb.txt | 80\n>>>> ++++++++++++++++++++++\n>>>> 1 file changed, 80 insertions(+)\n>>>> create mode 100644\n>>>> Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>>\n>>>> diff --git\n>>>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>> new file mode 100644\n>>>> index 0000000..4164512\n>>>> --- /dev/null\n>>>> +++\n>>>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>> @@ -0,0 +1,80 @@\n>>>> +Rockchip RV1108 RGB interface\n>>>> +================================\n>>>> +\n>>>> +Required properties:\n>>>> +- compatible: matching the soc type:\n>>>> + - \"rockchip,rv1108-rgb\";\n>>>> +\n>>>> +Optional properties:\n>>>> +- pinctrl-names: must contain a \"lcdc\" entry.\n>>>> +- pinctrl-0: pin control group to be used for this interface.\n>>>> +\n>>>> +Required nodes:\n>>>> +- rockchip,rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\",\n>>>> \"s888-dummy\"\n>>>\n>>>\n>>> This should be a standard property. Any device with a parallel interface\n>>> is going to need something like this.\n>>>\n>> so, i need to move this property to panel? or just rename\n>> rockchip,rgb-mode to rgb-mode?\n>>\n>>>> + - p888: output r8-g8-b8 at each dclk cycle for per-pixel\n>>>> + - p666: output r6-g6-b6 at each dclk cycle for per-pixel\n>>>> + - p565: output r5-g6-b5 at each dclk cycle for per-pixel\n>>>> + - s888: output r8-g8-b8 in three dclk cycle for per-pixel\n>>>> + - s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n>>>> +\n>>>> +The rgb has two video ports described by:\n>>>> + Documentation/devicetree/bindings/media/video-interfaces.txt\n>>>> +Their connections are modeled using the OF graph bindings specified in\n>>>> + Documentation/devicetree/bindings/graph.txt.\n>>>> +\n>>>> +- video port 0 for the VOP input, the remote endpoint maybe\n>>>> vopb/vopl/vop\n>>>> +- video port 1 for either a panel or subsequent encoder\n>>>> +\n>>>> +the panel described by:\n>>>> + Documentation/devicetree/bindings/display/panel/simple-panel.txt\n>>>> +Panel other required properties:\n>>>> +- ports for remote rgb output.\n>>>> +\n>>>> +Example:\n>>>> +\n>>>> +panel: panel {\n>>>> + compatible = \"auo,b101ean01\";\n>>>> + enable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n>>>> +\n>>>> + ports {\n>>>> + panel_in_rgb: endpoint {\n>>>> + remote-endpoint = <&rgb_out_panel>;\n>>>> + };\n>>>> + };\n>>>> +};\n>>>> +\n>>>> +For Rockchip RV1108:\n>>>> +\n>>>> + rgb: rgb {\n>>>> + compatible = \"rockchip,rv1108-rgb\";\n>>>> + pinctrl-names = \"lcdc\";\n>>>> + pinctrl-0 = <&lcdc_ctl>;\n>>>> + rockchip,rgb-mode = \"p888\";\n>>>> +\n>>>> + ports {\n>>>> + #address-cells = <1>;\n>>>> + #size-cells = <0>;\n>>>> +\n>>>> + rgb_in: port@0 {\n>>>> + reg = <0>;\n>>>> + #address-cells = <1>;\n>>>> + #size-cells = <0>;\n>>>> +\n>>>> + rgb_in_vop: endpoint@0 {\n>>>> + reg = <0>;\n>>>\n>>>\n>>> Don't need reg for a single endpoint.\n>>>\n>> ok, this will be deleted at next version.\n>>>>\n>>>> + remote-endpoint = <&vop_out_rgb>;\n>>>> + };\n>>>> + };\n>>>> +\n>>>> + rgb_out: port@1 {\n>>>> + reg = <1>;\n>>>> + #address-cells = <1>;\n>>>> + #size-cells = <0>;\n>>>> +\n>>>> + rgb_out_panel: endpoint@0 {\n>>>> + reg = <0>;\n>>>\n>>>\n>>> ditto.\n>>>\n>> ok, this will be deleted at next version.\n>\n> sorry,this can't be deleted, because rgb output remote endpoint maybe panel\n> or convert chip, the dts node maybe like this:\n>\n> panel: panel {\n> status = \"disabled\";\n> ports {\n> panel_in_rgb: endpoint {\n> remote-endpoint = <&rgb_out_panel>;\n> };\n> };\n> };\n>\n> bridge: bridge {\n> status = \"okay\";\n> ports {\n> bridge_in_rgb: endpoint {\n> remote-endpoint = <&rgb_out_bridge>;\n> };\n> };\n> };\n>\n> rgb_out: port@1 {\n> reg = <1>;\n> #address-cells = <1>;\n> #size-cells = <0>;\n> rgb_out_panel: endpoint@0 {\n> reg = <0>;\n> remote-endpoint = <&panel_in_rgb>;\n> };\n> rgb_out_bridge: endpoint@1 {\n> reg = <1>;\n> remote-endpoint = <&bridge_in_rgb>;\n> };\n> };\n>\n> so rockchip_rgb_bind() @ rockchip_rgb.c use reg id to find the remote\n> actived endpoint.\n>\n> for_each_child_of_node(port, endpoint) {\n> of_property_read_u32(endpoint, \"reg\", &endpoint_id);\n\nLack of reg property here should imply 0 for endpoint_id.\n\n> ret = drm_of_find_panel_or_bridge(dev->of_node, 1, endpoint_id,\n> &rgb->panel, &rgb->bridge);\n> if (!ret)\n> break;\n> }\n>\n>>>> + remote-endpoint = <&panel_in_rgb>;\n>>>> + };\n>>>> + };\n>>>> + };\n>>>> + };\n>>>> --\n>>>> 2.7.4\n>>>>\n>>>>\n>>>\n>>>\n>>>\n>>\n>>\n>> _______________________________________________\n>> Linux-rockchip mailing list\n>> Linux-rockchip@lists.infradead.org\n>> http://lists.infradead.org/mailman/listinfo/linux-rockchip\n>\n>\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyp9P4jdmz9s2G\n\tfor ;\n\tFri, 22 Sep 2017 06:28:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751851AbdIUTlJ convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 21 Sep 2017 15:41:09 -0400","from mail.kernel.org ([198.145.29.99]:41686 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751803AbdIUTlH (ORCPT );\n\tThu, 21 Sep 2017 15:41:07 -0400","from mail-qk0-f180.google.com (mail-qk0-f180.google.com\n\t[209.85.220.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 0B1D022A9D;\n\tThu, 21 Sep 2017 19:41:07 +0000 (UTC)","by mail-qk0-f180.google.com with SMTP id z143so6852342qkb.3;\n\tThu, 21 Sep 2017 12:41:07 -0700 (PDT)","by 10.12.209.75 with HTTP; Thu, 21 Sep 2017 12:40:45 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 0B1D022A9D","X-Gm-Message-State":"AHPjjUhRfgMXIeMu8WN1W+UFa4LgqooG0McHEVKFNz6Zw+iOc63RsyWS\n\teiYU6beLsVld652BHg1PRMcX2nh5b1DZNhjwfQ==","X-Google-Smtp-Source":"AOwi7QDYULm+Y5e/nP1h/yzgBr4ILpITGggJ28q/UVGv32KxGI1zD8eUP+gTfVPCvGB2c403bhKEQOvv77Y5WZH4Xc0=","X-Received":"by 10.55.10.76 with SMTP id 73mr4474206qkk.205.1506022866107;\n\tThu, 21 Sep 2017 12:41:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<6cd1ac0d-bc99-f8f3-15da-799f8623ce65@rock-chips.com>","References":"<1505360594-196508-1-git-send-email-hjc@rock-chips.com>\n\t<1505360600-196567-1-git-send-email-hjc@rock-chips.com>\n\t<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>\n\t\n\t<6cd1ac0d-bc99-f8f3-15da-799f8623ce65@rock-chips.com>","From":"Rob Herring ","Date":"Thu, 21 Sep 2017 14:40:45 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","To":"Sandy Huang ","Cc":"Mark Rutland ,\n\t\"devicetree@vger.kernel.org\" ,\n\tHeiko Stuebner , David Airlie ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tdri-devel ,\n\t\"open list:ARM/Rockchip SoC...\" , \n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tMark Yao ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8BIT","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773231,"web_url":"http://patchwork.ozlabs.org/comment/1773231/","msgid":"","list_archive_url":null,"date":"2017-09-22T02:59:58","subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","submitter":{"id":72133,"url":"http://patchwork.ozlabs.org/api/people/72133/","name":"Huang Jiachai","email":"hjc@rock-chips.com"},"content":"Hi rob,\n\n在 2017/9/22 3:40, Rob Herring 写道:\n> On Tue, Sep 19, 2017 at 9:57 PM, Sandy Huang wrote:\n>>\n>>\n>> 在 2017/9/20 9:51, Sandy Huang 写道:\n>>>\n>>> Hi rob,\n>>> thanks for you review.\n>>>\n>>> 在 2017/9/19 22:46, Rob Herring 写道:\n>>>>\n>>>> On Thu, Sep 14, 2017 at 11:43:18AM +0800, Sandy Huang wrote:\n>>>>>\n>>>>> This path add support rv1108 rgb output interface driver.\n>>>>>\n>>>>> Signed-off-by: Sandy Huang \n>>>>> ---\n>>>>> .../bindings/display/rockchip/rockchip-rgb.txt | 80\n>>>>> ++++++++++++++++++++++\n>>>>> 1 file changed, 80 insertions(+)\n>>>>> create mode 100644\n>>>>> Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>>>\n>>>>> diff --git\n>>>>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>>> new file mode 100644\n>>>>> index 0000000..4164512\n>>>>> --- /dev/null\n>>>>> +++\n>>>>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-rgb.txt\n>>>>> @@ -0,0 +1,80 @@\n>>>>> +Rockchip RV1108 RGB interface\n>>>>> +================================\n>>>>> +\n>>>>> +Required properties:\n>>>>> +- compatible: matching the soc type:\n>>>>> + - \"rockchip,rv1108-rgb\";\n>>>>> +\n>>>>> +Optional properties:\n>>>>> +- pinctrl-names: must contain a \"lcdc\" entry.\n>>>>> +- pinctrl-0: pin control group to be used for this interface.\n>>>>> +\n>>>>> +Required nodes:\n>>>>> +- rockchip,rgb-mode: should be \"p888\", \"p666\", \"p565\", \"s888\",\n>>>>> \"s888-dummy\"\n>>>>\n>>>>\n>>>> This should be a standard property. Any device with a parallel interface\n>>>> is going to need something like this.\n>>>>\n>>> so, i need to move this property to panel? or just rename\n>>> rockchip,rgb-mode to rgb-mode?\n>>>\n>>>>> + - p888: output r8-g8-b8 at each dclk cycle for per-pixel\n>>>>> + - p666: output r6-g6-b6 at each dclk cycle for per-pixel\n>>>>> + - p565: output r5-g6-b5 at each dclk cycle for per-pixel\n>>>>> + - s888: output r8-g8-b8 in three dclk cycle for per-pixel\n>>>>> + - s888-dmmy: output r8-g8-b8-dummy in four dclk cycle for per-pixel\n>>>>> +\n>>>>> +The rgb has two video ports described by:\n>>>>> + Documentation/devicetree/bindings/media/video-interfaces.txt\n>>>>> +Their connections are modeled using the OF graph bindings specified in\n>>>>> + Documentation/devicetree/bindings/graph.txt.\n>>>>> +\n>>>>> +- video port 0 for the VOP input, the remote endpoint maybe\n>>>>> vopb/vopl/vop\n>>>>> +- video port 1 for either a panel or subsequent encoder\n>>>>> +\n>>>>> +the panel described by:\n>>>>> + Documentation/devicetree/bindings/display/panel/simple-panel.txt\n>>>>> +Panel other required properties:\n>>>>> +- ports for remote rgb output.\n>>>>> +\n>>>>> +Example:\n>>>>> +\n>>>>> +panel: panel {\n>>>>> + compatible = \"auo,b101ean01\";\n>>>>> + enable-gpios = <&gpio7 21 GPIO_ACTIVE_HIGH>;\n>>>>> +\n>>>>> + ports {\n>>>>> + panel_in_rgb: endpoint {\n>>>>> + remote-endpoint = <&rgb_out_panel>;\n>>>>> + };\n>>>>> + };\n>>>>> +};\n>>>>> +\n>>>>> +For Rockchip RV1108:\n>>>>> +\n>>>>> + rgb: rgb {\n>>>>> + compatible = \"rockchip,rv1108-rgb\";\n>>>>> + pinctrl-names = \"lcdc\";\n>>>>> + pinctrl-0 = <&lcdc_ctl>;\n>>>>> + rockchip,rgb-mode = \"p888\";\n>>>>> +\n>>>>> + ports {\n>>>>> + #address-cells = <1>;\n>>>>> + #size-cells = <0>;\n>>>>> +\n>>>>> + rgb_in: port@0 {\n>>>>> + reg = <0>;\n>>>>> + #address-cells = <1>;\n>>>>> + #size-cells = <0>;\n>>>>> +\n>>>>> + rgb_in_vop: endpoint@0 {\n>>>>> + reg = <0>;\n>>>>\n>>>>\n>>>> Don't need reg for a single endpoint.\n>>>>\n>>> ok, this will be deleted at next version.\n>>>>>\n>>>>> + remote-endpoint = <&vop_out_rgb>;\n>>>>> + };\n>>>>> + };\n>>>>> +\n>>>>> + rgb_out: port@1 {\n>>>>> + reg = <1>;\n>>>>> + #address-cells = <1>;\n>>>>> + #size-cells = <0>;\n>>>>> +\n>>>>> + rgb_out_panel: endpoint@0 {\n>>>>> + reg = <0>;\n>>>>\n>>>>\n>>>> ditto.\n>>>>\n>>> ok, this will be deleted at next version.\n>>\n>> sorry,this can't be deleted, because rgb output remote endpoint maybe panel\n>> or convert chip, the dts node maybe like this:\n>>\n>> panel: panel {\n>> status = \"disabled\";\n>> ports {\n>> panel_in_rgb: endpoint {\n>> remote-endpoint = <&rgb_out_panel>;\n>> };\n>> };\n>> };\n>>\n>> bridge: bridge {\n>> status = \"okay\";\n>> ports {\n>> bridge_in_rgb: endpoint {\n>> remote-endpoint = <&rgb_out_bridge>;\n>> };\n>> };\n>> };\n>>\n>> rgb_out: port@1 {\n>> reg = <1>;\n>> #address-cells = <1>;\n>> #size-cells = <0>;\n>> rgb_out_panel: endpoint@0 {\n>> reg = <0>;\n>> remote-endpoint = <&panel_in_rgb>;\n>> };\n>> rgb_out_bridge: endpoint@1 {\n>> reg = <1>;\n>> remote-endpoint = <&bridge_in_rgb>;\n>> };\n>> };\n>>\n>> so rockchip_rgb_bind() @ rockchip_rgb.c use reg id to find the remote\n>> actived endpoint.\n>>\n>> for_each_child_of_node(port, endpoint) {\n>> of_property_read_u32(endpoint, \"reg\", &endpoint_id);\n> \n> Lack of reg property here should imply 0 for endpoint_id.\n> \nok, i will delete this reg id and set the endpoint_id default value to 0 \nwhen lack of reg property at next version, thanks.\n>> ret = drm_of_find_panel_or_bridge(dev->of_node, 1, endpoint_id,\n>> &rgb->panel, &rgb->bridge);\n>> if (!ret)\n>> break;\n>> }\n>>\n>>>>> + remote-endpoint = <&panel_in_rgb>;\n>>>>> + };\n>>>>> + };\n>>>>> + };\n>>>>> + };\n>>>>> --\n>>>>> 2.7.4\n>>>>>\n>>>>>\n>>>>\n>>>>\n>>>>\n>>>\n>>>\n>>> _______________________________________________\n>>> Linux-rockchip mailing list\n>>> Linux-rockchip@lists.infradead.org\n>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip\n>>\n>>\n> \n> \n> \n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyyrq30TZz9sRW\n\tfor ;\n\tFri, 22 Sep 2017 13:00:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751726AbdIVDAJ (ORCPT\n\t);\n\tThu, 21 Sep 2017 23:00:09 -0400","from regular1.263xmail.com ([211.150.99.131]:51949 \"EHLO\n\tregular1.263xmail.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751653AbdIVDAI (ORCPT\n\t); Thu, 21 Sep 2017 23:00:08 -0400","from hjc?rock-chips.com (unknown [192.168.167.87])\n\tby regular1.263xmail.com (Postfix) with ESMTP id D4AB66219;\n\tFri, 22 Sep 2017 10:59:59 +0800 (CST)","from [172.16.10.72] (localhost [127.0.0.1])\n\tby smtp.263.net (Postfix) with ESMTPA id 52E693D1;\n\tFri, 22 Sep 2017 10:59:56 +0800 (CST)","from [172.16.10.72] (unknown [58.22.7.114])\n\tby smtp.263.net (Postfix) whith ESMTP id 29105SWAHK4;\n\tFri, 22 Sep 2017 10:59:59 +0800 (CST)"],"X-263anti-spam":"KSV:0;","X-MAIL-GRAY":"0","X-MAIL-DELIVERY":"1","X-KSVirus-check":"0","X-ABS-CHECKED":"4","X-RL-SENDER":"hjc@rock-chips.com","X-FST-TO":"sandy.huang@rock-chips.com","X-SENDER-IP":"58.22.7.114","X-LOGIN-NAME":"hjc@rock-chips.com","X-UNIQUE-TAG":"","X-ATTACHMENT-NUM":"0","X-SENDER":"hjc@rock-chips.com","X-DNS-TYPE":"0","Subject":"Re: [PATCH 1/3] dt-bindings: Add document for rockchip RGB output\n\tinterface","To":"Rob Herring ","Cc":"Mark Rutland ,\n\t\"devicetree@vger.kernel.org\" ,\n\tHeiko Stuebner , David Airlie ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tdri-devel ,\n\t\"open list:ARM/Rockchip SoC...\" , \n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tMark Yao ","References":"<1505360594-196508-1-git-send-email-hjc@rock-chips.com>\n\t<1505360600-196567-1-git-send-email-hjc@rock-chips.com>\n\t<20170919144621.eledmglqgn7nf7zp@rob-hp-laptop>\n\t\n\t<6cd1ac0d-bc99-f8f3-15da-799f8623ce65@rock-chips.com>\n\t","From":"Sandy Huang ","Message-ID":"","Date":"Fri, 22 Sep 2017 10:59:58 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]