[{"id":1769798,"web_url":"http://patchwork.ozlabs.org/comment/1769798/","msgid":"","list_archive_url":null,"date":"2017-09-17T17:55:07","subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 13 September 2017 at 16:12, Rob Clark wrote:\n> Really just the subset that is needed by efi_console. Perhaps more will\n> be added later, for example color support would be useful to implement\n> efi_cout_set_attribute().\n>\n> Signed-off-by: Rob Clark \n> ---\n> drivers/video/Kconfig | 8 +++\n> drivers/video/vidconsole-uclass.c | 109 ++++++++++++++++++++++++++++++++++++++\n> drivers/video/video-uclass.c | 4 +-\n> include/video.h | 7 +++\n> include/video_console.h | 11 ++++\n> 5 files changed, 136 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass \n\nI don't see the test though - is that in another patch?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"lEBSyiBR\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"HQ/1X7nA\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwMdG4Q9dz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 07:26:10 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 59FF0C21CA5; Sun, 17 Sep 2017 21:26:09 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 37589C21F02;\n\tSun, 17 Sep 2017 17:57:19 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid AD454C21E0A; Sun, 17 Sep 2017 17:57:17 +0000 (UTC)","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181])\n\tby lists.denx.de (Postfix) with ESMTPS id E6791C21E1D\n\tfor ; Sun, 17 Sep 2017 17:55:28 +0000 (UTC)","by mail-qt0-f181.google.com with SMTP id x54so5766765qth.12\n\tfor ; Sun, 17 Sep 2017 10:55:28 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 17 Sep 2017 10:55:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=yNQ7jHPJVgE6NTQ/AavwFfRpLxfnWdTVm4DnWV2Gjt4=;\n\tb=lEBSyiBRBM2elAJ1vo9gB97ME0tW3JiYdpQk7wVahNerrdzs6a0qQfrBF8/3FMU2oX\n\tBcnvOFt6s7MI5Cg13ERl34scJTQvnCE8bCDMQPoUesnLPmMrTNNOsnyZmD92Bk822vuA\n\tLnH+Hiq3hT+4uTVgExMLtQBXkFb8mVi+iOO/mBjIhV4WskDDD66zFZ1qA7TyxFdic/K1\n\tuFdqELHPlRJjhzs8AFufOQXNg2g1D7fbNtUqRv/e6tpBr1Jci5Y/fGbJhqBSawPoD2yk\n\tN2brqr73ecRyeQRX44OVWCSxFoDrHn2pvlql2E8Wy+fgs8beQJPxCe+2YE3MwzHrQzUY\n\tuuMQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=yNQ7jHPJVgE6NTQ/AavwFfRpLxfnWdTVm4DnWV2Gjt4=;\n\tb=HQ/1X7nAv0niUyW20cwmDSyc4za2I7Woitfkvi7UYNWTJyN2FgmhTC10/wc+shuk6L\n\tIqh/RyWEtMJ4C9iCHPBFjkuYXT8XwKMT5vj6QrqTgJ5OQMpKzYhUYhg4CvHPx4ITcEVF\n\tu0ilsCVBwK88b/uIWaautA02ilXGn3Pm8L1pw="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=yNQ7jHPJVgE6NTQ/AavwFfRpLxfnWdTVm4DnWV2Gjt4=;\n\tb=aP8LT3MyU57MDKirjVwzfCDOkYx7KitfGYi/6M4Q5l0c7o55NGkb23lHEjuDfX6+05\n\tEsH20DxXDER/j2EDt72C6VRWHC3tUWj+GVUFzii2LfKMCNmUVFBXwM0r8T8/orh3PSKt\n\t85JK/d+x4T1gqbAZQx0+2XGPEsjpOxUaUl08m3m9PcmXESgaWbHiG24Y74AWfKlEBHHW\n\t1isCud4mbqR8Ejy3uTmaFUAjv1HnJkpEUXKvaJBB8kG0oWU+KmBSgIrgmELbp5VhCftF\n\tEO2R8ALCLatwWTzB3KgQb+KUMz/IwiFLO0yfzfg/BblVIJ+A8N0q/6WnTH0oseb1qUtW\n\txIVQ==","X-Gm-Message-State":"AHPjjUhuKP5WEsfM0wNtjdxphCKY+tjyQu0UOIZvIr/J+5N4f8sZAfkF\n\ta92Nm9L2KJKX2MZAzDINfyjPxwEWjbQurr9/oDzHzw==","X-Google-Smtp-Source":"AOwi7QCCidE6JJ2R0QTdvsWi24x382Gl5pNXPduNv1oEvBPDP87bScGzjyYUqPjaHtpYWykKBI6yJAxsLPjnuMeKNog=","X-Received":"by 10.237.37.182 with SMTP id x51mr45159555qtc.5.1505670927704; \n\tSun, 17 Sep 2017 10:55:27 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170913221227.21091-3-robdclark@gmail.com>","References":"<20170913221227.21091-1-robdclark@gmail.com>\n\t<20170913221227.21091-3-robdclark@gmail.com>","From":"Simon Glass ","Date":"Sun, 17 Sep 2017 11:55:07 -0600","X-Google-Sender-Auth":"4y1PypbT25LYUcoMFmi6JQVC2mA","Message-ID":"","To":"Rob Clark ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769811,"web_url":"http://patchwork.ozlabs.org/comment/1769811/","msgid":"","list_archive_url":null,"date":"2017-09-17T19:26:33","subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass wrote:\n> On 13 September 2017 at 16:12, Rob Clark wrote:\n>> Really just the subset that is needed by efi_console. Perhaps more will\n>> be added later, for example color support would be useful to implement\n>> efi_cout_set_attribute().\n>>\n>> Signed-off-by: Rob Clark \n>> ---\n>> drivers/video/Kconfig | 8 +++\n>> drivers/video/vidconsole-uclass.c | 109 ++++++++++++++++++++++++++++++++++++++\n>> drivers/video/video-uclass.c | 4 +-\n>> include/video.h | 7 +++\n>> include/video_console.h | 11 ++++\n>> 5 files changed, 136 insertions(+), 3 deletions(-)\n>\n> Reviewed-by: Simon Glass \n>\n> I don't see the test though - is that in another patch?\n\nwell, at this point test is load/bootefi Shell.efi and does it look\nmessed up on screen. If you have better ideas, let me know.\n\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QHIxDieD\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwP043BjTz9s5L\n\tfor ;\n\tMon, 18 Sep 2017 08:27:32 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2C71AC21EA9; Sun, 17 Sep 2017 22:27:31 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AB2DCC21D63;\n\tSun, 17 Sep 2017 19:27:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2FA4FC21D63; Sun, 17 Sep 2017 19:27:49 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 09A4FC21CA5\n\tfor ; Sun, 17 Sep 2017 19:26:35 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id q132so3519792lfe.4\n\tfor ; Sun, 17 Sep 2017 12:26:35 -0700 (PDT)","by 10.46.41.75 with HTTP; Sun, 17 Sep 2017 12:26:33 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=bvr4FSmJnmschFZedwBqrIfTKr5Mct/FO8rnJGym9pE=;\n\tb=QHIxDieDYI3YfUuARB5XWuuvNn9oLOGo+JvGCLVpDaB1i4AZUe+TjvOrJPcHDZlJ4q\n\tXhk/axU2xsHQw++nMi215tq3WICacJ7wf+VHuxBN2gisWPsTHPxTxCP8cr0Wrxdyxixl\n\trLEKcmtw/Bkq7nTwziGyiahoYMPuC65DX11Ke7VhG+xzObIH9FgnZ5T/hLDslgsRmVY0\n\t1OdX7D+oYqMI/+/vj0NVXkzxENcrJ9O9yrDr+u6zPOCF6VmPjvp/SiW1er1a98OYPznU\n\tZ2kGLe36qxuUhfrvjIJAMlIhw+TWs0iZQNSVIQ8oTaQxr25MsoqEeh2f/awENFY2zWFp\n\t6QEA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=bvr4FSmJnmschFZedwBqrIfTKr5Mct/FO8rnJGym9pE=;\n\tb=oueppW77hX2yGHrZjyg03xnLM6qdD0s7DWa2xdSY1BXNcKAVQoxHVHMdGMoRhgQbsV\n\tT5Gl9aNqwC6F3VOdeWJxzonhAU3UW7MxQvDaNMmzpSoHlSLfUl+NE2iBgQSkRziwCu4B\n\tDsrXoA4PIVnFwlePXf+8Zcp7wKya67/DYLiVhDUoFsMF/sZqAWxHeVh7XVPWhmK4OJhi\n\tIefMLGENBm38fE3CTjKH6ted6vUwBa6e4uN2BjrWV83byJ2yTJAZvdFrO1gB5nvdjhUE\n\truwVwMFrtSgwSbwOD9CSg3K4ur1STFLRUKRFYectIyS2nOMs9sEbQQ1k6mU/e3QKZPMy\n\t66ZA==","X-Gm-Message-State":"AHPjjUh6uerissGMgkpauhUfk5iQaYpuPqAI8XcEs+fCaD73AY8JTQeg\n\t2mfFAoW7xwAwH++K358vvExjbSevQFcEp9yzV3g=","X-Google-Smtp-Source":"AOwi7QDSMNXWMRxO96JZKYUMBWFK7P5IXzC3AliwsKecXtDhJEG1jkBHfyyS+csx7H0hGM8IW3ykKETOn0+vGguQ0jk=","X-Received":"by 10.25.41.147 with SMTP id p141mr2615628lfp.56.1505676394522; \n\tSun, 17 Sep 2017 12:26:34 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170913221227.21091-1-robdclark@gmail.com>\n\t<20170913221227.21091-3-robdclark@gmail.com>\n\t","From":"Rob Clark ","Date":"Sun, 17 Sep 2017 15:26:33 -0400","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769812,"web_url":"http://patchwork.ozlabs.org/comment/1769812/","msgid":"","list_archive_url":null,"date":"2017-09-17T19:30:03","subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rob,\n\nOn 17 September 2017 at 13:26, Rob Clark wrote:\n> On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass wrote:\n>> On 13 September 2017 at 16:12, Rob Clark wrote:\n>>> Really just the subset that is needed by efi_console. Perhaps more will\n>>> be added later, for example color support would be useful to implement\n>>> efi_cout_set_attribute().\n>>>\n>>> Signed-off-by: Rob Clark \n>>> ---\n>>> drivers/video/Kconfig | 8 +++\n>>> drivers/video/vidconsole-uclass.c | 109 ++++++++++++++++++++++++++++++++++++++\n>>> drivers/video/video-uclass.c | 4 +-\n>>> include/video.h | 7 +++\n>>> include/video_console.h | 11 ++++\n>>> 5 files changed, 136 insertions(+), 3 deletions(-)\n>>\n>> Reviewed-by: Simon Glass \n>>\n>> I don't see the test though - is that in another patch?\n>\n> well, at this point test is load/bootefi Shell.efi and does it look\n> messed up on screen. If you have better ideas, let me know.\n\nIt should be easy enough to update test/dm/video.o to use the new\nfeature in a new test. This code has nothing to do with EFI really.\n\nThe tests are fairly slow in that they gzip the display to check that\nit is correctly, but they work.\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Jmkb7YG5\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"X3UKyWJb\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwP6J0DSxz9s2G\n\tfor ;\n\tMon, 18 Sep 2017 08:32:55 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C1666C21DA9; Sun, 17 Sep 2017 22:32:54 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E9C79C21DC5;\n\tSun, 17 Sep 2017 19:32:14 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BB368C21DA2; Sun, 17 Sep 2017 19:32:13 +0000 (UTC)","from mail-qk0-f170.google.com (mail-qk0-f170.google.com\n\t[209.85.220.170])\n\tby lists.denx.de (Postfix) with ESMTPS id 3A4E9C21DA4\n\tfor ; Sun, 17 Sep 2017 19:30:25 +0000 (UTC)","by mail-qk0-f170.google.com with SMTP id z143so5689013qkb.3\n\tfor ; Sun, 17 Sep 2017 12:30:25 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 17 Sep 2017 12:30:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=JE08Nv3wIZGcQXNh6DIw5qL115wwOakkEjHOVsFlSVs=;\n\tb=Jmkb7YG5eyszgf+pX4B34RlFkFfHFNe1wPXcHE+VWB3wlDe5bl1pisZ/wmLAD0ffW5\n\trw0fPvUenNRcJONWx6kg58BHxBW/BEjNkYBHXams5OxSKBFk7cy7lHRnqQGaAnqq7V1v\n\t8TjEpySrcZErLkZW1sB85zEdJlfSgpEn4okK3un8anjlijVhlJsCfZCVWjqREyFzxngd\n\tBSGS2C+8TKimAK4b2072YOzREaWL+KghIw6MrYuGxsl7kFbDqvdY6OdzSijwxAvduu1O\n\tnTuU8ktoZ2EwG9BrItIpesrTKQL9JJ61b3Cro3J9iFcyBMfWAgpPw7ZDTfcRIVT2oPqJ\n\thjYg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=JE08Nv3wIZGcQXNh6DIw5qL115wwOakkEjHOVsFlSVs=;\n\tb=X3UKyWJb/7FAaOGRRIexViDtis1Tr5B1JOfJyHHRvbZFUWTjh3ZlhR+BWa2lkxHxOI\n\tdn+0uIY2YYmZHAIzOq6Nwm5yvor8AdwWDqAnXCFDBDQIzEk0CtvXW/eilNTZwka6CM82\n\thDr/eFWV9uLS6VX5FqIwcgpUdBzbKhVAlIJqE="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=JE08Nv3wIZGcQXNh6DIw5qL115wwOakkEjHOVsFlSVs=;\n\tb=pEya/WwyFNhJc0CsJilBv+5O8zxyLCJj9OY2xZ0fA93F8vmcv9QbQjiGd31z1hb9i1\n\t+if///1BrVU5XlcRs1RFfhlpdv9ogbX7SBcsA+VpVp+bA99NHwCE8i+0nmQ+SsYAXZa4\n\tr3qUb677SyrwLl8B3+QaY79ASni7AuB2MUJ/sz6kex3oB5uFP0/XxmH3ykyPL7HGwJej\n\tN4NGxSpPtfuO/2yvH3s/tV4lxGRQ7tXbz9xUDxy9C35ZVJMf+1iOZzDjKQp5K6HFvHML\n\t76crMI9bsiwb4bzB3XtzAPHmPx4Ffqn5YZG+wlzxPT8iVGPvPCFOXz0ONWTJjjVwulYm\n\tnqQw==","X-Gm-Message-State":"AHPjjUj9M/lWwGqbGxFEoTyk9XG5Iyr8IrlVvEt5eGhMY2K2Y9RNHIzk\n\tia/RRcKbsQG2dSth/08GtSxbeae9CQS1ehJcCJWDSg==","X-Google-Smtp-Source":"AOwi7QCiYXbGQJUYsDdGqtTRprLS715bB+Z+6nRqv/5gK+oUdE69j9XbrrRPkPN3FrKfWtj+QqCiqOJpcG6mr2qAl0A=","X-Received":"by 10.55.33.216 with SMTP id f85mr17719493qki.176.1505676623664; \n\tSun, 17 Sep 2017 12:30:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170913221227.21091-1-robdclark@gmail.com>\n\t<20170913221227.21091-3-robdclark@gmail.com>\n\t\n\t","From":"Simon Glass ","Date":"Sun, 17 Sep 2017 13:30:03 -0600","X-Google-Sender-Auth":"N6hFaL-W7itYzkfyIcM7jph1YgI","Message-ID":"","To":"Rob Clark ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769817,"web_url":"http://patchwork.ozlabs.org/comment/1769817/","msgid":"","list_archive_url":null,"date":"2017-09-17T19:39:49","subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 17, 2017 at 3:30 PM, Simon Glass wrote:\n> Hi Rob,\n>\n> On 17 September 2017 at 13:26, Rob Clark wrote:\n>> On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass wrote:\n>>> On 13 September 2017 at 16:12, Rob Clark wrote:\n>>>> Really just the subset that is needed by efi_console. Perhaps more will\n>>>> be added later, for example color support would be useful to implement\n>>>> efi_cout_set_attribute().\n>>>>\n>>>> Signed-off-by: Rob Clark \n>>>> ---\n>>>> drivers/video/Kconfig | 8 +++\n>>>> drivers/video/vidconsole-uclass.c | 109 ++++++++++++++++++++++++++++++++++++++\n>>>> drivers/video/video-uclass.c | 4 +-\n>>>> include/video.h | 7 +++\n>>>> include/video_console.h | 11 ++++\n>>>> 5 files changed, 136 insertions(+), 3 deletions(-)\n>>>\n>>> Reviewed-by: Simon Glass \n>>>\n>>> I don't see the test though - is that in another patch?\n>>\n>> well, at this point test is load/bootefi Shell.efi and does it look\n>> messed up on screen. If you have better ideas, let me know.\n>\n> It should be easy enough to update test/dm/video.o to use the new\n> feature in a new test. This code has nothing to do with EFI really.\n>\n> The tests are fairly slow in that they gzip the display to check that\n> it is correctly, but they work.\n>\n\n\nok, I guess snapshotting fb and comparing to a reference is a way..\nwhere do I look to figure out how to build/run these tests (and\npresumable update reference screenshots?)\n\nI'd be inclined to add any test as a patch on top of the following\npatch to cover color escape sequences at the same time..\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"F84fbY9S\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwPY96jjYz9s7M\n\tfor ;\n\tMon, 18 Sep 2017 08:52:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B19E3C21DE5; Sun, 17 Sep 2017 22:52:44 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9101AC21DA1;\n\tSun, 17 Sep 2017 19:40:59 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B8330C21CB3; Sun, 17 Sep 2017 19:40:57 +0000 (UTC)","from mail-lf0-f67.google.com (mail-lf0-f67.google.com\n\t[209.85.215.67])\n\tby lists.denx.de (Postfix) with ESMTPS id 5EA33C21D76\n\tfor ; Sun, 17 Sep 2017 19:39:50 +0000 (UTC)","by mail-lf0-f67.google.com with SMTP id c8so3537956lfe.2\n\tfor ; Sun, 17 Sep 2017 12:39:50 -0700 (PDT)","by 10.46.41.75 with HTTP; Sun, 17 Sep 2017 12:39:49 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=G760eJCvT0Souq1nRD+b/wi8pGbNx1ZQUULLO0XLItc=;\n\tb=F84fbY9SQpcMlznUFnDIphTVrG3Xk/DXyIxQ7rILPDmZtwGSCp2tXwVFeZgOHU93Vl\n\tIQk1AMUINBa2CtUpmUvtncathfWf+OEnuuSRTXcIQ09xLfJQZCASY1ti/SCdboIdRwSs\n\t9XvWkuo8o9CuL6Dqdzr4IKmw3l6JvE2CITrNxsEyCHbh+1nhF9zOUEOfudhDhp/ztoia\n\tqNocFhNWn95GwcqtJdWNyaH29+3aOdAEUgn8WdTaIeFfupfxdJrgCVotNe7j7APAgtQu\n\tCIdzMcgGr4JTJVibl25Hhn63NZHIkEpVUBaFPJDRrm+ZF8A+V5OrciUHLsPjo9mRI8qM\n\tnDmw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=G760eJCvT0Souq1nRD+b/wi8pGbNx1ZQUULLO0XLItc=;\n\tb=ahT0WWd1JmHQW8OYcCwzlOCjzJSZCXTJpsE3R4tXNrLqcYKKPWdLj60KV5cPKmh4f2\n\tNrulwO2lVS/ZSv8hWVPKOg8XJMd6IMubVkONT9xEyfl4aETSHd3Esh5RhGlwG9olPoNR\n\t4B4cCyxYBwBsIXE7gq5oZZ6REuSG8YDcD8mNRfCsfi3S5aJOGUYFGVf2VCgLKlbAThv/\n\tz9WJOEJ6jb+a/UKIJEFL7vkfEXhKLhww96mp7cwY1eg9gaHrK3aEpV6uh0Cw3LbZC2p8\n\t8DFHCmrMkqhz4fGADr67288h3gCzNZMnbkKX3/xhg+OmLmE+Xh1CYl1XdshptFx6FB00\n\t9U2w==","X-Gm-Message-State":"AHPjjUgk/lOAAHXyDe83EE7BiA1eP2YSdMGTpkcZ0zzW8E5QD5pHTjvc\n\t9A2JptentgosaDOo1zC+zPq3qkUzxp4QE9O70ruCzw==","X-Google-Smtp-Source":"AOwi7QCHdIr0BR4WTeDBEvBxnXPMdmCKwrBBX85I6GS4t2YMRdvy5Bsqoi5Y1JRBS2bApozKCHuqOCxp+ErAQH6dcd8=","X-Received":"by 10.25.41.147 with SMTP id p141mr2622488lfp.56.1505677189930; \n\tSun, 17 Sep 2017 12:39:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170913221227.21091-1-robdclark@gmail.com>\n\t<20170913221227.21091-3-robdclark@gmail.com>\n\t\n\t\n\t","From":"Rob Clark ","Date":"Sun, 17 Sep 2017 15:39:49 -0400","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1771871,"web_url":"http://patchwork.ozlabs.org/comment/1771871/","msgid":"","list_archive_url":null,"date":"2017-09-20T13:49:33","subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rob,\n\nOn 17 September 2017 at 13:39, Rob Clark wrote:\n> On Sun, Sep 17, 2017 at 3:30 PM, Simon Glass wrote:\n>> Hi Rob,\n>>\n>> On 17 September 2017 at 13:26, Rob Clark wrote:\n>>> On Sun, Sep 17, 2017 at 1:55 PM, Simon Glass wrote:\n>>>> On 13 September 2017 at 16:12, Rob Clark wrote:\n>>>>> Really just the subset that is needed by efi_console. Perhaps more will\n>>>>> be added later, for example color support would be useful to implement\n>>>>> efi_cout_set_attribute().\n>>>>>\n>>>>> Signed-off-by: Rob Clark \n>>>>> ---\n>>>>> drivers/video/Kconfig | 8 +++\n>>>>> drivers/video/vidconsole-uclass.c | 109 ++++++++++++++++++++++++++++++++++++++\n>>>>> drivers/video/video-uclass.c | 4 +-\n>>>>> include/video.h | 7 +++\n>>>>> include/video_console.h | 11 ++++\n>>>>> 5 files changed, 136 insertions(+), 3 deletions(-)\n>>>>\n>>>> Reviewed-by: Simon Glass \n>>>>\n>>>> I don't see the test though - is that in another patch?\n>>>\n>>> well, at this point test is load/bootefi Shell.efi and does it look\n>>> messed up on screen. If you have better ideas, let me know.\n>>\n>> It should be easy enough to update test/dm/video.o to use the new\n>> feature in a new test. This code has nothing to do with EFI really.\n>>\n>> The tests are fairly slow in that they gzip the display to check that\n>> it is correctly, but they work.\n>>\n>\n>\n> ok, I guess snapshotting fb and comparing to a reference is a way..\n> where do I look to figure out how to build/run these tests (and\n> presumable update reference screenshots?)\n\nmake tests\n\nwill run the tests.\n\nTo run the video tests, something like:\n\n./test/py/test.py -k video --build-dir sandbox/\n\nBTW there are no real reference screenshots. Just run the test once to\nget the value, check that the display looks good (run sandbox with -l)\nand then update your test with that value.\n\n>\n> I'd be inclined to add any test as a patch on top of the following\n> patch to cover color escape sequences at the same time..\n>\n\nYes that sounds good.\n\n- Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"qFpHU9+q\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"PmvG0AyL\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy1Nn4zXJz9s7f\n\tfor ;\n\tWed, 20 Sep 2017 23:51:05 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 59533C21F19; Wed, 20 Sep 2017 13:50:46 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2F68EC21F5C;\n\tWed, 20 Sep 2017 13:50:18 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 3C501C21F55; Wed, 20 Sep 2017 13:49:58 +0000 (UTC)","from mail-qt0-f177.google.com (mail-qt0-f177.google.com\n\t[209.85.216.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 727A2C21F61\n\tfor ; Wed, 20 Sep 2017 13:49:55 +0000 (UTC)","by mail-qt0-f177.google.com with SMTP id s18so2820802qta.3\n\tfor ; Wed, 20 Sep 2017 06:49:55 -0700 (PDT)","by 10.200.37.200 with HTTP; Wed, 20 Sep 2017 06:49:33 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=1AMOZpNPWTruVqMLNXkbbso8ZBe1oVirK2Szw3O5lL4=;\n\tb=qFpHU9+qIaRWCiV8yysIe3mHl6U7/mHXWHSsvgfiWO2fs1X6adO38lfJY2h/j1BbFU\n\tzsR2oCB6wMd+PV/rVjQrbVgciS3Ai7vXZfl0h9hNhnJi1EU9EnUQZCYiqtwwo/TR23nt\n\tH0X8+L9obSYLkBwwdgm8XjgGbqSwYAS67IwYc8z+lKNX4IAbPBJxWZvHqHQDG329tGp1\n\tVeIVpyfBDdW4ztQtqeALvptmoSZu98DMN/YPhDe+kIQfZ9e6ngxirOY+Cs+YkLlP7fTN\n\thgTGYOMYfXR8BxEQJTg+x5gMimGPZ1FONJ/xvjErGmC0hin6zNjsj4dYyxpFoOwNSr+D\n\tAKWA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=1AMOZpNPWTruVqMLNXkbbso8ZBe1oVirK2Szw3O5lL4=;\n\tb=PmvG0AyLcdHc6E4nZzs4syaJ1paUskHgpmzIUdZDFFhpAehKxymKFux87hCCxK7Zcx\n\tt7gO8gsEU34ljDoeM3Usf1MJc/V/0tpTpOwRvWhmgTTN7htyIw32OZ9EjuvfnslCz4nS\n\txKuJgEwh3VL0ylT7wZynU5nmAg0JqK2SeosL8="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=1AMOZpNPWTruVqMLNXkbbso8ZBe1oVirK2Szw3O5lL4=;\n\tb=YFyiD02vR0eT3BtmVKf+domh/1bVnsh7cUHxIa2/J48vFEVBYzmPDUOrhHOlP83sVQ\n\t+FLfLgkANsS9+1OGjvWl89zUJAIIRYaRawDwA8qdkyqVaxUQoIHiyyBIEWLh+MoO22jd\n\tOd49vMddyAW9E7o3wjIDR6ZY1gtNBnhDp58jVNC6ozSbWUJ8S4Cp9HqbQUzsM29l1XGP\n\tYrMMIWbJ2Zo8Oa07f+ZkxhF/biPWmv+6A+mayguRR82IFiMOxlKtDYY58oxomQ/JbHp5\n\tJsFv0IEcUkcO3iOFrEk0UZ9MAh1crITQ1/hTNwwKwd64u+CVXyUoKFQvGknarkNpm2fL\n\tzqhQ==","X-Gm-Message-State":"AHPjjUjHZKVsR4s34K3iNAEEPGS+2XnErM9AOvQrA21ldN0fEde5+f5M\n\tR+9ROdC+W4fF3y/m1gMzSd6w04u5suIpZJkFz9C2r6di","X-Google-Smtp-Source":"AOwi7QAqsBY0XYQEsaCKtC03h91s8U01uYqHDVvjNqQncd/xh3WseB5mCyxD6wZcjD9bGieijw/Xe5QZIGm6+0IGr44=","X-Received":"by 10.237.33.33 with SMTP id 30mr7260369qtc.138.1505915394122;\n\tWed, 20 Sep 2017 06:49:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170913221227.21091-1-robdclark@gmail.com>\n\t<20170913221227.21091-3-robdclark@gmail.com>\n\t\n\t\n\t\n\t","From":"Simon Glass ","Date":"Wed, 20 Sep 2017 07:49:33 -0600","X-Google-Sender-Auth":"Kv741nFq1aQe8s3dKNpqDb7njMY","Message-ID":"","To":"Rob Clark ","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH 2/3] dm: video: Add basic ANSI escape sequence\n\tsupport","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]