[{"id":1772479,"web_url":"http://patchwork.ozlabs.org/comment/1772479/","msgid":"<150597751168.58144.4318477903999484687@achrid.arch.suse.de>","list_archive_url":null,"date":"2017-09-21T07:05:12","subject":"Re: [U-Boot] [U-Boot, v3,\n\t08/21] efi_loader: use proper device-paths for partitions","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"> Also, create disk objects for the disk itself, in addition to the\n> partitions. (UEFI terminology is a bit confusing, a \"disk\" object is\n> really a partition.) This helps grub properly identify the boot device\n> since it is trying to match up partition \"disk\" object with it's parent\n> device.\n> \n> Now instead of seeing devices like:\n> \n> /File(sdhci@07864000.blk)/EndEntire\n> /File(usb_mass_storage.lun0)/EndEntire\n> \n> You see:\n> \n> /ACPI(133741d0,0)/UnknownMessaging(1d)/EndEntire\n> /ACPI(133741d0,0)/UnknownMessaging(1d)/HD(0,800,64000,dd904a8c00000000,1,1)/EndEntire\n> /ACPI(133741d0,0)/UnknownMessaging(1d)/HD(1,64800,200000,dd904a8c00000000,1,1)/EndEntire\n> /ACPI(133741d0,0)/UnknownMessaging(1d)/HD(2,264800,19a000,dd904a8c00000000,1,1)/EndEntire\n> /ACPI(133741d0,0)/USB(0,0)/USB(0,0)/USB(0,0)/EndEntire\n> /ACPI(133741d0,0)/USB(0,0)/USB(0,0)/USB(0,0)/HD(0,800,60000,38ca680200000000,1,1)/EndEntire\n> /ACPI(133741d0,0)/USB(0,0)/USB(0,0)/USB(0,0)/HD(1,61000,155000,38ca680200000000,1,1)/EndEntire\n> /ACPI(133741d0,0)/USB(0,0)/USB(0,0)/USB(0,0)/HD(2,20fa800,1bbf8800,38ca680200000000,1,1)/EndEntire\n> /ACPI(133741d0,0)/USB(0,0)/USB(0,0)/USB(0,0)/HD(3,1b6800,1f44000,38ca680200000000,1,1)/EndEntire\n> \n> This is on a board with single USB disk and single sd-card. The\n> UnknownMessaging(1d) node in the device-path is the MMC device,\n> but grub_efi_print_device_path() hasn't been updated yet for some\n> of the newer device-path sub-types.\n> \n> This patch is inspired by a patch originally from Peter Jones, but\n> re-worked to use efi_device_path, so it doesn't much resemble the\n> original.\n> \n> Signed-off-by: Rob Clark \n\nThanks, applied to efi-next\n\nAlex","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xySbP0ZJjz9sNc\n\tfor ;\n\tThu, 21 Sep 2017 17:16:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B6204C21F53; Thu, 21 Sep 2017 07:07:58 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 384F8C21EB1;\n\tThu, 21 Sep 2017 07:07:16 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 736E9C21F3C; Thu, 21 Sep 2017 07:05:16 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id 07EAEC21F50\n\tfor ; Thu, 21 Sep 2017 07:05:13 +0000 (UTC)","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id CA233AC3E;\n\tThu, 21 Sep 2017 07:05:12 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","From":"Alexander Graf ","To":"Rob Clark ","Date":"Thu, 21 Sep 2017 09:05:12 +0200","Message-Id":"<150597751168.58144.4318477903999484687@achrid.arch.suse.de>","X-Mailer":"git-send-email 2.12.3","In-Reply-To":"<20170913220546.19560-9-robdclark@gmail.com>","References":"<20170913220546.19560-9-robdclark@gmail.com>","MIME-Version":": 1.0","Cc":"U-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t08/21] efi_loader: use proper device-paths for partitions","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]