[{"id":1783547,"web_url":"http://patchwork.ozlabs.org/comment/1783547/","msgid":"<20171010092727.GE4177@dhcp-200-186.str.redhat.com>","list_archive_url":null,"date":"2017-10-10T09:27:27","subject":"Re: [Qemu-devel] [PATCH 08/18] block/mirror: Use source as a\n\tBdrvChild","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 13.09.2017 um 20:19 hat Max Reitz geschrieben:\n> With this, the mirror_top_bs is no longer just a technically required\n> node in the BDS graph but actually represents the block job operation.\n> \n> Signed-off-by: Max Reitz \n> ---\n> block/mirror.c | 18 ++++++++++--------\n> 1 file changed, 10 insertions(+), 8 deletions(-)\n> \n> diff --git a/block/mirror.c b/block/mirror.c\n> index 2ece38094d..9df4157511 100644\n> --- a/block/mirror.c\n> +++ b/block/mirror.c\n> @@ -43,8 +43,8 @@ typedef struct MirrorBlockJob {\n> RateLimit limit;\n> BlockBackend *target;\n> BlockDriverState *mirror_top_bs;\n> - BlockDriverState *source;\n> BlockDriverState *base;\n> + BdrvChild *source;\n\nIs it actually useful to store source seperately when we already have\nmirror_top_bs->backing?\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBBcJ28jrz9t6Y\n\tfor ;\n\tTue, 10 Oct 2017 20:28:14 +1100 (AEDT)","from localhost ([::1]:33710 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e1qpe-0000qx-2v\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 05:28:10 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39940)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e1qpF-0000pL-SW\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:27:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e1qpF-0006mO-21\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 05:27:45 -0400","from mx1.redhat.com ([209.132.183.28]:48436)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e1qp8-0006iV-6F; Tue, 10 Oct 2017 05:27:38 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B414937E8F;\n\tTue, 10 Oct 2017 09:27:36 +0000 (UTC)","from dhcp-200-186.str.redhat.com (dhcp-200-186.str.redhat.com\n\t[10.33.200.186])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 65A8A5ED4D;\n\tTue, 10 Oct 2017 09:27:28 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B414937E8F","Date":"Tue, 10 Oct 2017 11:27:27 +0200","From":"Kevin Wolf ","To":"Max Reitz ","Message-ID":"<20171010092727.GE4177@dhcp-200-186.str.redhat.com>","References":"<20170913181910.29688-1-mreitz@redhat.com>\n\t<20170913181910.29688-9-mreitz@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170913181910.29688-9-mreitz@redhat.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 10 Oct 2017 09:27:37 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 08/18] block/mirror: Use source as a\n\tBdrvChild","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Hajnoczi , John Snow ,\n\tFam Zheng , qemu-devel@nongnu.org, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1784542,"web_url":"http://patchwork.ozlabs.org/comment/1784542/","msgid":"","list_archive_url":null,"date":"2017-10-11T11:46:22","subject":"Re: [Qemu-devel] [PATCH 08/18] block/mirror: Use source as a\n\tBdrvChild","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-10-10 11:27, Kevin Wolf wrote:\n> Am 13.09.2017 um 20:19 hat Max Reitz geschrieben:\n>> With this, the mirror_top_bs is no longer just a technically required\n>> node in the BDS graph but actually represents the block job operation.\n>>\n>> Signed-off-by: Max Reitz \n>> ---\n>> block/mirror.c | 18 ++++++++++--------\n>> 1 file changed, 10 insertions(+), 8 deletions(-)\n>>\n>> diff --git a/block/mirror.c b/block/mirror.c\n>> index 2ece38094d..9df4157511 100644\n>> --- a/block/mirror.c\n>> +++ b/block/mirror.c\n>> @@ -43,8 +43,8 @@ typedef struct MirrorBlockJob {\n>> RateLimit limit;\n>> BlockBackend *target;\n>> BlockDriverState *mirror_top_bs;\n>> - BlockDriverState *source;\n>> BlockDriverState *base;\n>> + BdrvChild *source;\n> \n> Is it actually useful to store source seperately when we already have\n> mirror_top_bs->backing?\n\nI'll take a look whether it is, and if it isn't, I'll probably add that\nas a separate patch (to keep this one as simple as it is).\n\nI imagine it is not, right.\n\nMax","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBsdy6yzFz9sNr\n\tfor ;\n\tWed, 11 Oct 2017 22:47:02 +1100 (AEDT)","from localhost ([::1]:40405 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2FTZ-0003x9-1q\n\tfor incoming@patchwork.ozlabs.org; Wed, 11 Oct 2017 07:47:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56944)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2FTF-0003wU-Be\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 07:46:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e2FTE-00071Q-Kh\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 07:46:41 -0400","from mx1.redhat.com ([209.132.183.28]:47144)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e2FTA-0006vj-5B; Wed, 11 Oct 2017 07:46:36 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2D3437EA9C;\n\tWed, 11 Oct 2017 11:46:35 +0000 (UTC)","from dresden.str.redhat.com (unknown [10.40.205.86])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 041B6679CF;\n\tWed, 11 Oct 2017 11:46:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2D3437EA9C","To":"Kevin Wolf ","References":"<20170913181910.29688-1-mreitz@redhat.com>\n\t<20170913181910.29688-9-mreitz@redhat.com>\n\t<20171010092727.GE4177@dhcp-200-186.str.redhat.com>","From":"Max Reitz ","Message-ID":"","Date":"Wed, 11 Oct 2017 13:46:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20171010092727.GE4177@dhcp-200-186.str.redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"uqxUG4SCnAHXfNt9O4LRr6wfv13muSEN8\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 11 Oct 2017 11:46:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 08/18] block/mirror: Use source as a\n\tBdrvChild","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Hajnoczi , John Snow ,\n\tFam Zheng , qemu-devel@nongnu.org, qemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]