[{"id":1768084,"web_url":"http://patchwork.ozlabs.org/comment/1768084/","msgid":"","list_archive_url":null,"date":"2017-09-13T18:55:19","subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","submitter":{"id":12868,"url":"http://patchwork.ozlabs.org/api/people/12868/","name":"Samuel Martin","email":"s.martin49@gmail.com"},"content":"Hi Andrey,\n\nOn Wed, Sep 13, 2017 at 7:37 PM, Andrey Smirnov\n wrote:\n> Building host-lzo on 64-bit Fedora 26 ends up with library files\n> installed into $(HOST_DIR)/lib64 instead of $(HOST_DIR)/lib where\n> other packages (at least host-mtd) depending on it would look for it\n> (resulting in build failures). Fix that by specifying the directory to\n> be lib/ explicitly.\n>\n> Signed-off-by: Andrey Smirnov \n\nAcked-by: Samuel Martin \n\n> ---\n>\n> I suspect this might not be the best solution for this problem, but it\n> is a good starting point to discuss what might be and that's why I\n> submitted this patch anyway.\n\nIndeed the infra could certainly create the symlink $(HOST_DIR)/lib64\n-> lib (or $(HOST_DIR)/lib32 -> lib).\n\n\nRegards,","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EU3kCM/G\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsrTw4SdRz9sDB\n\tfor ;\n\tThu, 14 Sep 2017 04:56:04 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8C6708846C;\n\tWed, 13 Sep 2017 18:56:02 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id g1aWT7akiY1z; Wed, 13 Sep 2017 18:56:02 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0459A8848D;\n\tWed, 13 Sep 2017 18:56:02 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 946261C059E\n\tfor ;\n\tWed, 13 Sep 2017 18:56:00 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8D6CE8A483\n\tfor ;\n\tWed, 13 Sep 2017 18:56:00 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id tzK7d7wIllTS for ;\n\tWed, 13 Sep 2017 18:56:00 +0000 (UTC)","from mail-pg0-f68.google.com (mail-pg0-f68.google.com\n\t[74.125.83.68])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 17BB38A481\n\tfor ; Wed, 13 Sep 2017 18:56:00 +0000 (UTC)","by mail-pg0-f68.google.com with SMTP id i130so514274pgc.0\n\tfor ; Wed, 13 Sep 2017 11:56:00 -0700 (PDT)","by 10.100.181.132 with HTTP; Wed, 13 Sep 2017 11:55:19 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=dmrqKG27gvADk+UMtUx7AAbiycSKdMHGVgqOJYL52CE=;\n\tb=EU3kCM/Gxhqwcg3Dlsb6DJATIPzw8GKVzTBjFQUVAS3awMk+pqHXyUFBHiO6xE1dN8\n\tg3kmqi9Q4ZetyB6S0/IY+PYJYo7WXbSYznEVBDESAOy86CcS2vLK6Fm1FPf8VVNW1rrr\n\tHAmBUJdotXMfWU7Iko6KsmHSlS74p5Zt2tSxaHrFDsWEyadgQJHzgxu3G8yMNrcylu5R\n\tImBOcBQQcbNuvoPjFUxZr+iiLfI5eiD8dDJSTQ5dJlJkatrAuFljzsRIOEf7S+W1a2Wb\n\t7uFD1+U9xnA5orcvZlzGs+E22OfjjqDNHt/MLTNsDZf9OI6yNKfDNZh8Xdq24ydPfHZ2\n\tM56w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=dmrqKG27gvADk+UMtUx7AAbiycSKdMHGVgqOJYL52CE=;\n\tb=rmPfceXQ/ZLjUa68dhRT1t7wTrkjIpNtqUVRQVHKFlt74iiwS8qq4f3ALP76y7ts6j\n\t/Vaob0reSzB3gkEJoB72pShkufSzEyOz572SBs2pc1gfZ2SIUAWp9kNhamb1Vpa1rb9G\n\tP2evFWQaVgsV0a/CdfdEIM3zDPvaUiTK9BPt4Yy54ibkkTd5t7KNAnZUmUo99+w33tll\n\tvR/Z79MN79qqDqdfLmVkscCYOCRwLdrCY6RH4TIvMsNQkfB2+txRCpNeAO9mLWzHVhLM\n\ttr0Pg8R7NiPFlXmL3LkH5eCS92g3pM2clAR4bMpMcUxnJFx94ZqDf/YZhjc4rOAsxReP\n\tOd8Q==","X-Gm-Message-State":"AHPjjUiXm9GcDPiogYub9hLq2Ik84VIpWgIwbz7FrmDLpsIzDjFag7WO\n\tPBqTjAQrO/ykYut/PJAgHol+EcTfpUfPC5DaY8Y=","X-Google-Smtp-Source":"ADKCNb42UHpAFwvvi1FWoFGhKnHnuUzytYo9brbz/qjBkpmo+cuwIns3m3uagkus4FrIqYBehQ4lG9TiGcrst0y3Ejc=","X-Received":"by 10.99.143.89 with SMTP id r25mr18605283pgn.224.1505328959556; \n\tWed, 13 Sep 2017 11:55:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170913173724.6157-1-andrew.smirnov@gmail.com>","References":"<20170913173724.6157-1-andrew.smirnov@gmail.com>","From":"Samuel Martin ","Date":"Wed, 13 Sep 2017 20:55:19 +0200","Message-ID":"","To":"Andrey Smirnov ","Cc":"buildroot ","Subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1768162,"web_url":"http://patchwork.ozlabs.org/comment/1768162/","msgid":"","list_archive_url":null,"date":"2017-09-13T20:43:39","subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 13-09-17 20:55, Samuel Martin wrote:\n> Hi Andrey,\n> \n> On Wed, Sep 13, 2017 at 7:37 PM, Andrey Smirnov\n> wrote:\n>> Building host-lzo on 64-bit Fedora 26 ends up with library files\n>> installed into $(HOST_DIR)/lib64 instead of $(HOST_DIR)/lib where\n>> other packages (at least host-mtd) depending on it would look for it\n>> (resulting in build failures). Fix that by specifying the directory to\n>> be lib/ explicitly.\n\n It would be good to find out why this happens. I don't see anything in\nCMakeLists.txt that could explain this.\n\n Does this happen with the Buildroot-built host-cmake or only when you use the\nsystem-installed one?\n\n I expect this will happen with all host-cmake packages... Could you check?\n\n Obviously, we need a more fundamental solution than this.\n\n>>\n>> Signed-off-by: Andrey Smirnov \n> \n> Acked-by: Samuel Martin \n\n Nacked by me, we need a more fundamental fix.\n\n\n> \n>> ---\n>>\n>> I suspect this might not be the best solution for this problem, but it\n>> is a good starting point to discuss what might be and that's why I\n>> submitted this patch anyway.\n> \n> Indeed the infra could certainly create the symlink $(HOST_DIR)/lib64\n> -> lib (or $(HOST_DIR)/lib32 -> lib).\n\n That could be a solution, but I don't like it very much... OTOH we do this for\nstaging/target already so why not for host.\n\n Regards,\n Arnout","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xstv12WMbz9ryv\n\tfor ;\n\tThu, 14 Sep 2017 06:44:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 986E28889E;\n\tWed, 13 Sep 2017 20:44:24 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2dYChuBGP5rU; Wed, 13 Sep 2017 20:44:22 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8A2DD8889A;\n\tWed, 13 Sep 2017 20:44:22 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 944AD1CEB3B\n\tfor ;\n\tWed, 13 Sep 2017 20:44:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 8D9C589429\n\tfor ;\n\tWed, 13 Sep 2017 20:44:21 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rKZzAh3QTJKt for ;\n\tWed, 13 Sep 2017 20:44:20 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id E75CB89405\n\tfor ; Wed, 13 Sep 2017 20:44:19 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tWed, 13 Sep 2017 22:43:41 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Samuel Martin , Andrey Smirnov\n\t","References":"<20170913173724.6157-1-andrew.smirnov@gmail.com>\n\t","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"","Date":"Wed, 13 Sep 2017 22:43:39 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Cc":"buildroot ","Subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1768276,"web_url":"http://patchwork.ozlabs.org/comment/1768276/","msgid":"","list_archive_url":null,"date":"2017-09-14T01:39:51","subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","submitter":{"id":67013,"url":"http://patchwork.ozlabs.org/api/people/67013/","name":"Andrey Smirnov","email":"andrew.smirnov@gmail.com"},"content":"On Wed, Sep 13, 2017 at 1:43 PM, Arnout Vandecappelle wrote:\n>\n>\n> On 13-09-17 20:55, Samuel Martin wrote:\n>> Hi Andrey,\n>>\n>> On Wed, Sep 13, 2017 at 7:37 PM, Andrey Smirnov\n>> wrote:\n>>> Building host-lzo on 64-bit Fedora 26 ends up with library files\n>>> installed into $(HOST_DIR)/lib64 instead of $(HOST_DIR)/lib where\n>>> other packages (at least host-mtd) depending on it would look for it\n>>> (resulting in build failures). Fix that by specifying the directory to\n>>> be lib/ explicitly.\n>\n> It would be good to find out why this happens. I don't see anything in\n> CMakeLists.txt that could explain this.\n>\n> Does this happen with the Buildroot-built host-cmake or only when you use the\n> system-installed one?\n>\n> I expect this will happen with all host-cmake packages... Could you check?\n>\n> Obviously, we need a more fundamental solution than this.\n>\n\nJust finished digging more into this and it doesn't matter which CMake\nis being used (I tried both). As far as I can tell the reason for this\nbehavior is the following code in CMake itself:\n\nhttps://github.com/Kitware/CMake/blob/master/Modules/GNUInstallDirs.cmake#L201\n\nI agree that this probably affects all \"host-cmake\" packages. I don't\nhave any data to back that up (meaning I didn't try to investigate\nit), but I have a hunch that situation with \"host-mtd\" is exacerbated\nby the fact that it uses AC_CHECK_LIB instead of relying on\nPKG_CHECK_MODULES to find \"lzo\".\n\n>>>\n>>> Signed-off-by: Andrey Smirnov \n>>\n>> Acked-by: Samuel Martin \n>\n> Nacked by me, we need a more fundamental fix.\n>\n>\n>>\n>>> ---\n>>>\n>>> I suspect this might not be the best solution for this problem, but it\n>>> is a good starting point to discuss what might be and that's why I\n>>> submitted this patch anyway.\n>>\n>> Indeed the infra could certainly create the symlink $(HOST_DIR)/lib64\n>> -> lib (or $(HOST_DIR)/lib32 -> lib).\n>\n> That could be a solution, but I don't like it very much... OTOH we do this for\n> staging/target already so why not for host.\n>\n\nI have no opinion on the matter, so I am happy to modify the patch to\ndo whatever you think is best.\n\nThanks,\nAndrey Smirnov","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.133; helo=hemlock.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mHyETJ2k\"; dkim-atps=neutral"],"Received":["from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt1S648q2z9s4q\n\tfor ;\n\tThu, 14 Sep 2017 11:40:05 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 552B48A907;\n\tThu, 14 Sep 2017 01:39:58 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5EKes3qfbnIk; Thu, 14 Sep 2017 01:39:55 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 36E8C8A5A7;\n\tThu, 14 Sep 2017 01:39:55 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id C71B81C3F91\n\tfor ;\n\tThu, 14 Sep 2017 01:39:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C245830D8A\n\tfor ;\n\tThu, 14 Sep 2017 01:39:54 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zdIOmnT7V7aw for ;\n\tThu, 14 Sep 2017 01:39:53 +0000 (UTC)","from mail-qt0-f194.google.com (mail-qt0-f194.google.com\n\t[209.85.216.194])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 8077330C1C\n\tfor ; Thu, 14 Sep 2017 01:39:53 +0000 (UTC)","by mail-qt0-f194.google.com with SMTP id l25so1171074qtf.2\n\tfor ; Wed, 13 Sep 2017 18:39:53 -0700 (PDT)","by 10.140.23.116 with HTTP; Wed, 13 Sep 2017 18:39:51 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=tHwK2U95Z5Vi8IyjWH3CUqp7paBspBfo7Mh/EaGxnmM=;\n\tb=mHyETJ2ktdNW+YMN+MO0qrs+jR7DCO9Pn4eXtQ0jZ71WSsfp1p3JXoPOJU4h05dgmI\n\tY07E9KoNIHMzbTyAcAky6WoxyLjIH+t7Dcwf2ljsF3qE3Snm3brE3gc69QlOHtZrWNoi\n\tSfGLUuITpNZfmjY0SRoh0llJNlm/o32zTmxjPOWXAM/s3l0Okke5TV0P+lMGQPLtPqZF\n\tZLzT30B4qmCP0OZkX2Aink143nkIEiOdxK0usRcVOMjhSl110G0xQqdTzIwKxlteEkN2\n\t7P2hiF1GKoPcrYL5qZU3rsR4LZOLJIHWbRDw4kEFg+idL6dGn4VQMBV282TgWtssnNkU\n\tLQEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=tHwK2U95Z5Vi8IyjWH3CUqp7paBspBfo7Mh/EaGxnmM=;\n\tb=Nfd56Dv/mKtpcEsD4sKBnznc9ARGmvxpeybgRlnKSVV9QD7M79zEQYnZO7XLw5gaz/\n\tcmhn3MdG/n5XqBhKOQ7OeDOfeYw4/lFXjvFBaBhEmCV+p8f/RYKk+zzSI8mVfLw6YG4K\n\t2KQxACyGBj5R3bTRpIylFOjWsR4AkG/Vnuw4qq0zbHnPnRV4RiHGu0O34Z24ofQxUH6q\n\ti1mW/szYwTJ2mtt6nDD8P48LT4myyzB17QLhdLlSpCBS/ZUuSl+Oieo08Xb6t76Wbtfg\n\tfKcytYf6pZQ/Y8Xu5kjPLfuRpx4n+nQ2y044/qvGHZqCDybmXho2mSia8V4akFVkEtrY\n\tKnRw==","X-Gm-Message-State":"AHPjjUgPCEFlathz7hJtyuUUpNYPFUAjNasq2nnJKeFvTshDEwTplEo/\n\tPR2JnOPndluyKfjckJv56S3GyilLvCc5Ch3qWiM=","X-Google-Smtp-Source":"AOwi7QAbcAev5YF9JyfC27ve/GJjEYt6NY7Y3pbWW/p3GcADuA8A0Eg/OG7o46f0LGPJyPJClr7FiG9SlvWKjXcKMRs=","X-Received":"by 10.200.42.92 with SMTP id l28mr15218801qtl.137.1505353192436; \n\tWed, 13 Sep 2017 18:39:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170913173724.6157-1-andrew.smirnov@gmail.com>\n\t\n\t","From":"Andrey Smirnov ","Date":"Wed, 13 Sep 2017 18:39:51 -0700","Message-ID":"","To":"Arnout Vandecappelle ","Cc":"buildroot ","Subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1770468,"web_url":"http://patchwork.ozlabs.org/comment/1770468/","msgid":"","list_archive_url":null,"date":"2017-09-18T20:17:29","subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","submitter":{"id":12868,"url":"http://patchwork.ozlabs.org/api/people/12868/","name":"Samuel Martin","email":"s.martin49@gmail.com"},"content":"Hi all,\n\nOn Thu, Sep 14, 2017 at 3:39 AM, Andrey Smirnov\n wrote:\n> On Wed, Sep 13, 2017 at 1:43 PM, Arnout Vandecappelle wrote:\n>>\n>>\n>> On 13-09-17 20:55, Samuel Martin wrote:\n>>> Hi Andrey,\n>>>\n>>> On Wed, Sep 13, 2017 at 7:37 PM, Andrey Smirnov\n>>> wrote:\n>>>> Building host-lzo on 64-bit Fedora 26 ends up with library files\n>>>> installed into $(HOST_DIR)/lib64 instead of $(HOST_DIR)/lib where\n>>>> other packages (at least host-mtd) depending on it would look for it\n>>>> (resulting in build failures). Fix that by specifying the directory to\n>>>> be lib/ explicitly.\n>>\n>> It would be good to find out why this happens. I don't see anything in\n>> CMakeLists.txt that could explain this.\n>>\n>> Does this happen with the Buildroot-built host-cmake or only when you use the\n>> system-installed one?\n>>\n>> I expect this will happen with all host-cmake packages... Could you check?\n>>\n>> Obviously, we need a more fundamental solution than this.\n>>\n>\n> Just finished digging more into this and it doesn't matter which CMake\n> is being used (I tried both). As far as I can tell the reason for this\n> behavior is the following code in CMake itself:\n>\n> https://github.com/Kitware/CMake/blob/master/Modules/GNUInstallDirs.cmake#L201\n>\n> I agree that this probably affects all \"host-cmake\" packages. I don't\n> have any data to back that up (meaning I didn't try to investigate\n> it), but I have a hunch that situation with \"host-mtd\" is exacerbated\n> by the fact that it uses AC_CHECK_LIB instead of relying on\n> PKG_CHECK_MODULES to find \"lzo\".\n\nI confirm this behavior is to be expected from any cmake package (both\nhost and target since CMake guesses it from the target-tuple), but\nthis does not trigger any trouble in the staging or target trees\nbecause of the symlinks created by the skeleton-init-common package\n\nSo far, lzo is the only host-cmake-package installing libs that are\nused by others host-packages.\n\nAll others host-cmake-packages only install programs under\n$(HOST_DIR)/bin, without installing any libs; except for\nhost-mfgtools.\nBut host-mfgtools overrides its host install commands (installing it\nin $(HOST_DIR)/lib), because no install rule is defined in its\nCMakeLists.txt, so no install rule is generated in its Makefile.\n\nBTW, the host-mfgtools program still has a valid RPATH pointing to\n$(HOST_DIR)/lib, accordingly to $(HOST_LDFLAGS).\n\n>\n>>>>\n>>>> Signed-off-by: Andrey Smirnov \n>>>\n>>> Acked-by: Samuel Martin \n>>\n>> Nacked by me, we need a more fundamental fix.\n>>\n>>\n>>>\n>>>> ---\n>>>>\n>>>> I suspect this might not be the best solution for this problem, but it\n>>>> is a good starting point to discuss what might be and that's why I\n>>>> submitted this patch anyway.\n>>>\n>>> Indeed the infra could certainly create the symlink $(HOST_DIR)/lib64\n>>> -> lib (or $(HOST_DIR)/lib32 -> lib).\n>>\n>> That could be a solution, but I don't like it very much... OTOH we do this for\n>> staging/target already so why not for host.\n>>\n\nAnother solution could be setting -DCMAKE_INSTALL_LIBDIR=lib as part\nof the options of the host configure command in the infra.\nBut I'm really not sure about this, especially how it would play if a\nhost cmake package wants to set it (e.g. to install plugins)... it\nsounds even more fragile than the symlink approach...\n\n>\n> I have no opinion on the matter, so I am happy to modify the patch to\n> do whatever you think is best.\n>\n> Thanks,\n> Andrey Smirnov\n\nRegards,","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PIy1S2wI\"; dkim-atps=neutral"],"Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwy4V0prPz9s78\n\tfor ;\n\tTue, 19 Sep 2017 06:18:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id F271E87AF6;\n\tMon, 18 Sep 2017 20:18:13 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fPhhCdGnlqgG; Mon, 18 Sep 2017 20:18:12 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B10DB87A64;\n\tMon, 18 Sep 2017 20:18:12 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8E2EC1C0479\n\tfor ;\n\tMon, 18 Sep 2017 20:18:11 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 894AA30B9D\n\tfor ;\n\tMon, 18 Sep 2017 20:18:11 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id gUhjYKAknqRG for ;\n\tMon, 18 Sep 2017 20:18:10 +0000 (UTC)","from mail-pg0-f68.google.com (mail-pg0-f68.google.com\n\t[74.125.83.68])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 7A58630AD0\n\tfor ; Mon, 18 Sep 2017 20:18:10 +0000 (UTC)","by mail-pg0-f68.google.com with SMTP id d8so806954pgt.3\n\tfor ; Mon, 18 Sep 2017 13:18:10 -0700 (PDT)","by 10.100.162.144 with HTTP; Mon, 18 Sep 2017 13:17:29 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=6/iHJvYBP3XkMP+TofuvowuDLTHtw2bSOvRl/CGB4FI=;\n\tb=PIy1S2wIpNVlLTeAFiCIOtC2LQpHTK1CkkkgEDTTF+bPGfe4yr4vnkqWVeaWURelDS\n\tBG9z6f0lh6h1FjY9LB7otHupr1avRjQSk2tYmRQgukrzVZip5ZEEirsIPVpwOg8Vsjhz\n\ttplXmD+ucpBty1qqovsPF15HddXJQnZMuv6DrFgn9+BOA27MDj0dtSAaR67YwNMzoPuu\n\tXTwMfOxNDQceWiXI2nCYrDT4sBTd9kg+oLhUE4zrwuGv9NfiIkIW85nZrFjpeXA2jWyZ\n\tj6B08MdBtSTuZ2J7n2+YUHWC5nCMGBP2QUM7TFBZNz7+ZZTxjJyeI6JUUrqWo+fIWtH1\n\txASA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=6/iHJvYBP3XkMP+TofuvowuDLTHtw2bSOvRl/CGB4FI=;\n\tb=JlmWbhd+9AQ1/8n0lPc58L01g1mn/6gsl0QprA3g8xAbYEzMPDm1PNdoHAwANyS2/A\n\tVHQNTzvgLbzVBwaQfO8UEXG6gOFJywzwpcSagncyRrmbPc+Xs9DkShj0jNPv5ULILCSt\n\t54R1YTVUYGbmoZ5qd16to5kv7yS1vn4zB6h/YQS9y52nyH8dhFlPc2MyBLpJ70EJ2jdV\n\t2kPcAXGS9AKJMUn1KD3ekt1CsDTZ5AFAlezs8cRUPwF1ziy8Fd71jkRTnWP921tMxMoq\n\tmjTK2y3W/cwooQUXwjOJXCS6B2g/3cwB09LiPJPfjo98k15FVywcnvCWGu1ELho9FdTG\n\tE+pA==","X-Gm-Message-State":"AHPjjUgH+W40m/gjg6dnzxHrIn3af2r7M+y6BD1vZEORckbomn6CCQGp\n\t3AG++YxSLHMpsVrrRYTa+MXEw45Cba2bZawnASM=","X-Google-Smtp-Source":"ADKCNb7znYhOtkD3JRn5oAL6SEJdvoAVQEt5pPybkb3ydLWq6DL6qrgQNNiG7jaMezTtgSTK87Va8pvEUr1IKzkwA1g=","X-Received":"by 10.84.235.4 with SMTP id o4mr37201487plk.357.1505765889980;\n\tMon, 18 Sep 2017 13:18:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170913173724.6157-1-andrew.smirnov@gmail.com>\n\t\n\t\n\t","From":"Samuel Martin ","Date":"Mon, 18 Sep 2017 22:17:29 +0200","Message-ID":"","To":"Andrey Smirnov ","Cc":"buildroot ","Subject":"Re: [Buildroot] [PATCH] package/lzo: Set CMAKE_INSTALL_LIBDIR for\n\thost variant explicitly","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]